From patchwork Thu Dec 22 06:13:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuanchu Xie X-Patchwork-Id: 13079444 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 042DCC4332F for ; Thu, 22 Dec 2022 06:13:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34B86900004; Thu, 22 Dec 2022 01:13:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AC16900002; Thu, 22 Dec 2022 01:13:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14F3F900004; Thu, 22 Dec 2022 01:13:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0399D900002 for ; Thu, 22 Dec 2022 01:13:58 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D520C1C5C7F for ; Thu, 22 Dec 2022 06:13:57 +0000 (UTC) X-FDA: 80268926514.28.9E807FC Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf27.hostedemail.com (Postfix) with ESMTP id 3C7934000B for ; Thu, 22 Dec 2022 06:13:55 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RBzamxSf; spf=pass (imf27.hostedemail.com: domain of 3o_WjYwcKCEI2yerglyksskpi.gsqpmry1-qqozego.svk@flex--yuanchu.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3o_WjYwcKCEI2yerglyksskpi.gsqpmry1-qqozego.svk@flex--yuanchu.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671689636; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sXO+2cqQ2jD3iajPKrzJ7z5yUSuuXzzA/96bixg+F2U=; b=u6y5YK4zP79juI0ojNE3ELyJs9qnIAA4akfe7MvftaOvZIla5oHpU3cs0bp9fLQ/IePaLC IWmFcFAWiaKk5S1NMIgUhEKzgM9zQC2pz+gZ3XwVVWV57GOooLU7lXCDr0Tp0kR3Kl4uCY vfxLPXyW2NaQToZ/Sj9p7C9eIdabJog= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RBzamxSf; spf=pass (imf27.hostedemail.com: domain of 3o_WjYwcKCEI2yerglyksskpi.gsqpmry1-qqozego.svk@flex--yuanchu.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3o_WjYwcKCEI2yerglyksskpi.gsqpmry1-qqozego.svk@flex--yuanchu.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671689636; a=rsa-sha256; cv=none; b=rHkeoLYWUbDHLJyiUqfhGJ0hf/awyCVpLNDm6yrGoBAkG9x8msu2ilhejvSHVszo5fYoO6 UlWG8Rcek7It7sbR7IZslhrkA4d0m9Fu/TSE9o5VwnAKp6ToChWvligA1EFFSwXXCJ3g4v U7hFqsOXofIAb3v+TEMEZeMewIGyJgY= Received: by mail-yb1-f202.google.com with SMTP id h67-20020a25d046000000b00729876d3b2bso890758ybg.17 for ; Wed, 21 Dec 2022 22:13:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=sXO+2cqQ2jD3iajPKrzJ7z5yUSuuXzzA/96bixg+F2U=; b=RBzamxSflqz2dnljq8hzGh3K+g7vkV1vpSKFgX6w0JKOg9dUn+Y/WaXJu3DhtVpjuo ALtRZuX1WGVCUNKcpQ3ANWhiGUz73vxYXlmH6StTQnmI8CrYeQDhkLQrIhhy4L47n2hZ X4GN5QLqu301t7NXd8ZZpuBpYYhdqKGubvs5RiZsiQomDETrdTXahMnqZnQFGRqYlgNu im+/kRLg+lX53aiiY4oJwMmfNcEVi2vRTWLGHxJsAwH1UG3k0W10/QMGtsfXREIzH0wH htZIoSXJwK1BlJe4S7NeMCg4ED/HaIuuROna1LPz5R7n+77MkBDwjj6lUVA4LWn//7xl EAbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sXO+2cqQ2jD3iajPKrzJ7z5yUSuuXzzA/96bixg+F2U=; b=sg8b2OHXsysZZB/TsBB51sh5rwEU+gjvzVlzR3muYfecs3yuF7UI+LZE09LNWiSLjU 8lpCOQlpOPL7EKpSAFrasl4dORjWIPeIxoGr9JUhIgeoIri7i5ThLtskcUXn5fcFn1B6 k31+vSmK9sTfIRtdmSw4rN1egkYq2lB2fSOp1rXRoGlorDDnZSirVarB5rcN7mEL3Tkv Ta1YmTxYxBvDsMItkFnDc/JSk5+hLcN6sN/12ayTQqCqIFNjYMWVVVQZGZJ1nyiDEhw4 toZN97SpwNJrwFC6d/2XCfF6QnMXSy4Vp2jiYWdEJG/O9mGlKod+D110VMmjsJNkp86H XRBg== X-Gm-Message-State: AFqh2ko+4pn0tLRxqQYcUJP3xko1U3HelzDi8d/T9Xz2LR//pve1R2Ce vounsdjUww3Vvg17kpW9rV89iHDDPwqm X-Google-Smtp-Source: AMrXdXubpzMCVNxT2q9xbikXo1M/LUPkX3kF0KVqtXoPwmraEpRHv+a8w7/K7YmvnJDVJVUEAX/Ko3eLEoOT X-Received: from yuanchu.svl.corp.google.com ([2620:15c:2d4:203:bd6e:5c67:5831:adad]) (user=yuanchu job=sendgmr) by 2002:a25:6d56:0:b0:6fa:c7e7:a572 with SMTP id i83-20020a256d56000000b006fac7e7a572mr479654ybc.456.1671689635274; Wed, 21 Dec 2022 22:13:55 -0800 (PST) Date: Wed, 21 Dec 2022 22:13:41 -0800 In-Reply-To: <20221222061341.381903-1-yuanchu@google.com> Mime-Version: 1.0 References: <20221222061341.381903-1-yuanchu@google.com> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Message-ID: <20221222061341.381903-2-yuanchu@google.com> Subject: [PATCH 2/2] mm: support POSIX_FADV_NOREUSE for generic fadvise handler From: Yuanchu Xie To: Ivan Babrou , Johannes Weiner , Yu Zhao Cc: Alexander Viro , Andrew Morton , Steven Barrett , Brian Geffon , Oleksandr Natalenko , Suren Baghdasaryan , Arnd Bergmann , Peter Xu , Hugh Dickins , Gaosheng Cui , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Yuanchu Xie X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3C7934000B X-Rspam-User: X-Stat-Signature: oxqnbebzmkxfdzhseopqnyxk3m1xhmds X-HE-Tag: 1671689635-215146 X-HE-Meta: U2FsdGVkX19MrlzFSWxUnJv44iNSMVZMKbtEHGX8s93oENxgb0riDW5EHV838Q09LBxHWZI5wnQX7Lq2/BIjs438hkCBIEzdssW5drDJv2EYP9yRVTBMxTJbN+fFwVxs/Wf8Moj7TJPKB4OKOOsGpYEGxU1t6jOOi0peXKbOg5oPYeoiH2HBgbBPx8t6AZtkCKngMAKZEqdghVt902U0fzPK6CXWbrXpSfcKn/d/xsFjOsGEyjyhSEmUoDmkhLYDUIrzISwkg2lIE6X6+YcXgY/b/OxQmauHDrn1XMCZ9cSOc8Zovia84S6YG711LpeTf2sErdS4Y1mF7UARjlcgqkNK9v4vixZwQzIRqI96xEBVDQzI9guCDoGw+e9j/kwlesMYKcnlpbrxgavpRrZpk4CbkC89jgPf3EkZjUrvAxCvBjQ+ahp1V9E04yUqg6faITAXQzxPB+wX7+0uY0wVOYnsuOFV0TZatMifCJ0zJP3WBXAVCyY0sHK7IlclZS50BKYAJg/UdqU3OCrFJq1K339CHD4V+yPhoy1+2mLRn1xf1esi92DZvVBZ9pUgAQHEj7riLbMNdv4m3WAh6rnQgvKqSvlAm8FALJ4iye8rA7CargiE53pvTBBMk4z/yL0gGjiNB8VABohqezaO/P9I2S7qR2lRp3yiAQm2XfIDhZQc03dWrXcnfi4pbUsUklRrdqeYWdEqClVBQVRiW6eBxGxos8zPofdsUic6Qle8gLjk0R50abnN6iOo0gfkh6sUAKjXDSG2o+haNrXKNUV263TGHrV0XzFQUDi+ufn0SjQoH3i1nS5ie2ZPCJoOx2h5MmK1LvKRna8kcdEPYQY81ImzUi1lE7Kwbb5P65i/ILAhUi9xaGmQU8VMQ7vB4ebAbEB+Z0j23p/AozY2RVuCkDbZULn7diokT93ZNQXn9ykkJiUwIDcceqysI4W2o7BFl+262IYtXtJkrLR6Cpg jCPJ9QBe DpcPjw+GV2aHErNfTbuuDrQD0z8+xllip12fz4ewP4eHIJiqwfCz48Pb8uUUX3YqKnO9Nh3BA5FOZY8vqAiKJmDSn5L/9fOZ6UtDQVsNRsobhYBrh4+t+wNHwpqSI9W+GVZS4Siy013H02Ev6e+g6mFJATFdPbXzcqXRo5vJgENdRzXZSEnlic22DmQRz3OXnGARrleV6IX8bFmbCylD/anEYmNM4Lczsg0+WJxY+mApP7rwKn7G8Uzj0tjBksNZaqT729t8zuLpkotSwHPHWG92GVE3k4zqNYpmNhNpsaMXHAOBZMTGR3cukEyvCH+0dv+Er4jhxV/kiF83Fm5v9HcS4b+//o32QZTph6mX4SmQMcsgroApj67IVav9sMygx5n4O+bxHXzOmY5ujDgo+Z9SY9KOsG/r39QI5BROVypkbvrE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Yu Zhao POSIX_FADV_NOREUSE allows an application to specify that accesses to file data does not follow LRU and is used only once. Since 2.6.18 this is a no-op. We add FMODE_NOREUSE, checked in vma_has_locality to prevent LRU activation. Signed-off-by: Yu Zhao Signed-off-by: Yuanchu Xie --- include/linux/fs.h | 2 ++ include/linux/mm_inline.h | 3 +++ mm/fadvise.c | 5 ++++- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 066555ad1bf8..5660ed0edf1a 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -166,6 +166,8 @@ typedef int (dio_iodone_t)(struct kiocb *iocb, loff_t offset, /* File supports DIRECT IO */ #define FMODE_CAN_ODIRECT ((__force fmode_t)0x400000) +#define FMODE_NOREUSE ((__force fmode_t)0x800000) + /* File was opened by fanotify and shouldn't generate fanotify events */ #define FMODE_NONOTIFY ((__force fmode_t)0x4000000) diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h index 80c0f6901ead..024f834d952d 100644 --- a/include/linux/mm_inline.h +++ b/include/linux/mm_inline.h @@ -583,6 +583,9 @@ static inline bool vma_has_locality(struct vm_area_struct *vma) if (vma->vm_flags & (VM_SEQ_READ | VM_RAND_READ)) return false; + if (vma->vm_file && (vma->vm_file->f_mode & FMODE_NOREUSE)) + return false; + return true; } diff --git a/mm/fadvise.c b/mm/fadvise.c index bf04fec87f35..fb7c5f43fd2a 100644 --- a/mm/fadvise.c +++ b/mm/fadvise.c @@ -80,7 +80,7 @@ int generic_fadvise(struct file *file, loff_t offset, loff_t len, int advice) case POSIX_FADV_NORMAL: file->f_ra.ra_pages = bdi->ra_pages; spin_lock(&file->f_lock); - file->f_mode &= ~FMODE_RANDOM; + file->f_mode &= ~(FMODE_RANDOM | FMODE_NOREUSE); spin_unlock(&file->f_lock); break; case POSIX_FADV_RANDOM: @@ -107,6 +107,9 @@ int generic_fadvise(struct file *file, loff_t offset, loff_t len, int advice) force_page_cache_readahead(mapping, file, start_index, nrpages); break; case POSIX_FADV_NOREUSE: + spin_lock(&file->f_lock); + file->f_mode |= FMODE_NOREUSE; + spin_unlock(&file->f_lock); break; case POSIX_FADV_DONTNEED: __filemap_fdatawrite_range(mapping, offset, endbyte,