From patchwork Wed Jan 4 09:50:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yun Levi X-Patchwork-Id: 13088382 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6279C46467 for ; Wed, 4 Jan 2023 09:50:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30A518E0002; Wed, 4 Jan 2023 04:50:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BA688E0001; Wed, 4 Jan 2023 04:50:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 181C28E0002; Wed, 4 Jan 2023 04:50:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 067E88E0001 for ; Wed, 4 Jan 2023 04:50:59 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A215F80A80 for ; Wed, 4 Jan 2023 09:50:58 +0000 (UTC) X-FDA: 80316647796.20.6B9D972 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf21.hostedemail.com (Postfix) with ESMTP id 167DE1C0009 for ; Wed, 4 Jan 2023 09:50:56 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dm6bFou2; spf=pass (imf21.hostedemail.com: domain of ppbuk5246@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=ppbuk5246@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672825857; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=mXu4eopB6IErZbHfllRnsHuODa6KsYR3AQ1R//XwFrg=; b=mE6iHHHJs9Xyb/DgMxx7o1hoTyH0zssFvF+Q+YHAoGLW61BlRAOUE6TgFKUyfMcP8fJWjS I3ohTkl4AtDJ5H6dkfarcm+xdGvuHhVTp1scZzyFGEwSleCW6sqMjpaMSMvPeJOvsP/KXq uuVTboFWmVLv7x4b5arkfxoG3Cm14Oc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dm6bFou2; spf=pass (imf21.hostedemail.com: domain of ppbuk5246@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=ppbuk5246@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672825857; a=rsa-sha256; cv=none; b=B0WqZO98Ew/wNHNv0EXcSZyfS77ztI8kGmtiLfVC79Mfh8uK1CrF2zcitqNSdcGJVOOEhi 9n5DH9O56dwMu+2hYCwYCTiGDVnnARghuNKgXEu55T5hTMh2chK2VShohlASDV7b48x2hh Iq30C2EoZWEr1kiMsN9uc/rxnff1NSo= Received: by mail-pj1-f50.google.com with SMTP id m7-20020a17090a730700b00225ebb9cd01so26540150pjk.3 for ; Wed, 04 Jan 2023 01:50:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mXu4eopB6IErZbHfllRnsHuODa6KsYR3AQ1R//XwFrg=; b=dm6bFou26k5Xmbtzuh722dWOfKUCn9EjjmCxyrgJvZjxV2+tAP3w1l8CH30ZhYSTwT pOr2GSaM1kD6Yv6FyCeGUD/MbuzxodJzZUO3RYWoWCqG0qAWn+iHlVN5Ws4iqFy+Xyxp s0q77LwOoJhfmdgUXuyKg1n/uuBI5DX5FJehdpD5myz9Qt/TpjolqhKYlyz3WjmqSx1a RYtVFyzvNyJhjxx76C5yj2oJsoqbNSZis5HKpmjVGL0JTN+7XpCXR3oimnCOnbvWGABx TVOiUGqoEO5uRmZX2egBR1l4kHUWU0jj0poJhrRLTfd4iGxBsuORw+gdabmrDATcvP/I UEwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mXu4eopB6IErZbHfllRnsHuODa6KsYR3AQ1R//XwFrg=; b=AkQg89NmpVqTLnMryROcea05xAxwNW+DE7acCwh9LIdl9jQsIHFuhELeRIqVmn3rq+ cWOBHyPX6D0YjqHu57OK+EHaIkzD2ZTCJ0zmPjgoYWcxRbeCkCBV6j040iyv7DtShMr9 hlZsNz5tNPVVwDxE/cyU/3aNQTeaRDJUAVfLiqslkVu5qbJtZtOsdkpc6/NKR6uF/KMx DKuuEaX4XcqVLVjlh5G8AN+9vwY1IGGjP4oYwjBHqjMhlbmUR56ukEzhAWiACqyttmA0 CecOipxLP+918h6rQ7Uxj2JkyCsTEJXyVxHfcvycNtOxKG+o6t1CeV29HazBb7zX/RFi VfxA== X-Gm-Message-State: AFqh2kpPEokB2eiQv6J+sQzDdpnsRTX4MpaRcXU8B3Y9hG1yYaeKYkKZ OJPcZ5mOQ6H2yodBs85PVXrw4rI5MNI= X-Google-Smtp-Source: AMrXdXvf7gKzJJJmVg20ucN67VJRlaqLHtOTMTvKJn4Yt3aDPjPBGu9ug2hb2tFrhpD62w4PJsonkw== X-Received: by 2002:a17:90b:4c0f:b0:225:eb4b:222f with SMTP id na15-20020a17090b4c0f00b00225eb4b222fmr33844364pjb.45.1672825855885; Wed, 04 Jan 2023 01:50:55 -0800 (PST) Received: from localhost.localdomain ([118.235.15.65]) by smtp.gmail.com with ESMTPSA id t8-20020a17090a3b4800b002260c751b00sm13102610pjf.23.2023.01.04.01.50.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 04 Jan 2023 01:50:55 -0800 (PST) From: Levi Yun To: rppt@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Levi Yun Subject: [PATCH] [PATCH] memblock: Fix return sizeless candidate on __memblock_find_range_top_down. Date: Wed, 4 Jan 2023 18:50:49 +0900 Message-Id: <20230104095049.59043-1-ppbuk5246@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Stat-Signature: i34wi6sqazqceftp3xh9adqhsdkz68kw X-Rspam-User: X-Rspamd-Queue-Id: 167DE1C0009 X-Rspamd-Server: rspam06 X-HE-Tag: 1672825856-706130 X-HE-Meta: U2FsdGVkX1/C9BnEvSlcJmz0EIkuAVZhsgT5TNAgb/x1iTxkUceq6e86rE1hWO7YFg2Pa/gw1R2Rll/7uFdHsU+c3+RcIRgEPUSs/3G45jZdkfEaR650GOnc2tDfoGV/bnWgKr1Vwcr57I5QvWvSsNQBSE2mdKs99oQhqfHhbM0iGZRpobwSuoUTG8HGfsLR/z/YITaigWsdisvo625ClKqCj21YcLxdcQ174ywd+xT24et9PkZwXPNPZusoR5gZoJa66JZJZj1nWS7oeKlf0gt3eXN3fEmTTNbavEdAvr3yTb4nmuVLfjNQxxLkueTwseN88l8aAYi7sHiMdfMojZ+IU22wQMDPpqg58IL/gX7ELI18WclnUxtYXvv6FGmSz9vhSYIjH9HQPRBgHFDKzx3yJX9Tt8wlyue6mmiuAQQqRl4Wv7GZbt+/k+TPr478RgWipy4Let2dJ5THuRodCUAlh2j0cBt3HsMsOnt7q12ueFiCUkjTbWAD/9gzK4+1hzJcUorOane/XAi0BJRCt8df3Vy1s9+ZNvnzobTEPB9owpws/upA8b0FzqO6JTPclXX53oqaMN9nwlNcLzbWPgTXaxwUJi3jfCIsBGAvuN+yYJ8NI4RXIyhTmvOlweIeuM411Qkyfx6t/648JWB9J1h5cmbmH+0h8XO0MAGpbei6LUKHGyy+pj7VVn8SFfEm6ahzFJBWwCnu/wHR0D4+0Eih3Vdy8tO9C/NuIyPPk6Dewyo8c1Ao1RXcb65EpJ6uskOJYt8iQ3OBnHMr2yLqW+jUA7iwWo75ha4S2uH/09TxYyfihHe8INtgIfzrxM683mF86OHPLohUv61GvqfbjtIT1HiNyF/aTKd91pookVemo+QFkexUp00lCdScw7HmP7wTjgKQpmN9ogiP37/6CtC44uICos8gbOsh1vvLY0/MqwcltNZBeQRekACUHcWnBxYqWankYkvh9UglLgF vGbw+K4v ccqT7h0S8BepyqhYjpVAX5Q1esp7uhCuFacwI756jVGiG4yP0LlD8CtOtoYc++bOC5ZAwnZSL28ItFSIPYRbjs1BNei26jrhYQNS8UXkMz47PgISiKz4QIKnOaupotBO3pQp9+bXl8RrrTiZrhUtHpqrB3QHEjLfF2qR9t808CXMqR/I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.093303, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: __memblock_find_range_top_down can return start address of free region which sizeless then user speicified. To prevent the above case, add size check on candidate free region. Signed-off-by: Levi Yun --- mm/memblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memblock.c b/mm/memblock.c index 511d4783dcf1..710e2ef8d67d 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -262,7 +262,7 @@ __memblock_find_range_top_down(phys_addr_t start, phys_addr_t end, continue; cand = round_down(this_end - size, align); - if (cand >= this_start) + if (cand >= this_start && this_end - cand >= size) return cand; }