From patchwork Thu Jan 5 10:18:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Houghton X-Patchwork-Id: 13089675 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BEA4C3DA7D for ; Thu, 5 Jan 2023 10:19:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04709940022; Thu, 5 Jan 2023 05:19:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E2720940008; Thu, 5 Jan 2023 05:19:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0041940022; Thu, 5 Jan 2023 05:19:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ABE35940008 for ; Thu, 5 Jan 2023 05:19:57 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 77777AB30A for ; Thu, 5 Jan 2023 10:19:57 +0000 (UTC) X-FDA: 80320349634.02.C124345 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf23.hostedemail.com (Postfix) with ESMTP id DDE5E14000A for ; Thu, 5 Jan 2023 10:19:55 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=I8sjFLZn; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of 3S6S2YwoKCJI5F3AG23FA92AA270.yA8749GJ-886Hwy6.AD2@flex--jthoughton.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3S6S2YwoKCJI5F3AG23FA92AA270.yA8749GJ-886Hwy6.AD2@flex--jthoughton.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672913995; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oM1fuebOiYdsKI6sxS1LfWku8C58IPteD/Sei8VpSxQ=; b=B1BSLut8G6aSKRfdjry7oB/xuLQvrOYmgYas3SYf+ygThePo6SQyzOumoPcwynE4MRAEbd vijPPRr7khZamwPr1zeIUlRPy2v+K8YSOscdtJWkqDnLOwqQ+H0mHgng62Eo62GEbdRzqa fghFWLEwSE735MiWOxKASsBn9u/mq1Y= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=I8sjFLZn; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of 3S6S2YwoKCJI5F3AG23FA92AA270.yA8749GJ-886Hwy6.AD2@flex--jthoughton.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3S6S2YwoKCJI5F3AG23FA92AA270.yA8749GJ-886Hwy6.AD2@flex--jthoughton.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672913995; a=rsa-sha256; cv=none; b=vcj0Cy5GwCKWFbMAge0Q8Pv5Lc734DW9rhu1TF2wxPfimoGT2PsAEm1Bh73024bin2Yp3m KzgITIyCYeLJm0yVyD+yLMXxMrmLW301QNll1BQ7aOeaWMZ2MpogKNqc12YnhMI8ovkHmJ 9qPM1Vymo2Zbd82hICPIRYIRHvcBNl4= Received: by mail-yb1-f201.google.com with SMTP id s6-20020a259006000000b00706c8bfd130so36460515ybl.11 for ; Thu, 05 Jan 2023 02:19:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=oM1fuebOiYdsKI6sxS1LfWku8C58IPteD/Sei8VpSxQ=; b=I8sjFLZnx+aNBRXgBMZRH312QMYInRX5Te2g9nBKTxCe34+OYraFmUgSlUONr2eooJ 62HtRkoKcvk84eoWTg4qbcUFd2KKx07w9eSKHxyCphfKi6xjhUfineaz01Tx3MjmftXp zpVT5lb/OOmri7egZafvXcJTXzLNWPrLvhzt30S+FUXmd1QDJW2D+ASIf6sSrCO2pujj Wcuy4YdikybIl74tALJwRxpzS/O3LreoB3I8MFENTfEl2pSn4PDiQF+YbQjOUN/Fl9LC tguO+iGWrK5Q4xc2bG/OYNQ+g0mnWemidtzpfKV7SFWPLEAOT5YY+2u3ODxF8u421Xje VNWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oM1fuebOiYdsKI6sxS1LfWku8C58IPteD/Sei8VpSxQ=; b=TSDpe2MWtym0vtFL0+ZDv3fuiqgmww52+z1ej3h5ZDgU1/S0gZvwnxvjNT/Tzi+Q6N edqr97tbFIvB/Z6Z93RrMQS9n2ql+lmfn82Jryiy1Q+u5XXQf3iImRFaD0Cgpn9rpv3L ceIhGlWKZffSugKFUqhXNIf4ldxA4j4JAIjl1Y0unfT2tB/498xTKfgYao6zsRyI6mKb LSSELpQgZOcYkjk7cE92O1W31wJo5rEYfiAj0wW7a9qYLo954QK1kb3anicdtrt5Ycl7 tFKphVxSDJ2dRZP7CImDNch5b9zyYWl5O3E3bdNPx6kMHi6JQZC3qEGEj6UfJnlc1Qek 9ucQ== X-Gm-Message-State: AFqh2kpAHTV75eodQsx1br6fIN01yPicdD31RHagiiE1D951G6m4CsZl ro+Zaz1Hw+Ivf06qIHVciAqWbGGb2aapVKNT X-Google-Smtp-Source: AMrXdXt1McQ73HGP/bgfACgNt1pvdbvPI5F1rZ+GWu6XhGxvz7s7KKrAed+ZRcqWM42eHH4pUjfYXbqKojyiSuhg X-Received: from jthoughton.c.googlers.com ([fda3:e722:ac3:cc00:14:4d90:c0a8:2a4f]) (user=jthoughton job=sendgmr) by 2002:a81:25cf:0:b0:426:6938:b154 with SMTP id l198-20020a8125cf000000b004266938b154mr102769ywl.511.1672913995101; Thu, 05 Jan 2023 02:19:55 -0800 (PST) Date: Thu, 5 Jan 2023 10:18:40 +0000 In-Reply-To: <20230105101844.1893104-1-jthoughton@google.com> Mime-Version: 1.0 References: <20230105101844.1893104-1-jthoughton@google.com> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Message-ID: <20230105101844.1893104-43-jthoughton@google.com> Subject: [PATCH 42/46] selftests/vm: add HugeTLB HGM to userfaultfd selftest From: James Houghton To: Mike Kravetz , Muchun Song , Peter Xu Cc: David Hildenbrand , David Rientjes , Axel Rasmussen , Mina Almasry , "Zach O'Keefe" , Manish Mishra , Naoya Horiguchi , "Dr . David Alan Gilbert" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , Baolin Wang , Miaohe Lin , Yang Shi , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, James Houghton X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: DDE5E14000A X-Stat-Signature: 87s9mizjidt8p1z8ernpkte7cuzxd7mo X-HE-Tag: 1672913995-256110 X-HE-Meta: U2FsdGVkX19nCUCXKSlRmzL4M2TwjjLdt9/K0X9hxQdvw49d4uloN8ns0gS/u+f+8NFBh+nSd6qwv0ycGTMAo6CaBeQLkzpaWts2P5teK15FcJVfwF1KB9GRScX0UoP3j79omUCycVAkORcjNUolU22UFV5xmNVIH4WVTi56FIef9MQCpEkPCO7ERs+FCoFsmOdCouxlZj4m7ENWsB/Qnt8VPPxYIc9XB3zc0aVhRCiJETxQuKbWH1fLd61fzuN48QVuRINTtnGxMTYOGTJG2+CIRG60bpJGLs+G98a2mbXYSCI5kckfLkhfeOykH739YGmnmA+uax/4fZMtBHuvX29Yg+i1pd5FAAbXguUrRIVBZrg/3SWRqDTji1XF0oX+XfBWQxCitNxyWWMGcBEEZPkYpJ0LpGh9o4t5Cg079rDGQNHvPkAd2XpFAPMMlKh4VPv0/cdBvODJvhEuqZoY1oWSUdBp9jnGbe+VUTFMULaaonFV59wYPka2BaQP0HC5XX0eijys7GcXTP2a4qUA399WXDK7Ru+FT0G7xungMRcFpEwBn4Jm1xpdGa8qHSVRXg9nSsYjhkiUjCEBF8cZjq5b0Kduzh3unZE3WHWFgf6HemE23/yKlFlXSO8gAAEvawzAfs1JKUMig/mdHlo3tiRYI/nFOfObOGU2Y05wtLgOdF+ZOxjWhc/2xcpTTyXTy/5W4dHVB+x96uqD6IbQ2/LQe2zC2BxI/hXTY1U9dkzgtuHJkIEZ7QmMSJvp6UssoqKIRIDRceS2ifnRE14WAGuClTB65UpDHph0dsUNFLeelx3Jb0reeZICn7/ZEH4eWGpogOxbxSIIstJvUeYr0rK9A5STphojjMbI3sfQVgVOwVuejEmfTfA62JZngRIcERATnSoT5MEvBpIld9WSqd7xXqir80PgBXFALX2AErvq2QQghaXc6fZzetYb+3crU/zpA/U2NiZRCRCHawc gsDUh4uE +dwN/ymaudDtg18+xBcz08Nbt7LCY7keMJZuDKxXIuM7Wreymbvxb9BEIEcCvHu47BIecAisjn4NBVEP01uy+3Ta64eKfm1teLLYaOK43UKkGHHTdw8SJ0chcxhdlk3+HC9lVn4UkJE1jwHRKDjOd0yXwt+GIHbZfgZnZNXSSanUm151jjkynfv3YqbD42TQUN+nfnC63S26QMkXjezyUmXIPgYVTOKHsaH5Tz9LvFDroMFnUny7AnhruHeP94KCJm0FP5qGJJ3Q197daAQ3z4+/MOMF/dUziEJV6rZpHWQqVfO63p51uwi3owAPLOz0FV/LbuPWR2SZAL3M5E+W0r48Aitm5xvqlJl9xWButP9NWbv2lIApNUv/qhIJrPbhy97O1itYuBx5IB/o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This test case behaves similarly to the regular shared HugeTLB configuration, except that it uses 4K instead of hugepages, and that we ignore the UFFDIO_COPY tests, as UFFDIO_CONTINUE is the only ioctl that supports PAGE_SIZE-aligned regions. This doesn't test MADV_COLLAPSE. Other tests are added later to exercise MADV_COLLAPSE. Signed-off-by: James Houghton --- tools/testing/selftests/vm/userfaultfd.c | 84 +++++++++++++++++++----- 1 file changed, 69 insertions(+), 15 deletions(-) diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c index 7f22844ed704..681c5c5f863b 100644 --- a/tools/testing/selftests/vm/userfaultfd.c +++ b/tools/testing/selftests/vm/userfaultfd.c @@ -73,9 +73,10 @@ static unsigned long nr_cpus, nr_pages, nr_pages_per_cpu, page_size, hpage_size; #define BOUNCE_POLL (1<<3) static int bounces; -#define TEST_ANON 1 -#define TEST_HUGETLB 2 -#define TEST_SHMEM 3 +#define TEST_ANON 1 +#define TEST_HUGETLB 2 +#define TEST_HUGETLB_HGM 3 +#define TEST_SHMEM 4 static int test_type; #define UFFD_FLAGS (O_CLOEXEC | O_NONBLOCK | UFFD_USER_MODE_ONLY) @@ -93,6 +94,8 @@ static volatile bool test_uffdio_zeropage_eexist = true; static bool test_uffdio_wp = true; /* Whether to test uffd minor faults */ static bool test_uffdio_minor = false; +static bool test_uffdio_copy = true; + static bool map_shared; static int mem_fd; static unsigned long long *count_verify; @@ -151,7 +154,7 @@ static void usage(void) fprintf(stderr, "\nUsage: ./userfaultfd " "[hugetlbfs_file]\n\n"); fprintf(stderr, "Supported : anon, hugetlb, " - "hugetlb_shared, shmem\n\n"); + "hugetlb_shared, hugetlb_shared_hgm, shmem\n\n"); fprintf(stderr, "'Test mods' can be joined to the test type string with a ':'. " "Supported mods:\n"); fprintf(stderr, "\tsyscall - Use userfaultfd(2) (default)\n"); @@ -167,6 +170,11 @@ static void usage(void) exit(1); } +static bool test_is_hugetlb(void) +{ + return test_type == TEST_HUGETLB || test_type == TEST_HUGETLB_HGM; +} + #define _err(fmt, ...) \ do { \ int ret = errno; \ @@ -381,7 +389,7 @@ static struct uffd_test_ops *uffd_test_ops; static inline uint64_t uffd_minor_feature(void) { - if (test_type == TEST_HUGETLB && map_shared) + if (test_is_hugetlb() && map_shared) return UFFD_FEATURE_MINOR_HUGETLBFS; else if (test_type == TEST_SHMEM) return UFFD_FEATURE_MINOR_SHMEM; @@ -393,7 +401,7 @@ static uint64_t get_expected_ioctls(uint64_t mode) { uint64_t ioctls = UFFD_API_RANGE_IOCTLS; - if (test_type == TEST_HUGETLB) + if (test_is_hugetlb()) ioctls &= ~(1 << _UFFDIO_ZEROPAGE); if (!((mode & UFFDIO_REGISTER_MODE_WP) && test_uffdio_wp)) @@ -500,13 +508,16 @@ static void uffd_test_ctx_clear(void) static void uffd_test_ctx_init(uint64_t features) { unsigned long nr, cpu; + uint64_t enabled_features = features; uffd_test_ctx_clear(); uffd_test_ops->allocate_area((void **)&area_src, true); uffd_test_ops->allocate_area((void **)&area_dst, false); - userfaultfd_open(&features); + userfaultfd_open(&enabled_features); + if ((enabled_features & features) != features) + err("couldn't enable all features"); count_verify = malloc(nr_pages * sizeof(unsigned long long)); if (!count_verify) @@ -726,13 +737,16 @@ static void uffd_handle_page_fault(struct uffd_msg *msg, struct uffd_stats *stats) { unsigned long offset; + unsigned long address; if (msg->event != UFFD_EVENT_PAGEFAULT) err("unexpected msg event %u", msg->event); + address = msg->arg.pagefault.address; + if (msg->arg.pagefault.flags & UFFD_PAGEFAULT_FLAG_WP) { /* Write protect page faults */ - wp_range(uffd, msg->arg.pagefault.address, page_size, false); + wp_range(uffd, address, page_size, false); stats->wp_faults++; } else if (msg->arg.pagefault.flags & UFFD_PAGEFAULT_FLAG_MINOR) { uint8_t *area; @@ -751,11 +765,10 @@ static void uffd_handle_page_fault(struct uffd_msg *msg, */ area = (uint8_t *)(area_dst + - ((char *)msg->arg.pagefault.address - - area_dst_alias)); + ((char *)address - area_dst_alias)); for (b = 0; b < page_size; ++b) area[b] = ~area[b]; - continue_range(uffd, msg->arg.pagefault.address, page_size); + continue_range(uffd, address, page_size); stats->minor_faults++; } else { /* @@ -782,7 +795,7 @@ static void uffd_handle_page_fault(struct uffd_msg *msg, if (msg->arg.pagefault.flags & UFFD_PAGEFAULT_FLAG_WRITE) err("unexpected write fault"); - offset = (char *)(unsigned long)msg->arg.pagefault.address - area_dst; + offset = (char *)address - area_dst; offset &= ~(page_size-1); if (copy_page(uffd, offset)) @@ -1192,6 +1205,12 @@ static int userfaultfd_events_test(void) char c; struct uffd_stats stats = { 0 }; + if (!test_uffdio_copy) { + printf("Skipping userfaultfd events test " + "(test_uffdio_copy=false)\n"); + return 0; + } + printf("testing events (fork, remap, remove): "); fflush(stdout); @@ -1245,6 +1264,12 @@ static int userfaultfd_sig_test(void) char c; struct uffd_stats stats = { 0 }; + if (!test_uffdio_copy) { + printf("Skipping userfaultfd signal test " + "(test_uffdio_copy=false)\n"); + return 0; + } + printf("testing signal delivery: "); fflush(stdout); @@ -1329,6 +1354,11 @@ static int userfaultfd_minor_test(void) uffd_test_ctx_init(uffd_minor_feature()); + if (test_type == TEST_HUGETLB_HGM) + /* Enable high-granularity userfaultfd ioctls for HugeTLB */ + if (madvise(area_dst_alias, nr_pages * page_size, MADV_SPLIT)) + err("MADV_SPLIT failed"); + uffdio_register.range.start = (unsigned long)area_dst_alias; uffdio_register.range.len = nr_pages * page_size; uffdio_register.mode = UFFDIO_REGISTER_MODE_MINOR; @@ -1538,6 +1568,12 @@ static int userfaultfd_stress(void) pthread_attr_init(&attr); pthread_attr_setstacksize(&attr, 16*1024*1024); + if (!test_uffdio_copy) { + printf("Skipping userfaultfd stress test " + "(test_uffdio_copy=false)\n"); + bounces = 0; + } + while (bounces--) { printf("bounces: %d, mode:", bounces); if (bounces & BOUNCE_RANDOM) @@ -1696,6 +1732,16 @@ static void set_test_type(const char *type) uffd_test_ops = &hugetlb_uffd_test_ops; /* Minor faults require shared hugetlb; only enable here. */ test_uffdio_minor = true; + } else if (!strcmp(type, "hugetlb_shared_hgm")) { + map_shared = true; + test_type = TEST_HUGETLB_HGM; + uffd_test_ops = &hugetlb_uffd_test_ops; + /* + * HugeTLB HGM only changes UFFDIO_CONTINUE, so don't test + * UFFDIO_COPY. + */ + test_uffdio_minor = true; + test_uffdio_copy = false; } else if (!strcmp(type, "shmem")) { map_shared = true; test_type = TEST_SHMEM; @@ -1731,6 +1777,7 @@ static void parse_test_type_arg(const char *raw_type) err("Unsupported test: %s", raw_type); if (test_type == TEST_HUGETLB) + /* TEST_HUGETLB_HGM gets small pages. */ page_size = hpage_size; else page_size = sysconf(_SC_PAGE_SIZE); @@ -1813,22 +1860,29 @@ int main(int argc, char **argv) nr_cpus = x < y ? x : y; } nr_pages_per_cpu = bytes / page_size / nr_cpus; + if (test_type == TEST_HUGETLB_HGM) + /* + * `page_size` refers to the page_size we can use in + * UFFDIO_CONTINUE. We still need nr_pages to be appropriately + * aligned, so align it here. + */ + nr_pages_per_cpu -= nr_pages_per_cpu % (hpage_size / page_size); if (!nr_pages_per_cpu) { _err("invalid MiB"); usage(); } + nr_pages = nr_pages_per_cpu * nr_cpus; bounces = atoi(argv[3]); if (bounces <= 0) { _err("invalid bounces"); usage(); } - nr_pages = nr_pages_per_cpu * nr_cpus; - if (test_type == TEST_SHMEM || test_type == TEST_HUGETLB) { + if (test_type == TEST_SHMEM || test_is_hugetlb()) { unsigned int memfd_flags = 0; - if (test_type == TEST_HUGETLB) + if (test_is_hugetlb()) memfd_flags = MFD_HUGETLB; mem_fd = memfd_create(argv[0], memfd_flags); if (mem_fd < 0)