From patchwork Mon Jan 9 20:53:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 13094283 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19AFDC54EBD for ; Mon, 9 Jan 2023 20:54:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA9AB8E0005; Mon, 9 Jan 2023 15:54:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A59668E0001; Mon, 9 Jan 2023 15:54:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FA698E0005; Mon, 9 Jan 2023 15:54:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 814748E0001 for ; Mon, 9 Jan 2023 15:54:27 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5F16BA0B20 for ; Mon, 9 Jan 2023 20:54:27 +0000 (UTC) X-FDA: 80336463774.15.647C516 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) by imf23.hostedemail.com (Postfix) with ESMTP id BFC1214000F for ; Mon, 9 Jan 2023 20:54:25 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=oTTbEHXX; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of 3AH-8YwYKCBUDFCz8w19916z.x97638FI-775Gvx5.9C1@flex--surenb.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3AH-8YwYKCBUDFCz8w19916z.x97638FI-775Gvx5.9C1@flex--surenb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673297665; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hDqG76VNjmKFCkYaVQCHk1jK9PV7CZBX+MdyRpSUw7Y=; b=KzD9UR8TzynNCOZ4eCA1Gnf+ITCLdnGE8kCYCvo3iCfOHxkTdE1kY9jq64S9Mm6874E72d ppYTejuKtxrw/s6dU9goEt7BwNED/5toMyMaKsf2eEW+a0xXlhmxJFwE2O7pJ1SvdCtm+P HW1hEtms9aUpxuQiSRdmgcpkNO07Z74= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=oTTbEHXX; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of 3AH-8YwYKCBUDFCz8w19916z.x97638FI-775Gvx5.9C1@flex--surenb.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3AH-8YwYKCBUDFCz8w19916z.x97638FI-775Gvx5.9C1@flex--surenb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673297665; a=rsa-sha256; cv=none; b=a9HDxrU1G7DSl1lA75XSKLET6AC9CJOQQjVcKHVYrontY/AAlFZOVBBV9xT+N8l83tK5Pz WWi0twx6V795YX0GSSVqNZ9/xgzaGRV1xmeetCCrxbxTgZDsTw2g3RNhfHcI6AEeDZxS6I dKqeEUF9YW9T4f4dGep8fYMvBECyWxI= Received: by mail-pl1-f201.google.com with SMTP id l17-20020a170902f69100b001928d6b3efcso6963229plg.2 for ; Mon, 09 Jan 2023 12:54:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=hDqG76VNjmKFCkYaVQCHk1jK9PV7CZBX+MdyRpSUw7Y=; b=oTTbEHXXf074UTT/LXfKIzTlYAOVSZBWjz/z2pi8uw2sgTsKOn0pf4M+FUmb3fhKEp t8utYb+BYUrtOmcMbBRfjQmj3HjZCnvt7nX8XXsh4x467hUw4mc17N9vBA4v3IH0gXYu Tf0NgJ8TRnq+dnC575YF2XUlugz8igLSTMm592zbLFSlzWIJOjCEMLUlmrt7z2QrvV2T gekww8A2UJVHgfp1zwqjj/KBiOxEMFrYzziSkpJrGHAD1djB4N2zU8kmwkE7PnEOrNUu hxvDlopUQbh5t04B3B6cW3kLOVcLSOY+TAkcMQBqHoc5+w1BV2sS39QIbB6FPKvgrwld s2sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hDqG76VNjmKFCkYaVQCHk1jK9PV7CZBX+MdyRpSUw7Y=; b=QuRxgbpZkqDad8j123+2qfdoO1MUMtECwUTAAfb2CWqIE6oU5UGgx6gYUBsX4fKa2H XTigdAyBCMAqV7r7vrEWSmpY2rnmwt18uX0ZxNt1nLfFVlHM+nubjc1fhhQEhshYbUPh NKQ0OYWHlEuAFL9whKOhUWwNHV5+rKWo0WEufSb27dFZPnyGpk8CsVq4eC8hWKmdIUS5 FZKncEqIdqgmkyZrPqPfZ3IKJWPHw9j5vv6WSoUxAaxXNDKBijj8+E5VvMsWvg1UneY9 0JfiU4w71GC+t/coUGjNNW03WrBjI1lM0Mh5KrJNK1Ox+Ga8pA/5ni4ydcaUhcwINt/U O8Kg== X-Gm-Message-State: AFqh2ko+1Y+FMjUwH6wXY4DUxt/6B2RrW1Dqzb/F/HpvA/Gaf9EZm2Tl 70mo8PCUBn1PR5fM3OHPI568m+Ljyno= X-Google-Smtp-Source: AMrXdXvx+5mjUKCd2siyFSRbOdBiHgQPNh6ZnBtsj8lXWONeXJTph7ewao1odYnxoExvO1xzjoIbjT4zuzo= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:200:9393:6f7a:d410:55ca]) (user=surenb job=sendgmr) by 2002:a17:90a:638b:b0:221:52e3:1f56 with SMTP id f11-20020a17090a638b00b0022152e31f56mr5166916pjj.225.1673297664681; Mon, 09 Jan 2023 12:54:24 -0800 (PST) Date: Mon, 9 Jan 2023 12:53:12 -0800 In-Reply-To: <20230109205336.3665937-1-surenb@google.com> Mime-Version: 1.0 References: <20230109205336.3665937-1-surenb@google.com> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Message-ID: <20230109205336.3665937-18-surenb@google.com> Subject: [PATCH 17/41] mm/mmap: move VMA locking before anon_vma_lock_write call From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, surenb@google.com X-Rspamd-Queue-Id: BFC1214000F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: ycf6u5eb4sstdk8dp74wrhyakqb4q9an X-HE-Tag: 1673297665-981271 X-HE-Meta: U2FsdGVkX185fx3L0EEl51sss+RBg3PZJ0Mmk0sgGVZ5g0w4rG6Ld7CXgOwdXpHEcgUmWD8xGyVTlIx6yQklFBXeukJq0p3aqUuRCm4W2chVF6nJfBbQtJWYpEkEgTWl2eiP8CBqJ7sP6PcLXzaUfOVXKrqkMdcb5abFpDHI/0hGXhjkndDRkqCQ6oNeSZRv8FDQshCK+4/o/qYgtxurQQPR2GI5zgDx13LL/KOViPZwuaHToGIYans7equoOP28akKiF17vCllLMoc0N8iIhyiPvwChfRJMi8zPDvvyVo3uGZa4PPZZnnOqVUZ/aa3YN/JEjBMUBy0QkjyzEVIB4ZL4bwVF601c+gzvuoEVROO0WRQNosDh+PCaY2a3z+WujjUaYneRsnVO7/8kDO3VmjzCQLh/GuTP3JP1pb+//o0RpomhbBXBJDN/s6aNZVAHGOIbuh2CyTVC+zM7o1qq7OFbdXXHK9iMLo76Bq5Wsgg+eFC+ptoYjwdjzYQq3OpYdlXngwMty90tGk9KiYd0J+cH1Is0PcszsbCrg8onVrRjO/CCpeUII1s0t7VcvbcKTF2phiE1+gkJE+p+W4Jy1DtNBaax5uC9FrnMhevecIDXLWT385GltnLvMxgPjHswA2o8Qu4JIcsdOHrjDVybGre47iNCjzgw2MX47m77Kt8G9nxqfC+drpbpUrnb1WO4rLwokG9PT3BqkLgnpUof3qSp7SAjyrgTc6HF9Xoyhwx/OiVsB+eztmrxBNheoBUByPWhQZvqsdglPZMXr7o/jCYCr32hFGzU/dOGwfX+oCBOxr7ZON7VZyT0t0HJsGGRpacU4WTPBk/laUENVJPZefnUPckzyZqdqQD2DQhNc9mRHOagkZt+iq7S1gzZJvy6xHrtZ9BEIe6Op9Uy9+Vm/fuq6u72s7aL4GNRagob/9hpdutxXAnESehjaaqa1/uzHFza44GM+xSOF+dcIwT 5/Dth6Xj LpacRn4Vn9GUlpow4izqmbIe7fd8NDcJ2W4Dm5BcwAK96UbgSwT2XFKsUP4Mbn9mUPov3Xx4h8tB5SRai1IrRsOxyO3nkwOtk2q2haZ1D8al0wKXMFhkX5lYfo8nxMb97lSPkHZnLu3i2oQ4gOM0YzS9lA4rxnMASbBKOF0Lxr1vlYjydtsPPyxoOj9a42sQHK43f/bu/ejwXDdMrG2dqyDviObwRg7+lPkD6J7U6MSzF6qRmVREtCAKJXaFimVHzfSAHSHhQbh/Mp8IgO5+1tCGmfzvcniKUUcs5YbtcHoAoqmb5kyJecpOohV71wZ/TTkJxVLlsGkobNBYqql9byK89ChVgNAtXIDpVkYx20dqvaZ+rE+1b4BJidI7fARmjp1ciguC+tYYUvVI9XSKwVCEynlS2JmjshjwK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Move VMA flag modification (which now implies VMA locking) before anon_vma_lock_write to match the locking order of page fault handler. Signed-off-by: Suren Baghdasaryan --- mm/mmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/mmap.c b/mm/mmap.c index fa994ae903d9..53d885e70a54 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -2953,13 +2953,13 @@ static int do_brk_flags(struct ma_state *mas, struct vm_area_struct *vma, if (mas_preallocate(mas, vma, GFP_KERNEL)) goto unacct_fail; + set_vm_flags(vma, VM_SOFTDIRTY); vma_adjust_trans_huge(vma, vma->vm_start, addr + len, 0); if (vma->anon_vma) { anon_vma_lock_write(vma->anon_vma); anon_vma_interval_tree_pre_update_vma(vma); } vma->vm_end = addr + len; - set_vm_flags(vma, VM_SOFTDIRTY); mas_store_prealloc(mas, vma); if (vma->anon_vma) {