From patchwork Mon Jan 9 20:53:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 13094292 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 517DBC5479D for ; Mon, 9 Jan 2023 20:54:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E52688E0009; Mon, 9 Jan 2023 15:54:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E29D08E0001; Mon, 9 Jan 2023 15:54:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCA9C8E0009; Mon, 9 Jan 2023 15:54:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BDDD58E0001 for ; Mon, 9 Jan 2023 15:54:49 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9AE3F120C1A for ; Mon, 9 Jan 2023 20:54:49 +0000 (UTC) X-FDA: 80336464698.16.9719947 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) by imf03.hostedemail.com (Postfix) with ESMTP id F22FA20004 for ; Mon, 9 Jan 2023 20:54:47 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="k/y/f651"; spf=pass (imf03.hostedemail.com: domain of 3Fn-8YwYKCCsZbYLUINVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--surenb.bounces.google.com designates 209.85.210.202 as permitted sender) smtp.mailfrom=3Fn-8YwYKCCsZbYLUINVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673297688; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L7MiPLggwHMt078/i5i4Bbk0h7mxL/B1TX4Loq0bJkA=; b=Yk0NDeTLgB4iLyiIdMEJhKcTvz78DGYoxmPGiW+Dib8k4jMhrcB0hpPI10bDhNUoVmgqdB jo8LH2vK17Y2MOufER6y3Z/qA/SAAB9R8vcvD287uSGhidacbvzUfOh580D153qQv7reYK kdj8qj8S+ETLeiAtwR+Oox9cNqvgBYY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="k/y/f651"; spf=pass (imf03.hostedemail.com: domain of 3Fn-8YwYKCCsZbYLUINVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--surenb.bounces.google.com designates 209.85.210.202 as permitted sender) smtp.mailfrom=3Fn-8YwYKCCsZbYLUINVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673297688; a=rsa-sha256; cv=none; b=T8dgaEhyVu0tYeqYILcEDMu1BUvl/tU3699FLXQKOEP5PRWby+2NNcwjD7ZO6/8FdIo00y /b2ejjw2nA8TGMtpc2Urb65KB/Q9Ozb0TfQEAUqVmzyH5rbh/tf/oXsNJ1SxsbGtEK2+8p oe9Sm8VYmOrvpbDVXH/DwWSbgHouHrQ= Received: by mail-pf1-f202.google.com with SMTP id a18-20020a62bd12000000b0056e7b61ec78so4007808pff.17 for ; Mon, 09 Jan 2023 12:54:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=L7MiPLggwHMt078/i5i4Bbk0h7mxL/B1TX4Loq0bJkA=; b=k/y/f651ouIVm5VYXSBuN3WGA3r0siHAwbforN7cl7XldyaXSobuMoKnfRbHsUp2Zw mT4Fy24gz9zLv4V1qPdlGMDZmt4uQYDL7SMguN64hvgl+OPwnYaemI3hYYgdYfqYy2ZE RZpsDEbxomOp03K+XTMpAlOj5/FuHalix+oD7gvliXvyOvoSifjWwtoSfq337yDgZBWx NsM/wn5sH1zgbh2ZxdX6VDsXj4dH/jKa39D017jsbV+IQ14YXnxgSRRt8KTb8ppwgMfm uVAI77HN37Vy1v+4HMEL/4fAI+3c+Ki/ub6d+F+N4Xj5NK0ZJDRKlJXLfRFrsnczSTJ7 ObUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L7MiPLggwHMt078/i5i4Bbk0h7mxL/B1TX4Loq0bJkA=; b=enyTlltH//NIYVziZ4BQtGjnJmlKqv0iX9aVWRfb9Rtn8rPZCOoUTC/f8vXIKduFx2 0jn5U/mbOYUTHacjgIQvVvUtghVs/ktpEvHwDGJhVg402HlNZfJH9q1T42YsJ10YZVPD fFzXyBVx1+q0StbmsSZFJbcyxNFKHIeWWfC5tKrOC+C1SazvvJOp40Up8WxzegSV1hvL in5E99vpWYHI9ez6cd4Tyda36i7tv7aMjbLpWZ+6v2WyPjg2/MEQINzMbXp7nanzmkSp yEfTyiZfyhSsWSoTTmW2CsrpE7zA5ycrtMckhBjGUnkNjHeCwBr7YIIjCsa7hTY2hjCy gvrQ== X-Gm-Message-State: AFqh2kr6FyFrwEeF5h+1BfRnsq4WCHOv5mGlPKgSmlGqgWJAUWixk3yN 44y/GzY8tvyuBKscRrkJbrBWX8k0Sko= X-Google-Smtp-Source: AMrXdXscxn+TZfW1mPWgpj2/8Haqh4tY58OgT8gYBU0unalxDUYH6+O0E4BOyMrkarY33KKQg8fQ3JxSbTo= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:200:9393:6f7a:d410:55ca]) (user=surenb job=sendgmr) by 2002:a17:902:8e88:b0:190:becc:7e76 with SMTP id bg8-20020a1709028e8800b00190becc7e76mr6134633plb.1.1673297686693; Mon, 09 Jan 2023 12:54:46 -0800 (PST) Date: Mon, 9 Jan 2023 12:53:21 -0800 In-Reply-To: <20230109205336.3665937-1-surenb@google.com> Mime-Version: 1.0 References: <20230109205336.3665937-1-surenb@google.com> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Message-ID: <20230109205336.3665937-27-surenb@google.com> Subject: [PATCH 26/41] kernel/fork: assert no VMA readers during its destruction From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, surenb@google.com X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F22FA20004 X-Rspam-User: X-Stat-Signature: 65rd8m5eeusccd5q76rr5hqdwjgy1xnh X-HE-Tag: 1673297687-264837 X-HE-Meta: U2FsdGVkX1/y8XmESI/UQTOuPK+Mw1EOaFJsGakweEPxHI5h3RUCtrlbUFcWxuExr3JO/VaM1l0YFV9dF+le40yBMQsq3pOwQhH9fg3HVodG0/hv3uRlntOEYbaSo4qRwf97MFn1cpvFZUta3ZKsJCtgi/gKIW+87oogiMPnGKpsQB/JaVnGPgZWKMHuHk5GqN+2xnwZsOHayzSYYzsRsptpBH9VqrsQohpA+b6RmtmMm2NPCcg187jzskTlL6kKLy7LgYxP6fKUx8uXsvYd2hQZFNpf4YrsN8+QRP8/mRvE19jIDL9wj8PLqR2pP+hb4srQuKaDnSZjH4bBOpIF4dPtsw3nmxErsTQY7fwKNg0rSnnZWCIMEzbRlB22yg6RkW9rFK8EerZvuHyr3QpGO0DBIAopwisthVqFuf+GPxF4jyWLC0CHIV4U13MnVdjEd/hUpcpAIOfzQ3X/YdDvl0h2veQ5fU0NN1BqmQWj1MASvkls1Zt5ub3JO03s6bq6wnydI9hwghlWCbchForScRuqrHUulbqAiE8p6eEpfJIWjBFDtPH4UBIgXMpitOb4ZouhfB6KuWSjrZjyV0gJ8Kj3A79TkqWoQM3xqKNNJ14fbVuNKerVO56UDcgzUp5bO0pqPyqe7gUV5ApNUCw25pn0q1H9aC9hRiLV/ARBct59MMtIwcBqoNbcQZr7wwij3nc7zi4P65LiTnoXoM80i5t9pHd76pSbRuPCvR5bRDCIi4U+FZLIDHXJdWjkIobkDMmNpKfyBr/sbMphLK2OgY0EaathoN33QOHHAidRreJxYVthsFmv98TeMFn/vGGqhwa52r1sMVsSsWNxs6RosWdeFRTCcv6984ncldZrrxyD6mCnBP8BZVftAhNRIEsksKfAnsJNIJCTq9EabJQImDOp9udY6OY1K6ZoZVmvSuwDZ5X7x4OmERmagEuBQhFIjye1U8XZtWbd4V1+pXr i9wXalft yloFVtS+dWKrA4aiFDxkNmRl/Rd4H7iJsC/YV4RdHxJm1pUl1BP/sRyhLVTrI+p0qDwfNVYTA237uTfurioA+e01u44+80pvEFr7VZ0o0QLr7Z1N4i7Vf2iEYkn8VoLkS0FnzldRO7ISBNVvyndyuwMXc6yvFbGsMom8uikpdqrs4YZAyRmPj+5QJZmJrOwPUelii/olTWC5Acj49ykomvW0pAz6hPJxrqyaEgWTgCyq9Kw8X+zgXuPxDo0FENM+XbdjUm+EU2v2SaVsR3BrNL0OVw6P7Hfgbd1qVpKUKSN4tWX/6I9F3d3v0MpqUTkHfnujHSem+Serm+bRkvnX9pq0RTDwJ5dhB0QRKhGsJFE2V/wA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Assert there are no holders of VMA lock for reading when it is about to be destroyed. Signed-off-by: Suren Baghdasaryan --- include/linux/mm.h | 8 ++++++++ kernel/fork.c | 2 ++ 2 files changed, 10 insertions(+) diff --git a/include/linux/mm.h b/include/linux/mm.h index 594e835bad9c..c464fc8a514c 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -680,6 +680,13 @@ static inline void vma_assert_write_locked(struct vm_area_struct *vma) VM_BUG_ON_VMA(vma->vm_lock_seq != READ_ONCE(vma->vm_mm->mm_lock_seq), vma); } +static inline void vma_assert_no_reader(struct vm_area_struct *vma) +{ + VM_BUG_ON_VMA(rwsem_is_locked(&vma->lock) && + vma->vm_lock_seq != READ_ONCE(vma->vm_mm->mm_lock_seq), + vma); +} + #else /* CONFIG_PER_VMA_LOCK */ static inline void vma_init_lock(struct vm_area_struct *vma) {} @@ -688,6 +695,7 @@ static inline bool vma_read_trylock(struct vm_area_struct *vma) { return false; } static inline void vma_read_unlock(struct vm_area_struct *vma) {} static inline void vma_assert_write_locked(struct vm_area_struct *vma) {} +static inline void vma_assert_no_reader(struct vm_area_struct *vma) {} #endif /* CONFIG_PER_VMA_LOCK */ diff --git a/kernel/fork.c b/kernel/fork.c index 1591dd8a0745..6d9f14e55ecf 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -485,6 +485,8 @@ static void __vm_area_free(struct rcu_head *head) { struct vm_area_struct *vma = container_of(head, struct vm_area_struct, vm_rcu); + /* The vma should either have no lock holders or be write-locked. */ + vma_assert_no_reader(vma); kmem_cache_free(vm_area_cachep, vma); } #endif