From patchwork Wed Jan 11 12:37:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirill A . Shutemov" X-Patchwork-Id: 13096662 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AFA3C46467 for ; Wed, 11 Jan 2023 13:24:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C08F940007; Wed, 11 Jan 2023 08:24:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7ADB6900002; Wed, 11 Jan 2023 08:24:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B687940008; Wed, 11 Jan 2023 08:24:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2533E900002 for ; Wed, 11 Jan 2023 08:24:04 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E77A81A017E for ; Wed, 11 Jan 2023 13:24:03 +0000 (UTC) X-FDA: 80342586366.27.BAF3ACF Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf01.hostedemail.com (Postfix) with ESMTP id ECBD940004 for ; Wed, 11 Jan 2023 13:24:01 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=VwCc6Ij3; spf=none (imf01.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673443442; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gpMcPWw+KawxLiOKdWGlNB1Ju6DNgSGHUJPP1yQBi3Q=; b=HhLfOG6SoL/p7WgvGEIGlBKbe7/Eo+jbPBbOtdOsnbEyuMm+p620dUqB8DOyFvWUF4DqQD xWYQeOcYmr5G6FhAxPlxsMwxind2jVUzpORRDZ9j6huVLSpa1iGRQ7MViREX84X2UE8GPs Tu5Q6fPjGQJJjYiW64F4/F9iFwprhtg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=VwCc6Ij3; spf=none (imf01.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673443442; a=rsa-sha256; cv=none; b=Aoioc/GW+X0VSOouN5acaZT9sgsybKK4NsWg/T9b47dIQTyBBjy29sGqVjI1lsDr0P0/Oo Th3mHUP3fig0wNGv+fnjLaJCuqiEREEUXP4R6QHLvFEEVEtrVis/UjBL66tOSbKP6cL2K5 xv4LpnpB8hO1a84t4T1esxb5BMrhyR4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673443442; x=1704979442; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=yOPc1Ih/L2zXkoODIOcmvuNWh1/N6FlnZJa49Np69gU=; b=VwCc6Ij3hipIRrPTtlE0hJEDJD2ew0nhlUZIQZV4yVfayioSCGK4vT1E eD+RngpFdk/ScNaBUhrscIa5DZhuGMote7un2nJyoP7MWZCsvCJIIVq/n JvoFiF/iUy6IaXalj7Gc75c9TAIJ9PCpgbNMav/gyT3ZJ9dGYkab3y+9s wqqySn8BljQv8hVA5Xh/HGnlaZdWqe6yCvWn0Knhyt6W5/9AKENIA8Fa1 8KfV3Cpzho11TaBgrtBOrrCfjkXUmD5Sypa5BYabgyFEIJND34Q3CcQt7 aygg6jJO+azI65/bstNPbOQ7s8dy8QQHvYiHrWnt0+DKsSRINmiwFy4wl Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="324646104" X-IronPort-AV: E=Sophos;i="5.96,317,1665471600"; d="scan'208";a="324646104" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 05:23:54 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="720725483" X-IronPort-AV: E=Sophos;i="5.96,317,1665471600"; d="scan'208";a="720725483" Received: from bachaue1-mobl1.ger.corp.intel.com (HELO box.shutemov.name) ([10.252.37.250]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 05:23:49 -0800 Received: by box.shutemov.name (Postfix, from userid 1000) id 133EB109C7C; Wed, 11 Jan 2023 15:37:41 +0300 (+03) From: "Kirill A. Shutemov" To: Dave Hansen , Andy Lutomirski , Peter Zijlstra Cc: x86@kernel.org, Kostya Serebryany , Andrey Ryabinin , Andrey Konovalov , Alexander Potapenko , Taras Madan , Dmitry Vyukov , "H . J . Lu" , Andi Kleen , Rick Edgecombe , Bharata B Rao , Jacob Pan , Ashok Raj , Linus Torvalds , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" Subject: [PATCHv14 02/17] x86: Allow atomic MM_CONTEXT flags setting Date: Wed, 11 Jan 2023 15:37:21 +0300 Message-Id: <20230111123736.20025-3-kirill.shutemov@linux.intel.com> X-Mailer: git-send-email 2.38.2 In-Reply-To: <20230111123736.20025-1-kirill.shutemov@linux.intel.com> References: <20230111123736.20025-1-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 X-Stat-Signature: 7w3jejws5m933ctaedbjsfz6g4zafeyy X-Rspam-User: X-Rspamd-Queue-Id: ECBD940004 X-Rspamd-Server: rspam06 X-HE-Tag: 1673443441-834856 X-HE-Meta: U2FsdGVkX1/6vhGaNM2qHKli+5vT7TiN8JeUNfXrALZgOOAsEcHp43GWueFGXfvL/le6T+hUzUfeG6gbbT9SPR9hS+3nCbJVvEvc/sMtdUGsRp5DB1Q+r3IQ/CMHA/ARt4dxc6wj9mRCVut8DfgssDocHAuIfrdVdOSHI20y+ovCAAGV4F0AQmCrh9kR6PZAYJ/GchZY2XZQCv+ijR9Jofc/vw8V1Bm8GjvdsPfNQU6lVyy5laMey8bk4cDF5Zkv2m+j8dX7eyZV4VeLqsmN4otIVRLNJmHyTn3CvbJasKyI/mkMVha4WbD3ol0aFYsJebKmmRhEYPsgJ2I9p5Rc6V/ztkl2do/qkqQ3o7/1Y1c5zVA1TgAxIN1phemmEmKsa0gKlnolnfh323kdUBgr6RXaVJBqM2p+mrYwogSQNbWYeA0HtXUYF3Ew39Jpf5l1ltg4XQGZ9u0lZUsuNtFTL1RO457kvIYZ6/l2LKmAoI8A/HsACM4alJH1szE1cIvhAJ5yiGwUfGS9YPy6Zj6XVvlYhJq7wr/+ZT3kjDFoWZ7zVomyxFQViIoFV4TXmRc0fvSUrWvSlPSY2QvZg4hurYmL5BIpfMLpc8VmnHMMmy9jdOU8djCrH5l0boyS6AxMdhKV/ZdqkJmmMItlqoR1DT0Fiu23e6gUhM/qZuAvdZRS64vsOgBfkWUkxcx8C0Z9XCov5WgTM4RinhIy5hRTg2FjumD/obEAVjY4/fsiDdv8U1BJTUJ6V4C1SkDjwode4ElCQYgtGs5l2YRPg6SYUtLIRGH8Tbnpq8ZezPIuPcyk4CtG+jqa72aFC6GrFH67JNdUpSDROc86VodthzEGEDK60/bgWq8jD8UFf2SNyw7YZOZZoRAWf4GCW3DL1OVvGu4QvW5JYyuhetbOsG33mMZAXjv2DLWM3q5NLX8/Jh1XO4Lx17DOLW+nPT6jmaWmpzGMeIio4myg9PyqYXG uhKxNGdF sAZozvqc2ZvnESt82MkL2W+nwcOUY8qxXlu47 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: So far there's no need in atomic setting of MM context flags in mm_context_t::flags. The flags set early in exec and never change after that. LAM enabling requires atomic flag setting. The upcoming flag MM_CONTEXT_FORCE_TAGGED_SVA can be set much later in the process lifetime where multiple threads exist. Convert the field to unsigned long and do MM_CONTEXT_* accesses with __set_bit() and test_bit(). No functional changes. Signed-off-by: Kirill A. Shutemov --- arch/x86/entry/vsyscall/vsyscall_64.c | 2 +- arch/x86/include/asm/mmu.h | 6 +++--- arch/x86/include/asm/mmu_context.h | 2 +- arch/x86/kernel/process_64.c | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/x86/entry/vsyscall/vsyscall_64.c b/arch/x86/entry/vsyscall/vsyscall_64.c index 4af81df133ee..aa226f451c52 100644 --- a/arch/x86/entry/vsyscall/vsyscall_64.c +++ b/arch/x86/entry/vsyscall/vsyscall_64.c @@ -317,7 +317,7 @@ static struct vm_area_struct gate_vma __ro_after_init = { struct vm_area_struct *get_gate_vma(struct mm_struct *mm) { #ifdef CONFIG_COMPAT - if (!mm || !(mm->context.flags & MM_CONTEXT_HAS_VSYSCALL)) + if (!mm || !test_bit(MM_CONTEXT_HAS_VSYSCALL, &mm->context.flags)) return NULL; #endif if (vsyscall_mode == NONE) diff --git a/arch/x86/include/asm/mmu.h b/arch/x86/include/asm/mmu.h index 5d7494631ea9..efa3eaee522c 100644 --- a/arch/x86/include/asm/mmu.h +++ b/arch/x86/include/asm/mmu.h @@ -9,9 +9,9 @@ #include /* Uprobes on this MM assume 32-bit code */ -#define MM_CONTEXT_UPROBE_IA32 BIT(0) +#define MM_CONTEXT_UPROBE_IA32 0 /* vsyscall page is accessible on this MM */ -#define MM_CONTEXT_HAS_VSYSCALL BIT(1) +#define MM_CONTEXT_HAS_VSYSCALL 1 /* * x86 has arch-specific MMU state beyond what lives in mm_struct. @@ -39,7 +39,7 @@ typedef struct { #endif #ifdef CONFIG_X86_64 - unsigned short flags; + unsigned long flags; #endif struct mutex lock; diff --git a/arch/x86/include/asm/mmu_context.h b/arch/x86/include/asm/mmu_context.h index b8d40ddeab00..53ef591a6166 100644 --- a/arch/x86/include/asm/mmu_context.h +++ b/arch/x86/include/asm/mmu_context.h @@ -181,7 +181,7 @@ static inline void arch_exit_mmap(struct mm_struct *mm) static inline bool is_64bit_mm(struct mm_struct *mm) { return !IS_ENABLED(CONFIG_IA32_EMULATION) || - !(mm->context.flags & MM_CONTEXT_UPROBE_IA32); + !test_bit(MM_CONTEXT_UPROBE_IA32, &mm->context.flags); } #else static inline bool is_64bit_mm(struct mm_struct *mm) diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c index 4e34b3b68ebd..8b06034e8c70 100644 --- a/arch/x86/kernel/process_64.c +++ b/arch/x86/kernel/process_64.c @@ -671,7 +671,7 @@ void set_personality_64bit(void) task_pt_regs(current)->orig_ax = __NR_execve; current_thread_info()->status &= ~TS_COMPAT; if (current->mm) - current->mm->context.flags = MM_CONTEXT_HAS_VSYSCALL; + __set_bit(MM_CONTEXT_HAS_VSYSCALL, ¤t->mm->context.flags); /* TBD: overwrites user setup. Should have two bits. But 64bit processes have always behaved this way, @@ -708,7 +708,7 @@ static void __set_personality_ia32(void) * uprobes applied to this MM need to know this and * cannot use user_64bit_mode() at that time. */ - current->mm->context.flags = MM_CONTEXT_UPROBE_IA32; + __set_bit(MM_CONTEXT_UPROBE_IA32, ¤t->mm->context.flags); } current->personality |= force_personality32;