From patchwork Thu Jan 12 19:43:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Zijlstra X-Patchwork-Id: 13098770 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 111A1C677F1 for ; Thu, 12 Jan 2023 19:58:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2009B80010; Thu, 12 Jan 2023 14:57:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 193E88000E; Thu, 12 Jan 2023 14:57:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3CB780010; Thu, 12 Jan 2023 14:57:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A82A58000E for ; Thu, 12 Jan 2023 14:57:31 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 84FA2A0DE3 for ; Thu, 12 Jan 2023 19:57:31 +0000 (UTC) X-FDA: 80347206702.01.41DE682 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf22.hostedemail.com (Postfix) with ESMTP id 085AFC0015 for ; Thu, 12 Jan 2023 19:57:28 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b="MCFGk/zf"; spf=none (imf22.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673553449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=tPOdw9LFGiPCDTfwXmDjC03yH+Atd2yWpwgqK4SP6Bs=; b=AvghVs09U8oARx9JdTMtmLavrR1pZ8Ik5G1elk4h/52zlkdQL3wxnoJW99OcD2sYpKlnCi G0ywylGRmVsjEruzf+h40s4o6ejSinGIMpcdRuxkk/Y2QHgQ8xVhKe2vhJjiATJb4Wpd5h tTKPydyCBt23EDydJvCqInirRsy1jM4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b="MCFGk/zf"; spf=none (imf22.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673553449; a=rsa-sha256; cv=none; b=5ZvpUpvRQnGexJ+QkuH86u1b/K+Pt3z3IhXnkDAPRDg9mXxrYITGFTz5/gRrhrunIKhd0T +31oee/SZiCGl5BFDNaHji8TFNkhvSM/jopG+AAePsLn+V9PTEDPrnYU/w28SStQJoSbro c721j+UtD9OLhyzL6kp8gs6KwLmkppk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=tPOdw9LFGiPCDTfwXmDjC03yH+Atd2yWpwgqK4SP6Bs=; b=MCFGk/zfAQ1MOxe655CfrxSndB KMsj8OM47QEIEF+dE7LPbkmxg/PQAts31gFJ5Xz3no3m62IuisxdrSXrLN8SYgr1mtDIwtR8p1Foy vgMnbz7h6ch5F50b53yunuqk9MFEuX5uEMORRcRhTqQRFnQzXIgNjlWLrzQ8IyZodgjiEI5j/hfm2 jtsLGmSu2xYww6Em1c+Sd7XPqSMSM0BgTy1Y9iUSaQMsmpIltEMs2Z+FvPcdV8LPGTs0uCR8XY70j Jdml4OVol/2E06Nb6eijodGglka4wn0K9TaSFCWA1YgF/306McxeUsk6Jgniwje3STV7G1K2gesSb SZObcOlw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pG3hB-0045nq-0A; Thu, 12 Jan 2023 19:57:05 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 5F208300F30; Thu, 12 Jan 2023 20:57:11 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id 9180D2CCF0C22; Thu, 12 Jan 2023 20:57:07 +0100 (CET) Message-ID: <20230112195539.453613251@infradead.org> User-Agent: quilt/0.66 Date: Thu, 12 Jan 2023 20:43:16 +0100 From: Peter Zijlstra To: peterz@infradead.org Cc: richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, nsekhar@ti.com, brgl@bgdev.pl, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, atishp@atishpatra.org, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, dennis@kernel.org, tj@kernel.org, cl@linux.com, rostedt@goodmis.org, mhiramat@kernel.org, frederic@kernel.org, paulmck@kernel.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, vincenzo.frascino@arm.com, Andrew Morton , jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, "Rafael J. Wysocki" , Ulf Hansson Subject: [PATCH v3 02/51] x86/idle: Replace x86_idle with a static_call References: <20230112194314.845371875@infradead.org> MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 085AFC0015 X-Stat-Signature: knfq7nzcpytu948qoy86qzzsgjpf1ibd X-Rspam-User: X-HE-Tag: 1673553448-534492 X-HE-Meta: U2FsdGVkX18MV9y4V30OEExi5E2dKXkhGKdTjJGjUfVQe5rs4c6HChvbdjiezaCSnGHHtDHqv8lZdNe6qJRTG+gFeUM2BjUv5FXnK9NDPMUzRHKHXidQFYi4BZGbj7+LkVIaWs2w6XQAAhL0IP1o6eZSN+FAM12+p24CUYeos/gFc7tWb8jNyBB3ur4LRKoX2ZhHBI4uiu73U9uBozL4ql9k6aD1L1pQJUJN+vlR/Jedb1W9o0OVCbl5EKgwspBG6AnKdRGL4uuofuZTW8PSt3NPsB6jzkfu9P7WrWhiwzOzIsm8h4UsUQe69d9mQ3fIhj2mjq9pkglhZhoPQf8ojX4h8VEFYg/fxc8KCdhWLJE7Zcj5VRP4QZVVyCsEWNpIrQ3rTGBoF1qbQgt071RUFgh0C6aezrMnQsgJvOHPF76DVH08CwyUWE2X7fe0Q3aUx+m5BXwHO8UQQdBJ2uSJ8Kx+8BTrqwpjIxDiTsH0+1cie+Gn6/cAuC/E0W0lddSOqpFcNnW2RnhtKEiPooOMsxVBjhyzw0ZK3d1wc/79WacYPBu143Rs9bUiqaydNJodn9iCJGh97S9ZNSVGy9w36CpsCr3Haraf2zrxBuD+EE76eJJQ0w63+UOsYwxYxHgUqwvpvU6YsxRE8D32apbAO+WeMAIZ/ccS9reA4c6U4acG81kaxMgPstEj89KKKyXivIJtZcIX1AP6VM2JArhUkm99POo/kPKbpRFjeXY6/5k+ikrWan7XpBU9kteC7POIQCMar/GChhaBsi0HokbJxulbmMjkBGtrCy7HwFtYKs/z+UHM955LjmOoaugrf68jqM3y54E7xj9Ws6YYrolw2hWNPHcMul2inOLmkV8/dbYZSxMXpmM/mBzlvQs/XQPrxDLYcx7Ep6QFeErW1735oIbDCz0oeQFZM5t+iL7eiskF/kyqINhzTIhHeWfyLWOaHlNJ0oCjSUZTTfk3pi2 a5mqEbRY WfZ1uRUqaPt2iW2c9CKvJn3oRxpYAVYGRuQsJsGnBZ3gN2xhRzw/I0k2S612yQPDqxJkZzzKCxOd52/dHKZC3u3h9K0rSy1Utt7aGoxjbyQ+JvOe+GBp2PH1RTQMsRKwqRdkAs5u3xz79XFIMSnIWpik6nnC/MZB6DIpwr2Q/J3usUfIj7N9CXicYd0S4hbHl0J4AU/i5i2W8Cv5WE5Sz3zhq7FvGZKgjPAVv1CnVImF7VPb50eGKVNBWiF9nQnR+iRTRX0lCT40vSHyVACRh/wspa9G9ij0X/HTHIe9Lv+/XOUA1VeIcfluUusodITAwfrohjVtWJslB0rQy1k8zXhWt1NSQcohqc1YhEYlYJUuBW+68DJIRxQhxTewbX9ngcxUXvSY4pyV7ny3MxfsJj5gO7LUfYnl2bHuB7ToGGRr4ECliagtRK+N3aIqKdtR0VDDQP2fKnJuJnp1UXM5hq1pZSjYkcZL9NsiBGreWCF+Uat1v8ukMRnPcuVNU5+4ii6scdrFeHONsrEW1cruJC/+HKZ1cKYtq1gl0KYO4WjyIBtjV883o0bnqSlWNmn0UPBDhzLVIgLhVfZY9Up6eeLuawlgoYPRysPa1N7WBrhBNNSiN74exHAEIkcrg3P6qQBaAorEfa2euZtT6T8aQQ1LbnJAUCZ5xTafiy0VD0njVRWAD+bvhvk1HeZY5tC5WuHK2YV6CodMNZoiiE/Cg/p/nwU79LRXI6aq6r++TMIpe/hNBmSiVcvt77287hLJ2yqZKeWmBHXfuotBFMuZNXDP93r67cZkEeTfxQ953k6KYtDQA7DYKlVwYTHOHs7wFDEjkkULNmL5UHJdIgATK/rX0nAHLoGRDcHz+E0pavQqjxgk4H9U6mNs+00/7RL4gtu5fmlu/q5yKOIKez9B+PpHQ4kpFNsfMfLjRDEMvYJ+6+YMjtIppz+wS+T5X9St/n8ADnoLRPIxglaF3E+EyVt0/1nic Khp9poaB ua07SC1kcAwv0cPufCugozSVBXmMRlSQWQJiSUXb9rTF4cdpYOil5yZpEDf+xSCY7kx4HGTa1BNSMjBkB0h4OUe9dFhsIgwmuf18eAd/0EpdAxu7YwVlFF7rNJQBEDMhdQNEaDgDPRVmgRITZ0e2VLF0QJSo8PApWObGWzHEr8AXLkbDZS8OIAuPbK0p4uSkvhbTlnwSGMz/ESFESrGMh69MOn06mdQa2kE8VfpU1pVz/DA95SzRiYbcU2lOY2OavM0U0etbNF0bK6vUlJ8OzgEMzsVy/qBtn/2zGC3M3lugPD2KsEGa/JOaraQ4ZLCCcdxv+abhmwDi2tYxoONDrstcWDtOUTSMPYW2/g8wyuJhkJW4i/VO5OjD6VAO4pHH4yRGx14xVNQ6E14+Ns7iMxfmsXyOsD4bUhuW1uXKqBWQlmLwJJULu8o83OYVeKtNIbSCNvhG1FV5Qo++/HFrFN1gZ1AgnL7xMtLkh/9auOc5MzX/CLz5vtBOjA5QdxYzD7c/urSfMYEnt4aWo20c+7dhVUl+2IRGWHZ7cEdlAyJh66QYQhQDtzp/O5Tq9yoUMExBTCtRnMIipnK+XG4JZYAmQWEUxz8Vq4eWsqNRQecpQSp6G1g4lITw7nY/YJ8w3l/zap6ncyNOcC/dxI8uBPwfb6Utl2tUffk1y/2K6s4FtwSaYXczJyELclq9f+eY56deAlT+sbw58DQjC5Fml4UxnEp9Sf//eiDJrjLRfyTQcixuVNrx6m4HpvOg4Q1gdQCcCU8/RMm+69jht1/DvbmcR1C+xnJjV86ADj+Pa6j81ASFcC2u3mQrTpEXV5IeFDnNTUj3xH3SbgYdS7M36gflJD5Oq1Dp9/KRGlkodBrjIPbYgI0TzEzRPm0sawFq9CSwhAwiCBzwSPNqtQPDB7VJ2/Y3edxLhMkmxLh17bZe0WaLsRJhalXyd/kptOixkHIYTuJvy9eWqXtuODGx90jpSxd0Q tI7Z7AQu bdd++iC195UJlP7X658rHdgSj2I0D2ZCnS9ppk8jRAgD0g8h4eLsC5zY5J7X3oZowV2U22N3JHe+X9HpuSqP3w8KudN5vqHAHj2cVlZeaBZPY3KNdZ4vvqY8Xm30piiUy2j0XiNmoudoaY6ZkBh11+8xztXWLN/MFLm1/8MUtLAKByM+BpfoNrBznogME7xb6i9HXM5BX25K23acgiqufN6Mdn/TsX0hExLxz0c64NBnMUE/P/9dq/WHy94eJTwNm4L276eNKbCiPwAu8+FpztZw2uuy6I51qq4LUgTd+ERS2ysz5zKY4TVWUt01N3Vm5av0Jhfq9x+0az12thcpiUUGutjI7MX7bSqhKj3iHjXeyTzhIX2jLvnG34AySWyZrcP1N1Tb+07iSdL70G6cQqCM9lUYCZ57dtK3DMGDdGpB6dPmVdsDMRlH7aJthRx3nwsiIZ6+eCFZaVs8Kn3INlG5zdXZROB7W6Zx3C7oCnsqlQ0d52Atze8UZERH1rImshyWQ22jPl3G6PMweLNoNP0/MCcYxGPZGXr7iTdPVzlJQkH96vAxNx1wfcwXMNaZDWtBXHXBtZjMq9M4FnQewjj18qqDS4Z9IBBWD3P78kT49JcI6xriQS8A1UQyg6+JV0RpxpLcHXUGY8H+YkYn8WUq3dJPJ1FfYUTzZhp/u37gz8z/DS72ovsVDPKpz0LTVkFyR/lRUiS3ZpuHR0UBv3dBqCRqgzN2vqZqfBWHw7KOoNzXGNQ0hGklu3mE2Xj0emqaOOaUtTje/4xsNrGmogOPg1+Q8Qu5px0zyD2xL+p1X0pYtUawKIoxfRN0gn3vVE0Sk7cJuadRA97IhyDzTz07/0H1CZqQJBaSnJHEWxEYY6xPK7Ki3TzDOfqGmEMwy7bS1tbuz+PDliUL116xgFHwbzaBliOy6zuajlocNXoAOZ7kOFtrBjfA+uklU/6GFwvh8ovA4NNU7y3VToSIUntZ0E8JM 2vWMBLBK xYhcVAcF2WFfZbpCWPr6inng1z4h6MpQPwiVFqCIjkPyJGX7/lHLMPiypLA2ERU/ig6OIPd8GhEEyM3/EERr7zwEmUGV7/6s2OW+y09ddT4WiVTSltSdq53//IexfeFXsHuBIv+GV5XoF5klWrRCDx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Typical boot time setup; no need to suffer an indirect call for that. Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Frederic Weisbecker Reviewed-by: Rafael J. Wysocki Tested-by: Tony Lindgren Tested-by: Ulf Hansson --- arch/x86/kernel/process.c | 50 +++++++++++++++++++++++++--------------------- 1 file changed, 28 insertions(+), 22 deletions(-) --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #include @@ -692,7 +693,23 @@ void __switch_to_xtra(struct task_struct unsigned long boot_option_idle_override = IDLE_NO_OVERRIDE; EXPORT_SYMBOL(boot_option_idle_override); -static void (*x86_idle)(void); +/* + * We use this if we don't have any better idle routine.. + */ +void __cpuidle default_idle(void) +{ + raw_safe_halt(); +} +#if defined(CONFIG_APM_MODULE) || defined(CONFIG_HALTPOLL_CPUIDLE_MODULE) +EXPORT_SYMBOL(default_idle); +#endif + +DEFINE_STATIC_CALL_NULL(x86_idle, default_idle); + +static bool x86_idle_set(void) +{ + return !!static_call_query(x86_idle); +} #ifndef CONFIG_SMP static inline void play_dead(void) @@ -715,28 +732,17 @@ void arch_cpu_idle_dead(void) /* * Called from the generic idle code. */ -void arch_cpu_idle(void) -{ - x86_idle(); -} - -/* - * We use this if we don't have any better idle routine.. - */ -void __cpuidle default_idle(void) +void __cpuidle arch_cpu_idle(void) { - raw_safe_halt(); + static_call(x86_idle)(); } -#if defined(CONFIG_APM_MODULE) || defined(CONFIG_HALTPOLL_CPUIDLE_MODULE) -EXPORT_SYMBOL(default_idle); -#endif #ifdef CONFIG_XEN bool xen_set_default_idle(void) { - bool ret = !!x86_idle; + bool ret = x86_idle_set(); - x86_idle = default_idle; + static_call_update(x86_idle, default_idle); return ret; } @@ -859,20 +865,20 @@ void select_idle_routine(const struct cp if (boot_option_idle_override == IDLE_POLL && smp_num_siblings > 1) pr_warn_once("WARNING: polling idle and HT enabled, performance may degrade\n"); #endif - if (x86_idle || boot_option_idle_override == IDLE_POLL) + if (x86_idle_set() || boot_option_idle_override == IDLE_POLL) return; if (boot_cpu_has_bug(X86_BUG_AMD_E400)) { pr_info("using AMD E400 aware idle routine\n"); - x86_idle = amd_e400_idle; + static_call_update(x86_idle, amd_e400_idle); } else if (prefer_mwait_c1_over_halt(c)) { pr_info("using mwait in idle threads\n"); - x86_idle = mwait_idle; + static_call_update(x86_idle, mwait_idle); } else if (cpu_feature_enabled(X86_FEATURE_TDX_GUEST)) { pr_info("using TDX aware idle routine\n"); - x86_idle = tdx_safe_halt; + static_call_update(x86_idle, tdx_safe_halt); } else - x86_idle = default_idle; + static_call_update(x86_idle, default_idle); } void amd_e400_c1e_apic_setup(void) @@ -925,7 +931,7 @@ static int __init idle_setup(char *str) * To continue to load the CPU idle driver, don't touch * the boot_option_idle_override. */ - x86_idle = default_idle; + static_call_update(x86_idle, default_idle); boot_option_idle_override = IDLE_HALT; } else if (!strcmp(str, "nomwait")) { /*