From patchwork Thu Jan 12 19:43:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Zijlstra X-Patchwork-Id: 13098758 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE57DC63797 for ; Thu, 12 Jan 2023 19:57:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15EDD8E0005; Thu, 12 Jan 2023 14:57:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 09DD680008; Thu, 12 Jan 2023 14:57:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 477CE8E0009; Thu, 12 Jan 2023 14:57:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 17B2F900003 for ; Thu, 12 Jan 2023 14:57:26 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E1C1EC0D34 for ; Thu, 12 Jan 2023 19:57:25 +0000 (UTC) X-FDA: 80347206450.10.172DF6E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id AA4741C0015 for ; Thu, 12 Jan 2023 19:57:22 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YR175EZY; spf=none (imf20.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673553443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=uinp+F1SpsUbDqJ/LD9jugydtpLudfVqOBpAkBm/Kuw=; b=ndNb/l+NQMYlhAXSKqBN5KDBzKLvPWDNzhxZfi02fKH6rfxnlj0JQwhPgI61AY9oWpAAd3 CdBbYI7xpAX4BX1jO65sB9Casdbor9sr3JV5Xsn22RZQOxe/jbVuiYPRawc6YYDzCMHqH0 gWZJ8U59VHlp11C5sGH+SULHEBR5Abg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YR175EZY; spf=none (imf20.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673553443; a=rsa-sha256; cv=none; b=IHJ/GC6isIIl++pK01qagOp1un5ru0E0+FFStnqQUFHTBtjslKHxBrImoRwrIy4RJAC4ul uhOkz8e96xNLuk8F7+yKx31+XFGY/NBQS81G7z8pDpWnARVr/+UOlFDKYiA4WIgY77OV/U E1nbwNeug2VUN1xVgx4TOywCx5WpTpw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=uinp+F1SpsUbDqJ/LD9jugydtpLudfVqOBpAkBm/Kuw=; b=YR175EZY4r1kZkSNwONKk5sRjm 0Jh9q1s+0AnbJ3XR1s+uETOHy6/KMPWcZ2A/3pPA2YRmIe4FLXT5YQWBLkP162ZQZQxcLo5zKmBR8 yPxuLFclFoYWLWUAfQaCyKbJfRfGBsr2SyTtFnOANeO7FTb/SglFZ6SweZE90daB8dw1ASmM8UjQM M4ZnMo5a3b3a00pQSh2naJ9Y8eCc6pRMpPzYKWwgFkcsiZ93mCPMmAdByjjnxT7hStav5sFWJ+w/a kpBCoIODr/szF4CoOZ9aEs2Ye7nsYGTHHRFperi/Zde5nuQcuGmRSiIIIE6VXydfVcevstKfVVHvk kpjr9KYQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pG3hX-005OcT-Tg; Thu, 12 Jan 2023 19:57:27 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 0BFF63033F7; Thu, 12 Jan 2023 20:57:13 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id ADA0F2CCF1F54; Thu, 12 Jan 2023 20:57:07 +0100 (CET) Message-ID: <20230112195539.821714572@infradead.org> User-Agent: quilt/0.66 Date: Thu, 12 Jan 2023 20:43:22 +0100 From: Peter Zijlstra To: peterz@infradead.org Cc: richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, nsekhar@ti.com, brgl@bgdev.pl, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, atishp@atishpatra.org, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, dennis@kernel.org, tj@kernel.org, cl@linux.com, rostedt@goodmis.org, mhiramat@kernel.org, frederic@kernel.org, paulmck@kernel.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, vincenzo.frascino@arm.com, Andrew Morton , jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, "Rafael J. Wysocki" , Ulf Hansson Subject: [PATCH v3 08/51] cpuidle,imx6: Push RCU-idle into driver References: <20230112194314.845371875@infradead.org> MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AA4741C0015 X-Rspam-User: X-Stat-Signature: wapjjirb58bukcwwudzdqpacbp74epjp X-HE-Tag: 1673553442-918660 X-HE-Meta: U2FsdGVkX1+DVrnJ+YZL3meyyFEUe8qaFg21KLnSIL7OlbGrZIkSiUtkLv2iee29GYYlCmHr9aB2P764yRe4epzBtO1ZCcxLzNEJEUiUXxoQ6wxOsEHi/Kn6ypRg6wpSc9aO8Yo1RDObRt6F1WIkzkBOs0ZB1OgQQQk7aDRVHtUSC2+ENrbvN4kxbQKNS5s0PDMyr1ZEcBUUP+3ZIsNVDbbZa2mBYP680JT8qug8d4C30B55F1QuwC+eZwclngTxovFKLE/dEyYsO8G1MWq27X7Xguj9jzDHr0QADfksfKaQZN9PFF2QP/ECo81NOfJuPXDVW41S40ha+2q5QY0fabVqJjtwl73pLu9ziAGv4ezKWxDixfkoN707omvVI5B5lGRxJ0ayrVEJ8dFLJ9dkNPZMuMQDQFPqs2FFVnRqrWpSacuHaOc5dyQaFq5hI2nzHcZgxB9/R/oxgEQOlJcR3M1HFBQY30UqgYiEe5VgA+CILyETPhb0gqxdbC3+x8Bprvl6URhTrX2Yyt89zJoabf8bKKFcFvJ+sT0ZqAKb1C3jZ730t5sIgMbcFXasx4UK1nCbb5xPFIvJ+EL7OV6SK5MxlJkOP/7/KaHmalRqapWDyJCqinWqCt8N14sOiT4RrA956bC5Lxtu9lsUz7U168zUuEsiWS/DWpzn8dvYU2SsbyusllXQXI82Q/g8kmohY7o8oWAPc31lTrl6INH8kxNFCBAMbh2O2iMdAq5nl8ir5Q38ICgKltxel1CsK+ftD4kGTactmO6dCFpgJOXzNt+cnKZfKPxif1P8/E+KgtUih9DUwhHm74n4Gs8cXuw7xk/cN4+3++tie75iQsIW+M0potueLwLrIjkCnpciZ9lWkU8V5KY613XFiPAk63TJfwJcc+1BP9aDe/YptpbIiavehOa1eCFmTpg5BGtHZVaPuoXkA+BtbKp4H/OhD34ueTTvlKQOhLJ0+Gb9zKY 60evAQC3 hX5E2BvsPV30D+MZPx2/VdpshfXVdgdQf5STBTArAZinzOhaCAcKzcG9zLR1D9hAINOJNtUOzR9NUv/0EEjz1s9ho8QwHh8PnOlTdvEt/3FIIVTnUaBE/VeK+zFDWweqx66I3jNe2UpwUcdTsK0mVCmyT+8aRR5oF3RQOPAwaq7D46suHueTJ8mPPaLCOcPw7eFfU2TVVbYAwIkBRRN2tfia120JmfwFHKbLSKU0XCVqqfG+mrRQNiiAE4UaWPmcn1PFw0wBC31Ke2W331+cQC+RoElYLhQr5bG3sf2zKbDaGQpDMkg/0yis2KgPpob2Ph/NKCG6yrf4otWcXPwxBCwzJdBERyaaK8HBx2SNV8jr00pMxjvH/INPm+6AP8JI1ee7Yhk75yepDpyaow+4q+4VJ4f5kpKESJfEYjiIdydczIvkV7HozfK9VP5k1h3mJ8cbVl1yEBRJStGhaXkuW02V0czbkMKY1i9Q5Yfbn80+xL2kQRwbv9NafqXJSCSRY34XcYuxk15t8SuXpgDOENAX0Kq0dtlnmsUFwiCUG4okqodj0xTWDEI1Ry4ocOwh6rLEk7Gd47LCXvuXZxWO6A4Q1uBY/CEUIXRvbuY11Hbm0irCsmKJKzTHZt/E2ysCbnNC/42mljRmz4/mkcDsY/r6sf+LcA0T5qcrZPBdLMYTpLC4U/mGtT+mFoKa1b2H3nLsxNVgoJurmmFcxtpWXYXurVk1hDn4SNTqGK7ZyiwcFmp+IH9jpiY/rB2/QJ1MxX0eGHMp35J9Gix0My9a8TCsweXv8w3u1PuOtxbTI8QhWpobh9gmtyC94RfVQf5DWAEqx9dkBR2n2Ui4E4U6tji+brDOmHFElVLWDPS5Sr25x8Kb9CVP5nBauZ9EJsxPpcmN7xpEt/x6Z541TI1C/IW0tT0iuEsgIZ4djXXCQ5VN8O1iVqKy365g7LtrwaN5mJlUi09ohy2i5w2Dl/rt6w+3vS95w CRuJ1O7e 5FeofiO2Wki2FcOnJsQI/rRfBlDhcnF0W4ERmfEVULJSbJ6NgdJHX1ELPyYqg9oMLxD0ilfgGU3IUX50Lre+VKWaQ+cx8Hp1PZtQdtHr5YUB3hsuioQBDA0ouWMmnNhRCKVVaVeH3RNN7qRAcDFaGgimMmRmE3Hu+r1l/mo81OvbqMKBc4fukPH7ZWDMP3tRyDumK93iL0yELXjGTpJASBWyiV50xCswexPbKTnVFg/MwXpvC7uPJgxvuMMRSarq0vURsdbfB3IAXNQnlYocxrdOSTfgDmxumbErcPua1CpSzL84ZNdG/DNf14Qnvch4Ic44E9KlsgSzXFARhZ/XDjvWmBl/mLwg9m+kVjBJHQ93GRjFEs0HFvMcSrESQ5wDB5QRE6MvO6DvyyyTrntH9JekH4beplplH1aRIgYpQbVYHj+JKqWQOrIsRPh0D7nLIYgzLkj0lpR/ctUz3bppkPEgZ9cfr25gkVXDceMcSgEcMLnqB30C7iMkv/2SvBAmQSuTkJ0AUehsPhAjhA0opnvyHfTyzCNvrIf5l/YCI9F5Mll87kwynMUIV7RCqFiStw4S5eB5kIBFxQS32pHTiz/abfu0jYD7FyZLa5M2/dtpMOC5d8hbwB+O/FplylVW/VBtyVgpYEgrs7gBx5weY1i72UXdA3HiyAzEWVykYBFQf3Wm+UNopm+RGwcOlnvnMifI8n65ciL23BwNX5i5nhaWDBYrnK47V1aESJ7z7rdAbKVaPVQxptoLr2aAfJY2HsC5Flo/n6ScqkjF7TeeRx0JgNKkH8yMX8QSvgu3BsOMMlaa+EetZOteYFBhLZg/9kWSDfeY4fJfH/R8QTD3agnSPZuH3KsBG3QmBm/2axFtxT9VLhA1H794GC+ZjjAiVtvh7MmUCU+n0wMMEOhfdvLDLPtUyqYcruqdtVZvNxyK5VZ9taIBbHfGebhvPAdtnquaQc/SzzxLkUX+YgddonRxI4eMN Mi1UOA8g tVVHWrRwmmYhbxGWPf+N9sxhcBgDFEu8R42ln2hX6eRaMS/0+T5Zc1karrXbZ8npnDDyS6mBBUJficp1X3hAuZFNeuivAUowyg06mj+x4+vPnnc7cGIWeJYz9aBCfK2G/ZYh1OauCcvQncrPXy0hc0NFPD6TyaC50iXJ8kzaXQXYm0EFkRHZTdOknnk4F0iyEexpwmNa9eI9R4Oh6KANXKdHewH1t3eAGSFvpPW6uYZQ45xo9gqOEogWK5bgF9XD94Dm9TyDWMhglzT0rJ44dDX80fDMiGk/X+CKA8I2k8euOKyrCb4k5Fuj9yPx3VR3D02Ou2XMOZvRfwiFLrzApBEAAfLQJ/Xn0cpEEvHwOeIJVj0l6DxpcfMGxCDHnA3kOeRjrwPBpVzNRE1i4RVU0qQnbntkPA+SK/OXa0QlUvb16R6OTfeCRGMaBMCpaGufhVsAsnfqjKu2gXqMumPaHwW2dsYgNBdhaCy0iaX/x0pHxO/a9OWxYD+3oGXqbutrTQsgIXjvRo8arK5Ud30HrfSJu8p3o+N0Hy9TWSUMicZnD0jaH+qvpKasrNbv4qnd8ydeOVPMFON68TISzGvlUStbQi/qyLsYrnPSU3UBo0x5z8IEdJc/bLL1nm3YEWgEAjQpyEeGQv9SOff9jZWTzYoovqlLJ34z8Xrqv3FgB/ibX3dNyogQK0XoMdgwty022iQ2D4GNguzjTgtK4y3mMzaWzEqrJ3DbTKRLSSXh2sNZ6g6F29QuuEMPeU6OoETKNBF7eWefcfmO8ZvI1Nc93m0CTq5ZM+5edBi7UcI3aN4wQ5fNPPCJPBH7OzRgwrwOPd/mVmrjCXnZNix+Lbip9GiMrTvQzW40XB4a/Zbb583HJUberSZ5XrcGJepcGRf8pHPfHHkx0rJuW8EE6l+53y9iZLQbgxZt5a6ucbTF6mBLHfk7Vj/jraKrHjSIpyJjCCnUiZOp2dfzf1eqXk7cbnzeeW/bi pHq27o1r iq+8XoG4/ie0uwSKrJpVwB48zW0xuhsKPHZvRMhx+jLt24NY4tU3ab9h68QiKqxPHfm4H0E1ukBvxbozfJQV2JRLOu9xWxR7bIqinnrsL24A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Doing RCU-idle outside the driver, only to then temporarily enable it again, at least twice, before going idle is daft. Notably both cpu_pm_enter() and cpu_cluster_pm_enter() implicity re-enable RCU. Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Frederic Weisbecker Acked-by: Rafael J. Wysocki Tested-by: Tony Lindgren Tested-by: Ulf Hansson --- arch/arm/mach-imx/cpuidle-imx6sx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/arch/arm/mach-imx/cpuidle-imx6sx.c +++ b/arch/arm/mach-imx/cpuidle-imx6sx.c @@ -47,7 +47,9 @@ static int imx6sx_enter_wait(struct cpui cpu_pm_enter(); cpu_cluster_pm_enter(); + ct_idle_enter(); cpu_suspend(0, imx6sx_idle_finish); + ct_idle_exit(); cpu_cluster_pm_exit(); cpu_pm_exit(); @@ -87,7 +89,8 @@ static struct cpuidle_driver imx6sx_cpui */ .exit_latency = 300, .target_residency = 500, - .flags = CPUIDLE_FLAG_TIMER_STOP, + .flags = CPUIDLE_FLAG_TIMER_STOP | + CPUIDLE_FLAG_RCU_IDLE, .enter = imx6sx_enter_wait, .name = "LOW-POWER-IDLE", .desc = "ARM power off",