| Message ID | 20230116164332.79500-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [next] mm/secretmem: remove redundant initiialization of pointer file | expand |
On Mon, Jan 16, 2023 at 04:43:32PM +0000, Colin Ian King wrote: > The pointer file is being initialized with a value that is never read, it > is being re-assigned later on. Clean up code by removing the redundant > initialization. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org> > --- > mm/secretmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index 04c3ac9448a1..be3fff86ba00 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -190,7 +190,7 @@ static struct vfsmount *secretmem_mnt; > > static struct file *secretmem_file_create(unsigned long flags) > { > - struct file *file = ERR_PTR(-ENOMEM); > + struct file *file; > struct inode *inode; > const char *anon_name = "[secretmem]"; > const struct qstr qname = QSTR_INIT(anon_name, strlen(anon_name)); > -- > 2.30.2 > >
diff --git a/mm/secretmem.c b/mm/secretmem.c index 04c3ac9448a1..be3fff86ba00 100644 --- a/mm/secretmem.c +++ b/mm/secretmem.c @@ -190,7 +190,7 @@ static struct vfsmount *secretmem_mnt; static struct file *secretmem_file_create(unsigned long flags) { - struct file *file = ERR_PTR(-ENOMEM); + struct file *file; struct inode *inode; const char *anon_name = "[secretmem]"; const struct qstr qname = QSTR_INIT(anon_name, strlen(anon_name));
The pointer file is being initialized with a value that is never read, it is being re-assigned later on. Clean up code by removing the redundant initialization. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- mm/secretmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)