From patchwork Tue Jan 24 02:11:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nhat Pham X-Patchwork-Id: 13113307 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9C06C05027 for ; Tue, 24 Jan 2023 02:11:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E521D6B0078; Mon, 23 Jan 2023 21:11:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB0FB6B007B; Mon, 23 Jan 2023 21:11:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C05406B007D; Mon, 23 Jan 2023 21:11:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A89416B0078 for ; Mon, 23 Jan 2023 21:11:25 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8EB60140490 for ; Tue, 24 Jan 2023 02:11:25 +0000 (UTC) X-FDA: 80388065730.10.CEC165E Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf26.hostedemail.com (Postfix) with ESMTP id B16E614000A for ; Tue, 24 Jan 2023 02:11:23 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qolPgDzV; spf=pass (imf26.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674526283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OaOZQvWhqFGfMeSz4AFcJuI7rpVT7E7rM49XqO7Em38=; b=O6SrAEheBq6GlguIDfyF+e5phprdSMza6YpqofEJ3DmMGGO6QSJMfRLTFk+vLrF2OE6HLZ TaXJSqa3Ulh4qEskfU9UKcAASnFX1Z9eeYuHiivTOhdQzXK6aOgQJuP0ML+kXo6n3Oxc42 +deKw8RD5J5aixQJYZU3k9dHuBGbrq8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qolPgDzV; spf=pass (imf26.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674526283; a=rsa-sha256; cv=none; b=634jZEfdDLJHWjtQe1wGOcZ3BmKf+lBagNqwCjvOzzhCh4wDRXNGkSA57A8RQ9PCU1CdLp cTr49obsbPJxT4kIItpWi4wumdGq9rrp3eJIUtWzc8h5w3YBzisw8fbHgMvh6lcH5M9t3d bFJx2cCYS51z3dUm5D7j3a9QycQvh8U= Received: by mail-pg1-f176.google.com with SMTP id 78so10396866pgb.8 for ; Mon, 23 Jan 2023 18:11:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OaOZQvWhqFGfMeSz4AFcJuI7rpVT7E7rM49XqO7Em38=; b=qolPgDzV6WTMmEI6CTfee/XNnVeFwSycBdR6sxa3RDTKsFEDFbfMDpf1yuiHkUoB0W qCAwE42zut1UXqmTkksmHh7anIagLJcUdajFLA2QC2PYIw7xbyYuvxoK/6F+f/4wqGaI YKyROuufnspTUugUqFdGDlv806xubBy0D0UGkfDDKKg0GW4KLgCL4ahV8fQduxJQlJPu WTDFRZwSuWONdLpOdHCOiIa4oLlPgBmgXQSG87O7gLMHf0Rztwdlwj/s3xSZB9V2URG1 rQ82yD4/PYKQw/+d9rMXUMQQK5gCTvKbZhUZ9K4PVgk+VtNkM0VjEr/hMyLXaoDHdDNF tfjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OaOZQvWhqFGfMeSz4AFcJuI7rpVT7E7rM49XqO7Em38=; b=cHHHE2xnSl4p44tVjBVluqLCC796xuoW+Rykd2BzAd1ZN4K6BLNF9NMAjrDlpVwtLn k03bpnXXmQTgbAMHIX0t/CP9ManPgn53w0IEKVEFftDKZr3810ABkkduTMdMtZOyQulM fGHoZkuBR2knh8a//5xt7/9b0NRQ8+O+SVS4Dtt2bXKS77tMhlK/9bKPOO05x3+KwNbG QMWIXbhOyxO6bF5GNXtLxjGH28kMpKvSXddgZT5FKlyZitceUsYvMBssui8Tn+K65fOl PPRuRPf30+tczQTU2PIZkLrsoqjDnmdCYc0/3UT1u4Lq24PJtODkJm7mwtFOt04+W3TR rVxA== X-Gm-Message-State: AFqh2kpo+Z5Ke3Ctj/Ycy+46UdBGh0tdFx0yH+y/SDwT4TOOK2nd/67Q V0s1E0qPJ4b91PR9tjf43VE= X-Google-Smtp-Source: AMrXdXvmznlWSyCEdUPu/4HGztouGzRHNa2KB7pdYIy6UE4wCwA8w9Q4jMeoYnMU36XGxYsXHQbg+Q== X-Received: by 2002:a62:79d2:0:b0:582:b089:d9be with SMTP id u201-20020a6279d2000000b00582b089d9bemr27995513pfc.13.1674526282605; Mon, 23 Jan 2023 18:11:22 -0800 (PST) Received: from localhost (fwdproxy-prn-021.fbsv.net. [2a03:2880:ff:15::face:b00c]) by smtp.gmail.com with ESMTPSA id w1-20020aa78581000000b0058a666aea32sm276555pfn.147.2023.01.23.18.11.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 18:11:22 -0800 (PST) From: Nhat Pham To: akpm@linux-foundation.org Cc: hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bfoster@redhat.com, willy@infradead.org, linux-api@vger.kernel.org, kernel-team@meta.com Subject: [PATCH v7 3/3] selftests: Add selftests for cachestat Date: Mon, 23 Jan 2023 18:11:18 -0800 Message-Id: <20230124021118.154078-4-nphamcs@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230124021118.154078-1-nphamcs@gmail.com> References: <20230124021118.154078-1-nphamcs@gmail.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: B16E614000A X-Stat-Signature: h66set1xgq9ubcab9xju355g1e8z536x X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1674526283-381983 X-HE-Meta: U2FsdGVkX1966QyogyfBzDyNMaRZHKO4XyECJD/1qCH89hhM039Ni08yyD6Z9Lasv2UBJCWnuFR1QnQgBcX7hjp9kLEvjCFSBOg0gPnLKF6rstr9cgdYoeZoB7RSwXUncNvl/3ssHNmXyF9ZTMTholjajYw/ftu0iFwsh9JxpckrQM4mrTMVB8UmHV8qmi9eX7yqI1XjpU+HYFFogfhAGR/e4XcQWFdeWBUmAavSQNPOe//caYdG42z6bpXCATLBeYMi8J0lpEPZ72VDkd9jqogrM8XHtXW0vo3AzoHjn5pX2LVDSsa36tROuMOFuwMuDhWQDhivFEqwhKnlv6iVf1FIMfgKlrLBppip+eATOc6h0u60s9en1clfCfPsWD0wgXvSDuZ7SMlQXMVawQ2GId1uMRiuWUx2s6Cw7rQRnMhTa/2x4YnYW8owVSBYhP5hI5GdO5cw1wWlhIORQiEvQDq9EDlXpirpenRjMqm4Vo5uJmunG7599oWx3jkij6FUUtQ3ZCJB02+wPyUcWbObsHR9PRCcnCdfYyjpKA7SL40iUcCG8839nV/ZvfLkOvirqrpe0KatQHEi1S7ZQNzJRVRseCNGCiP7wOchArTtnCjjpx6XwVINzv5W6aza/A9ZdxFTq+Obos/Sy9ZQJbdTZNhPpxTTrg1qKr9N0wMvcKCo+aApHQW5wtOnU1gHEX+yY2Lm24EwhYbWnp2bljPKCFLFmzNrQPZUiog7IgFL6/prAcA3D9jPcf2OkVv+5m6bmidTfhgJJ0zOWPsauMXHyjz5ojrPzZ2ckgWIhSEkKV7MgH2FvUaWl3CRWj71Gfq0d+1/Rvtomm/FKJAP53vaZoeGXGW+cKZd7lVZTXsJdixBEdxAxr3IXYtcxOgsm4ldvoDMFSL+IiwLqP8c4omVhs5K7foOhBU6TpWzWF5KBJYG8RJp/uRaHE5HWtk8442tMAgTyrY5TlfW7ZBrVdE 0WleBDEb 8ttQiUoFvKub7oqi/ThQNzFf6McXp7hWguFs0PY3dTiPRIIL7fDQGdEFVOg+ZQBb5h12APU02YFOPili70xyU2DngniuPWRaYEW9vOHECsv47rlKCLO8tIP0/QZD2XxwTjbrzMCUNiyUp1Ujg8DSiwbGTLEu6SKF1o0+CPVx3wI+sP2LC8onoII54mfHluPmz4UjNZf4nKqQ8h/xE3wpF0vS+YrVCwCBjCqpIWou2WV9cAZ3waLlH3IW4cYBu003EdEqQ/YItynqXRzaiDCV6mya5wl76aXu72ZCVbuRsS1bGtn1RzW5T0uGtyF/faZRP0cHDwK/J+rR8TqLetd72eTgJ7KrJVXgX5IsHH3whwiUhzgAZvwTikuQabLikGFJJyRb+c7ZEoim2v154BHuTWmjfOnjB+fsY0r9iqcd5e0oh5PM5xuqvF4FaEBhyVhkScAQCY2+bKSXBiP1Na83BKPSxzCfEoaTeC6BBs8+4hgL9FnhXqavEb84pxeq0A/u9me6Bg83W51WnQcP5iqJO++DH3HHd1Vht4t4cf5/lMkUW4W4JOtWlwzgO1zBzJmMuO7HaD+yGBa8C19ebhjvIUPbvn99xOvgO+NGWEjVjqTKHoYx/TGXmwzjorA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Test cachestat on a newly created file, /dev/ files, and /proc/ files. Also test on a shmem file (which can also be tested with huge pages since tmpfs supports huge pages). Signed-off-by: Nhat Pham --- MAINTAINERS | 7 + tools/testing/selftests/Makefile | 1 + tools/testing/selftests/cachestat/.gitignore | 2 + tools/testing/selftests/cachestat/Makefile | 8 + .../selftests/cachestat/test_cachestat.c | 260 ++++++++++++++++++ 5 files changed, 278 insertions(+) create mode 100644 tools/testing/selftests/cachestat/.gitignore create mode 100644 tools/testing/selftests/cachestat/Makefile create mode 100644 tools/testing/selftests/cachestat/test_cachestat.c diff --git a/MAINTAINERS b/MAINTAINERS index a198da986146..792a866353ec 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4552,6 +4552,13 @@ S: Supported F: Documentation/filesystems/caching/cachefiles.rst F: fs/cachefiles/ +CACHESTAT: PAGE CACHE STATS FOR A FILE +M: Nhat Pham +M: Johannes Weiner +L: linux-mm@kvack.org +S: Maintained +F: tools/testing/selftests/cachestat/test_cachestat.c + CADENCE MIPI-CSI2 BRIDGES M: Maxime Ripard L: linux-media@vger.kernel.org diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 0464b2c6c1e4..3cad0b38c5c2 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -4,6 +4,7 @@ TARGETS += amd-pstate TARGETS += arm64 TARGETS += bpf TARGETS += breakpoints +TARGETS += cachestat TARGETS += capabilities TARGETS += cgroup TARGETS += clone3 diff --git a/tools/testing/selftests/cachestat/.gitignore b/tools/testing/selftests/cachestat/.gitignore new file mode 100644 index 000000000000..d6c30b43a4bb --- /dev/null +++ b/tools/testing/selftests/cachestat/.gitignore @@ -0,0 +1,2 @@ +# SPDX-License-Identifier: GPL-2.0-only +test_cachestat diff --git a/tools/testing/selftests/cachestat/Makefile b/tools/testing/selftests/cachestat/Makefile new file mode 100644 index 000000000000..fca73aaa7d14 --- /dev/null +++ b/tools/testing/selftests/cachestat/Makefile @@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0 +TEST_GEN_PROGS := test_cachestat + +CFLAGS += $(KHDR_INCLUDES) +CFLAGS += -Wall +CFLAGS += -lrt + +include ../lib.mk diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/testing/selftests/cachestat/test_cachestat.c new file mode 100644 index 000000000000..dc2894028eee --- /dev/null +++ b/tools/testing/selftests/cachestat/test_cachestat.c @@ -0,0 +1,260 @@ +// SPDX-License-Identifier: GPL-2.0 +#define _GNU_SOURCE + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "../kselftest.h" + +static const char * const dev_files[] = { + "/dev/zero", "/dev/null", "/dev/urandom", + "/proc/version", "/proc" +}; +static const int cachestat_nr = 451; +static const int cstat_version = 1; /* first version */ + +void print_cachestat(struct cachestat *cs) +{ + ksft_print_msg( + "Using cachestat: Cached: %lu, Dirty: %lu, Writeback: %lu, Evicted: %lu, Recently Evicted: %lu\n", + cs->nr_cache, cs->nr_dirty, cs->nr_writeback, + cs->nr_evicted, cs->nr_recently_evicted); +} + +bool write_exactly(int fd, size_t filesize) +{ + char data[filesize]; + bool ret = true; + int random_fd = open("/dev/urandom", O_RDONLY); + + if (random_fd < 0) { + ksft_print_msg("Unable to access urandom.\n"); + ret = false; + goto out; + } else { + int remained = filesize; + char *cursor = data; + + while (remained) { + ssize_t read_len = read(random_fd, cursor, remained); + + if (read_len <= 0) { + ksft_print_msg("Unable to read from urandom.\n"); + ret = false; + goto close_random_fd; + } + + remained -= read_len; + cursor += read_len; + } + + /* write random data to fd */ + remained = filesize; + cursor = data; + while (remained) { + ssize_t write_len = write(fd, cursor, remained); + + if (write_len <= 0) { + ksft_print_msg("Unable write random data to file.\n"); + ret = false; + goto close_random_fd; + } + + remained -= write_len; + cursor += write_len; + } + } + +close_random_fd: + close(random_fd); +out: + return ret; +} + +/* + * Open/create the file at filename, (optionally) write random data to it + * (exactly num_pages), then test the cachestat syscall on this file. + * + * If test_fsync == true, fsync the file, then check the number of dirty + * pages. + */ +bool test_cachestat(const char *filename, bool write_random, bool create, + bool test_fsync, unsigned long num_pages, int open_flags, + mode_t open_mode) +{ + size_t PS = sysconf(_SC_PAGESIZE); + int filesize = num_pages * PS; + bool ret = true; + long syscall_ret; + struct cachestat cs; + + int fd = open(filename, open_flags, open_mode); + + if (fd == -1) { + ksft_print_msg("Unable to create/open file.\n"); + goto out; + } else { + ksft_print_msg("Create/open %s\n", filename); + } + + if (write_random) { + if (!write_exactly(fd, filesize)) { + ksft_print_msg("Unable to access urandom.\n"); + ret = false; + goto out1; + } + } + + syscall_ret = syscall(cachestat_nr, fd, 0, filesize, + cstat_version, &cs, 0); + + ksft_print_msg("Cachestat call returned %ld\n", syscall_ret); + + if (syscall_ret) { + ksft_print_msg("Cachestat returned non-zero.\n"); + ret = false; + goto out1; + + } else { + print_cachestat(&cs); + + if (write_random) { + if (cs.nr_cache + cs.nr_evicted != num_pages) { + ksft_print_msg( + "Total number of cached and evicted pages is off.\n"); + ret = false; + } + } + } + + if (test_fsync) { + if (fsync(fd)) { + ksft_print_msg("fsync fails.\n"); + ret = false; + } else { + syscall_ret = syscall(cachestat_nr, fd, 0, filesize, + cstat_version, &cs, 0); + + ksft_print_msg("Cachestat call (after fsync) returned %ld\n", + syscall_ret); + + if (!syscall_ret) { + print_cachestat(&cs); + + if (cs.nr_dirty) { + ret = false; + ksft_print_msg( + "Number of dirty should be zero after fsync.\n"); + } + } else { + ksft_print_msg("Cachestat (after fsync) returned non-zero.\n"); + ret = false; + goto out1; + } + } + } + +out1: + close(fd); + + if (create) + remove(filename); +out: + return ret; +} + +bool test_cachestat_shmem(void) +{ + size_t PS = sysconf(_SC_PAGESIZE); + size_t filesize = PS * 512 * 2; /* 2 2MB huge pages */ + int syscall_ret; + off_t off = PS; + size_t compute_len = PS * 512; + char *filename = "tmpshmcstat"; + struct cachestat cs; + bool ret = true; + unsigned long num_pages = compute_len / PS; + int fd = shm_open(filename, O_CREAT | O_RDWR, 0600); + + if (fd < 0) { + ksft_print_msg("Unable to create shmem file.\n"); + ret = false; + goto out; + } + + if (ftruncate(fd, filesize)) { + ksft_print_msg("Unable to trucate shmem file.\n"); + ret = false; + goto close_fd; + } + + if (!write_exactly(fd, filesize)) { + ksft_print_msg("Unable to write to shmem file.\n"); + ret = false; + goto close_fd; + } + + syscall_ret = syscall(cachestat_nr, fd, off, compute_len, + cstat_version, &cs, 0); + + if (syscall_ret) { + ksft_print_msg("Cachestat returned non-zero.\n"); + ret = false; + goto close_fd; + } else { + print_cachestat(&cs); + if (cs.nr_cache + cs.nr_evicted != num_pages) { + ksft_print_msg( + "Total number of cached and evicted pages is off.\n"); + ret = false; + } + } + +close_fd: + shm_unlink(filename); +out: + return ret; +} + +int main(void) +{ + int ret = 0; + + for (int i = 0; i < 5; i++) { + const char *dev_filename = dev_files[i]; + + if (test_cachestat(dev_filename, false, false, false, + 4, O_RDONLY, 0400)) + ksft_test_result_pass("cachestat works with %s\n", dev_filename); + else { + ksft_test_result_fail("cachestat fails with %s\n", dev_filename); + ret = 1; + } + } + + if (test_cachestat("tmpfilecachestat", true, true, + true, 4, O_CREAT | O_RDWR, 0400 | 0600)) + ksft_test_result_pass("cachestat works with a normal file\n"); + else { + ksft_test_result_fail("cachestat fails with normal file\n"); + ret = 1; + } + + if (test_cachestat_shmem()) + ksft_test_result_pass("cachestat works with a shmem file\n"); + else { + ksft_test_result_fail("cachestat fails with a shmem file\n"); + ret = 1; + } + + return ret; +}