From patchwork Thu Jan 26 21:51:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Keith Busch X-Patchwork-Id: 13117835 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA8E9C05027 for ; Thu, 26 Jan 2023 21:54:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 489FB8E0003; Thu, 26 Jan 2023 16:54:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 43A3C8E0001; Thu, 26 Jan 2023 16:54:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3299C8E0003; Thu, 26 Jan 2023 16:54:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1C3928E0001 for ; Thu, 26 Jan 2023 16:54:30 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E32A6A0EF2 for ; Thu, 26 Jan 2023 21:54:29 +0000 (UTC) X-FDA: 80398304658.29.6414401 Received: from mx0b-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) by imf01.hostedemail.com (Postfix) with ESMTP id 0465940021 for ; Thu, 26 Jan 2023 21:54:27 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b=Kefr2vNT; spf=pass (imf01.hostedemail.com: domain of "prvs=4390123481=kbusch@meta.com" designates 67.231.153.30 as permitted sender) smtp.mailfrom="prvs=4390123481=kbusch@meta.com"; dmarc=pass (policy=reject) header.from=meta.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674770068; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UyoQbuDcWCkMLbCWVjg85By3HibyoyANdI6PglTOTlg=; b=xBLiKNgfDRQ5X9irUcpG6rJx6Bm5mMjB7cfxSf7fh9wWGqZkH94vGa2bS3rviiaMdSciW0 ZZv6432BWj1JgAi2e/+1rUyQOcT87+R0WT7Ge/y/InxblFq01G9aBB+e/cBlsew7McmUqC zHRQ0sD5jmO+1gtTwF6pT037d7T2uGg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b=Kefr2vNT; spf=pass (imf01.hostedemail.com: domain of "prvs=4390123481=kbusch@meta.com" designates 67.231.153.30 as permitted sender) smtp.mailfrom="prvs=4390123481=kbusch@meta.com"; dmarc=pass (policy=reject) header.from=meta.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674770068; a=rsa-sha256; cv=none; b=EY11Lin1OE9WzKeSWok7I8P1Hjs0fdNYGZ1O/dlt3cHWIf/h7qtFYl3rvHf7o9JNVglCuh 8D94COnkihFkOr/4lGqjmInAffhR/GzJkhnMwehbsF8fOnTQ0jMfvvsXewQRA3X42qOLb1 XOis80yth9oOCCq2z0En0f9gRwRoSPo= Received: from pps.filterd (m0109331.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30QKJF8L004994 for ; Thu, 26 Jan 2023 13:54:27 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=s2048-2021-q4; bh=UyoQbuDcWCkMLbCWVjg85By3HibyoyANdI6PglTOTlg=; b=Kefr2vNT1NBrRgx/cIhqb29JdH3QfkFrzcMsv6RXzVT/Bt97zPsJi1ET99miCOlLfTaL VEDmvWx7lvbKlLrL3paXcIyf03+HCP3piWuL6Yp6G75d7u1xnOHXkDS2yurJSNQWBArZ dRQnHWxRwcNFBzfjxEzInlGlAimyfWyC54ieeApmniWm/EZsxawzWis1h/pAZMf5UrHB AHwBf7kdSicFV0rADI8j31EPcC+t/OjNLd6Rckkf4hXLuiPRVBHRuXADLX0faJzRFkXd vFAZ2qrs8T3pcZphxfizNaKjgvuuJq0R8smmoj+TbVJX3QeKyWqqcGcZthgBb7zMSyhA 6A== Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3nbb800ngc-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 26 Jan 2023 13:54:27 -0800 Received: from twshared24547.08.ash9.facebook.com (2620:10d:c085:208::f) by mail.thefacebook.com (2620:10d:c085:21d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Thu, 26 Jan 2023 13:54:25 -0800 Received: by devbig007.nao1.facebook.com (Postfix, from userid 544533) id 1F1EFFE80A97; Thu, 26 Jan 2023 13:51:26 -0800 (PST) From: Keith Busch To: , , , , , CC: , Keith Busch Subject: [PATCHv4 05/12] dmapool: speedup DMAPOOL_DEBUG with init_on_alloc Date: Thu, 26 Jan 2023 13:51:18 -0800 Message-ID: <20230126215125.4069751-6-kbusch@meta.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230126215125.4069751-1-kbusch@meta.com> References: <20230126215125.4069751-1-kbusch@meta.com> MIME-Version: 1.0 X-FB-Internal: Safe X-Proofpoint-ORIG-GUID: 5TnmCA6rfTE1zG4dSfmMi-b90MgKRqiI X-Proofpoint-GUID: 5TnmCA6rfTE1zG4dSfmMi-b90MgKRqiI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-26_09,2023-01-26_01,2022-06-22_01 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0465940021 X-Stat-Signature: woz7yi5d6yufjoqidqha7kzwwry5gsbn X-HE-Tag: 1674770067-682076 X-HE-Meta: U2FsdGVkX18+ooJRGBI7pdA+0js0E7sDafYD8tVQtwWvKNs3eOBXRHEhCG0En2mHFEONba1KskwR/YoxqvSDH1IEpJEAC8Lmly3VU7SVTznfL9Wt1aeiQIou+Xz2fonVEDNOaz0JYtMG/O8nRVvUP5OGEtzFMMI13s3KPl9mlk8LZirAQzpAQfP961ljK082Y1oqT72cc6jkCoxGdXdQpsEFeuPiomNhV+Rhl1xoB1cGbtgVuVIgHUXI7KRTCPr9A/SLEgbqisvgRSIXEiKizILFN5CTYPDD+MMxNXO0a4aBgdBuESFOGIR8uibVdw+l07Kwe7Obq8/OvWuPQL36wGw9Q40PxnJJGwlMZT2V1Wd7dg3F2+xeAIUMrc1i+Bvvwc1F0MGPgunHKWkABK46ZmoO8xqk0WcK7Cms+ZgrUCzYMWLE8R9aO+R3/gKnwL2UYITSpOxgn+dQNTEvLCqjikGsz/ke6S8unmhsqtuAKw+M0FXtk9HXS3xQ9ruxhbgq7J4ij/TpAJswJpv5utUCBpJ0S2H8+Lf19ebXiDOvU96m3FiK5DE8YjsQUAS7lDDr5w4wd7P36VLZHVvbz7JklZmQGqCXhkrUbrwjJt9kXvUG2QGHijWt/OpXi4KDmzfxNbrWfiZYz0Wzu1I6+3IenXYBWCS2oBXg5kqZnZLx0cJDeu6iFSvKWiWGq68e2hpgRmijDVKhCex5h5IyQ77duQcrnXl0ODMZImz/hwfBHeJnGRzFQuP9ixwx3mNM8OeUExzsuMeWNWcZOPMWAahK5HQhhIF7Vt5D4TpscJCT3xIR0pJ+gTamkf/e0oxMPUt9Dq/YniZoj+saCdslCbyrKPV9A00Dk5MZuzF8CbNBOvRvUwBt4l/RQ/mFWokMAG1A8fFEbOypBQtO+Q8IR8cDGAFtZUsT749/HTIPTmrFxAcjJhQQWzsMbtsNgq10Zd4buoi+tsuyDnPWMPxuexX OQbOcoJU neBPbmEmSbcOVszNTccx2i1/bpc+Ppk3Je8qv3J7mvleDl5Xlj2AWrNoLO70lu2w4a43MNXljpejXRXisbl0M6Tmj3Bja9wBEfTf97CeiZPS76YO4GUt1z93wXptAae/Y9maiknWcNfyzHr7FhfEqUALwgo7RNdyH6fZgiVuEE8fOKL0nV43BSP3OOpOX9SF4eldV/o+dRh/v1fdA8a5YsnCybb20UWt7/rFdVUcH0azgVAHK4sqGKddBzIRiQCeElNzuvBrV4kwqXKPefTPGfOCdcVsbVnVNGWOXI+ikv4FjbuSTdT7EJK3GRlPl7LycIq/ebG2lYT2pp7KyH5b9CFmrHHshRXmvyBpC+0HKDlgD3pHP+AZo/r3ObSrtZrGdBjah3zJkfUkU9htxim2LWjjMdlMZx12VVnk1E/WYLV5oBxHw+4M9IHg5QpZheWQRcyvMqoRK0QWephAsX8u95iY0b6cYvQBHLHm/M8czvrZKZjdpCayupQgxAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Tony Battersby Avoid double-memset of the same allocated memory in dma_pool_alloc() when both DMAPOOL_DEBUG is enabled and init_on_alloc=1. Signed-off-by: Tony Battersby Signed-off-by: Keith Busch Reviewed-by: Christoph Hellwig --- mm/dmapool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/dmapool.c b/mm/dmapool.c index ee993bb59fc27..eaed3ffb42aa8 100644 --- a/mm/dmapool.c +++ b/mm/dmapool.c @@ -356,7 +356,7 @@ void *dma_pool_alloc(struct dma_pool *pool, gfp_t mem_flags, break; } } - if (!(mem_flags & __GFP_ZERO)) + if (!want_init_on_alloc(mem_flags)) memset(retval, POOL_POISON_ALLOCATED, pool->size); #endif spin_unlock_irqrestore(&pool->lock, flags);