From patchwork Fri Jan 27 11:58:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hyunmin Lee X-Patchwork-Id: 13118530 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C00EC54EAA for ; Fri, 27 Jan 2023 11:58:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 609A56B0071; Fri, 27 Jan 2023 06:58:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B9AC6B0075; Fri, 27 Jan 2023 06:58:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 481356B0078; Fri, 27 Jan 2023 06:58:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3621A6B0071 for ; Fri, 27 Jan 2023 06:58:52 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F30521A0F80 for ; Fri, 27 Jan 2023 11:58:51 +0000 (UTC) X-FDA: 80400432462.29.3ADBA6D Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf12.hostedemail.com (Postfix) with ESMTP id 3F8CA40009 for ; Fri, 27 Jan 2023 11:58:50 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="PwU/MxFf"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of hn.min.lee@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=hn.min.lee@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674820730; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=SJQyMP8KtEdsdoG1W/rDTY2sHvstU2onoiuLNZSdqRA=; b=7PBlvPUUT7mM2MAX4+A4SJxz2QFJXXmqqDkJJj3TN26G4T1jAOyzNVfegfSvIY78A6UE/c ek1oydyLDh9RidQ1kwVK1nzTrhhLxcBP3Iuv4bMAvkMl761a6GM9sf5PTzHuJXI9AmcZV3 uV312Bb90xKBR2V7DS96WODlhyncLOM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="PwU/MxFf"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of hn.min.lee@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=hn.min.lee@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674820730; a=rsa-sha256; cv=none; b=CAZXCxG0ui4bPq44zdnhfhaEqFzCdECeFpiBDUhqo+uOQRfIF/BoQHBLCs0wWROqfJxcJS l5a20TsnJJltLgosaJkFvPyg+wJYBZHqAQUCCzVPYllKZnA2x9zixbhFD2W8i7mANR8Gll IUTef5e8Y3njNH6d03t4P4VP9tYDHs0= Received: by mail-pj1-f46.google.com with SMTP id w6-20020a17090ac98600b0022c58cc7a18so199656pjt.1 for ; Fri, 27 Jan 2023 03:58:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=SJQyMP8KtEdsdoG1W/rDTY2sHvstU2onoiuLNZSdqRA=; b=PwU/MxFfxjI7rblgdodb3z+Ia427ZsfwVdOF5RDiO/To4doDp3lZnreegyJfPEUcfL eMYGGqaiTVYl2nj9mjtC2cRdIuJMHr9zsy/cqlzL1LLDupBEagQYpzOg9MF5k7wwDVO6 +uRNVvqRI45PPuMAJE27a2lKwMNPX+QPvK6S0mW4poSVFW30+k1M2I5JQSCLTotDkXos PfyeHOKKSe8VN/rVEQwedqsC8mvy9wQLEtnBo1BQBkQlNifURH7ZR3Pd5O+NvakkPWiT CstnuWhVJKO5XDJcqPRnF2KyAZiN9LqFVF9UT53wpNdYXX8UIHuY+fpn/+Zvw9ptPolF Z4IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SJQyMP8KtEdsdoG1W/rDTY2sHvstU2onoiuLNZSdqRA=; b=v15ULVJkOeq7cHjmrDJXJfPl9dpvCdjJE8kqaDljwGWXfv+3EpCks8x2GvOcLUK7cs MO3+CshyEt6Obg7Hp/+l1lL/ptQ/hue38Chk99IBordtXa5pu/KGkaLyPfTppvuZy9Xe 9E+u9SlC4xs73x7cLMPKXFZsRQtKHVdXR6w1Q7Rn7pLQYM6+h3sGQSQzxlO8Dz1oHVXS sNnBumRNhfrjy2xTDJd6q2wbiElVLJLxqmL1nxcBt1LnnbdxS30U/Hsa6eaCOB+iA7LE afRjL+Ki/8OvfzXTt7zYGRYvVHzVb9oS9e2f0XeAco8+scV3lAgqPlDAyj/syj3D5wUD 9j+w== X-Gm-Message-State: AFqh2kp1d90WXa4MP+F8f8kwoS0u7VfsHOKjD+Eue2IvENUl36skEkP9 gLhMUsYUBspZ8t2m5635fQA= X-Google-Smtp-Source: AMrXdXs5qdqdD1dcu7VPXFaAEJULrNvcKAOlo7ycLqi1WJSgPC7qNCKHNlSBkhnd9pymGsdCaOPEjQ== X-Received: by 2002:a05:6a21:3a82:b0:b8:7d48:2860 with SMTP id zv2-20020a056a213a8200b000b87d482860mr44988169pzb.4.1674820729118; Fri, 27 Jan 2023 03:58:49 -0800 (PST) Received: from min-iamroot ([210.91.70.133]) by smtp.gmail.com with ESMTPSA id y191-20020a638ac8000000b004d182686e08sm2324994pgd.39.2023.01.27.03.58.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 03:58:48 -0800 (PST) Date: Fri, 27 Jan 2023 20:58:44 +0900 From: Hyunmin Lee To: Andrew Morton , Uladzislau Rezki , Christoph Hellwig Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] replace BUG_ON to WARN_ON Message-ID: <20230127115844.GA1124261@min-iamroot> MIME-Version: 1.0 Content-Disposition: inline X-Rspamd-Queue-Id: 3F8CA40009 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 3psip8bhkmfzu73b4xarx8dpsy5s1afh X-HE-Tag: 1674820730-803976 X-HE-Meta: U2FsdGVkX1+HW0Pg/qV9w8xeEGoxhR59bVhRd27PGOdKrq6GnxEPIqaCCwZqXBvxXvD1/DOC4A+vzyrjxhokpRs1gWtyLGfJniYZOJ/oNe0gEOddEwlQFv6pKiGf2tuoH32QXHYMj3NAzYUbF0nC0B5hp5zJ6eGScmFIk1DaM/lswrPKYPEfgtGUo2iX9RvIIfRrmGUl/EobyCPLn3xXpHopnACBySVsEtRit35w6QgJpRMDorO70Le0BZQhP0oZJspCCReHH9sdVl1k+bl3xpLCbSG0sH7PdyImBSgV+KiBzramQGEg1SjyXr4Q3cjJT6ATfCV874tE8w1y8o/V/yPxVrjjo1U0OxTczJCbZgqIeIxUnO6DVDZBChUa5hwIAeBCw+WoxKOehmgjReMw3AhyJT9yUOcGnwzxQJfv91RN6jcDB3cfBWgNX4JDgX0p112/81agVWTbriEVzmQBDYyfdUjq/rlFtpF479OSebWve+/Zkb8oKJcOYgWnQ3/HoSpVh47imCkoVZMDO0rZeTZfH/OLDpM2kCM5im6ANNLwC7ngGazG/VdDxwg/eB0MOlx1Egt+28LTOzVKNEKu50oiCm+eNHShTbj/z/LULegIhyD8Wx7HHUayqNj3g5tSQn4yM6GS2uVySTppQJhX4bK0LVNWGyBmpL2d3WPvLoX/cu6dlWXxoeHt/3rlA9oyXiz+SRf3Ib7+saEbw+kqJO+fKTTNSpRXr5KhBHZbnvgr1MosUJn6is98aYFR8a7p9hC5TUJAdjHA19Tp9GlH10xf1oADGSG13g4A7ZlmbMnVJGFDuS8DCx41HnszCzzgr9NYerpnx8BGHtHwsTtvbY5QnTKJGVB802ivQHti6O9s/UbqiwDQdsd7sdCLJXyWXys66D8a4moPvmkrOMVirI9fPb2VM+LpLkyns2g4DHbWOtP8YSP0VdWXpB6eQqBqyrEXtiNQoIDLhIHnFKv +7IL6EIo FbvYiposb3kL3I/i+ZhZYfScFEr2o1k0Bsngmzpl016LPYpOIpcJlkwUuoVHtRfzPMcNhtLns5PA9FSCJeWpzpHdv1Ohz+/ogy06oDINyOg1O4ZKrvRCVZ5W661quUgMJJerQs2dSSpPmq0fKzkQAr3W+j4d/ZleT2RYTN6wNbz1ouPpVE8cXUf2UQnh3yUUAsbUJwsL1keEKg0hzdx8zzsxjL0ydDgEXybCipqSSshdTSEo+qx99tE/hjn/a9zWEhtm0+LyHGdQ23r7PMnlobTodP1AhqymT3wQ04WEgN53qN1T+h4yvyLoSoAs/e3xa1l9F5yh2UmsIqhJNh2ePPIw1AKiCcb47eC5TgvD8aYpe/HDOF62EIahZW73BC+rXJL5/a84JreOZUC5r1WL+QHJI2n9rvrnquzbz/6aHepLKwdGbWm+XSCkm3N4aVxN/K0Hn8TKm1aOLMJOWYL4sAYKKGwDAymoO/SzgqFTtzGtq6jcmmOQH7WeA++Qkd1UXphMxBOyvvJNlqsjdWBkNxHcoOSAS2QJm4FpVUTCmPURI/YZqTjpwj38sSVKBPfyN5eLl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Replace unnacessary BUG_ON to WARN_ON. These BUG_ONs verify aruguments of a function. Thus, the WARN_ONs return an EINVAL error when their condition is true. Co-Developed-by: Gwan-gyeong Mun Co-Developed-by: Jeungwoo Yoo Co-Developed-by: Sangyun Kim Signed-off-by: Hyunmin Lee Signed-off-by: Gwan-gyeong Mun Signed-off-by: Jeungwoo Yoo Signed-off-by: Sangyun Kim Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> --- mm/vmalloc.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 74afa2208558..9f9dba3132c5 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1587,9 +1587,14 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, int purged = 0; int ret; - BUG_ON(!size); - BUG_ON(offset_in_page(size)); - BUG_ON(!is_power_of_2(align)); + if (WARN_ON(!size)) + return ERR_PTR(-EINVAL); + + if (WARN_ON(offset_in_page(size))) + return ERR_PTR(-EINVAL); + + if (WARN_ON(!is_power_of_2(align))) + return ERR_PTR(-EINVAL); if (unlikely(!vmap_initialized)) return ERR_PTR(-EBUSY);