From patchwork Fri Jan 27 19:40:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 13119257 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A2E2C61DB3 for ; Fri, 27 Jan 2023 19:41:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDCC06B0095; Fri, 27 Jan 2023 14:41:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B64006B0096; Fri, 27 Jan 2023 14:41:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F36C6B0098; Fri, 27 Jan 2023 14:41:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5F3E76B0095 for ; Fri, 27 Jan 2023 14:41:58 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 35155161019 for ; Fri, 27 Jan 2023 19:41:58 +0000 (UTC) X-FDA: 80401599516.05.039C756 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf29.hostedemail.com (Postfix) with ESMTP id 737AC120028 for ; Fri, 27 Jan 2023 19:41:56 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Cb3p2QcN; spf=pass (imf29.hostedemail.com: domain of 3ACnUYwYKCMc574r0ot11tyr.p1zyv07A-zzx8npx.14t@flex--surenb.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3ACnUYwYKCMc574r0ot11tyr.p1zyv07A-zzx8npx.14t@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674848516; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z2/pTj5C3cgEFiOJp2CeCn46OI8ibDfme0ccGGe2ykQ=; b=oulqlebZnwq5ydExtS4WNpJami1T69rhbXQ9itYVWoXbzXrbfyBEFNKRpwgGshW3r7ia/l 23j47A4TsLiuGtCEoClJ9hsuCmKAuISFdmulLN9xbu1Cq+m6NH4SBSOusSvXDPe/Cemrp/ 6HA35W5u11WdQlXIMwNzvg9r0AbVldc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Cb3p2QcN; spf=pass (imf29.hostedemail.com: domain of 3ACnUYwYKCMc574r0ot11tyr.p1zyv07A-zzx8npx.14t@flex--surenb.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3ACnUYwYKCMc574r0ot11tyr.p1zyv07A-zzx8npx.14t@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674848516; a=rsa-sha256; cv=none; b=TJwaFRZQkqoRF/Eh28EQckN9zsgyPK4/9m3E+l2roaPljim50eUSaIlyrC+0BKAzN59FYN HQMNXfRYgvcRPRSsNQJuKv9pK1UG/NMOhCmlyAkek2ejz0Q9F7v5yG498zO7NEPd5CEjOA ekEfe0PVVNKOQ1b/Slx3Dx/JT0aB064= Received: by mail-yb1-f201.google.com with SMTP id a14-20020a5b0ace000000b007bf99065fcbso6360922ybr.2 for ; Fri, 27 Jan 2023 11:41:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=z2/pTj5C3cgEFiOJp2CeCn46OI8ibDfme0ccGGe2ykQ=; b=Cb3p2QcNsUnk+wL6/K6P4ED35dG3ZUcB734zcAsddvwr/PVSkrRYzepHFsLMU82wqr DCByjFxSWTXuXxKpPzrEyhOes5tD65SfDW58DVPGzZ4bl/GM62EXvV72BYyh+FkQftRL 9ik0iporDuduJD370bXV4KniJvgp40Hs/4xlWBjuzB4w/OEbzQnMEDOcEM26lHODokML 801aFmGgsonG3Ea3SKObTIkdYEG/WUj/siwNQ/Elnoh6/xVR3ypDahdEx2v1JUXFD+l6 cbwz8ftG3Ry5zhC62QLkQy0TB2bZZjts/vu8EdbF1X6krxdoifCb7qgLuiaEVqlGXvIi PdsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z2/pTj5C3cgEFiOJp2CeCn46OI8ibDfme0ccGGe2ykQ=; b=rFim4uMDz55rnJKNGldbw0aZQbld4qSQAdCEDtqpp7GFX5gmwK2aOCgZzbuCn36Vek 4fPBF9FA7BsfY2yIjs6K6S7qbOyIgascUS9rKugANA/oe+MGcJdE8Qpt2hSq/TZtm+/o KALbvx5EvY9yWFOVSpGgkiK0yM+pQ/Mu68TWzWfiNw9Isye7qIQsU0JL989cPjCFPcxw bTxOnC2wfEQ/jofRHiPJU7ASNDRZoENzneeydUBnfKDZxTS0d2SJ8xV/kZw3jxRvzfW1 LQ6doa4v3Y4BVxZbk2ESjn3JO/DcZcmfmFybRU2rIY935inmDoxUmUwvGMFanuGN5kl1 PlYA== X-Gm-Message-State: AFqh2kq3/7FXZUCXOTBiUTC/+vHkPBvPRz8dXXQQ9NQg4aMcWDl9SBpD wZqdNd1FGpRKWYB+2nqoia1X51E8Dfw= X-Google-Smtp-Source: AMrXdXvc0ioDltykhYGthi7quhcG5gFdvKFRYGkIf9fgUkYhxxt/rX6VwG8N7AhqKPLty1w08hNt6tf3mAM= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:200:4e19:be9:c5d0:8483]) (user=surenb job=sendgmr) by 2002:a0d:f6c2:0:b0:4dc:1241:cc0a with SMTP id g185-20020a0df6c2000000b004dc1241cc0amr6165876ywf.499.1674848512603; Fri, 27 Jan 2023 11:41:52 -0800 (PST) Date: Fri, 27 Jan 2023 11:40:53 -0800 In-Reply-To: <20230127194110.533103-1-surenb@google.com> Mime-Version: 1.0 References: <20230127194110.533103-1-surenb@google.com> X-Mailer: git-send-email 2.39.1.456.gfc5497dd1b-goog Message-ID: <20230127194110.533103-17-surenb@google.com> Subject: [PATCH v2 16/33] mm/mmap: write-lock VMA before shrinking or expanding it From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, surenb@google.com X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 737AC120028 X-Rspam-User: X-Stat-Signature: ydbmekczi8ubsioqqgbcf68by5mo44du X-HE-Tag: 1674848516-462550 X-HE-Meta: U2FsdGVkX1/k5MVOqsWPBPDfmxViNlYju4Po+NdheB9V3oKhzIpUvEoDlRqCC0hDg/seRvoNOJG8FPJ/cVt7S2CkJl1sbEoEcSwMBzfD/HyouOs/nAwDrgtic/wGz3/L/vjRXsGOjR88KDPeAELFiCa1CckFlCLrsrQ8MZ1HWzfKXgXvs41e9ihmgRYxwEmSKy+LASb336NG65N3ljZ5hRT/Z7uuEMahsQKenU6ezcejKzts3U19dyle1LZijogwzZp8p/521hUvDdXeR+1hHwhI6w8bX3e0LSXjRDXf6NUBai79fhPHGOE8cY9v9D+KIOfvpaqW7UJxIBUnRH2grAMKFILBjZxTQ0OmApx1n0eI4C3eoRf9Exdapja5kRSYqAdK8Oq+E29kkoEgS/3fYSzTCA1udOPDg114Esq+em7AN7sRYBSWC61IbM0s1DyPxWpwwEyrv0ene2Sb1TUU09DpyQUGyxGgdnM7ZdfsoVFKxr/OrSyBJ9vF1Bg0Tcs16D5/WzELbLJamEVZBYjwW6mSdVLZzp1COzTeWF3ibCafnqvFKNu6Nm75kaGCwIQ175vbY0JfQDZG6NT5NRbc2o8obZAhBGaSxJ+KZ4NngzD1xO8hhG5YRugF5D+aXlsi+l3/DoLA3K/ctRLZkfPnjRG6lPfQFiBy3LCA9BpdudSrhkigUgu+22cOO4ta3N1CjBPWtIdy9VM14mIURJjh6MyDY9gPsqDZ10VtISDUDbXYvgu6BEcFuLHyNmYB8YoKnwY8LV7PlgPmyoFtptbUG0xdThkbrKr+i6lcfFj/cnEw2PWzdPw41ozqMhlFptjMdrFvM2V0dbGohdqvOdC8/BQnBpeNi3yHNiyGF1N3hcN1tYV1cV5SFK2c8dcAcgSX2+g17jC4u+2n2g//UqJ2HWABeklvTx1JbPW3GFIsQc80BBDFvUX9LvMtGlskjIET7tWw7H+AiqB43jWU1cC zQ0gpI2S jh2LNeudrw16aqbstG6fzClG5rOQcjkpfVPadNQS9Jyxn0Rw34eFl6JKpsvshJuQKNGXIMHN6vIAnUAG8pIwkVLPofryXTfksG0/HhpPLVQltmH6hcW1YPbN4zurDZhTD8vawpHjBj3/xBr1Q7gSbD3Ek5hAUnK3Ve+RL5bgM1bCFq4qwSLOHRSKorSs6HDpodueT2W+pczorOm87jfT51VnVb4jL1c1ZgZV3vuBLTRREG3VX40E0JES0ejeUPDtrWrb1w2mkHleLPCCRbpcz02TKrJZFNi2QZUAviZV2ny8Dc5nkOG57RDdWYkrgrmcG1Vhzltp6BlOnBXmX18HRH3NdgsFSyOP+8m25xQBHDWpKEVbVD2Hx8aKMg6Mn8FoQD7SumZ8qoCy1wmvGxMgolmhXLvv883a2jDPqFjzT26kNpU6brq7Il304qjZDpEkNXowNZwe5w6v2MkNAMBBszQiewzuGPlNbRrn+f2q3l3lbaV7spqXS24JCHbudQTmUDY1f+XFc1jEkRNxvVHu9C668JcqFphX/hDr5AcRLJ0b3dV0i/pjTDkNimWxiu0AIKozn1kNZwDLgZsoouMOrlm8OWR4e63eJyDZYdCOL+dV5js1vpnnMdM4HSw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: vma_expand and vma_shrink change VMA boundaries. Expansion might also result in freeing of an adjacent VMA. Write-lock affected VMAs to prevent concurrent page faults. Signed-off-by: Suren Baghdasaryan --- mm/mmap.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/mm/mmap.c b/mm/mmap.c index 6fff76334177..60038c24d836 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -674,6 +674,9 @@ int vma_expand(struct vma_iterator *vmi, struct vm_area_struct *vma, ret = dup_anon_vma(vma, next); if (ret) return ret; + + /* Lock the VMA before removing it */ + vma_start_write(next); } init_multi_vma_prep(&vp, vma, NULL, remove_next ? next : NULL, NULL); @@ -686,6 +689,7 @@ int vma_expand(struct vma_iterator *vmi, struct vm_area_struct *vma, if (vma_iter_prealloc(vmi)) goto nomem; + vma_start_write(vma); vma_adjust_trans_huge(vma, start, end, 0); /* VMA iterator points to previous, so set to start if necessary */ if (vma_iter_addr(vmi) != start) @@ -725,6 +729,7 @@ int vma_shrink(struct vma_iterator *vmi, struct vm_area_struct *vma, if (vma_iter_prealloc(vmi)) return -ENOMEM; + vma_start_write(vma); init_vma_prep(&vp, vma); vma_adjust_trans_huge(vma, start, end, 0); vma_prepare(&vp);