From patchwork Thu Feb 2 03:10:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Longlong Xia X-Patchwork-Id: 13125227 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AE63C61DA4 for ; Thu, 2 Feb 2023 03:12:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43E716B007B; Wed, 1 Feb 2023 22:12:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3ED546B007D; Wed, 1 Feb 2023 22:12:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B79B6B007E; Wed, 1 Feb 2023 22:12:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1D1056B007B for ; Wed, 1 Feb 2023 22:12:34 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EEF0A140DB5 for ; Thu, 2 Feb 2023 03:12:33 +0000 (UTC) X-FDA: 80420878986.30.5BF4B7B Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf19.hostedemail.com (Postfix) with ESMTP id 725391A000F for ; Thu, 2 Feb 2023 03:12:30 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of xialonglong1@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=xialonglong1@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675307551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=joBD8uzrif102mTzb4KXY9g9UvP/gaLL8z0/pgtt1No=; b=Re9QPEDfgctAvpYEwds6hY7+ucv1cKIEHLVHm9SGSbmQdbJy3Ju26REbp2QXFvYQuWkUmd 9dhQ6uWjiruxnPFsW/zLAuxE5rO8cTFbVT7FCwPNS2xsAWlJPsW/59FHjafBe69umnxNdt f5Y8gk2LwuCwq0v+JfbC5yNX7EBVaZI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of xialonglong1@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=xialonglong1@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675307551; a=rsa-sha256; cv=none; b=yAbs/RoflOZK5w7srzjcqpinxTSH+HRxcNWym8Lq5MyAzkUDhAVhOAd71qyrTnoUHUrzoj hd3/A97whKjXR6kJLcyOlq+kGCOisWUS0hMRdkWTctk30YTN7bwXvOFWfhVtqmpqtUVaDh Mng4nCHkBRDUNvtDUlHlT1oH78V3nhs= Received: from kwepemm600003.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4P6kHY1gtFzJqrH; Thu, 2 Feb 2023 11:07:53 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 2 Feb 2023 11:12:22 +0800 From: Longlong Xia To: CC: , , , , Subject: [PATCH -next 3/3] devtmpfs: remove return value of devtmpfs_*_node() & devtmpfs_submit_req() Date: Thu, 2 Feb 2023 03:10:46 +0000 Message-ID: <20230202031046.1224338-4-xialonglong1@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202031046.1224338-1-xialonglong1@huawei.com> References: <20230202031046.1224338-1-xialonglong1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 725391A000F X-Stat-Signature: nx88n6ftf8kz4nnnee3tjknnueqqu4a5 X-HE-Tag: 1675307550-982546 X-HE-Meta: U2FsdGVkX1/f/sh+ZJNwonfPdJ6ZpfV3WupndOl4tWn0IocU+HCeKzuVdVky48WIjGMGd0IkHVmPzR2cciruI9wSjwTFlCBRLfuTiobXz62PpIQa/4ld8GglS8b1Pak5CrqFoXJZHiWNAFS/Q/peCelL0yhyBJRvWV3vPcxSvGHxcS9912g4GrNNBa3AxYGVs9ZxCXIhixKXYoQqpZsv4NRcSRlebFnbY9Ix/FsYqaNY8bb0fqDI65kSA5VdZFMEKDalIjDuk5vinK4956ayukBB92HrCj0aYVaHiSzDpc1vrL3r0XXAYhzTgmNXqJW7JNddVCYQai15saCiX3+zgzlmDOfBKm8CXQ83tyem8y+V+rwiDcS21+ZaVuBnMv2LSxAFpCPB5dYH1fywt+Lm4CJ6dEp2Hbw02SfpUzFCfNnLZM2fDpLBlhmvcg4qyRLonJBDd0pOI33sraKA+kUcB8kkz3rNljTgDPE/V6dnXGWJGEyklLrPckXJY0LeHKdIcXmJlgLfzmvwx699jqbrzY0vQZa2zEwNi+fGnP/T/veDNs5srRaByJVE7Z3vIl/N/V5rwOzjboRzi+OKC3/e3xmGTLaw9HrreorkplUlT3rEzjry/wkdv2mNB9vz3j1dVNI0XfRoeP8MhZzgc0R4xkAVv2RFCQTf07V0WQ1yGQzOBgL9p2usUORUngzm6iFbNx3Nu0oPp/k6LvBlS963bH80L6qaoaVjpLRJsXF8tROaCkH6S5dfZ/U7MRVjVqDiwu+if7SNrPk0AEGIWOuuN+9bm9imyByG5aqllTDsbJszAOVBDIGzFcLTuG8k0MfHdO1MX2REfl1YM6iXAYU5vIlAmB9/jOiCAFFwGiQPjSUws5U0ZYCC8kwDEKNKKVbis4R6ffIYhld/k+hPtI50YOkPd/ZQcvViQcB6NO9+eCf9k8tnDzveimrUNmpam5eLOI21N0wzb48jecCioFy jXUfxXMS LLretVZNnUuU483j75YO0RziuhQgtx899S7Kl4KcWlf7CafdfbdZJKuH+eAry6i8PkrHmeS25i0D+DjaoWC4ULZW8QY1qstJeJVc25wjPXXIqfXU0PM55MIGP5+gafnDkzstSl0M0VizZraGbBJAyXfLin29vVq3NH2xbmpGO78YxOONNJRiX8h2N7StkfNUmyyImltd/XfMoVnnyafahot28rw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Because the return value of devtmpfs_*_node() and devtmpfs_submit_req() are not used by their callers, change them into void functions. Signed-off-by: Longlong Xia --- drivers/base/base.h | 8 ++++---- drivers/base/devtmpfs.c | 20 +++++++++----------- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/base/base.h b/drivers/base/base.h index 2208af509ce8..ffb7321e39cf 100644 --- a/drivers/base/base.h +++ b/drivers/base/base.h @@ -198,11 +198,11 @@ extern void fw_devlink_drivers_done(void); void device_pm_move_to_tail(struct device *dev); #ifdef CONFIG_DEVTMPFS -int devtmpfs_create_node(struct device *dev); -int devtmpfs_delete_node(struct device *dev); +void devtmpfs_create_node(struct device *dev); +void devtmpfs_delete_node(struct device *dev); #else -static inline int devtmpfs_create_node(struct device *dev) { return 0; } -static inline int devtmpfs_delete_node(struct device *dev) { return 0; } +static inline void devtmpfs_create_node(struct device *dev) { } +static inline void devtmpfs_delete_node(struct device *dev) { } #endif void software_node_notify(struct device *dev); diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c index 77ca64f708ce..3c4e61c99b77 100644 --- a/drivers/base/devtmpfs.c +++ b/drivers/base/devtmpfs.c @@ -103,7 +103,7 @@ static inline int is_blockdev(struct device *dev) static inline int is_blockdev(struct device *dev) { return 0; } #endif -static int devtmpfs_submit_req(struct req *req, const char *tmp) +static void devtmpfs_submit_req(struct req *req, const char *tmp) { init_completion(&req->done); @@ -116,24 +116,22 @@ static int devtmpfs_submit_req(struct req *req, const char *tmp) wait_for_completion(&req->done); kfree(tmp); - - return req->err; } -int devtmpfs_create_node(struct device *dev) +void devtmpfs_create_node(struct device *dev) { const char *tmp = NULL; struct req req; if (!thread) - return 0; + return; req.mode = 0; req.uid = GLOBAL_ROOT_UID; req.gid = GLOBAL_ROOT_GID; req.name = device_get_devnode(dev, &req.mode, &req.uid, &req.gid, &tmp); if (!req.name) - return -ENOMEM; + return; if (req.mode == 0) req.mode = 0600; @@ -144,25 +142,25 @@ int devtmpfs_create_node(struct device *dev) req.dev = dev; - return devtmpfs_submit_req(&req, tmp); + devtmpfs_submit_req(&req, tmp); } -int devtmpfs_delete_node(struct device *dev) +void devtmpfs_delete_node(struct device *dev) { const char *tmp = NULL; struct req req; if (!thread) - return 0; + return; req.name = device_get_devnode(dev, NULL, NULL, NULL, &tmp); if (!req.name) - return -ENOMEM; + return; req.mode = 0; req.dev = dev; - return devtmpfs_submit_req(&req, tmp); + devtmpfs_submit_req(&req, tmp); } static int dev_mkdir(const char *name, umode_t mode)