Message ID | 20230202204428.3267832-3-willy@infradead.org (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4FB9C64EC7 for <linux-mm@archiver.kernel.org>; Thu, 2 Feb 2023 20:44:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B4B96B0073; Thu, 2 Feb 2023 15:44:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 065576B0074; Thu, 2 Feb 2023 15:44:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E487A6B0075; Thu, 2 Feb 2023 15:44:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CF2C06B0073 for <linux-mm@kvack.org>; Thu, 2 Feb 2023 15:44:39 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9266C141027 for <linux-mm@kvack.org>; Thu, 2 Feb 2023 20:44:39 +0000 (UTC) X-FDA: 80423530278.07.4827EA2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id EC9E1C0010 for <linux-mm@kvack.org>; Thu, 2 Feb 2023 20:44:36 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Cnpe1akX; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675370677; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CHTViCFku/KBgg0p6DZbUUb80eMrbMHO+BwTMmLL/c8=; b=ORxFHIgxCyvTvPDW9WJV+2+mQMyebxG1aW+0sL6mOuh40XfR7Z7GiQyEVnfUNahJp0D2J+ Zbc76Awk1A5h+Yjxlr9RR7esdv/Y2P+n/s9iQ/rSh4oVCOAJ4g2onbLeabhuJSx/rfd9nv 9DnToNpR92bGMKoy0ALkVecMI2VLcGk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Cnpe1akX; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675370677; a=rsa-sha256; cv=none; b=CZlnUtbmWgQ1AUv/vKOIDSGgQd3ri+ZgaMzIAyYF4176tVrkn4iih9i1EgCBSRax6e+3Uc ROP0ozeYP4GlfnXAUxLUTAKakY5aDiJCM4QdvHIa9PauSYNLP+gjm6UysO4X2SxDor0+ro iYk3K0fR/+gHDApkkeTbS8cdn19pI94= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=CHTViCFku/KBgg0p6DZbUUb80eMrbMHO+BwTMmLL/c8=; b=Cnpe1akXRcTjrbOFxM+9HrW+ur d1lfcvyzmUOAlYVR9x6xYmCbrq53KnUEe+yqtSAHOPbH7OHm0rewQg2RMYzAmtBFcYZE4oSeqLxMi eCHHJ8dFrq4kz9d/JcMQzW5XpXnfBUje4e46WGl4WZgLZJBy7/sDkudm3R/iXLIpz5Vh7F5wllJ7I OUkIXT5U0OkITUYHT6Dd+ODvKs5q3qcDfvn3fcX5d53emCWIimY8ED0Y5esijwiT7AN7seZkhU+G+ eFufWstFTegm87OA4SkZuEQOD6F1ZgjDbt9nNJNndVfqGOf533nK3ibsN/iH0hY3EkdfhgfQTwKHm GPQu7rFA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNgRa-00Di7O-Ue; Thu, 02 Feb 2023 20:44:31 +0000 From: "Matthew Wilcox (Oracle)" <willy@infradead.org> To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, Hugh Dickins <hughd@google.com>, linux-kernel@vger.kernel.org, fstests@vger.kernel.org Subject: [PATCH 2/5] ext4: Zero bytes after 'oldsize' if we're expanding the file Date: Thu, 2 Feb 2023 20:44:24 +0000 Message-Id: <20230202204428.3267832-3-willy@infradead.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230202204428.3267832-1-willy@infradead.org> References: <20230202204428.3267832-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 4a87fe8e4q84xho3peuo7npnobxgat9m X-Rspamd-Queue-Id: EC9E1C0010 X-HE-Tag: 1675370676-964528 X-HE-Meta: U2FsdGVkX19sqiQDVkTPymeb2FFtdJ/uBQgJggL+fiPCs3PhOFa1UHbEJkL03Z0d3NIr1R/4W//jHUcliNxUz8vTwGUc1yf30UDgUMyauTEziFAyQJbwkv7qY0Afl0AdzDXlj2/co3hKM1NE6IB6EK3XXGlprLyaJsh3SPXx52I1SiuBL0wro6dSGWf2tFkuLoYjA05H7RjBgdCT5XqkD0ew3lAFZU06ArE/H1iGN+lnrwb02UwYuqxfu/jAlkwq0hfMtxvZNwzK5QD0Tu/7juCVeR9jRFM0MVNBjKECHcHcVuc1VJV8kkptVtLi9QGLbC0Bs2IpeUUERLZrbVNieouZKK3EWi3xKhHfiqYx9nVjJD9YZSxMcNmY+0RQdnGVmWn3lKuYSwz8leJbSXTMyrZCW+yhebM79ErGriv24BBmG6UQkFESZ3C6BCvwrAMhQzsvX5o9n/ivZhRwuoB4etq+ksBFsg89ygFB6EgEmH+VhxXUpKX+BdSO+55ZauxzG9tX1QZhl0uEqpTSLEnomk/aWkPiiYijTIKozj8Tup2xrPDomM5WJRL9IM4nGxriRsqEncAculpscl2+v9tu0BGSFgQS7+B1OQXj5YnkXclP3hDMxEO9ABFhQnnXES837dAPhTDwnew5HLnYL6r/HiBxYgPyrSp32gksBwNDu10T1RkgCmMtGEQX4y48pkQ6IkQUG+az7BNetxf91/CXPXZep7w3DUQCW4bgSLBBT+Mp8oRRL2gzK48TpZsf4uFWdL4gBQqXifgMkY4DaJucOS5/9arEwHai/TD7PYaXTtJkHHIApwjt7WlGSXMiEGvqBX5mhrixhtX4NrT27KddN8C2yntCUuC5JV1i0jIY9roNI6yQeQOz17wtagdpOXqJ1SoJx8aTlnohdse5l2h6SsLAlzvvfv1P9wrpSoqmqBeeDx04bi+jZMeEprE4DXM4nmOnMHXNt2/kJMpAJM7 tiW6uUfj TZw9ahpMwjR4fJfuyCNjwY0Bh+B0ci4JsddVb+mXmIT+/LbmdUiQxFrLqQpL8kF9v70z73nGOaqkCRJKebIooRLs1f49/6na5GjuBd4CDccTuBeGPzNlit8I6u2CvIu6eg7EyeDX6OHtUsD2vh0+7qrkrYSGkRdUcQaYmXJcSO17TwgKA/JrPZYXIrIXQRdnV7B7v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
Fix a minor POSIX conformance problem
|
expand
|
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 9d9f414f99fe..14e3fa99f733 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -5604,6 +5604,7 @@ int ext4_setattr(struct user_namespace *mnt_userns, struct dentry *dentry, if (!shrink) { pagecache_isize_extended(inode, oldsize, inode->i_size); + truncate_pagecache(inode, oldsize); } else if (ext4_should_journal_data(inode)) { ext4_wait_for_tail_page_commit(inode); }
POSIX requires that "If the file size is increased, the extended area shall appear as if it were zero-filled". It is possible to use mmap to write past EOF and that data will become visible instead of zeroes. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- fs/ext4/inode.c | 1 + 1 file changed, 1 insertion(+)