From patchwork Tue Feb 7 17:13:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 13131883 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C655BC636D4 for ; Tue, 7 Feb 2023 17:13:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 870766B0128; Tue, 7 Feb 2023 12:13:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 820A06B0126; Tue, 7 Feb 2023 12:13:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69A0D6B0128; Tue, 7 Feb 2023 12:13:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3E7C46B0126 for ; Tue, 7 Feb 2023 12:13:32 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 228064019C for ; Tue, 7 Feb 2023 17:13:32 +0000 (UTC) X-FDA: 80441142264.04.D246263 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 4CA40140012 for ; Tue, 7 Feb 2023 17:13:30 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hm40Q+Qd; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675790010; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AA3SDxqAw6tV+jeEhwhhXCCPQx7iw6NiGu/cAPT0aQk=; b=Q+FUYK6fhrfVNg1BJIo7otHKRJAmV9BBHO8DBt53xzTrV5x0DcOz3Ogsv+Fw08aT3kZ5iX TS7wSQcU0aEg4Z7qnQCLpUVuPvyh4kLHffVaAgYaSSDxw1CueRauyHuprhYD2a0ACBO2EO 35eMBAMu5m/wG8eTRGjohqFehbBUaHY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hm40Q+Qd; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675790010; a=rsa-sha256; cv=none; b=Cc+ySncIGS9Ltc9td9CkloTYAdq/HeEBCp5mgcpD5lIcTbq6LcSwu2d2CrznuuQxePFgiJ 8SY5L6xs5p066odzf5jM4GDtdvT4r4FSoh9WubWfmEADPnhYtDm41BJKok8WD9phGVGyS8 98fX2M11gX6X3ppl3955Uh2EuK2VKho= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675790009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AA3SDxqAw6tV+jeEhwhhXCCPQx7iw6NiGu/cAPT0aQk=; b=hm40Q+QdgwM89yEvm002WXQ6H3T99yQ4SuNl1Iba7t0fdPXUOwyT+B+vWVoJKSdJ1cxoho iLQt9+vqn8g+qgNON59uQFG8ZqWKkbjMz1XPcebS5TpE2cKtPrSaWOSE+uSGBOhR5oFElB RXaGNrqAAn84KTMZ6M9+Tv3tycq8UGk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-452-wF4wE6smMp-jExteuoiB4Q-1; Tue, 07 Feb 2023 12:13:26 -0500 X-MC-Unique: wF4wE6smMp-jExteuoiB4Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7ECF4858F0E; Tue, 7 Feb 2023 17:13:25 +0000 (UTC) Received: from warthog.procyon.org.uk.com (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id A6C1918EC5; Tue, 7 Feb 2023 17:13:23 +0000 (UTC) From: David Howells To: Jens Axboe , Al Viro , Christoph Hellwig Cc: David Howells , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard Subject: [PATCH v12 05/10] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Date: Tue, 7 Feb 2023 17:13:00 +0000 Message-Id: <20230207171305.3716974-6-dhowells@redhat.com> In-Reply-To: <20230207171305.3716974-1-dhowells@redhat.com> References: <20230207171305.3716974-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4CA40140012 X-Stat-Signature: bwgwr1kfset5nh61szu3q8sydierx1gh X-HE-Tag: 1675790010-936481 X-HE-Meta: U2FsdGVkX18RnznOTc66+Q5kALajmm6sJD0LC1LfeLeX+XSH8+7sdK8nbzWk1+VwcuQ2YEc0ei+5y92n7spqmfMmxli7cDN8GIuEHskS4FJmCJnRGUCFGB5KS+QssSNxhqxgbMSLF/1waXh8sswmWCtNHpgEty/fCIHadjBFXBiG4X3v4eBJ3x4hZT80I0Q2rdA5t3OlV7OtB4nH9MrHxWs6kDEAKDc6HlI5oxTN63TDkysTytD+HAwaNz079JfVz0y/mTb+JVtqnC4YpR8fpkpxRxaod9vzjmiY0VUxEiKt5agWHmeey/KmQyjJ918lCiQQ9hNIDABoCZ9bjEj5g9sBcfAWQi/u227Q/W0bH3jjgtzLStp31QUaqIgG5qmxcCoDmaiahE5pmZPY28IZkF5RkmU4f503i1pe5nOV3XlhjjWf2/zKGj5a6zzyDqnGGqliztZgoBNeVU+dzX2P6g3uOArFECYuhpxqySaPv16Vn+wNLC9jOpiYQNgrtKcuH4AyLi8rgHtRa5vY1A8gTpkRHtNULgoid4aqea2vV8rYsmJLAjLZCtdl3fNt6TqRPGDS4t9mTioVtZSdR5yUpFByx+WqUMU5tbbpnPgcY67aUUgjVcYK797hvYFJvh/C3a+VzCJ/VILKcRFLqIZPgwbKmFTWW2mwdi8QVja81JnPxDCSzS3FSG8g/7suKoTnvlDOB8s41WbAlyv4qw0ceAiTU6l1Agh64kYF9Bgu0U9w4WlNYaEiPcJu75Aoi/Vxk3L8plQTRkq2q90356jczi7GxqYvdRKl6OUK3XkXVvCG8XCymJVTtPt8Z65Fyt3lcH2XRSUy7TSExX30MpfQfaBq010moQNTZOAYw+jUVctpKQAi5Fhwic+jfsjXR2qzfF7Rfa7Jod5d2DvmN4j73vwnYbXHOL7ThSVwKJiU9bRQu1JAeOFLISW2AmXI8FlNAHUyGlUGUNmnpNya+tx V3qKBLzd gzKLc1SbQwBe+wlmqgXgCsquTF/Tmn1DS7I71RgkLRWRhcRfBLK83LuSnz9hAXzNVAJISAU/P8AUh2kguN5GyGBosWhEnYeGSlm9r9BF5qAUjM8tmjWIYovcP2nuyNBM0KnlsP2fExTk3I5xQl5aidYDF2AfrdhPENJ/OdoBuif9sH1nDWRnxp4rw67WKmNPpht6uMro2A38rUF4a1l3beCODXa+mGYiMR6F6NjvMDQq6OhWZxk6Kq0erPh3hJu/hLnRzQ2K8fcx5dV79p/CuGZ+h+VevYCC6BFTqJCAbYZLj5+jyWwu7D5lrBLpKOyfv7bkonn2Qq4D/mQvZA72IFINVlkwDpPJRLLbvJ0PeRpCIpVwcU6JoVH2XUAEIe8yM8MJ9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ZERO_PAGE can't go away, no need to hold an extra reference. Signed-off-by: David Howells Reviewed-by: David Hildenbrand Reviewed-by: John Hubbard cc: Al Viro cc: David Hildenbrand cc: linux-fsdevel@vger.kernel.org --- fs/iomap/direct-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index 9804714b1751..47db4ead1e74 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -202,7 +202,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, bio->bi_private = dio; bio->bi_end_io = iomap_dio_bio_end_io; - get_page(page); + bio_set_flag(bio, BIO_NO_PAGE_REF); __bio_add_page(bio, page, len, 0); iomap_dio_submit_bio(iter, dio, bio, pos); }