From patchwork Thu Feb 9 10:29:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 13134344 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6B90C05027 for ; Thu, 9 Feb 2023 10:30:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E51D46B007D; Thu, 9 Feb 2023 05:30:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E00886B007E; Thu, 9 Feb 2023 05:30:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDE006B0080; Thu, 9 Feb 2023 05:30:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B048B6B007D for ; Thu, 9 Feb 2023 05:30:29 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 86BBDC046E for ; Thu, 9 Feb 2023 10:30:29 +0000 (UTC) X-FDA: 80447384178.21.9585DB6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id BB2BB18000F for ; Thu, 9 Feb 2023 10:30:27 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Z0mlKeO/"; spf=pass (imf06.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675938627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AA3SDxqAw6tV+jeEhwhhXCCPQx7iw6NiGu/cAPT0aQk=; b=29+VBy0Rdck5elu5UjLKwe5D971cjp0YyjFGwpiy6hCTnddI9dihq5hDeuvWZcrjF8aMdG RAYo6niXPshfXxYvWWVeAQ5VFkbNxjbAZKmAHxAdzdcLkOmFWnH4jPNCRUcG+KQDsZY2gr WzvtLwObj4Vy7skV5z3tArGoppMC59Y= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Z0mlKeO/"; spf=pass (imf06.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675938627; a=rsa-sha256; cv=none; b=CQH2pSaFP6KhCCQ3JpY7xiN8gXotxW58KZspzEmPWNWpMJ8Giy8Tj1sX77Z2QBLv7x4fLk jq608ln8iE8nJ1O8d1V69V+u77V8e7tjQEOLGz7PSG00bQMEw50hZYfKvvOkZ/WW4t5Si8 988vBrp6mdw2kg8p9UnkmgkiFrwYWzo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675938627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AA3SDxqAw6tV+jeEhwhhXCCPQx7iw6NiGu/cAPT0aQk=; b=Z0mlKeO/EjZSVCXGvuR3N+a7yjIuBqjPQWtZY0am8frZiUxlV2MRnYTk36uvcc8xDGKnmv rHZ+D2bMz2DD9Uh882VX7DXegSs+eTswPn142xevXn1R1vM9NN2N92dvA+yU4pxE+b4f6I lyMtK7qhNcR0Gb4HiMmAYaD0R9htn+E= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-480-gCLZSpzUOyqIbLen8hMYnQ-1; Thu, 09 Feb 2023 05:30:23 -0500 X-MC-Unique: gCLZSpzUOyqIbLen8hMYnQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7E0DF18E005F; Thu, 9 Feb 2023 10:30:17 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 986F41121314; Thu, 9 Feb 2023 10:30:15 +0000 (UTC) From: David Howells To: Jens Axboe , Al Viro , Christoph Hellwig Cc: David Howells , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard Subject: [PATCH v13 07/12] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Date: Thu, 9 Feb 2023 10:29:49 +0000 Message-Id: <20230209102954.528942-8-dhowells@redhat.com> In-Reply-To: <20230209102954.528942-1-dhowells@redhat.com> References: <20230209102954.528942-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BB2BB18000F X-Rspam-User: X-Stat-Signature: yene5gezk4rh1ojwyec66gj6iemhz6q1 X-HE-Tag: 1675938627-767741 X-HE-Meta: U2FsdGVkX183/cSeujPOoGCZhI+/2BXWoJEmRPN6q45unUh+VtQnhTuSkh+iXcHBhfvq2HoLNkDJFALA1IJFb6hQikW+/PKeB2GTjrV8WHxvNwfW9YJ1YZluVbjlggk4hKu0fe42fZKlLfX6vRhLRkCw99dAlAJztFWJlGzRy8jfnvvLreWsqZlRKY6mWcEV51WUZpnifeRBwBYaCND+txJKbKkZuCpEp8JqV3grpJxeNFShrrV7GycAdtwCJd6i87V879j5Lm52X8XYdgWHFvR0Mlt8PrJB7joWcYrNyCcdfDRo2jhRbbI4dQzljnei3emcWPqIbeust/CSHSPwMDVgC2PHuMBCIFIsjPZjavPKy6YJDcUr8faajBMd/91JCx2BxlwugaME5jsxytJZ3wYgwZAz3gxMIRjSWLLc2a6QOJIagOCt8I5ACoO2AejKzRfcz1EyIFQYWf8L9snIdOCh2tQXYYuWtw58JtVlcFZTWEs4gNHa4vVs+XXKPL7iIIr/XBiE+XqpftccaRaBhJKQqUmc4Ub5vMjqiEdTglF4vW2xrK4YaUjLvwkub+Ra5Rx0dp2iZnIRq/OoKi8cj3ALjjxxGoG93VITTG9Xz06hso7fPSIK2/gnS38GpKWTvRQxJNr3F8121gn8nx+Xkn935iCMTYz+z0+n5/eCk8q+sKJAwtE5N93oXQoH9ozsBCDFt1Hfr1X5L5nu6P2XvbBBOuJTGiMEk2hNs7eqGMY93Yj38na93sDsjSqIeV277+gpuombgqX52zsMlkNcxdcwp2VoR1r0kEp/utUbLyPfNCKVYZQi7C2k1tQUZAN6p3VEWUaJquPZMw8jvFZhuABj3APgZ1cJa8HXf/F545HVFI5+igzJSPGf2Uy9W1s+cNZbIFYNjIsHIVn91g28WD6hEnbRh34LcHJCRPvze9Oh3AtYu1r5wgSRZAGGMMq+L6r4deZ8jfNMb9G7mDj vxtArfCW 066PMx1ioJHwnyTdWCqu9Qz9StaL9yGKKHixkd0fgjFhuESAjaQTsv+OYKis3+APq3CHwn4bQASskhWxjx4b5CZxsPo/xzQBsEmvCz+N/TgqgTl889W9DisEXI+VNsXDUgTfkGf9Ia/s8CA0rcMCPT3NqsIuPPhO4MXh3/mm/3gVcvKUm7cv1EvuNU9ITT99XPwS07AYWw54qimFwqr6EQTsxTc5REmxpspVeSCpoFfnPCTaxcQfVsk9ttIyJl0G+jkQUmM5YXinG1T29qPkGfIJRwxP/NdsEHgZWnIgNkckrpiWo+IIhYQsiBIzivVMidp66UNvBr3BKPpT0zvpbTgoiguAcOWZfKnkrBMeVSwYODoyu+hb40o7/5UGhGx7C/0gm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ZERO_PAGE can't go away, no need to hold an extra reference. Signed-off-by: David Howells Reviewed-by: David Hildenbrand Reviewed-by: John Hubbard cc: Al Viro cc: David Hildenbrand cc: linux-fsdevel@vger.kernel.org --- fs/iomap/direct-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index 9804714b1751..47db4ead1e74 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -202,7 +202,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, bio->bi_private = dio; bio->bi_end_io = iomap_dio_bio_end_io; - get_page(page); + bio_set_flag(bio, BIO_NO_PAGE_REF); __bio_add_page(bio, page, len, 0); iomap_dio_submit_bio(iter, dio, bio, pos); }