diff mbox series

maple_tree: Remove some unused functions

Message ID 20230217084647.50471-1-jiapeng.chong@linux.alibaba.com (mailing list archive)
State New
Headers show
Series maple_tree: Remove some unused functions | expand

Commit Message

Jiapeng Chong Feb. 17, 2023, 8:46 a.m. UTC 
These functions are defined in the maple_tree.c file, but not called
elsewhere, so delete these unused functions.

lib/maple_tree.c:331:21: warning: unused function 'mte_set_full'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4105
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 lib/maple_tree.c | 15 ---------------
 1 file changed, 15 deletions(-)

Comments

Matthew Wilcox Feb. 17, 2023, 2:10 p.m. UTC | #1 
On Fri, Feb 17, 2023 at 04:46:47PM +0800, Jiapeng Chong wrote:
> These functions are defined in the maple_tree.c file, but not called
> elsewhere, so delete these unused functions.

These are for a feature that hasn't been implemented yet.
They're static inline, so they cost nothing to keep around.
NAK.
diff mbox series

Patch

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 646297cae5d1..f89b61e37d93 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -328,21 +328,6 @@  static inline void *mte_safe_root(const struct maple_enode *node)
 	return (void *)((unsigned long)node & ~MAPLE_ROOT_NODE);
 }
 
-static inline void *mte_set_full(const struct maple_enode *node)
-{
-	return (void *)((unsigned long)node & ~MAPLE_ENODE_NULL);
-}
-
-static inline void *mte_clear_full(const struct maple_enode *node)
-{
-	return (void *)((unsigned long)node | MAPLE_ENODE_NULL);
-}
-
-static inline bool mte_has_null(const struct maple_enode *node)
-{
-	return (unsigned long)node & MAPLE_ENODE_NULL;
-}
-
 static inline bool ma_is_root(struct maple_node *node)
 {
 	return ((unsigned long)node->parent & MA_ROOT_PARENT);