From patchwork Mon Feb 20 13:22:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hyeonggon Yoo <42.hyeyoo@gmail.com> X-Patchwork-Id: 13146452 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2559BC05027 for ; Mon, 20 Feb 2023 13:23:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF57B6B0074; Mon, 20 Feb 2023 08:23:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BA6A76B009A; Mon, 20 Feb 2023 08:23:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A94A06B009B; Mon, 20 Feb 2023 08:23:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 98FC46B0074 for ; Mon, 20 Feb 2023 08:23:42 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 69C0DC04F4 for ; Mon, 20 Feb 2023 13:23:42 +0000 (UTC) X-FDA: 80487737484.29.0DEC440 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf23.hostedemail.com (Postfix) with ESMTP id 11065140020 for ; Mon, 20 Feb 2023 13:23:39 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RmJBQn07; spf=pass (imf23.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676899420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MJephf/cE6pyMyxIK1qVn/6WhIHz/ldUDs9NMMmWGv0=; b=0HkmxGyccS10dtMJkqlEECHjnQekbsQOv2aqpTjvU08IvrzsFVG6xiH4AWYanTHIIfHMZR 6EAREa7rKPjAOni1DQwSSEmd/0qQ6Y7+7cUKVNNBoKA/e2FbjTaCDTzoDoRTURSbQ+NB7J 06di6cZ0JcfUYUOIlosIG2a9hxnqAj0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RmJBQn07; spf=pass (imf23.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676899420; a=rsa-sha256; cv=none; b=MhMIagS+9rIgTG6toLrQYAK57wdTGn5+q2iT+l0QvaDQznPBqkdDe0PI6RgJiIbsmG7woF GBWLFQJg45YmBmhcY70+HFdTpVmJooFcTP2CKRzIuFl65OhgIVCgseRIeR581S78zlpW6a sku8KLcMBGgGPaVHzDoAB+5j0uYCSIU= Received: by mail-pl1-f173.google.com with SMTP id q12so1420520pln.7 for ; Mon, 20 Feb 2023 05:23:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MJephf/cE6pyMyxIK1qVn/6WhIHz/ldUDs9NMMmWGv0=; b=RmJBQn078xHGiNh8byqJgJDtnT9qFpabZQQ7h31IEdlfrIxdmWXCmaYK/4pxpRWQU/ wMJbNHkN8VmDfy0O+BC8NvWWLTchE0k/Ox2KEzV5ImBVW/Ls9HQj5q/feTu4HdysEevQ cXpytbHwAZCKTfYv8XGvwdR3OofPKR59spSYoMyx//kkRQ42OECDSZYDbtDoGr+Qfnol m03EsDMrDPMsimStfsBM9LxltnCtEuU0BrfjtdWSAJRYH29pt4a+lDNjySxug2ROccEo /hCJ5Yxfxb2qp1WGsyhruR3c5xUJoLe2g/Fk/zClYC8gyXa6xlMQbAunCuIlj1QDv3Yx 6Eow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MJephf/cE6pyMyxIK1qVn/6WhIHz/ldUDs9NMMmWGv0=; b=WDu+/3jRuzY926WDCHN73zz0qmNYeXFa8Y9hOGtyr4u3675e0FKMqujTDfZmbfI8kt Zjba2B6YuxXqf9pk3ZsSyLypVym9dcmUojgs6pKhiIh5yykDyJomxMKtjvNm8DkhZr3a oLCMZ/Tria0BAQoW8FuXA9QGSuZHrVdkdDeB02IaN5Tw2waTaX1lz+2cjfMyOagnrd5C NuYg5QSG3tvf1MQxnJyNuVG+x0Aws4uimXZtpVrQsKmYpB0sGhziZjBsjslDRQ39nFyW lDWEd4nxC51mqfE0kU0kwUYIVVUxr8paMXhRQEerdNXc97hZXmQ4vZ9SrpLHaMYIfA+G VaQA== X-Gm-Message-State: AO0yUKXY9nfGseFEt9sS4uFARxHRtCMK/BXudcC+teLK+yBXC4S+j4ek 8p5QFEEbtGxFwDe1A1FjXw4= X-Google-Smtp-Source: AK7set9RJqCjyNg4l6UwqBDASUb3Ih7vwTeNyN8bSqpn2BWR8LbKPlnjEgEGxO60/VqfveS8CWYxGA== X-Received: by 2002:a17:903:2345:b0:196:3feb:1f1e with SMTP id c5-20020a170903234500b001963feb1f1emr3156359plh.47.1676899418881; Mon, 20 Feb 2023 05:23:38 -0800 (PST) Received: from test-ha.kr-central-1.c.kakaoi.io ([210.109.63.229]) by smtp.gmail.com with ESMTPSA id x2-20020a170902fe8200b0019c13d032d8sm6125436plm.253.2023.02.20.05.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 05:23:38 -0800 (PST) From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Minchan Kim , Sergey Senozhatsky , Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org, Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: [RFC PATCH 24/25] mm/zsmalloc: remove now unused helper functions Date: Mon, 20 Feb 2023 13:22:17 +0000 Message-Id: <20230220132218.546369-25-42.hyeyoo@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230220132218.546369-1-42.hyeyoo@gmail.com> References: <20230220132218.546369-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 11065140020 X-Stat-Signature: fqcg63cpwc51cmy71zmj5skh8fp9xqa4 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676899419-553723 X-HE-Meta: U2FsdGVkX197gAbmWzxNfe3ff1dxPtBVDV3uuNs7clRwK0ZOSE7jFXioDlFeg7xMTjIisT1UfzWFZTHRFX8JuKH1qsVYAh5zXSSHK0a1MNSTGBdC37ofmXCpp6kgWLGJOZi3cIkGpCP0gdhsc4J3HbvnpM1xHSUqvzBqPNZhUFPkX4wJqa+MBbXu+wlDe19XqTe/yZecwrOpWvAZxid8E733lgXwfQa0jfhbgOEM8+7/R5Xc7t36bZOFt4lX9C1rY3y1x5hEG94STBnfhOEsPPMxpYwAaIhYM4hcoK8+S6LDcvQfgZ1g+kgj7J2CLgr4q0jvQKTNs8KavpG5vVmsJ9FAa9mFlytdI/8c7t8SSn2+EWSDCnQD3DU6hzfo1dQJL4OulkS6LoQ1w4fZKR6McccWaOHfcKBf+hvbchlJw4EFwaVwE1/u37MPDru/oCfTaBHJwZxuy+4XHmEgPAC5K4o1GCtshfC5Ye3pIV056XHzu13fXSjJ29Gu3VRPB6pNbr2D9OGrnVMcl2bDOs3d7KQo/xoVStDW0IsT0wW6dq6Fa3EXR5Eb42iBjN9wKhoFloOvvUcrUZLIAlaEFWYIxM9tl8lqbT+6h4leUTfi6EzZZIB5thd8csO/HW+W2LJYJzrW+RytdVsdivx28pBLIIO1nQ/agBWHT8wUMdFYnROogJKwur8+i8arVcb3LcSAV5VuYmhYf5ArmGbM6SLzKCW3QK9lybiqk/5pNG22cZ4Q7ESMWMvPVCExNaIXRHPQgxwrattdlamGIEitotl6EZUSRWlhr+BK0q3emOE/hgwcKm++SSZEIejRvGtP4WGNwVErTQw9QWG0W60r1exWSWHNc7u40lO4M4Z2lF+UR4ZZniooGhzNCubAZDHYWPjygTeWCl4ID4hck9/Tj95pnGRLem2kFu9ugFYxJgZiLh7axx7V1J+8pcYW9qqtcYMb+tXmrNMjfYqRTi5ITqW fJpyCh8c 1TCoOwa02sNgoTNi1MAA3bVbw2HD8pPkgKaQRPrTtztFmr7iTBHYcyo4QO8ufI1+wRAE5nMRvHwInt2Ca76PLSO+daEyeIoh4W88qnle4MP/FHWagECEIrb+LGmizHkJV6Mrf1fGAPc5eWjTAPtJSWlFMMwtcQJQiOuvAGtQqE8S7ua2TKR10F/UcqubzxAdAsqHFApJ8faxNvtSGiWOvfQQquXet1LMA/VPZzJjdrZS7Rkbybtr3wJ/zP5Rrrla4Hq2JmT5r6T6WxYJpdv06F6EgQSROAqVYMyPF3i1uRtrfcBXIp2GQPqN4CyEzOYf+DL1QMFdQ+y3FkJK8T458APOop+II+MpJV6k5p5wMOSO+4uEsWfCrB0eusAL1Wkag4CRo7QZeVd8u1/Z9dbpaYeNY1GiQ6QXrcnAd1Ur768cuIu2mkrIbN2eLhANjXE3buzZvzSBuZouuD+n6D6KTastjAcpeo2Tuf98pDrSBV07aG2xqD6HOyse+anIOoJBqJFDFBK0sDmeBuy9KScnwbqDxZWDIU/JgNTqruBQoV2M9b/GD9vxOSPdsOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: All users of is_first_page(), get_first_page(), get_next_page() are now converted to use new helper functions that takes zsdesc. Remove now unused helper functions. Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> --- mm/zsmalloc.c | 27 ++------------------------- 1 file changed, 2 insertions(+), 25 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 7153688f5bca..59fe8d469aed 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -659,11 +659,6 @@ static DEFINE_PER_CPU(struct mapping_area, zs_map_area) = { .lock = INIT_LOCAL_LOCK(lock), }; -static __maybe_unused int is_first_page(struct page *page) -{ - return PagePrivate(page); -} - static __maybe_unused int is_first_zsdesc(struct zsdesc *zsdesc) { return PagePrivate(zsdesc_page(zsdesc)); @@ -681,15 +676,7 @@ static inline void mod_zspage_inuse(struct zspage *zspage, int val) zspage->inuse += val; } -static __maybe_unused inline struct page *get_first_page(struct zspage *zspage) -{ - struct page *first_page = zsdesc_page(zspage->first_zsdesc); - - VM_BUG_ON_PAGE(!is_first_page(first_page), first_page); - return first_page; -} - -static __maybe_unused struct zsdesc *get_first_zsdesc(struct zspage *zspage) +static struct zsdesc *get_first_zsdesc(struct zspage *zspage) { struct zsdesc *first_zsdesc = zspage->first_zsdesc; @@ -997,17 +984,7 @@ static struct zspage *get_zspage(struct zsdesc *zsdesc) return zspage; } -static __maybe_unused struct page *get_next_page(struct page *page) -{ - struct zspage *zspage = get_zspage(page_zsdesc(page)); - - if (unlikely(ZsHugePage(zspage))) - return NULL; - - return (struct page *)page->index; -} - -static __maybe_unused struct zsdesc *get_next_zsdesc(struct zsdesc *zsdesc) +static struct zsdesc *get_next_zsdesc(struct zsdesc *zsdesc) { struct zspage *zspage = get_zspage(zsdesc);