From patchwork Tue Mar 7 20:59:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Liam R. Howlett" X-Patchwork-Id: 13164700 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8548C678D5 for ; Tue, 7 Mar 2023 21:00:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2B6A6B0071; Tue, 7 Mar 2023 16:00:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DDBF26B0073; Tue, 7 Mar 2023 16:00:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2E2F6B0074; Tue, 7 Mar 2023 16:00:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B45106B0071 for ; Tue, 7 Mar 2023 16:00:23 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 79200A060A for ; Tue, 7 Mar 2023 21:00:23 +0000 (UTC) X-FDA: 80543320326.30.4B2A6E6 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf02.hostedemail.com (Postfix) with ESMTP id EEFB480004 for ; Tue, 7 Mar 2023 21:00:18 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=hMz0WmOG; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=SHaUaxTO; spf=pass (imf02.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1678222819; a=rsa-sha256; cv=pass; b=G0A9h3y7RnbX2NqKUCOLxugJuceI2wOxPA8G0cJ5pSqIvU1RKQo3xc493imzXj8tlQB6b0 Wz2Q37pA9VOIuwHzFAglU4+5p3G5mFJ0nuy6ZZPVmTTwzIv3I5f59xsdVizBOR2pubU4gA +6LPflpwDS2BzCOMB7ygKL3YLZ/2KEY= ARC-Authentication-Results: i=2; imf02.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=hMz0WmOG; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=SHaUaxTO; spf=pass (imf02.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678222819; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=y4TIKLHZySqO98qYzQyHoHZGKwl/KxJszkQRlg172q8=; b=xvdmnQ3bZglgZPqQL3BhHBRZPA2OwPMYQB+vnODAvKAw6G599JNV+ciugcPH9SekoGMP0g f93xKmFXeM3wDBIPyvKwgWSJLRZ4n5oKy+vAGUwdvUbXbreo0HbesE/FDG/k17vEJsX39N S0uA/UtdWxPT4v/LvCy4kfLNHHsXieM= Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 327JuDMX015840; Tue, 7 Mar 2023 21:00:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : content-type : mime-version; s=corp-2022-7-12; bh=y4TIKLHZySqO98qYzQyHoHZGKwl/KxJszkQRlg172q8=; b=hMz0WmOGtu9wUaRPWmUxz4Hf4pH6HGzALLZUi0jRZvNQ/d+3G9SCNIgoU7M2gjWp9+/h Vqa+jlVCqWSn6JNaFfSM16oLOAVW3bqQ7uvd1ukkEtJBci4a4xrI0/vvFWDA7zRQ+qoW gHwbtGVSXf7wzjrDy11LnyyOhFHsFcZAyhQoxMecu6tq7NGss75joi7GE8MFta97sB6U 6axKIrz7rcg3lsO0QgYEF8jyxe6aQkcHx7bEo6IuCYCOq6DmzVVd8ppmtkVW5cG7uMx5 OumuvoYAAdmN3Kn63GRgnwtuaDpT/Ns9ZonnwPEArOppjW+XccHz9M5w5iKU+VYkRbqY JQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3p418xxpk4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Mar 2023 21:00:08 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 327KV09U011126; Tue, 7 Mar 2023 21:00:06 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2171.outbound.protection.outlook.com [104.47.55.171]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3p4u2jbnpj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Mar 2023 21:00:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e1PG3yA2lLuATzWlFDBQY44NplkTuDJKKgZ9nxy0/up0HzyCM40s0uG/8klzuPk5UvhjXkVBM7LYGgI7yqZoM8ga2dPbLriGqhYciLv+lXVmXEAhPx0/BdBBKpGQRo8uJ7HPilCPrtUNL11RD6mn/uKiG7k4c+76shg8Tz7wpui4nt7fJePCibIxEvWi2VVvgIlzlHAfecK8jACZ1NYgwtY8ClYla2+RrzkC6CJPxM1QKkrGCVR3R3N5VLFURczLuyswYmpYR4y7c0fw0cDKIr7rXTE+YCXPOEv1XuSr1cgQZ3DktouLclSN9sji/gI/bcNuwWon/DHvSr/fVWlFuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y4TIKLHZySqO98qYzQyHoHZGKwl/KxJszkQRlg172q8=; b=jlmx5wCJWwY7ktNxuhJ4NVJHGMEcuxXhvFCrTndLD/hUtAhCCeaQE0Th8e8bdZL7lF4ZnJrw4cQ55sBuxB7op/ZkdMVnnQ86gmRLSbMRBodGkuSaHuPhWwVIKhmu0ZIGSpc084MXm89eygqvpelI00lJwzONDBoJVgDmMuOuMy3mrseocFPASXUYMlRyoGb2BqomD9RAfAlSxR8S6xlu6tC/91NvHYuuMLD9vKR3mbWXiupn+p7OkH9GMImhII9HBTf3edw72j/77Gn78M/nBYF+AtJ5HS3CaG22E9vkJXa1sLfz5pn48jGqLJOFwgUzuIcEyti5RfhENfWf6YQ43g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y4TIKLHZySqO98qYzQyHoHZGKwl/KxJszkQRlg172q8=; b=SHaUaxTO3h8RF+YEVZf0tqMMZzGGtoaoORqTN2TU2ctfzB2hGazqa4g2zbXR5Ndinc+E0jNRCwqZafDoTK3xJlF40eYAbL2L9TkVj/L3+FuGsWz6JAtSiq9Xq0ghYel4tJCz/yIV5C4NqliwhN9W5mOdDQ3tAeoIW0GE0zaNhfM= Received: from SN6PR10MB3022.namprd10.prod.outlook.com (2603:10b6:805:d8::25) by DS7PR10MB5037.namprd10.prod.outlook.com (2603:10b6:5:3a9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.29; Tue, 7 Mar 2023 21:00:05 +0000 Received: from SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::93c9:c99e:5ab:4319]) by SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::93c9:c99e:5ab:4319%7]) with mapi id 15.20.6156.028; Tue, 7 Mar 2023 21:00:05 +0000 From: "Liam R. Howlett" To: maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: "Liam R. Howlett" , Pengfei Xu , syzbot+2ee18845e89ae76342c5@syzkaller.appspotmail.com, Matthew Wilcox , heng.su@intel.com, lkp@intel.com, Stable@vger.kernel.org Subject: [PATCH] mm/ksm: Fix race with ksm_exit() in VMA iteration Date: Tue, 7 Mar 2023 15:59:51 -0500 Message-Id: <20230307205951.2465275-1-Liam.Howlett@oracle.com> X-Mailer: git-send-email 2.39.2 X-ClientProxiedBy: YT2PR01CA0020.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:38::25) To SN6PR10MB3022.namprd10.prod.outlook.com (2603:10b6:805:d8::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR10MB3022:EE_|DS7PR10MB5037:EE_ X-MS-Office365-Filtering-Correlation-Id: b4f7e81d-c2b1-4593-4734-08db1f4eed1d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jqzpWA2bk3YGm3wP9+MlDbrjGZVdQ3TdLpJJiyb/Tp3fpz4Kfp7RoXEWQNCIVBLqt+lfyR+/6SwA09YElpHCkEkBAkZyhiaEhHa3a05P52vG5H5Ck+CEeEuYm/reYL7kxNXv4wYvltTCeEec8/JSp8NIz/TPivVLy/laAK1ChbqGAc9YaTXBk7ofLCLbmwwrm5K/+Ncp7/z6YEIbGncQfWX4sDhl2hWmOFjJgBo7rr6VESCwcbaKd77h5wgj7xRKoiExrPqEiRetTPgtXWn+Iku+amY1fva3YLEr/Iqtn4BCX8fPMzgLNZvGsoiBky/Q/QHagHtKnAsY11X+5eqjpb0e5eu4ZfCA5nfvcyQFXZIHNFAqe7IUzywwivct2+5cZG9UW/s1KVW8CeCawVgpw2RaqXhI2Iiq4gmaAFMNZK2AVxBhHBwfi9blnnpabUTsymMzDF+rEdwdMBc0OxwlanvGjT61jOW+kvkKl8RDzLGh4WZGbA6nx2LT7FxR+6umYmqaBU9byGvz3dcJMzzzidKMuJ7wvRJ2k9wwNPJi839EWCabi20zJwR+wlmk/GXDi3+Kw6O7Q+VLG8nUUkI0bNfhCd1ScPOB/ma7uOBn7UgAeAVmmlxBRYyUTjQbuCTXejK10w/vMZ9TcdTk6Khnx5ddWNpC4EghTdssdI/qvaCr37Ac93TvhzO9Xut5svKG8s3VT9jvyj47tbDJZFPgDTYJufPwnbMVNvKUNoSNJrc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR10MB3022.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(376002)(39860400002)(366004)(346002)(396003)(451199018)(66946007)(66476007)(66556008)(8676002)(54906003)(6486002)(478600001)(316002)(966005)(41300700001)(6916009)(4326008)(5660300002)(86362001)(36756003)(6506007)(1076003)(26005)(6512007)(186003)(2616005)(83380400001)(2906002)(7416002)(38100700002)(8936002)(6666004)(99710200001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: wAndExHv8ooNQ1G6B1F5O/4VNbPWo3a5b63RLRAyoOCdZgFAMCZuDMrLM++0QbA2UL+9iLtm6d839x17mjmIalw2Lb6P7cOS9tv1VzB1lfqcb53MMYj0Vd1RH9iCUV43+2o6oobuaTazfhiUPjSdW/SyZWMOhGKC/oz4hTa7NbbV+nExm+zE6/ck9PRRw5yiq/3zZa8sBS2ecwTp4PjcDP18oQAsq1Vf0UHC8fKavnczFmB0AGzIcN01I4Xj4yyUoUnBEJIlUR4j5iBya5rE+8it1H2q7aHn7x74yMIOd2tn2gXlspuMklVMOuMu5smBpMbhd0fBNW1UBUlTspVIoLjUUvip1acm/APYZRjNW/0ZMcfjY0eTLkgTUGjLFHoczSN7m3UztZygEXIZlYAhcDUAVGOj8S5cEHUfJdiqIDN+K3XwQE4IbzbkX4zTLWAIpxOsaRdu5nZ+d74Sk40pMGn4W5iMo+LUyxlbht3qg0B5vRNxG2nRByGOHgobfiJ06R9XC0N8Dwznh4DuSTtpIfwtGAA49Cn35N4mSM6DoPaXrqb3PU9uytc44zetXG42M5o6S68GVUf+h9Qp2xC5I4l2WcvK6JKRNVZ1CqeWE7hgtP1i7lo3AcH8wAawfUmDO1G8uihPsLjgoicSbqm4cextRaPZeXMrMxxHmuXBywF4dK00OmsXkgfvOiWjz3aafPbXVuFoprPbyqYRf/4wcE4Jzey0iMpQ9bl0HFbTmiXLeUCY6pQB3Rw6tynfMern9k7yaCN8s+xr9Yo4Im7jGau5BCh9xWuXjLe+CvBJZFXsFaCQAM9O6bf1K2qSRmpWd6iMbd1CzOiZg5ss5EUYdFp2b1lw6r4WUXNvsDSL4EQRxVZ+4rWfUFU8CtOvPxX7xTYbII8c2K9sv9jkd/Yk4ldJlGfuebCfCkmX+u0NMDCsuNQz/vNRW/OL7ceqDN7b8ef2oGncbcbffNkAYZs8KsHgDT2Xcf5HhFw1raO0tiEqAobg3c9Y74ji8to0QRxyBsPVmVehJWLSa0OOJCbwrg+XIESD2L1R+BClXVkDwU6jd+ljp8JlBKN6Bpd3hDD7WzZqc1iqN28QKtaXK/kR24dJAky0Uc6bKOjFFQshVeF08/GM6kHBAhXzqwoOrp+rfNGIrxJCPbsWALQW9vZolYuLIOUimA53qgY1wEug9lpvC0pMVfLcLPahPyHqDKgUui1FM1zu8tKUbSf4lmua5gwiG0uNLN3WDIHpf6lCIQ/UklY2alfpSTWO3QijMXUA7J+mFAkgZNx2iLHaKyD9Kk9Ugvi5aCnS1Fz2b5qDKxt79vtcBXEbCdzYMrh0OTwqY4vWlENATtLz/9kmoqAwyFJvgAl5WzI+z9HdP7L+xp4MeiiiOctBAXaklpQ9uxzZxFz79AAkA5EPMuqcB6kOBJhZSvFElPj59n8x3jnHo3SP9iiVxMOqgUq4Uywc+qMKn6xvJ1lDyk62C01nd9KynIgiSML7meQVIwq+38MU1iF9PS6k3BPaWkfx+qb+8sQKNGuul5+pMXQ1UpGYMCE51RFr9ArWSpTTPbWSbIGjbIoWc7MWKccDc5S3D87wShFyiD8fBGPTS+7B8L8OKK7t8Q== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ukmRKx6dDe5XwJrWVyQ1PeQBKFSGS+QO0CmIzdaf/tkasFysrFX9p//7DxMOlrE70t99UxsRQuQyYhmEmThpnAOitLFVk5HKbIMj5glKW2tVz/1310H7axqSFLBaHkqdmgUjdLxoQ6noBLjIE6LwQ0l/ltM8ynox5LhaN7uQbtH42ivYjKh2Q5Z7FFHwtG051MoqUunzpvPbMBu7nKk/bnDh35UxDvzWx+a4Fl5+MLhmP0OQ9mLN6uUwHUL/DKQNaO3jrXK8TZ0Gu2vno6i6qmQWJOfRKGAuh17UGdk4yQNhPmC3x2Df/fDxYf2N+jos2Bl1Coej1TK6t90SCQPOd44c31cR2xv4Pbp6jRokRRndAd3MY4rrZwKR8L/Wk5UqskGHNaIt+0yhfSJ7abZn0ITz6uYDtIIF1qorqmqIcxT4xqAytCFg/IcjXscpMxozuLXWlau5YxdEke01I7JbKsEIGKLTYwoUvv8T3geHrA7QUyX3wctfC5bu7iq8yHeJz0T9jGz6WcH3nuoL56f7jY+ds20721ZGrZkQdLKyxBYXq/hmqBCFuQ1mdC7Ym+UOQ6vuMgMd2NkG4vut+evdf/1DyjaDIOjNOhAvYaGQNW7oieTpogxqGgYedcBGJCN2ILk92tEb/q/9vSNohYXIU5MeMDrnZSYoOsgEpi/UayWqwl2nvNsL+srDqlFxikLFdV8JlXXrPEfYKpBjysFm3mFBJ4qferDRPk0jkaU3E9j/SoO5jW0LbOUkuQTPxRTvkKXlBZIN24YfBqa4qN9tIBuFtd9XvCVRpwIRUhh58YkwosUy8B3hwSPOGl6+5aaWIVjtqKBYkI7LRZ92xCrZ1bS4HtyiNBT5QF442KWtI3qMjbRro7VwXQLo34LKRYfkca3OJ2IqBD27Z9tBBAukeHwYIPrVvDUEPVGHUgsdU0G5SL8pkR2BEfP+wz//2P3XXc6M3T4nRtV8Qsf2isRqZR1mDTWrs0rWXkiZ8xuolzVPu2BJolfYvm7eV6a6VT9cAKUQ3r8NH3bN3X2CR4WQ1g== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4f7e81d-c2b1-4593-4734-08db1f4eed1d X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 21:00:05.0179 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ii/DTyqcTqYfPhNZpzFqaD9Dpg4NCl3HKDd8E9S+6+61lNL59Cp56NpnUkpGBJ/3l8hTZ05ubtfbwvAMAfYayQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5037 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-07_16,2023-03-07_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 bulkscore=0 phishscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303070187 X-Proofpoint-GUID: _7J32a3CXEl0QD9awKRPWpN3KCwu9nOd X-Proofpoint-ORIG-GUID: _7J32a3CXEl0QD9awKRPWpN3KCwu9nOd X-Rspam-User: X-Rspamd-Queue-Id: EEFB480004 X-Rspamd-Server: rspam01 X-Stat-Signature: f5ybkm8imjk7t45yfpo3e833ob5ii5c1 X-HE-Tag: 1678222818-672386 X-HE-Meta: U2FsdGVkX1+0wMapxE68eoniute4ph0hl8TtO8+mSnpQTyEXkFTmNExs5rkxkV88IWtcmKdnqO0Fdlve7pgQf99K4/xFoi7LENSl6p/KPJUm1sz0EoZRvR4HnzllqaOKMhW2wycX0GdkDvlBHqep1TqZutwufmetYoI8T0zJyKryRLmj1f/NdiTldOPVidEEfTdQjc8zisY8jQ67S7rKGs066QATJolszKLPr5iNIBDQYAXr2qVHVKDpVGfPllfe4/yraBuulVt324rUKkCcIZOx0Tz0VA3O2CXGvY9zXUHTVRDBsrZJCfe4KW4HWDThU9OyWuiqSM3HI0R+1Blt+MymfMHfmtPUje1cxGUc3s0FEILjMcpYzBlZaJ5MQvVD6h5zWSuf7ha8ETi/X/gN6SAo7pCdaaRPfyn0HvxQ55DWGYecHDannoqGJWzsS5yvmzrI7uANjFS0Kwf2Cd1R8WXSJzLn59YAKcW0wljweqmgKAP01D3lEkqui7UrVAY7WibYr43eEKn2aKCXoeMteCDCkBDPDO3UW4wVdtnAbkZ2I5dYsB/B0nk1j8EJTwIGjaZ8J8x288elBcpgmzOEb8ZS034GsyOv2h6H0Raeh2MwXFM1VyGqHdCtp9UAQbAPkDt/DNJMd3N24ntTT29HTB+GODDbYWmoArHwMblSnS/3W/icquK8gyAEwhwmCqMm73pxQeUlLZeTLvOhwnKahLJgisoVhBsvRGDkOieJujBewwh0TT6+Sci2gkc9kfnGw/kuoLuLxKfoZK7yya7nfbrmhP4o+CvqXQ1P9jcohebd5mhlrykhEE2qwDLqRpV0lvw8KxubrcjwlzVaqKKICqIs0YksYAostJ0t/Lxt52PGLJY5bppRboJv4vETCOaZhyswtIUVkckEU2hYSHLFX2/v3tjuslHmjToW2ipZz3BHzssRg+AbBMjrZk05gDyoQwxGVwyfSyPXYMarmkC fNKo9xd2 Ws0G5eC1JJ1vpI8fuJk1QNZkgDzLTvAUayCv0YBjqsEUSD22T+83Gmdb5K0Jm2colbwaIMhb6DCY/dRMqb5e7Kosx70P80+TKigviHLqAh+JtZF/ngnjKo+S47vhjiDAPi1Z1RxBiAEU7ebNsGvgv047jvHWszqUmsefr8bqAyKHPPBoiQUdN87n9eBEmIKva7xcZ60IonNwEN3XSx4B/xB2tDad6kEhJu/jZiPBk9AzWv4jlDiFaB17Z+C5Acl3tqxdJco2iurF9lypjiadyYg8irWajceNr93gxb054t7Z7CxGWqvqRH9byf1bX5bD7qimKXI5X0V63Isj3YSViQmpCUH5A7OTRAxStg5K0QYbNz91HncgzjJtkFqxRhebRfC19D4wWEKT6Ks0/HUe1jpZ9sDip9eJEMJn1NfI3O3d4l/TwOKahwgdRftVKRPJBUH/X3LV4VMv5YIl2NauGaMd4/Eyw72xwvzRKP7THpAEMQK/gdrZeHptNmNOsFIQqbZazBg8FwKNg5Dof6dEZY0Hd0WFfu6/RsVaOunKpZdnrw/17uGW8Ia26FbVHzUC5dyzuQTC7qUULeZk8bkHOC422L2Xa5kB6lOB+pfPil4AFwE7IF1qlbmnqg7doGVJnlTpli4Q0NK9oQcPKfPZQ/tz6Q6QofZYsf3ZGd4fi7ZWbfcImC++yO0e8ksXIroKIOcCEfXA75HRW6N/oomVfR/WYHpGAqL+e7nexEy+OpWWPgrAJz73mmK5tmsVe2MdPGwdiHcdSIVrr4E6gW5+ZmACDc/1HDrnPcuabaiIcW8wMiJ/Et3HwBrs1qHmTavD0cukiEGvcfIyb9NpQ7KcvoLI5X2/oJ4MSbPhV88F5QOlPKge5L3gUrbUfraBFYMI1wmq6movhqV1SkebJFHJbHY7COcptxkIIpDr6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ksm_exit() may remove the mm from the ksm_scan between the unlocking of the ksm_mmlist and the start of the VMA iteration. This results in the mmap_read_lock() not being taken and a report from lockdep that the mm isn't locked in the maple tree code. Fix the race by checking if this mm has been removed before iterating the VMAs. __ksm_exit() uses the mmap lock to synchronize the freeing of an mm, so it is safe to keep iterating over the VMAs when it is going to be freed. This change will slow down the mm exit during the race condition, but will speed up the non-race scenarios iteration over the VMA list, which should be much more common. Reported-by: Pengfei Xu Link: https://lore.kernel.org/lkml/ZAdUUhSbaa6fHS36@xpf.sh.intel.com/ Reported-by: syzbot+2ee18845e89ae76342c5@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?id=64a3e95957cd3deab99df7cd7b5a9475af92c93e Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org Cc: Andrew Morton Cc: Matthew Wilcox (Oracle) Cc: heng.su@intel.com Cc: lkp@intel.com Cc: Fixes: a5f18ba07276 ("mm/ksm: use vma iterators instead of vma linked list") Signed-off-by: Liam R. Howlett Acked-by: David Hildenbrand --- mm/ksm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mm/ksm.c b/mm/ksm.c index 525c3306e78b..723ddbe6ea97 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -1044,9 +1044,10 @@ static int unmerge_and_remove_all_rmap_items(void) mm = mm_slot->slot.mm; mmap_read_lock(mm); + if (ksm_test_exit(mm)) + goto mm_exiting; + for_each_vma(vmi, vma) { - if (ksm_test_exit(mm)) - break; if (!(vma->vm_flags & VM_MERGEABLE) || !vma->anon_vma) continue; err = unmerge_ksm_pages(vma, @@ -1055,6 +1056,7 @@ static int unmerge_and_remove_all_rmap_items(void) goto error; } +mm_exiting: remove_trailing_rmap_items(&mm_slot->rmap_list); mmap_read_unlock(mm);