| Message ID | 20230314071601.343817-1-vernon2gm@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] mm/slub: fix help comment of SLUB_DEBUG | expand |
On 3/14/23 08:16, Vernon Yang wrote: > Since commit ab4d5ed5eeda ("slub: Enable sysfs support for > !CONFIG_SLUB_DEBUG"), disabling SLUB_DEBUG also disables > SLUB sysfs support that is not true anymore, so fix it correctly. > > Signed-off-by: Vernon Yang <vernon2gm@gmail.com> Thanks, slightly reworded and pushed to slab/for-6.4/trivial > --- > mm/Kconfig.debug | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug > index c3547a373c9c..9a90a88ce053 100644 > --- a/mm/Kconfig.debug > +++ b/mm/Kconfig.debug > @@ -60,9 +60,8 @@ config SLUB_DEBUG > select STACKDEPOT if STACKTRACE_SUPPORT > help > SLUB has extensive debug support features. Disabling these can > - result in significant savings in code size. This also disables > - SLUB sysfs support. /sys/slab will not exist and there will be > - no support for cache validation etc. > + result in significant savings in code size, the /sys/kernel/slab > + will exist but will not provide e.g. cache validation. > > config SLUB_DEBUG_ON > bool "SLUB debugging on by default"
diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug index c3547a373c9c..9a90a88ce053 100644 --- a/mm/Kconfig.debug +++ b/mm/Kconfig.debug @@ -60,9 +60,8 @@ config SLUB_DEBUG select STACKDEPOT if STACKTRACE_SUPPORT help SLUB has extensive debug support features. Disabling these can - result in significant savings in code size. This also disables - SLUB sysfs support. /sys/slab will not exist and there will be - no support for cache validation etc. + result in significant savings in code size, the /sys/kernel/slab + will exist but will not provide e.g. cache validation. config SLUB_DEBUG_ON bool "SLUB debugging on by default"
Since commit ab4d5ed5eeda ("slub: Enable sysfs support for !CONFIG_SLUB_DEBUG"), disabling SLUB_DEBUG also disables SLUB sysfs support that is not true anymore, so fix it correctly. Signed-off-by: Vernon Yang <vernon2gm@gmail.com> --- mm/Kconfig.debug | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)