From patchwork Tue Mar 14 13:13:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Zhang X-Patchwork-Id: 13174413 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC26BC7618A for ; Tue, 14 Mar 2023 13:15:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBEDC6B0074; Tue, 14 Mar 2023 09:15:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF9118E0003; Tue, 14 Mar 2023 09:15:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B74CF6B0078; Tue, 14 Mar 2023 09:15:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9315D6B0074 for ; Tue, 14 Mar 2023 09:15:41 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4DFE8160EA5 for ; Tue, 14 Mar 2023 13:15:41 +0000 (UTC) X-FDA: 80567550882.01.3A16602 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf06.hostedemail.com (Postfix) with ESMTP id C1B8118001F for ; Tue, 14 Mar 2023 13:15:37 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf06.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678799738; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z9oXbFnouLu3UJ7M+jlusf4zWTmPRKVpTvfRvfSohEA=; b=5mUAnVL9/jQJdEv6OWQtEGaQdSR3IUhiKOQ/piVDJZA/p5U/yy7XbrdilyTTI/n/gCyanP ICzR1axWLzLTpAsgt5dVKyl+R9ExuzwFloEft/WO21jBsBX5jq9+DnCrqiPcXMgUogkf9B 8z4ZV3HnisUj4biu23HQBuTLMSkNnJc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf06.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678799738; a=rsa-sha256; cv=none; b=zc7pUB7LTTh5spK3mtNWytvhrE7APFJcAGbjV4omytJQWmGbRRthqZa3OqfWkpKGbEO5M7 z7Abc7sdVOC+UrHc38HEXjuG045RCm6Yx1Ic0Sy0Pzbh7O+06oTDsRzbI+Z4XUeztcdY5R WNT/tuZnZY57biVkxTlQ/3a84VNCOd4= Received: from kwepemm600020.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4PbYs90fb7zrT4F; Tue, 14 Mar 2023 21:14:37 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by kwepemm600020.china.huawei.com (7.193.23.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 14 Mar 2023 21:15:29 +0800 From: Peng Zhang To: , , CC: , , , , , , ZhangPeng Subject: [PATCH v2 2/3] userfaultfd: convert __mcopy_atomic_hugetlb() to use a folio Date: Tue, 14 Mar 2023 13:13:49 +0000 Message-ID: <20230314131350.924377-3-zhangpeng362@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230314131350.924377-1-zhangpeng362@huawei.com> References: <20230314131350.924377-1-zhangpeng362@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600020.china.huawei.com (7.193.23.147) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C1B8118001F X-Stat-Signature: qewhz8adb5istxctab6fbacmqy1h9a6n X-HE-Tag: 1678799737-6295 X-HE-Meta: U2FsdGVkX183a1AWI2a0GZoEGYFJAT9EwIecZKwvB2LXT1upwL7RXxLEV6OQt4CoShcvpIK6FL5zhOQDYZdkRkITy6iSsJ1H7Hctn2Ioy2idamc5kZU4NZk8/D7J2ss/CZbJZNwMLnI/ra0zKD4rHRw+rZspapOtstFM3PXc3etarYs/NKCzHrnERCJN1hIV01hfjhjnapTsW9rJbrhbKc3E/5Yio8PgppjiiXQhqWc6bIGu+m2lNPzfJi+rGAj7ROq2tLeTVmbfd5lMa836V/ktI+vMoMi/sYZX5vvIzXq3Xz1R241BM5HC74jnkphBghoIEy74UT0p4RsS6P2D++JYiR9nVnDlauUh2L+Y/svK55ZpXv8kSTKTAWKUW8wy1kfM6T1d8eEihIwrbA1s/w4ukuySVWoKIkN43LIifSvjpyR7o4DqVX6bzcoaOpsheQZw92+1T95IsfkyzMvRTN7LLCgXhF05RwO5iNngMP4+NjINHJxXVrBaeSZ5Ex6xrTdVBIP8IYI8TLSfjOD572Gu/ITSF9Z+T8cDmXyilNJ96tvUNBj1YmfQiYWxzTjUlJFq1/RajVCGyHqpCRYY0qH01LpRtuOQAoAXrgUxQ7iWSY64a0V4534VrpG61yfbkWXmeyrBu+mdXvhuM9Hr5+8KKsFKN8gKOpnGMJesiGaEGPneX+fWOgawk2qAXgV+Sy5SYgxfKznjI4CU3eC/VEV8vpcONX72fVu5eXR/4Vx2omBa2iv3sXvopUdCOCeXfdOcO5pOlVldi0mcdU7F3zxcjONDc8fl6kVWFEUDUMyHc+GzTRWBWgTQRBWEgQarIB+FlRNWumR4B5Vkkjl+QzadPeB5rO449cj2xu1Rnu2juNBUzDPc13z4bo0CsHLu4fqd2tip2fKerqVEk6tQEYmgTOIzfuPhuuiDhU8JB+AOstnDidXFPoviprb9LH79wcR6OTf/lOQFnzGecet 4IboX2I8 r2iUekU+R6bZ1iGGqZHvPi4udCOQl3AaHmDw7sgmga8LoufDgs4pvaElYt3MD0LSBOw42R4Ju466ihGAMITtLSd/Jcsw2ovcxIqs1Z6LicwTKQEJgelh9tpAInh19IwEEI1kJ4UCJ4enu5Fr2qTQIn07Rc7eysqbXBNEpb9IB5/0NClAU12BJjd3oLJ4mknLa8fCrds6jfXnsHAgcb/LqJKpFOdqRkHxwmyHVy9tQJXkunrg899yEGNPOtnESF28MpOLMSczS0MTHizsluqyaV0ZD2HVHb1GsfW1t X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: ZhangPeng Change copy_huge_page_from_user() to copy_folio_from_user(). Convert hugetlb_mcopy_atomic_pte() and __mcopy_atomic_hugetlb() to use a folio. Signed-off-by: ZhangPeng --- include/linux/hugetlb.h | 4 ++-- include/linux/mm.h | 3 +-- mm/hugetlb.c | 25 ++++++++++++------------- mm/memory.c | 27 ++++++++++++--------------- mm/userfaultfd.c | 20 +++++++++----------- 5 files changed, 36 insertions(+), 43 deletions(-) diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index 7c977d234aba..030252ce51bd 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -163,7 +163,7 @@ int hugetlb_mcopy_atomic_pte(struct mm_struct *dst_mm, pte_t *dst_pte, unsigned long dst_addr, unsigned long src_addr, enum mcopy_atomic_mode mode, - struct page **pagep, + struct folio **foliop, bool wp_copy); #endif /* CONFIG_USERFAULTFD */ bool hugetlb_reserve_pages(struct inode *inode, long from, long to, @@ -399,7 +399,7 @@ static inline int hugetlb_mcopy_atomic_pte(struct mm_struct *dst_mm, unsigned long dst_addr, unsigned long src_addr, enum mcopy_atomic_mode mode, - struct page **pagep, + struct folio **foliop, bool wp_copy) { BUG(); diff --git a/include/linux/mm.h b/include/linux/mm.h index 1f79667824eb..428cff424d26 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -3546,9 +3546,8 @@ extern void copy_user_huge_page(struct page *dst, struct page *src, unsigned long addr_hint, struct vm_area_struct *vma, unsigned int pages_per_huge_page); -extern long copy_huge_page_from_user(struct page *dst_page, +long copy_folio_from_user(struct folio *dst_folio, const void __user *usr_src, - unsigned int pages_per_huge_page, bool allow_pagefault); /** diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 07abcb6eb203..ea1f3b448b7a 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -6163,7 +6163,7 @@ int hugetlb_mcopy_atomic_pte(struct mm_struct *dst_mm, unsigned long dst_addr, unsigned long src_addr, enum mcopy_atomic_mode mode, - struct page **pagep, + struct folio **foliop, bool wp_copy) { bool is_continue = (mode == MCOPY_ATOMIC_CONTINUE); @@ -6185,7 +6185,7 @@ int hugetlb_mcopy_atomic_pte(struct mm_struct *dst_mm, if (!folio) goto out; folio_in_pagecache = true; - } else if (!*pagep) { + } else if (!*foliop) { /* If a page already exists, then it's UFFDIO_COPY for * a non-missing case. Return -EEXIST. */ @@ -6201,9 +6201,8 @@ int hugetlb_mcopy_atomic_pte(struct mm_struct *dst_mm, goto out; } - ret = copy_huge_page_from_user(&folio->page, - (const void __user *) src_addr, - pages_per_huge_page(h), false); + ret = copy_folio_from_user(folio, + (const void __user *) src_addr, false); /* fallback to copy_from_user outside mmap_lock */ if (unlikely(ret)) { @@ -6222,7 +6221,7 @@ int hugetlb_mcopy_atomic_pte(struct mm_struct *dst_mm, ret = -ENOMEM; goto out; } - *pagep = &folio->page; + *foliop = folio; /* Set the outparam pagep and return to the caller to * copy the contents outside the lock. Don't free the * page. @@ -6232,23 +6231,23 @@ int hugetlb_mcopy_atomic_pte(struct mm_struct *dst_mm, } else { if (vm_shared && hugetlbfs_pagecache_present(h, dst_vma, dst_addr)) { - put_page(*pagep); + folio_put(*foliop); ret = -EEXIST; - *pagep = NULL; + *foliop = NULL; goto out; } folio = alloc_hugetlb_folio(dst_vma, dst_addr, 0); if (IS_ERR(folio)) { - put_page(*pagep); + folio_put(*foliop); ret = -ENOMEM; - *pagep = NULL; + *foliop = NULL; goto out; } - copy_user_huge_page(&folio->page, *pagep, dst_addr, dst_vma, + copy_user_huge_page(&folio->page, &((*foliop)->page), dst_addr, dst_vma, pages_per_huge_page(h)); - put_page(*pagep); - *pagep = NULL; + folio_put(*foliop); + *foliop = NULL; } /* diff --git a/mm/memory.c b/mm/memory.c index f456f3b5049c..78fe9ef0c058 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -5769,37 +5769,34 @@ void copy_user_huge_page(struct page *dst, struct page *src, process_huge_page(addr_hint, pages_per_huge_page, copy_subpage, &arg); } -long copy_huge_page_from_user(struct page *dst_page, +long copy_folio_from_user(struct folio *dst_folio, const void __user *usr_src, - unsigned int pages_per_huge_page, bool allow_pagefault) { void *page_kaddr; unsigned long i, rc = 0; - unsigned long ret_val = pages_per_huge_page * PAGE_SIZE; + unsigned int nr_pages = folio_nr_pages(dst_folio); + unsigned long ret_val = nr_pages * PAGE_SIZE; struct page *subpage; - for (i = 0; i < pages_per_huge_page; i++) { - subpage = nth_page(dst_page, i); - if (allow_pagefault) - page_kaddr = kmap(subpage); - else - page_kaddr = kmap_atomic(subpage); + for (i = 0; i < nr_pages; i++) { + subpage = folio_page(dst_folio, i); + page_kaddr = kmap_local_page(subpage); + if (!allow_pagefault) + pagefault_disable(); rc = copy_from_user(page_kaddr, usr_src + i * PAGE_SIZE, PAGE_SIZE); - if (allow_pagefault) - kunmap(subpage); - else - kunmap_atomic(page_kaddr); + if (!allow_pagefault) + pagefault_enable(); + kunmap_local(page_kaddr); ret_val -= (PAGE_SIZE - rc); if (rc) break; - flush_dcache_page(subpage); - cond_resched(); } + flush_dcache_folio(dst_folio); return ret_val; } #endif /* CONFIG_TRANSPARENT_HUGEPAGE || CONFIG_HUGETLBFS */ diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c index 263191c37fb5..a7da26cdb731 100644 --- a/mm/userfaultfd.c +++ b/mm/userfaultfd.c @@ -324,7 +324,7 @@ static __always_inline ssize_t __mcopy_atomic_hugetlb(struct mm_struct *dst_mm, pte_t *dst_pte; unsigned long src_addr, dst_addr; long copied; - struct page *page; + struct folio *folio; unsigned long vma_hpagesize; pgoff_t idx; u32 hash; @@ -344,7 +344,7 @@ static __always_inline ssize_t __mcopy_atomic_hugetlb(struct mm_struct *dst_mm, src_addr = src_start; dst_addr = dst_start; copied = 0; - page = NULL; + folio = NULL; vma_hpagesize = vma_kernel_pagesize(dst_vma); /* @@ -413,7 +413,7 @@ static __always_inline ssize_t __mcopy_atomic_hugetlb(struct mm_struct *dst_mm, } err = hugetlb_mcopy_atomic_pte(dst_mm, dst_pte, dst_vma, - dst_addr, src_addr, mode, &page, + dst_addr, src_addr, mode, &folio, wp_copy); hugetlb_vma_unlock_read(dst_vma); @@ -423,12 +423,10 @@ static __always_inline ssize_t __mcopy_atomic_hugetlb(struct mm_struct *dst_mm, if (unlikely(err == -ENOENT)) { mmap_read_unlock(dst_mm); - BUG_ON(!page); + BUG_ON(!folio); - err = copy_huge_page_from_user(page, - (const void __user *)src_addr, - vma_hpagesize / PAGE_SIZE, - true); + err = copy_folio_from_user(folio, + (const void __user *) src_addr, true); if (unlikely(err)) { err = -EFAULT; goto out; @@ -438,7 +436,7 @@ static __always_inline ssize_t __mcopy_atomic_hugetlb(struct mm_struct *dst_mm, dst_vma = NULL; goto retry; } else - BUG_ON(page); + BUG_ON(folio); if (!err) { dst_addr += vma_hpagesize; @@ -455,8 +453,8 @@ static __always_inline ssize_t __mcopy_atomic_hugetlb(struct mm_struct *dst_mm, out_unlock: mmap_read_unlock(dst_mm); out: - if (page) - put_page(page); + if (folio) + folio_put(folio); BUG_ON(copied < 0); BUG_ON(err > 0); BUG_ON(!copied && !err);