From patchwork Wed Mar 15 05:14:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Wilcox X-Patchwork-Id: 13175329 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C559C6FD1D for ; Wed, 15 Mar 2023 05:15:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3DDC8E001B; Wed, 15 Mar 2023 01:15:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E50E88E000C; Wed, 15 Mar 2023 01:15:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7D468E001B; Wed, 15 Mar 2023 01:15:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AE3098E001A for ; Wed, 15 Mar 2023 01:15:02 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 082C4120FF5 for ; Wed, 15 Mar 2023 05:15:02 +0000 (UTC) X-FDA: 80569968444.01.DF191FB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 62E9320016 for ; Wed, 15 Mar 2023 05:15:00 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rgnn4YC9; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678857300; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UeQ+O6oeC7OHwfv3c/ZJoE/vNT6tW4e5INVzBD1cDW8=; b=wBNLqhoqR1rP5k/mdCEnz4VuZoVBJVRN4U9TinvaL314DMcS/Q0A8sk1zlw09WR6IsoorV my/bM5NTKXiO6HJ5M925cOYxnUIWXQjL0t4mL6giobiuEJBPcBSvwmhBxmnETHOy3bFJq+ uf6eoFzbaQ44jLnmkm+ciYH4QeGU9EU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rgnn4YC9; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678857300; a=rsa-sha256; cv=none; b=7uM4g3BprTWO6K9EanX615J3xkFvQHIuIQsZUUa0i66EpWCikn1mGRadflWo8rZu0G5h8I j0timn7n8NGyXMVOVRbuLNJ1O48TQivu8yta6hjZOX6B9OcjKkQ1788/fRNftEqfXJbQlR t5nLCOFCjVhglaJpondVHQxdH9n/sFY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=UeQ+O6oeC7OHwfv3c/ZJoE/vNT6tW4e5INVzBD1cDW8=; b=rgnn4YC90j/RsWvK5pnFiQnU5p hPvoVA2CoeE1JU6WVacxl//cQfpsQE75+0ZNZyGpC2a/tGmEMZvpmXRJHpMFjRybq5d3A0fKqkdhi 36fX35llTJuCW9wWFAdauEzPCDcEUgGJi6wPT82nzDP2+Znx3itTOW/u095Qy3Q6FmoJD4omXAGoZ eKeKVMcCwdR0tvUPmPMGP3ZriYeckK6lFaF7TBFqsWp373L+DkuiR2c4I51weGh70v9G9Fb1ip7Ck BuC2MvbqR1CMGQVwr9Zd1hku6E5lscKQiybvfAFVKWismiy3/4qvIpsmOKH9W/8b8D2kXXdqa9/DG ye7e2R4g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pcJTK-00DYAx-PN; Wed, 15 Mar 2023 05:14:46 +0000 From: "Matthew Wilcox (Oracle)" To: linux-arch@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 04/36] mm: Remove ARCH_IMPLEMENTS_FLUSH_DCACHE_FOLIO Date: Wed, 15 Mar 2023 05:14:12 +0000 Message-Id: <20230315051444.3229621-5-willy@infradead.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230315051444.3229621-1-willy@infradead.org> References: <20230315051444.3229621-1-willy@infradead.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: fpqrjh5431kno51kqyftajohzuurca9s X-Rspamd-Queue-Id: 62E9320016 X-HE-Tag: 1678857300-721521 X-HE-Meta: U2FsdGVkX1/PM4AproldZEsJ0DW9Iq0QUKW4Zkromm7cS+wKhZOuihvzG6yzkoVfdZpHKmKR7TzjJmqd8OzoGSfbIe5dD8WFN66GuEW6x/D39+KYDCMb13iADpLWxqmD+OtJXt9MmzosJmgS/FyBrULVmLHnhFNHk4kHkmHws7vRNbXpH2l8k9+Kvg2akw3iCqxerXMXMafjJt3tFh8b35YLSb//5HhzSaJqNc/scwqYOzmLq63KZ6oGxRZNNYvG7TlIuVRyMw0HHyoVuwOTGlS7HWgGvlkce4sEMtkTDVO4fNQx8wZPqkUjhxjIDrAajCAHx08NeLxcE6HOMzUhtAIZ1ubTpXkE6cbegbfOvuCrzM05/Q6Jtz72jg8Oy3a6BUgPrXPHJPo8YomOR/5avMxnDdPQqbuTS+Wu1nAe0j0bU4Fv/JWBozEwaX7CxR2fWt7m95zaY2CijUJrYMt8+3qfFA7N6lJIh+YZtEDzeUv6ogWFzJ5kC2jDy2V9HzUeiKLF9+bRhBz0ZvG8QOz2OR13X0BLV8VhYzUeNv/F6ajbAxFKv09LgNpLfVEJ7vWHvIUwhRoZZU8qdBtMolxGPqcfiewpGsMPISHoPCQztOo3B+meApc4jtmjuCZhI17dHmdUW/lYUIIHb8Mf8whw3ARzKDuHTVfbnjt58SMDjherxyig0O+QoSUcOwYSA+WLkWsBNQaSG4HUOdIKXPiflfMcDvUxWoNQYtbOI+qQg+smoEmsfXAu9o65WnYa09ZH1VTSp/bZ9grd5oOspAmjt13PpQHATgOwhI8+qTpq1vx6xcgpYAe6wmH6tMWBDGfbF9PxWLXleEa2DDlfihIsmHR3VbELJcRGEo7i/cPX29PGoDt8RjEtyc/+N/VLzu4im3dgq1e174AuTORwOi1LG4ajMpYFlRbEvoKx49UOia4ETq8X52yy+fCwWkMm8aTW1KCtvh46IbsRzkGonA3 X/IpeXPs 6ltlGCs92Qy4+HxEkK5c9QzbPUr2GSX8StVj42OesOHtmL/uO7iuQHoycEv52sVKf5wVtQ1/coVRB4zyDc3JXawB38wwAoEGg2tt2dfvfV4I3kPyKTWiuYXNDQmg3pRIwcYq5CJ8QkytbCidUUISY1Dmd8UbOj3PoNfZZV+lpfCc4E+Yfi4umt3WxxvNTEYKKmUnbkh39qdl0mLLfPLQpyeLgmHXYXSuxiiUshact6gzWNcOE1zm02l3XQw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Current best practice is to reuse the name of the function as a define to indicate that the function is implemented by the architecture. Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Mike Rapoport (IBM) Reviewed-by: Anshuman Khandual --- Documentation/core-api/cachetlb.rst | 24 +++++++++--------------- include/linux/cacheflush.h | 4 ++-- mm/util.c | 2 +- 3 files changed, 12 insertions(+), 18 deletions(-) diff --git a/Documentation/core-api/cachetlb.rst b/Documentation/core-api/cachetlb.rst index d4c9e2a28d36..770008afd409 100644 --- a/Documentation/core-api/cachetlb.rst +++ b/Documentation/core-api/cachetlb.rst @@ -269,7 +269,7 @@ maps this page at its virtual address. If D-cache aliasing is not an issue, these two routines may simply call memcpy/memset directly and do nothing more. - ``void flush_dcache_page(struct page *page)`` + ``void flush_dcache_folio(struct folio *folio)`` This routines must be called when: @@ -277,7 +277,7 @@ maps this page at its virtual address. and / or in high memory b) the kernel is about to read from a page cache page and user space shared/writable mappings of this page potentially exist. Note - that {get,pin}_user_pages{_fast} already call flush_dcache_page + that {get,pin}_user_pages{_fast} already call flush_dcache_folio on any page found in the user address space and thus driver code rarely needs to take this into account. @@ -291,7 +291,7 @@ maps this page at its virtual address. The phrase "kernel writes to a page cache page" means, specifically, that the kernel executes store instructions that dirty data in that - page at the page->virtual mapping of that page. It is important to + page at the kernel virtual mapping of that page. It is important to flush here to handle D-cache aliasing, to make sure these kernel stores are visible to user space mappings of that page. @@ -302,18 +302,18 @@ maps this page at its virtual address. If D-cache aliasing is not an issue, this routine may simply be defined as a nop on that architecture. - There is a bit set aside in page->flags (PG_arch_1) as "architecture + There is a bit set aside in folio->flags (PG_arch_1) as "architecture private". The kernel guarantees that, for pagecache pages, it will clear this bit when such a page first enters the pagecache. This allows these interfaces to be implemented much more efficiently. It allows one to "defer" (perhaps indefinitely) the actual flush if there are currently no user processes mapping this - page. See sparc64's flush_dcache_page and update_mmu_cache_range + page. See sparc64's flush_dcache_folio and update_mmu_cache_range implementations for an example of how to go about doing this. - The idea is, first at flush_dcache_page() time, if - page_file_mapping() returns a mapping, and mapping_mapped on that + The idea is, first at flush_dcache_folio() time, if + folio_flush_mapping() returns a mapping, and mapping_mapped() on that mapping returns %false, just mark the architecture private page flag bit. Later, in update_mmu_cache_range(), a check is made of this flag bit, and if set the flush is done and the flag bit @@ -327,12 +327,6 @@ maps this page at its virtual address. dirty. Again, see sparc64 for examples of how to deal with this. - ``void flush_dcache_folio(struct folio *folio)`` - This function is called under the same circumstances as - flush_dcache_page(). It allows the architecture to - optimise for flushing the entire folio of pages instead - of flushing one page at a time. - ``void copy_to_user_page(struct vm_area_struct *vma, struct page *page, unsigned long user_vaddr, void *dst, void *src, int len)`` ``void copy_from_user_page(struct vm_area_struct *vma, struct page *page, @@ -353,7 +347,7 @@ maps this page at its virtual address. When the kernel needs to access the contents of an anonymous page, it calls this function (currently only - get_user_pages()). Note: flush_dcache_page() deliberately + get_user_pages()). Note: flush_dcache_folio() deliberately doesn't work for an anonymous page. The default implementation is a nop (and should remain so for all coherent architectures). For incoherent architectures, it should flush @@ -370,7 +364,7 @@ maps this page at its virtual address. ``void flush_icache_page(struct vm_area_struct *vma, struct page *page)`` All the functionality of flush_icache_page can be implemented in - flush_dcache_page and update_mmu_cache_range. In the future, the hope + flush_dcache_folio and update_mmu_cache_range. In the future, the hope is to remove this interface completely. The final category of APIs is for I/O to deliberately aliased address diff --git a/include/linux/cacheflush.h b/include/linux/cacheflush.h index a6189d21f2ba..82136f3fcf54 100644 --- a/include/linux/cacheflush.h +++ b/include/linux/cacheflush.h @@ -7,14 +7,14 @@ struct folio; #if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE -#ifndef ARCH_IMPLEMENTS_FLUSH_DCACHE_FOLIO +#ifndef flush_dcache_folio void flush_dcache_folio(struct folio *folio); #endif #else static inline void flush_dcache_folio(struct folio *folio) { } -#define ARCH_IMPLEMENTS_FLUSH_DCACHE_FOLIO 0 +#define flush_dcache_folio flush_dcache_folio #endif /* ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE */ #endif /* _LINUX_CACHEFLUSH_H */ diff --git a/mm/util.c b/mm/util.c index dd12b9531ac4..98ce51b01627 100644 --- a/mm/util.c +++ b/mm/util.c @@ -1125,7 +1125,7 @@ void page_offline_end(void) } EXPORT_SYMBOL(page_offline_end); -#ifndef ARCH_IMPLEMENTS_FLUSH_DCACHE_FOLIO +#ifndef flush_dcache_folio void flush_dcache_folio(struct folio *folio) { long i, nr = folio_nr_pages(folio);