From patchwork Wed Mar 15 16:35:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 13176342 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E017C6FD1D for ; Wed, 15 Mar 2023 16:36:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3026F6B0080; Wed, 15 Mar 2023 12:36:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 294C56B0087; Wed, 15 Mar 2023 12:36:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 153926B0088; Wed, 15 Mar 2023 12:36:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 063896B0080 for ; Wed, 15 Mar 2023 12:36:38 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C43064034B for ; Wed, 15 Mar 2023 16:36:37 +0000 (UTC) X-FDA: 80571686034.18.8409942 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 224A840026 for ; Wed, 15 Mar 2023 16:36:35 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NatCcCbg; spf=pass (imf12.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678898196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w0CyxxuCfKyDxUhqZI8uZNDs4yTA+LT97JFfaSxmf5E=; b=Ie6o8fecRkR3XtgNoRbzB5Bb3+Wq1odRKBKPQoOXOujubJp9HoHFo6D0OT2f5g8EXctGmS GBnfYvO6gt7HZQF3Bk8jdm1sYZjiqfFa6Dd4uTh7mk3htXv5x6Df5IcRKWfRpq3njSlGOL nh/FcGAPOVQBVL+hvbjUYiT9TIuLtK4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NatCcCbg; spf=pass (imf12.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678898196; a=rsa-sha256; cv=none; b=sCuB9W+eSSE4ttuh89lZOFBL7RDED6mJjrfNKGX5BCkEQYeFZAZg9H6vT6zljZptqmCKIO X6dsaoefFfDJVo1aZgaZB7oGQrdAlT1/xkvI11qT5rbJjAUJGYc35xFHnppoRBYedmcoDC OyRgd6ImMbay+negWEE7mkoWjq/n9V8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678898195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w0CyxxuCfKyDxUhqZI8uZNDs4yTA+LT97JFfaSxmf5E=; b=NatCcCbgMVsN0LbAv9xZSVLFjodBDYMn8mbCU0I6VHntm626EbigU8kn0F7a81NsgPG1Gt T/z5WMCGtFH38gpqjFrzgBDbQAO9h5jSOagu5iZKbOwKLvtCNQY2DMJCHj+mIRChjMY3tg scalSDx2Xdf6pe58CGor6cmA/1Ro60I= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-503-KRZAb1KrMEG4we92PR2NZA-1; Wed, 15 Mar 2023 12:36:27 -0400 X-MC-Unique: KRZAb1KrMEG4we92PR2NZA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 316A48828C6; Wed, 15 Mar 2023 16:36:24 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6A4C2C164E7; Wed, 15 Mar 2023 16:36:21 +0000 (UTC) From: David Howells To: Jens Axboe , Al Viro , Christoph Hellwig Cc: David Howells , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard , Dave Chinner , Christoph Hellwig Subject: [PATCH v19 10/15] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Date: Wed, 15 Mar 2023 16:35:44 +0000 Message-Id: <20230315163549.295454-11-dhowells@redhat.com> In-Reply-To: <20230315163549.295454-1-dhowells@redhat.com> References: <20230315163549.295454-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 224A840026 X-Rspam-User: X-Stat-Signature: g6pcq5q4caewjfg1h5q15wmw5kcpsirp X-HE-Tag: 1678898195-191919 X-HE-Meta: U2FsdGVkX18hlmUXLK6VaV61a5cMunh+lhYSd9pqvs91dAObMMclD7KVRgVkNH5e9eeW74fC33X0SGijb4V86b2kjhRFdjuT7DskaHug5y5DIhkTP1Yh5+g9wVdEOU3r2TBJL5rlU1Z1ekg0Dfcbm9HOiNZd4+OgP5Xw5AegOSsoDBmvirb7sDdaMXGPxg530XsjYe3PdLJeHM4fpGdeql2uzAM4TS7hhWsGs6f0fFE8Am/xhtAl9GfxwcGwqTROXPmfiXS6+hmfiUQCfuMyaHZ7yL/oqH7mBUSY4GmIoQBP5D1LlCKCN5iI9ptZ2shvyMJIwXWvqWu7G86CSEcn2IvGNHJ+vcGGV6qScMU2St2TPgY6ArxMmP3Xoi0RvuV/oOGCw/+yZWPTEbfc6YL9nqexHDZ0MDcXciYDDACKgpQpV2da6IMS8RBvOD/vJff1XYVlaz57Z6UXBQ3TeAzxZ4Mk64V47V8K0AHoPxM8OKCEP7FPOwSaaxL8jRT6ehl8WifsyoNHZlKjPdTbYfPWAxUR7ELFezIsjhOgI3uD965BzAxJTR9ICMa3xaC34RfTG1kgyTrMEbvOrqjrC4gEgJw1gkvWWOW/eoFmUOBeMa0p7iP3nEhib+KZcPbXhlV70ctOxsx/uBhO0Y3dcm/CJ01QaNAP5latIrszETalv0yhl+igwRTunYtYKURZujVVzcSOy8LpbuQQEWIcrUQauNRfQDPsXXGbDqqb3XWaj6uSmaeEFETW4O4OXLtPHUEZBkL59N2zkllI2jUc9w3YNBvLog8YwnqZbhb5dzOiV5hOOtbmsfNXGEOvWSjAuOwQR16j0jyJz0xMdfilW8yMRba1d9WdShex7WOvu2S0g6I0GvRL8f/IZ5TH1djLIVCNkdy0k+y/r8Rvyq84KKNeePgixh6U+asgAVw6GsGYHVO58Wo3Spc2bJ+KPdcp2epXq5wG+AK836VasfP4I3j s+TEybIv bJC88i2zOv6x+Yp+4EK3ig2U8p2dg3jT3YXrOIrre3lI7ouPmZk2N8pOcHUJtPJq6pBVY6qrONy+Ki+Wwmj0vOhtrdbqIRJ3HwSSq07dFH/0qa/CzIPZJvhErornED3QiIaMbO+3HoJRF9mAVphfUVcWE6kLcTcTl9xtoabaLlROgFDztLR+B1VKtXPNbQ2YJd3RHsAW+8Asmb1RUGJVoEajZ/1UNfy+HbIurEpK/3r+zVz5aNEwWOv0A17Oamnb0Fr20fJL9aHg+NxxZoQJsR4K+lsTo9sYr8L2ox3ugPhgV/sbR5LuKERTENDYyzwG+1TOGhH71s+pXp8/+Pvskd5zpwZDJ6pFMHwo7wxuLpkVl8jKs5DF0ckAQ0D63oGPpCpuK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ZERO_PAGE can't go away, no need to hold an extra reference. Signed-off-by: David Howells Reviewed-by: David Hildenbrand Reviewed-by: John Hubbard Reviewed-by: Dave Chinner Reviewed-by: Christoph Hellwig cc: Al Viro cc: linux-fsdevel@vger.kernel.org --- fs/iomap/direct-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index f771001574d0..850fb9870c2f 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -202,7 +202,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, bio->bi_private = dio; bio->bi_end_io = iomap_dio_bio_end_io; - get_page(page); + bio_set_flag(bio, BIO_NO_PAGE_REF); __bio_add_page(bio, page, len, 0); iomap_dio_submit_bio(iter, dio, bio, pos); }