| Message ID | 20230323171904.14444-1-krckatom@amazon.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm: Be less noisy during memory hotplug | expand |
On 23.03.23 18:19, Tomas Krcka wrote: > Turn a pr_info() into a pr_debug() to prevent dmesg spamming on systems > where memory hotplug is a frequent operation. > > Fixes: 966cf44f637e ("mm: defer ZONE_DEVICE page initialization to the point where we init pgmap") > Fixes? I suggest top drop that tag here. > Suggested-by: Jan H. Schönherr <jschoenh@amazon.de> > Signed-off-by: Tomas Krcka <krckatom@amazon.de> > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index ac1fc986af44..14d70f4e6c0a 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6959,7 +6959,7 @@ void __ref memmap_init_zone_device(struct zone *zone, > compound_nr_pages(altmap, pfns_per_compound)); > } > > - pr_info("%s initialised %lu pages in %ums\n", __func__, > + pr_debug("%s initialised %lu pages in %ums\n", __func__, > nr_pages, jiffies_to_msecs(jiffies - start)); > } > Acked-by: David Hildenbrand <david@redhat.com>
On Thu, Mar 23, 2023 at 1:19 PM Tomas Krcka <krckatom@amazon.de> wrote: > > Turn a pr_info() into a pr_debug() to prevent dmesg spamming on systems > where memory hotplug is a frequent operation. > > Fixes: 966cf44f637e ("mm: defer ZONE_DEVICE page initialization to the point where we init pgmap") > > Suggested-by: Jan H. Schönherr <jschoenh@amazon.de> > Signed-off-by: Tomas Krcka <krckatom@amazon.de> Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
On Thu, Mar 23, 2023 at 2:37 PM Pasha Tatashin <pasha.tatashin@soleen.com> wrote: > > On Thu, Mar 23, 2023 at 1:19 PM Tomas Krcka <krckatom@amazon.de> wrote: > > > > Turn a pr_info() into a pr_debug() to prevent dmesg spamming on systems > > where memory hotplug is a frequent operation. > > > > Fixes: 966cf44f637e ("mm: defer ZONE_DEVICE page initialization to the point where we init pgmap") > > > > Suggested-by: Jan H. Schönherr <jschoenh@amazon.de> > > Signed-off-by: Tomas Krcka <krckatom@amazon.de> > > Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com> Can you please specify what you mean by frequent hotplug: wow frequent is it and what is the usecase? Thanks, Pasha
> On 23. Mar 2023, at 20:06, Pasha Tatashin <pasha.tatashin@soleen.com> wrote: > > > On Thu, Mar 23, 2023 at 2:37 PM Pasha Tatashin > <pasha.tatashin@soleen.com> wrote: >> >> On Thu, Mar 23, 2023 at 1:19 PM Tomas Krcka <krckatom@amazon.de> wrote: >>> >>> Turn a pr_info() into a pr_debug() to prevent dmesg spamming on systems >>> where memory hotplug is a frequent operation. >>> >>> Fixes: 966cf44f637e ("mm: defer ZONE_DEVICE page initialization to the point where we init pgmap") >>> >>> Suggested-by: Jan H. Schönherr <jschoenh@amazon.de> >>> Signed-off-by: Tomas Krcka <krckatom@amazon.de> >> >> Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com> > > Can you please specify what you mean by frequent hotplug: wow frequent > is it and what is the usecase? The use case is virtualization environment, case like new virtual machines are spun up and shut down frequently and where the workload of the virtual machines varies widely over time. So specially in case of small virtual machines. We can talk about multiple times per hour, depends on the workload. > > Thanks, > Pasha Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index ac1fc986af44..14d70f4e6c0a 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6959,7 +6959,7 @@ void __ref memmap_init_zone_device(struct zone *zone, compound_nr_pages(altmap, pfns_per_compound)); } - pr_info("%s initialised %lu pages in %ums\n", __func__, + pr_debug("%s initialised %lu pages in %ums\n", __func__, nr_pages, jiffies_to_msecs(jiffies - start)); }
Turn a pr_info() into a pr_debug() to prevent dmesg spamming on systems where memory hotplug is a frequent operation. Fixes: 966cf44f637e ("mm: defer ZONE_DEVICE page initialization to the point where we init pgmap") Suggested-by: Jan H. Schönherr <jschoenh@amazon.de> Signed-off-by: Tomas Krcka <krckatom@amazon.de> --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)