From patchwork Sat Apr 8 14:16:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 13205747 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5243C77B6C for ; Sat, 8 Apr 2023 14:16:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C49326B0072; Sat, 8 Apr 2023 10:16:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF9E36B0074; Sat, 8 Apr 2023 10:16:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC0DD6B0075; Sat, 8 Apr 2023 10:16:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9C6116B0072 for ; Sat, 8 Apr 2023 10:16:17 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7141140A37 for ; Sat, 8 Apr 2023 14:16:17 +0000 (UTC) X-FDA: 80658423594.28.3358D18 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 7D16880027 for ; Sat, 8 Apr 2023 14:16:14 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dqrai5Cu; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of trix@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=trix@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680963375; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=16PACF2Cqi8DglmssJPQj5cwBgWbt6Gz12Izi9hnlTs=; b=Pw1UlTx8qmfkliHpbWRgb9NEhn409Iu32z8cWNBV7WjAZul8t3zXe4oqKxkYmcqcmDbEaC 2aUtWbODLPpyWqfj4WhXma65dlkhpfXgRha0W7tvXdOpVg4gxc0CUouiDwgEHukTMCIPpM 99sBf6pAzGI4y0NIbo6nDSzaF/c35PA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dqrai5Cu; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of trix@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=trix@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680963375; a=rsa-sha256; cv=none; b=idtB5jIBZ8KaAVJhGWwjlrq09FfE1dj+8Q5KUhmMo9YmwIJYMVk0WW/Yn4yDimpOKdxO0v SxxTPRF2m3nNWQ4ktTBF7LJ7NTUnS6S3D4xiNJF1Xl5zp1C9Zuzdk/nLHgAJEnp3oAKWuM GghwXdQ4oHtkOfPyfI0FvLelMBO1N5c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680963373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=16PACF2Cqi8DglmssJPQj5cwBgWbt6Gz12Izi9hnlTs=; b=dqrai5Cu+4ODxszxNxBt+7cH+l4Yy0fmF8DclWSr2anKzb2OUQUZLpc5vxSvb0zWbVU3Zi Qvmn6NC/FTM4UfjzSTYu0m6Ru1tpjA6NMsr4f05HtPZEKfD8QFZGaplYXCKqCUKsQzfO4n 7n7LlOfOPT2zegHHA7bpcarVcDW6f80= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-213-tAi3FJmCPuqlc0lrrJOuaA-1; Sat, 08 Apr 2023 10:16:12 -0400 X-MC-Unique: tAi3FJmCPuqlc0lrrJOuaA-1 Received: by mail-qk1-f198.google.com with SMTP id s18-20020a374512000000b00746864b272cso535492qka.15 for ; Sat, 08 Apr 2023 07:16:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680963372; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=16PACF2Cqi8DglmssJPQj5cwBgWbt6Gz12Izi9hnlTs=; b=EA2moM+EnyIrRUauLgIcj2oC1yMv6uALD0AORi21H/Gxp3s5RchH0oQqf8vsl1pvMb wm7fRcgnKFrpJc1upHaZaoics28ZK+iUTCFHDR0HArezqkJm36t3LOElQlaoHa1RbLPN 9manwqL0/GPPWhgVkBmV9JjINRd5IaEgsN0Afet2JK9qhEQuYz5xa/EcXG4ihGe8FFZA XnL+DTIcW/QzBft55xPTNjMhJgqm+z3wGUnGGAkUjhlcL+I5g5ajuvvpLJUl5ccC8QJS RPIW5w0IzR6Slg/zvF001i35vriJUY7ovMnAgXWw7oYOwk0fhQWonw1voxIvOt/sbZJS IkqA== X-Gm-Message-State: AAQBX9eN9c3SwoXg72VDHGJKPrsdWE55YKeVnj7v7RmTgSFViQLGxxJj FEdVVONcOizwYuSi7Dcmz7Uis97ReTOZvgGiFZi7XfrOy4q0oKrrUgSIpsO+gZsWk3GXgx/92VD ViQELoALKO3o= X-Received: by 2002:a05:6214:2347:b0:5a9:609d:e23c with SMTP id hu7-20020a056214234700b005a9609de23cmr3808812qvb.34.1680963371946; Sat, 08 Apr 2023 07:16:11 -0700 (PDT) X-Google-Smtp-Source: AKy350a+MFuek8zXfsgwggZbwN/3OOFkmjQaWKdr8ANSLVnRP0Wk1S6eMy9QYpJUKQJaNeGz5hHHSQ== X-Received: by 2002:a05:6214:2347:b0:5a9:609d:e23c with SMTP id hu7-20020a056214234700b005a9609de23cmr3808792qvb.34.1680963371715; Sat, 08 Apr 2023 07:16:11 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id w16-20020a05620a0e9000b0074230493ccfsm2032569qkm.73.2023.04.08.07.16.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Apr 2023 07:16:11 -0700 (PDT) From: Tom Rix To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] mm: backing-dev: set variables dev_attr_min,max_bytes storage-class-specifier to static Date: Sat, 8 Apr 2023 10:16:09 -0400 Message-Id: <20230408141609.2703647-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7D16880027 X-Stat-Signature: efhpkoehr9i1k8asa8rwyepzueiq4kgz X-HE-Tag: 1680963374-617371 X-HE-Meta: U2FsdGVkX1+iSMo5uGm9pNizogna9HrvqOmSxztUplHKkqQTWTqdr7Umkufj8MH4JMpV9vow7WhYh1GFka1W6y3Mv9i+B0l8GYJUGPoPYe9ChwyHrsCgJsvhEpqX59pckRzx6HkWRQwTS74gW5hRC3cVmN6rwPnHoo21/BpF1FPzRgyuI4LOj9k410kBjDCH5CIojT0/pu5P8i2xZICr8/oCU7yk6I6ucpS+Wna7jJJm7A8AKfjEv7kYWhx18b8AheDGWjEAnP1vqJuHm5UbhxRrzvF2lGd1wASsBXAsz4aCTnjlKciOKd9rr/bBvsUTq4LmyZ4AQdihHR1INchUxQfcSw9ur09kqZyAf3pVo9lX/HssSnLwYyABJC700xC89Z39dWPzERyD903mQH9ASNECQS6yzZifTl1mlo3BwjRExS8F9SuXiL1gcWBF3+7WrWCbAXtsfxlZalrd5Xq5CqVq9aHCaljCWy+mDnmN+3hGmGRa+oBORNQANONRcAiWPLFbp+nkcRn+NCYpsXfHLWvgI4Jq97nSlOVdnG6leuyv93poUjOo9pauGMIahfU9h9HLlqq8rXNCEe53nEPhXppvznSDeYBq2DQ1QuKJto9N1xU+RkrUD25Bt7HcSgCCh5U3O8GfJ/YNImEmmEX/rDI98bOcOoybzSdtwY1tJI//X6GdnUK8SZNS2ckf18kmrOCMUxRYsCiViJEIz3OAmbVv3ftN7P+lcgzm4LUhOTAi5GccPA+i2t7KzheNHADeh4K7B4UX5GS9Ct3SmvIrZ6GZYNe61PPO6QTn3Arz2nSlFIIdWoiWeLd+lluha6yOFKUfVBiV5wf64h4EPV1TVW+dVdclFI4lE1EJ0hua4ddh2S7kAkcrC8pTR2nH/eJhCwGtlMePO4GG6grVW+lz0DAgQfhNSrEMZ8pjlRELUGq9JWakI6fv83QsG8mS4jp6rmWlUjyFxNhr01Iu2Oe dgTBdVWq Yfzeidj7HVi/DxIUpC/WVvRJB18a2Md2EqCpr0xo3EOkGEI8xtBFShBDgJeulwOr9AnMB4EWCX9QrfEe7VNfjeYwYkQ3zGTcvnCAQD6aXSlE1dhhoxg4ZU78w3BWWLUQx2Y05SSPi+rDshwG3VTYyua+H4dy3ps0SOICLD0+TFQRRD+U0RNYz+FfFZ/PlV0la7NJowRXI+9jec5yLE7f9r3xhKdKxQ3f5DoSToWResI9mNEQU+k26J20ELzb3E8rqHpcKbIKRQwkVOrDIex+/YfnINxDio/Sux2K6gPL8t9mM2ciLgzgZpLjJzeKDB+8t4XtimrLzx9DhQeRCYDWjPJIzod3domnBVXZxYONZb8bGFNZdy1VyjcvDj8PrX3bK7kJVaGws3HAP7jLHXw/kVnuzLHgReD8X/3dJbwqg0MYtEhfKTcn/brkJhFO+oAiYEuJx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: smatch reports mm/backing-dev.c:266:1: warning: symbol 'dev_attr_min_bytes' was not declared. Should it be static? mm/backing-dev.c:294:1: warning: symbol 'dev_attr_max_bytes' was not declared. Should it be static? These variables are only used in one file so should be static. Signed-off-by: Tom Rix Reviewed-by: Christoph Hellwig --- mm/backing-dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/backing-dev.c b/mm/backing-dev.c index ad011308cebe..7ed2559b8809 100644 --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -263,7 +263,7 @@ static ssize_t min_bytes_store(struct device *dev, return ret; } -DEVICE_ATTR_RW(min_bytes); +static DEVICE_ATTR_RW(min_bytes); static ssize_t max_bytes_show(struct device *dev, struct device_attribute *attr, @@ -291,7 +291,7 @@ static ssize_t max_bytes_store(struct device *dev, return ret; } -DEVICE_ATTR_RW(max_bytes); +static DEVICE_ATTR_RW(max_bytes); static ssize_t stable_pages_required_show(struct device *dev, struct device_attribute *attr,