| Message ID | 20230411034929.2071501-1-steve_chou@pesi.com.tw (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | tools/mm/page_owner_sort.c: fix TGID output when cull=tg is used | expand |
On Tue, 11 Apr 2023 11:49:28 +0800 Steve Chou <steve_chou@pesi.com.tw> wrote: > When using cull option with 'tg' flag, the fprintf is using pid instead > of tgid. It should use tgid instead. > > ... > > --- a/tools/mm/page_owner_sort.c > +++ b/tools/mm/page_owner_sort.c > @@ -857,7 +857,7 @@ int main(int argc, char **argv) > if (cull & CULL_PID || filter & FILTER_PID) > fprintf(fout, ", PID %d", list[i].pid); > if (cull & CULL_TGID || filter & FILTER_TGID) > - fprintf(fout, ", TGID %d", list[i].pid); > + fprintf(fout, ", TGID %d", list[i].tgid); > if (cull & CULL_COMM || filter & FILTER_COMM) > fprintf(fout, ", task_comm_name: %s", list[i].comm); > if (cull & CULL_ALLOCATOR) { Thanks, copy-paste error, I expect. I'll add Fixes: 9c8a0a8e599 ("tools/vm/page_owner_sort.c: support for user-defined culling rules") and cc:stable.
diff --git a/tools/mm/page_owner_sort.c b/tools/mm/page_owner_sort.c index 7c2ac124cdc8..99798894b879 100644 --- a/tools/mm/page_owner_sort.c +++ b/tools/mm/page_owner_sort.c @@ -857,7 +857,7 @@ int main(int argc, char **argv) if (cull & CULL_PID || filter & FILTER_PID) fprintf(fout, ", PID %d", list[i].pid); if (cull & CULL_TGID || filter & FILTER_TGID) - fprintf(fout, ", TGID %d", list[i].pid); + fprintf(fout, ", TGID %d", list[i].tgid); if (cull & CULL_COMM || filter & FILTER_COMM) fprintf(fout, ", task_comm_name: %s", list[i].comm); if (cull & CULL_ALLOCATOR) {
When using cull option with 'tg' flag, the fprintf is using pid instead of tgid. It should use tgid instead. Signed-off-by: Steve Chou <steve_chou@pesi.com.tw> --- tools/mm/page_owner_sort.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)