From patchwork Fri Apr 14 14:23:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chih-En Lin X-Patchwork-Id: 13211616 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C35E6C77B76 for ; Fri, 14 Apr 2023 14:25:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B4136B0071; Fri, 14 Apr 2023 10:25:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58AFE280003; Fri, 14 Apr 2023 10:25:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42BB2280002; Fri, 14 Apr 2023 10:25:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 367A56B0071 for ; Fri, 14 Apr 2023 10:25:38 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0BD0CC0278 for ; Fri, 14 Apr 2023 14:25:38 +0000 (UTC) X-FDA: 80680219956.27.FE240F9 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf28.hostedemail.com (Postfix) with ESMTP id 32B84C0017 for ; Fri, 14 Apr 2023 14:25:35 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=DO2Q+d81; spf=pass (imf28.hostedemail.com: domain of shiyn.lin@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=shiyn.lin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681482336; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oPtVqejd8xN45YdR2Q6v6XG0kYjXUF7jvXEtA29Ek40=; b=BSQ3t86gGEj3vIGNs2sdSNrVm+UsL46ZHtMkCy7ndDkEkYY3vgDjhl5wA2ZkzANTnklkIS 7K8uBaDhKqSchBKN3v5MWu8VsWV0Ek+Kfw058pjLldbGK47oWH8wwV0yLSXOCX29EMmC4A t73t8nd6VMllJU2YcDUrTnM+a8kpAZ4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=DO2Q+d81; spf=pass (imf28.hostedemail.com: domain of shiyn.lin@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=shiyn.lin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681482336; a=rsa-sha256; cv=none; b=DJcoR4g522eHUnuJUNHIT5RBTaIQblTEwU1JBq2nROcY2k6SPO+pmUU5H61AvPuzA63dKE 9r8OZPFcleUIh9TdxO09bK6uMG4H+ftn68Oy6Ihub6tEWW5UYD5z+tcl4UQb+uwEFrsKf2 E8gUCW0VT9DWWkdKY2jnemCKnpijpYU= Received: by mail-pl1-f173.google.com with SMTP id o2so18427873plg.4 for ; Fri, 14 Apr 2023 07:25:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681482335; x=1684074335; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oPtVqejd8xN45YdR2Q6v6XG0kYjXUF7jvXEtA29Ek40=; b=DO2Q+d81fMe4kXw95FsyYMfTz/qUSAi6t2W34rh9XXJe8g3xYfBr+ymjaQ+uYh9eTI gHotO5OUPv5kWIbSchNOMjer5oobGqrHJG+prcCHTVFXEpI6y9M0+rge1hgjyuYxoB0u wX1SvUVvU2sIJxeGvrr7rS1EZIQVvYq2oa4eABUzfPnn7z8r+qL+fynWlo9OAhrZaHzR 3jOzOMCHKM1OzWW9i5YbxNsYH1Uk4ufsEhHfEwnQp8mwyPkSVTACUM3lCwWK6IlQbd5Q G7EY5aNAMKUNsQAQl+8b7ZKPp2am6ArpZNUTK0p0bV3mimWd5Tg5a3ckqpM3MRvKpkwh wEcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681482335; x=1684074335; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oPtVqejd8xN45YdR2Q6v6XG0kYjXUF7jvXEtA29Ek40=; b=QhHs9Zwe4KOYqKap+1MTckvPqZNk2hIwa1HR51TfhjPu+WQufMEjAx9iKuRo4jUPts 29wKtKPFSnJUb2K3KY/iQNKygqE/sFSfNEUcHud99MHm2fMzKjIqgoVTwiygRgsx9EXs Tp8bedhOM/UrN9PvO/QOKKE3JJENQyWbbjDqYGoDsjb+Wi/Ng+yvEmGvRSBXs2yDYPE6 s8dHZWJ+aMhlE6EYywco0XPRe+QodBJf5UuTwiQyFt9qyuRvRur2e/uhlt3CQWXdeg9V 9VeMc0TZ2/1uJC2we08JuLs/7eMkI0bjjI/YmJPf+OTBA0BOvF5jW1sOzfe+4d7/rmZ/ CI6Q== X-Gm-Message-State: AAQBX9dbPNK7L0GJ1FpBe/xhM1wNEEHJnWEKP5M+lR9ejmnUgjG1z83i 4ikTOwr/Fje5pyk/If6jB0g= X-Google-Smtp-Source: AKy350adAdAtgay4aFNJF81hhKV3XEsvf6Y3Gn4taIN+xVDvh1O3itAQNBSXC0EdDJB6K6v4iC1zqg== X-Received: by 2002:a17:902:d4cc:b0:19f:2dff:2199 with SMTP id o12-20020a170902d4cc00b0019f2dff2199mr3045076plg.68.1681482335057; Fri, 14 Apr 2023 07:25:35 -0700 (PDT) Received: from strix-laptop.. (2001-b011-20e0-1499-8303-7502-d3d7-e13b.dynamic-ip6.hinet.net. [2001:b011:20e0:1499:8303:7502:d3d7:e13b]) by smtp.googlemail.com with ESMTPSA id h7-20020a17090ac38700b0022335f1dae2sm2952386pjt.22.2023.04.14.07.25.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Apr 2023 07:25:34 -0700 (PDT) From: Chih-En Lin To: Andrew Morton , Qi Zheng , David Hildenbrand , "Matthew Wilcox (Oracle)" , Christophe Leroy , John Hubbard , Nadav Amit , Barry Song , Pasha Tatashin Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Steven Rostedt , Masami Hiramatsu , Peter Zijlstra , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Yu Zhao , Steven Barrett , Juergen Gross , Peter Xu , Kefeng Wang , Tong Tiangen , Christoph Hellwig , "Liam R. Howlett" , Yang Shi , Vlastimil Babka , Alex Sierra , Vincent Whitchurch , Anshuman Khandual , Li kunyu , Liu Shixin , Hugh Dickins , Minchan Kim , Joey Gouly , Chih-En Lin , Michal Hocko , Suren Baghdasaryan , "Zach O'Keefe" , Gautam Menghani , Catalin Marinas , Mark Brown , "Eric W. Biederman" , Andrei Vagin , Shakeel Butt , Daniel Bristot de Oliveira , "Jason A. Donenfeld" , Greg Kroah-Hartman , Alexey Gladkov , x86@kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Dinglan Peng , Pedro Fonseca , Jim Huang , Huichun Feng Subject: [PATCH v5 08/17] mm/ksm: Break COW PTE before modify shared PTE Date: Fri, 14 Apr 2023 22:23:32 +0800 Message-Id: <20230414142341.354556-9-shiyn.lin@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230414142341.354556-1-shiyn.lin@gmail.com> References: <20230414142341.354556-1-shiyn.lin@gmail.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: yrc4xg4p7cnekpx5chqq7c7emfhgbnbe X-Rspamd-Queue-Id: 32B84C0017 X-HE-Tag: 1681482335-720767 X-HE-Meta: U2FsdGVkX18/eH88j6N6tvtsAsbPUOeZ8SgE4L/WtdQDoThGvB9F3YNPkSYKN66czSXPfdFILu+NSKK9VkRdsKjBREonmD6pVcwR2MUMTkv/nUYgs3P62IV4fG6v2P9cBQRlzLS7bwOvMONvzY4jionjtmz7tX0qqbGNoLe45o5PYdLph3/4fg8xU4UwA3Bzaytnmdg77ezSLS3edPZ0oqIFQ50zh8OCODGMW277/5oZtG19v6CF6nYUmPYNFGaEGvy9kHFmny0fZyrxv1uFCK4iGvLGSbnNg0fyQN8I7e0mAnvRgbo2PWk2ryMt4g4NLxuIWjI0W/GDXle5ZYPeWzIrzvyJ1xAo8n/Sd6hPv24aRzctPlPRdfvQ/OrLhHWju3SNt48Bm7pBMB4S4P534WhCqVXy7GEYc1XtuhD0W7fzgjIDS18WTul7aMi7MEyk8TPFlHuD7EcOGm703c/2HkMp/Lyr1+6c3u1ZgoEh8hIGaiG2BNR+Nryb4+tVl0fB5plGKt3oDFfMCkecDKbdNsYq3rl9QlahXXvT6qhKvqM6ZEZ0gPulTLoeiZVwu8R7xaSfBvQqE7TYyKXucziRDqv73pHtcRppk+LQfcdBWUnv4BlI3iK0AfDV/N0Rmc6AsLFbP+Jjj6/HkVvapn/NMiZfBHtiIhjtO4czNAoFvs8R+Lo6DPtg1UoumXmP54vLgy4FGJZ7AK8Eg7zBnYM177xAyXEJo4mSP38uuhex+AFlc5S8MuiPkewEeuFs3KSgIt6w0CTwwNfihXpa7DK5MemjJ84jzJOkiA6O2ANa9JEUqKmrBYvyzxl6sNmGSFcWXTHiM+z3pmZjDVQxnhhPJQ+aKy18/8M+/tB2mfspS8c5Qs+J3DRTI+2bklxfcUyWooDOiuLq7u6CtN02mF5i2mojZzQz2l58K/q9qePYguKlvnjulrXBUvmadE7g8j2FzleBKdCF7LewlvQWnnS /yBo7vYW wt9GAVopRekG3H/9ID1dOD612ZyfyO6Ju5uvPF6TZO7gkmvsz277/cYdUgxXVDCwzErmH19UAqRrZeiuNsi7QFIAcUg1yp6EP1a12dLsiibiPaAVo82mFsC+6JYf76+RtqlIiOLPDhJ41iECSN5coYfklg7UnpLuIRyvsdJN2w/cf9m5U0wqGz0+7dsDz3OBwhryg5YzE2o2h6l9N5WYePH6E9O8/ofqCrMl5Nm0LcVR5QJfxDN8YeeDTKm0vFFTibWx5wAwQpwE7YLKPwpc/TPilv+CcMiyUDIcmlVaJNzvZyiHbleSVcNvSDC5IKdmsbiwlXQTcNoCArVCr9lDDHMfGF9MrVJQiK5Ndm80Z0AOJVlwvAKLCqXm8Rym3UfR367MiJmBvRlVWZtemIHGQsyGtvcJCythY8MbpqvIpzKoy0//dNi4G1W6UhAlJxFVHsJJa7q3R/Gr1AC9Z2C9BchzrECxXqKOFYOKw07+K7u7mdYg6ba1Xw1FfnZWXwdxiO8q57jDirGAMlxq2i+hrneEzvBjp3nm9PSSeb8idw0Niv5c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Break COW PTE before merge the page that reside in COW-ed PTE. Signed-off-by: Chih-En Lin --- mm/ksm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/ksm.c b/mm/ksm.c index 2b8d30068cbb..963ef4d0085d 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -1052,7 +1052,7 @@ static int write_protect_page(struct vm_area_struct *vma, struct page *page, pte_t *orig_pte) { struct mm_struct *mm = vma->vm_mm; - DEFINE_PAGE_VMA_WALK(pvmw, page, vma, 0, 0); + DEFINE_PAGE_VMA_WALK(pvmw, page, vma, 0, PVMW_BREAK_COW_PTE); int swapped; int err = -EFAULT; struct mmu_notifier_range range; @@ -1169,6 +1169,8 @@ static int replace_page(struct vm_area_struct *vma, struct page *page, barrier(); if (!pmd_present(pmde) || pmd_trans_huge(pmde)) goto out; + if (break_cow_pte(vma, pmd, addr)) + goto out; mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, mm, addr, addr + PAGE_SIZE);