From patchwork Thu May 18 02:18:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 13246058 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB328C77B75 for ; Thu, 18 May 2023 02:18:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95F1A280002; Wed, 17 May 2023 22:18:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E872280001; Wed, 17 May 2023 22:18:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EC8D280002; Wed, 17 May 2023 22:18:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 52F9B280001 for ; Wed, 17 May 2023 22:18:50 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3410F160627 for ; Thu, 18 May 2023 02:18:50 +0000 (UTC) X-FDA: 80801767578.30.A296FD1 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf02.hostedemail.com (Postfix) with ESMTP id 5DE6F80003 for ; Thu, 18 May 2023 02:18:48 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=XjEWVFgj; spf=pass (imf02.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.160.169 as permitted sender) smtp.mailfrom=joel@joelfernandes.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684376328; a=rsa-sha256; cv=none; b=kDJnERDtLkGSMv9dDFFEmn0jz9S1H/60tLXx4f+M0DCkllgVIFxYNA9BNoeh/iai/3w4M5 U9ULHA4Zd0KxMKGmsypcHG3T6hjdFjyLFQM0m68Oh+4Ws6qCbLUZ2TcUyIaqREldPaIOmU KHtWeaBa5RXe6z7XGxNI0NDZk4aU1wk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=XjEWVFgj; spf=pass (imf02.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.160.169 as permitted sender) smtp.mailfrom=joel@joelfernandes.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684376328; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tGuemAvtIS/ALPtC/Ke2yJXoSr37KqjSOh21F52Z0b4=; b=b1zdH4TOqs1MvJ9MzSLIN9K+rv4GqIq2u+GO+GMbnib5YZ5EYQjYnOqMaQbrs7VHEdBLYB c3bA2PKCvSLCNdp1EAYWsJ8HTq+KtDRuy14nj8FTV6mwl6rHZpb41hf0kU+GYC+NSArtcv bzVKuK6CtC9kFiniPLsUWsSv4aYDjEQ= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-3f507edcaaaso15611051cf.2 for ; Wed, 17 May 2023 19:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1684376327; x=1686968327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tGuemAvtIS/ALPtC/Ke2yJXoSr37KqjSOh21F52Z0b4=; b=XjEWVFgjHhBSgx+JzMuzHzMuMMrg6ZCjBCCAdXf//YzfKBHsPOaTSvveyrxyVc63mB OszLdP5qzb0tPw+Ax1TNz+UB1DuNFET/RCjILS/7u5bCzvBBR1KOj19dWdhgLKcgBzef NYJtJv4KZejE9EsPY58w3IzlHS7ZNhsiLoXuY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684376327; x=1686968327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tGuemAvtIS/ALPtC/Ke2yJXoSr37KqjSOh21F52Z0b4=; b=Y+WVh/ULEvk8JXxPNWyyCTkYYsBPN41bqJO9G+StNB0k1T2SXzRtSnUK5qBGdfj8b3 CHTmcUz/jKbioFp104nhNfIxY0Mmz03O12fpt3wcPEt0NhBYiZSS+fSpCiAxJyLSLYNa /oMI5vMvuJiXeB7FOQI4ycBInLGMXhkatueJrRtCCGNe4TUIaIcGs4MRcY33T6dMVfCZ /AwwNdv4QC0LBxTPXhZlI1216I1a1y5K4yFoA8Zl42DH+bpUEzsaXiJiG5PDyer8UC0a HPejgCe4Ub9LjTVyuf+s8tTrPzuU4ox0ue4vfaMy3TRhdb4maE/F9UtSa8TJFKqrWyH+ BGOw== X-Gm-Message-State: AC+VfDxcLOAF38t3CJKX+M3kmtU3GDt9OEeiacJU7rjgwrCSr83pK2cN 34tmdHbyFJYLnF42U5bYnkmdvg== X-Google-Smtp-Source: ACHHUZ4YcOJzn6aoVPNard/VpdQHjhpKxZ/STCMnHfkC5tH5L1a/155XBb4RZDt8EkvRYuJwqaMCWA== X-Received: by 2002:a05:622a:1d0:b0:3ef:366b:5afa with SMTP id t16-20020a05622a01d000b003ef366b5afamr3403956qtw.54.1684376327485; Wed, 17 May 2023 19:18:47 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id j13-20020a05620a000d00b007577ccf566asm85082qki.93.2023.05.17.19.18.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 19:18:46 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Shuah Khan , Vlastimil Babka , Michal Hocko , Linus Torvalds , Lorenzo Stoakes , Kirill A Shutemov , "Liam R. Howlett" , "Paul E. McKenney" Subject: [PATCH RFC 4/4] selftests: mm: Add a test for remapping to area immediately after existing mapping Date: Thu, 18 May 2023 02:18:25 +0000 Message-ID: <20230518021825.712742-5-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog In-Reply-To: <20230518021825.712742-1-joel@joelfernandes.org> References: <20230518021825.712742-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5DE6F80003 X-Stat-Signature: 1f41p4p7deedsaxrwg7z1apqshd3zph4 X-HE-Tag: 1684376328-605093 X-HE-Meta: U2FsdGVkX1/XfyDIQvUhB2KTq6T/67NfWsWfreUylFnaoDNk0+e/yGeYNOAknst2slRNn8912CraLL+//VitXYeiI6Cs8vjvapawhrHD3X6ocy448LNMnORvh+GJtBAJYEJHAMDdQ+Jeao32qQuE2S51yaolucTjUDgAuqv4jMran3A6BNTO3IHk6CDW8PiCfum88y2t6LuzzZhJob7LjEApzg2FNmG2+Fr1XQB7ELyA5bh+bvaenyYHK+nc3Jw/26J1KrT2/DJk0geUeoXebnCGk5WDiveJNEro3FLW8vDrXhheXUedxPfLJNKUxbSam3On/7+t2ny6B6n3CGi0370p9q2FWvVfOcPTlURUZs4HXEKGvPCGzsAmo1WXiWgPbha4+2SDkmekVvu1Uk+0aWTI3Z7zs1nJhP+ltiBuP5KrsS2w5EaemsmCoKhEidOyCmv57qH/KIqT349rSWKKMibb5OyWnKSU6WviyEpVwFsiMbUIvmCeEvB3SXm3rwG4whwMqDrqOvCsQp8kdqEbhm8F0Y9Pot2USGOdH8uKuqc16GzZ68eBfU3nRzKoQhU0gr3p5DBFlovZJN6+hnNygtWRxycSzOs7y/95ZJW62hMy6w6vOgns953BZOFJ9XNJamyqssiFY8aeW7qDgczMMU6sn3beq5nbXKTPcgI7W/4jvH9yGt+Mwo8CHBh8WjpzU4MjwfYV+ZknZvfrPsHME3BzkrqiyBAGNklSchwfUNnBmRGkEIpbwG7/NadxGF1KS7GgkSerOG56Gwtg2g85BxeJPIwru887rQl4iXlxfNboJzjYPCkR4Ye9r5VpA1Q+H4CXoLVK3XAeG5VfEZErGFeC12orlXCv1AQkKVwJ33uyv7tDtIbaG2Z2F5p/f1BboNySh37KAg2EMsrq0u8UvlJqMy2fsEYbfrqjN2TV+anv9k/YYCbPVhR37czmjtppowCrdywpTujppX97lly vwZ5dfaD p+/VkqbKmk7zerr1sdnccOpw1GuhKE9uAdoZZgIObh2jX/OweNQWqEgU+mgHL9di0icALh6lxMD2LhL3eoxOm3jDcTlkLXPoz41oL+F6KLr38tl6WG4lS0R14G/IrqIEG6QleP95cDgLBaLTctoCw2+m0HdGm5PWowVzgZ+jYcSqLJy5P931/OWxjgGgizKSEqgszrxN2siw6L2azKHYwiWWs5alrAtQX9CvXHWrKpENWwVFbXjYCs78aljaQjwWUwHb3dEWt7Ls0dnnYptsxwzuHP+xbDSvfeVidJ0jXd+KPd5fm/A/WtXPN3cZsZ437iXgM20giJ8qtLDmWELt03/6bR77lJEw9YU1MnoWCYnPrB36cpAIOM2V0vZJLuK8tJV1qg9mEoRf9jtiT6yLoPW7BP/IGNBHdjyjjIO+MOWYcqC4ha0kODsVVusze/p7TGE059vbmGRqn9qGaeCqJXVW+MkXT9SdVKXFd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This patch adds support for verifying that we correctly handle the situation where something is already mapped before the destination of the remap. Any realignment of destination address and PMD-copy will destroy that existing mapping. In such cases, we need to avoid doing the optimization. To test this, we map an area called the preamble before the remap region. Then we verify after the mremap operation that this region did not get corrupted. Putting some prints in the kernel, I verified that we optimize correctly in different situations: Optimize when there is alignment and no previous mapping (this is tested by previous patch). check_addr_in_prev(old_vma->vm_start=2900000, old_addr=2900000, mask=-2097152): 0 check_addr_in_prev(new_vma->vm_start=2f00000, new_addr=2f00000, mask=-2097152): 0 === Starting move_page_tables === Doing PUD move for 2800000 -> 2e00000 of extent=200000 <-- Optimization Doing PUD move for 2a00000 -> 3000000 of extent=200000 Doing PUD move for 2c00000 -> 3200000 of extent=200000 Don't optimize when there is alignment but there is previous mapping (this is tested by this patch). Notice that check_addr_in_prev() returns 1 for the destination mapping as we detected there is something there. check_addr_in_prev(old_vma->vm_start=2900000, old_addr=2900000, mask=-2097152): 0 check_addr_in_prev(new_vma->vm_start=5700000, new_addr=5700000, mask=-2097152): 1 === Starting move_page_tables === Doing move_ptes for 2900000 -> 5700000 of extent=100000 <-- Unoptimized Doing PUD move for 2a00000 -> 5800000 of extent=200000 Doing PUD move for 2c00000 -> 5a00000 of extent=200000 Signed-off-by: Joel Fernandes (Google) --- tools/testing/selftests/mm/mremap_test.c | 57 +++++++++++++++++++++--- 1 file changed, 52 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/mm/mremap_test.c b/tools/testing/selftests/mm/mremap_test.c index 6304eb0947a3..d7366074e2a8 100644 --- a/tools/testing/selftests/mm/mremap_test.c +++ b/tools/testing/selftests/mm/mremap_test.c @@ -29,6 +29,7 @@ struct config { unsigned long long dest_alignment; unsigned long long region_size; int overlapping; + int dest_preamble_size; }; struct test { @@ -283,7 +284,7 @@ static void *get_source_mapping(struct config c) static long long remap_region(struct config c, unsigned int threshold_mb, char pattern_seed) { - void *addr, *src_addr, *dest_addr; + void *addr, *src_addr, *dest_addr, *dest_preamble_addr; unsigned long long i; struct timespec t_start = {0, 0}, t_end = {0, 0}; long long start_ns, end_ns, align_mask, ret, offset; @@ -300,7 +301,7 @@ static long long remap_region(struct config c, unsigned int threshold_mb, goto out; } - /* Set byte pattern */ + /* Set byte pattern for source block. */ srand(pattern_seed); for (i = 0; i < threshold; i++) memset((char *) src_addr + i, (char) rand(), 1); @@ -312,6 +313,9 @@ static long long remap_region(struct config c, unsigned int threshold_mb, addr = (void *) (((unsigned long long) src_addr + c.region_size + offset) & align_mask); + /* Remap after the destination block preamble. */ + addr += c.dest_preamble_size; + /* See comment in get_source_mapping() */ if (!((unsigned long long) addr & c.dest_alignment)) addr = (void *) ((unsigned long long) addr | c.dest_alignment); @@ -327,6 +331,24 @@ static long long remap_region(struct config c, unsigned int threshold_mb, addr += c.dest_alignment; } + if (c.dest_preamble_size) { + dest_preamble_addr = mmap((void *) addr - c.dest_preamble_size, c.dest_preamble_size, + PROT_READ | PROT_WRITE, + MAP_FIXED_NOREPLACE | MAP_ANONYMOUS | MAP_SHARED, + -1, 0); + if (dest_preamble_addr == MAP_FAILED) { + ksft_print_msg("Failed to map dest preamble region: %s\n", + strerror(errno)); + ret = -1; + goto clean_up_src; + } + + /* Set byte pattern for the dest preamble block. */ + srand(pattern_seed); + for (i = 0; i < c.dest_preamble_size; i++) + memset((char *) dest_preamble_addr + i, (char) rand(), 1); + } + clock_gettime(CLOCK_MONOTONIC, &t_start); dest_addr = mremap(src_addr, c.region_size, c.region_size, MREMAP_MAYMOVE|MREMAP_FIXED, (char *) addr); @@ -335,7 +357,7 @@ static long long remap_region(struct config c, unsigned int threshold_mb, if (dest_addr == MAP_FAILED) { ksft_print_msg("mremap failed: %s\n", strerror(errno)); ret = -1; - goto clean_up_src; + goto clean_up_dest_preamble; } /* Verify byte pattern after remapping */ @@ -353,6 +375,23 @@ static long long remap_region(struct config c, unsigned int threshold_mb, } } + /* Verify the dest preamble byte pattern after remapping */ + if (c.dest_preamble_size) { + srand(pattern_seed); + for (i = 0; i < c.dest_preamble_size; i++) { + char c = (char) rand(); + + if (((char *) dest_preamble_addr)[i] != c) { + ksft_print_msg("Preamble data after remap doesn't match at offset %d\n", + i); + ksft_print_msg("Expected: %#x\t Got: %#x\n", c & 0xff, + ((char *) dest_preamble_addr)[i] & 0xff); + ret = -1; + goto clean_up_dest; + } + } + } + start_ns = t_start.tv_sec * NS_PER_SEC + t_start.tv_nsec; end_ns = t_end.tv_sec * NS_PER_SEC + t_end.tv_nsec; ret = end_ns - start_ns; @@ -365,6 +404,9 @@ static long long remap_region(struct config c, unsigned int threshold_mb, */ clean_up_dest: munmap(dest_addr, c.region_size); +clean_up_dest_preamble: + if (c.dest_preamble_size && dest_preamble_addr) + munmap(dest_preamble_addr, c.dest_preamble_size); clean_up_src: munmap(src_addr, c.region_size); out: @@ -440,7 +482,7 @@ static int parse_args(int argc, char **argv, unsigned int *threshold_mb, return 0; } -#define MAX_TEST 14 +#define MAX_TEST 15 #define MAX_PERF_TEST 3 int main(int argc, char **argv) { @@ -449,7 +491,7 @@ int main(int argc, char **argv) unsigned int threshold_mb = VALIDATION_DEFAULT_THRESHOLD; unsigned int pattern_seed; int num_expand_tests = 2; - struct test test_cases[MAX_TEST]; + struct test test_cases[MAX_TEST] = {}; struct test perf_test_cases[MAX_PERF_TEST]; int page_size; time_t t; @@ -510,6 +552,11 @@ int main(int argc, char **argv) test_cases[13] = MAKE_TEST(_1MB, _1MB, _5MB, NON_OVERLAPPING, EXPECT_SUCCESS, "5MB mremap - Source 1MB-aligned, Destination 1MB-aligned"); + /* Src and Dest addr 1MB aligned. 5MB mremap. */ + test_cases[14] = MAKE_TEST(_1MB, _1MB, _5MB, NON_OVERLAPPING, EXPECT_SUCCESS, + "5MB mremap - Source 1MB-aligned, Dest 1MB-aligned with 40MB Preamble"); + test_cases[14].config.dest_preamble_size = 10 * _4MB; + perf_test_cases[0] = MAKE_TEST(page_size, page_size, _1GB, NON_OVERLAPPING, EXPECT_SUCCESS, "1GB mremap - Source PTE-aligned, Destination PTE-aligned"); /*