From patchwork Thu May 18 09:14:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuwei Guan X-Patchwork-Id: 13246318 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C5E5C77B7A for ; Thu, 18 May 2023 09:15:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83CAA900004; Thu, 18 May 2023 05:15:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7ED4F900003; Thu, 18 May 2023 05:15:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B51A900004; Thu, 18 May 2023 05:15:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5B958900003 for ; Thu, 18 May 2023 05:15:03 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2E0D1A01BC for ; Thu, 18 May 2023 09:15:03 +0000 (UTC) X-FDA: 80802816486.23.4C67619 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf22.hostedemail.com (Postfix) with ESMTP id 722DDC000A for ; Thu, 18 May 2023 09:15:01 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ncwIvPQ3; spf=pass (imf22.hostedemail.com: domain of ssawgyw@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=ssawgyw@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684401301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=AEruk6lgv2UDdUrR3IRiS7raiUqRukdhzsBT0y7QWd8=; b=64o1nqVEPss2qH9WDfvIlu2UZ+Sok6hq7AIUp+M3QNol4nSSEo7h8zImIamN2MOzF5da3m vt4g5ZekG7rcGealmeHkDX1sZewkrLUaaTKSd8an2R2t0alw6HPhiQryNiIucKGfLNdtxk +AzWR1gGBtPqeipTgvY0jhuIxx1uBB4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684401301; a=rsa-sha256; cv=none; b=JGpirlUawTqbO+keduXh4TvvyTHUu1Xk/I7Gh23E+dxLT+WC+QCbEopY+3QKcGHYLhNMuy jKA9J3E6ff1/UpQgvwJhLQmjKAjxSP312lBEeQuBl01NAbLZKghKQvH5SB2ejAAt+606nk P0w1cydhGt/aGmmrVH+b1stW4bMvID8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ncwIvPQ3; spf=pass (imf22.hostedemail.com: domain of ssawgyw@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=ssawgyw@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1ae3a5dfa42so13802345ad.0 for ; Thu, 18 May 2023 02:15:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684401300; x=1686993300; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=AEruk6lgv2UDdUrR3IRiS7raiUqRukdhzsBT0y7QWd8=; b=ncwIvPQ3tpE5ajVR5XQ9ZcmF3F9Lx43OHj/zr3p2G6dINoM6/uTDxjVkP3ILiSxU3s m5kzXXYADsCz5VHt+Z0yAi/YqcTYSC7gHPof3iAv8cwJCEcHtxo+w90JmhmvxjFY+W80 7RXmwGKpYjyCodNhLI4k6IsugXMbIrX9+iP9V4+sggfWyjPHclN3cT46Lkm69qI9F2Ry l3tAHFHXJ/k4hHqcv8+YzkpFuiddRQFlikw11Jlg1wJQ6Wrvlq6PdRDnOiDBgqYLlVvn 6rkChuhF85AgL3WgKUgnQT/Cn87I7mY0bHgeR6WqLnQm6n/CT7/X96L0yi3qQausmjV9 3ijw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684401300; x=1686993300; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AEruk6lgv2UDdUrR3IRiS7raiUqRukdhzsBT0y7QWd8=; b=B40DHVeXEBLAeEs3do7G2AHs0oRKedXMKAexEKog8n+IRTN+9b4rzvepy7gfbBDpvD LKr1872QgdhYisao5FnD55QQZh+g92DxOpzzrYeObIp6IWwaIl94pNPG6zHGEiMALVgG Sqo0q/TKSnsDX6eYQgpPqrX094PnQAMZZ2Ylai5yvErsyZbHu3PToMSgLXoixbCNvfsl qhwlW/pv+5vUINlQDGoDSIOdTQffWcG6IXFLJkKXsmG2MmmvqjQuK87famcR10dxxhKo 0DTX4VxHvERGTj3XFuOkZPv0/vlBsE/hlNuf0KebsSDfqzvuIL/qv4dxurUG+iCrynNn sMMA== X-Gm-Message-State: AC+VfDybrR77pzqAepqhSZcsnwskhKWQxyHUto4igY/Qs9puwxAJ45EI qIZZ0JZnhWntl27yTT9aoMI= X-Google-Smtp-Source: ACHHUZ64T69OZGxvcLDXuWD9MHO2gQBxdaNNrGFsoDTvXmb5t5tX/2op+M9sjq47xxxrxPO1JHzvag== X-Received: by 2002:a17:902:ced1:b0:1ad:e099:fbf9 with SMTP id d17-20020a170902ced100b001ade099fbf9mr1805522plg.42.1684401300135; Thu, 18 May 2023 02:15:00 -0700 (PDT) Received: from localhost.localdomain ([45.43.34.98]) by smtp.gmail.com with ESMTPSA id 12-20020a170902c14c00b001ae4c498d29sm862165plj.265.2023.05.18.02.14.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 02:14:59 -0700 (PDT) From: Yuwei Guan To: rppt@kernel.org, akpm@linux-foundation.org, tsahu@linux.ibm.com, anshuman.khandual@arm.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yuwei Guan Subject: [PATCH v3] memblock: Add flags and nid info in memblock debugfs Date: Thu, 18 May 2023 17:14:31 +0800 Message-Id: <20230518091431.299-1-ssawgyw@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Stat-Signature: yte58wg18ohoqwdznnub179b9mxeoqnz X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 722DDC000A X-Rspam-User: X-HE-Tag: 1684401301-861705 X-HE-Meta: U2FsdGVkX1+73SHeMTKhoN1y8baSs8qja/FR7a3vXduxsxtUqTO3rmfGzF4mkNY38cIqFK+PEKIucLsFcnwq0xAOebGxQNMzc+uWLy2b+bGKMt/cILXmHl8LfWLqHKVLuXGfVdKvPVXg9BYp9uTrqfTViuctYKDBSMgCm0z6coH4ocd7PrN3UIO8tB61m0LRe//b9R2jMYlyWJQnT69nneumI80Qcs5uY1zVUgnCTT4nlYWae4znWWCcpQZ9m4sicSHkaUGiKpDjd608H1U797a/MZMQGb0MsP0nRfc3/C1ufFS2c8DkaGtYYbc+98U/YrMcUDaTgIqYN36RCWxHts8MydLgYZQZYDM64qXyN3o1ZuCQlYRhNqMUtXCihhGSfuNJmWB/5qlJxTdChmzqczWTucXgI0Tx6I/S9YvAHRS/NSHlfWNivbQi6FfaWEoXoyGOLYllPta/mnXebQeqC1EpEaUTIrUTx9eX03zc+TE05e4ZwcbIYs0OOHmbeaW6TbUOwl6vvDTpoUEGAJa/kJaHrtu7coVDbn7N4fM2bLJ3RIaUPDertgCo5JhAQ6jK+LR88FEK7FmBq61HnRyA5dZHTxoDet293SgW4nb1XFD9V7BFdZL1oerjP7NitZRl+vyy6f/VMQ6f8Jn6iZBQnlNLooVZr73i3SfYgGOccFjklY8rm5R/UqBanc/TSBRa5Lubmvwjj6gSV3E8ewc7+xTAsPyds/MceTD4jEkWQmZw7tpG3mRNDPtDTh2H615NiCu5mo7NkqVXuRe+t0fMASK6/xnhn1hyfWk2Zyi7lYo2HmmYGBUcTMCM2tFyat9SmtrhjUg96Msy9INOr2kXeuP26rVpssS6qB5MrYvxgCbcDjruV3+MqozhjMhtj3ERulgp4BCPjFHenvd3FGCTsYcHXGbePNnIGljq3AfrAjS7rZk24sIQCa7fHJX8uRgIiRBcpHKc7stZg9iMLvI UjFBavnx Q+jE2qqNX3mQhAyR6MUtHCedd1DEnAMYu0IBk7De4t1lh8CjWlaOVStXBP+tsaA52FYri6zIsa04+i87vFxK7Gy/OY4965lSA/1jQp+OCR9DsDYBHItKWm1K3+bvDVwEQiAPyak2ys0/1wj36fOqWRV97gSaoTT1hUFRGJ1xb8GcuNBTyGFaKFE8BilhTtXRGol5oMxRf/RCo17pbf3A8HC8BTCqObacZZIRVxRAWA3fzKOuBLp1H/9cgTyDgX8G8KWCZSBFwq1+Nk1lzr8arTFZNAB5dXPLJ4NZfliPJYoy55do8NtJCNHQ8FgCsnpGjQ86RF6pXOtaZBI5Uwc727Mj7twQVK0n9chQ6e4KIairvA4wxCJABb7O1+aYTK2JP3I4mGkVQhEFVfLwx4//Gomqr7nvIXhR/JH2S8Ga3T9VZx0TG8myxkbk8qxI3afnTy7kN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Currently, the memblock debugfs can display the count of memblock_type and the base and end of the reg. However, when memblock_mark_*() or memblock_set_node() is executed on some range, the information in the existing debugfs cannot make it clear why the address is not consecutive. For example, cat /sys/kernel/debug/memblock/memory 0: 0x0000000080000000..0x00000000901fffff 1: 0x0000000090200000..0x00000000905fffff 2: 0x0000000090600000..0x0000000092ffffff 3: 0x0000000093000000..0x00000000973fffff 4: 0x0000000097400000..0x00000000b71fffff 5: 0x00000000c0000000..0x00000000dfffffff 6: 0x00000000e2500000..0x00000000f87fffff 7: 0x00000000f8800000..0x00000000fa7fffff 8: 0x00000000fa800000..0x00000000fd3effff 9: 0x00000000fd3f0000..0x00000000fd3fefff 10: 0x00000000fd3ff000..0x00000000fd7fffff 11: 0x00000000fd800000..0x00000000fd901fff 12: 0x00000000fd902000..0x00000000fd909fff 13: 0x00000000fd90a000..0x00000000fd90bfff 14: 0x00000000fd90c000..0x00000000ffffffff 15: 0x0000000880000000..0x0000000affffffff So we can add flags and nid to this debugfs. For example, cat /sys/kernel/debug/memblock/memory 0: 0x0000000080000000..0x00000000901fffff NONE 0 1: 0x0000000090200000..0x00000000905fffff NOMAP 0 2: 0x0000000090600000..0x0000000092ffffff NONE 0 3: 0x0000000093000000..0x00000000973fffff NOMAP 0 4: 0x0000000097400000..0x00000000b71fffff NONE 0 5: 0x00000000c0000000..0x00000000dfffffff NONE 0 6: 0x00000000e2500000..0x00000000f87fffff NONE 0 7: 0x00000000f8800000..0x00000000fa7fffff NOMAP 0 8: 0x00000000fa800000..0x00000000fd3effff NONE 0 9: 0x00000000fd3f0000..0x00000000fd3fefff NOMAP 0 10: 0x00000000fd3ff000..0x00000000fd7fffff NONE 0 11: 0x00000000fd800000..0x00000000fd901fff NOMAP 0 12: 0x00000000fd902000..0x00000000fd909fff NONE 0 13: 0x00000000fd90a000..0x00000000fd90bfff NOMAP 0 14: 0x00000000fd90c000..0x00000000ffffffff NONE 0 15: 0x0000000880000000..0x0000000affffffff NONE 0 Signed-off-by: Yuwei Guan --- v3: - show string value for each memblock flag --- mm/memblock.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/mm/memblock.c b/mm/memblock.c index 511d4783dcf1..5fba53f98b2d 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -2143,13 +2143,23 @@ static int memblock_debug_show(struct seq_file *m, void *private) struct memblock_region *reg; int i; phys_addr_t end; + static const char flagname[BITS_PER_LONG][8] = { + [0 ... (BITS_PER_LONG-1)] = "?", + + [ilog2(MEMBLOCK_HOTPLUG)] = "HOTPLUG", + [ilog2(MEMBLOCK_MIRROR)] = "MIRROR", + [ilog2(MEMBLOCK_NOMAP)] = "NOMAP", + [ilog2(MEMBLOCK_DRIVER_MANAGED)] = "DRV_MNG", + }; for (i = 0; i < type->cnt; i++) { reg = &type->regions[i]; end = reg->base + reg->size - 1; seq_printf(m, "%4d: ", i); - seq_printf(m, "%pa..%pa\n", ®->base, &end); + seq_printf(m, "%pa..%pa ", ®->base, &end); + seq_printf(m, "%8s ", reg->flags ? flagname[ilog2(reg->flags)] : "NONE"); + seq_printf(m, "%4d\n", memblock_get_region_node(reg)); } return 0; }