From patchwork Tue May 30 22:24:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nhat Pham X-Patchwork-Id: 13261181 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99E68C7EE23 for ; Tue, 30 May 2023 22:24:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10E04900002; Tue, 30 May 2023 18:24:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 095BE6B0074; Tue, 30 May 2023 18:24:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5296900002; Tue, 30 May 2023 18:24:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D2ED56B0072 for ; Tue, 30 May 2023 18:24:44 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 92D57AE2F1 for ; Tue, 30 May 2023 22:24:44 +0000 (UTC) X-FDA: 80848352088.02.8294D2E Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf13.hostedemail.com (Postfix) with ESMTP id AF9F420008 for ; Tue, 30 May 2023 22:24:42 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=WnGpKbOV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685485482; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G/1SowEewql6UJanqoqPfCeIbhtfTWUbi0a35Y9vIrs=; b=eUw30inAcxOhCDjWTAnvW++03YlXpBYgU4JET8X3MBjB1sKEwDKHKLnulT8Zn0wGgLNNhF azhFa8bu3+WRZZKqTob/5byehRNhsv014xfRj9Tmo+Aq1v73sen+Qec3wT+4LpwpaYOADP 7NvdlXFUkaDwI6ybl2JcOPL5pr66p0o= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=WnGpKbOV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685485482; a=rsa-sha256; cv=none; b=MUeyXzbyMm0ThJp85z+f8SrjJawnhG8NH+XeWRKqvbUCA8UyIlozvZhVYyPl9MX5I2lvJZ MDBnZb478E56riKWkXcL9SuTV/ZLfldYy4tDKct4rEKazLhrYuPMkcavcW12W87zmvxpeB Z5KXKHYANUcYo8VqLKgsv1rfIaVD/T0= Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-64d2a613ec4so3702869b3a.1 for ; Tue, 30 May 2023 15:24:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685485481; x=1688077481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G/1SowEewql6UJanqoqPfCeIbhtfTWUbi0a35Y9vIrs=; b=WnGpKbOV8lvKv65POyTi6fFpPciJnn2J218zZF6h2JBge30QnWdNUvnzUrtIt8UgnZ 2eW1iZOQ2Tt2wXfrF2sy9wyLOHpdabbOEbVJDs3E75P65V7vvOuV1Ux5MwkFcjkLY7Xz Bu7uKz5n+vefnTqjV1nadY4GfOrsQ0Uw+HjVXvDl4I0StS513zWcuXQq5eVL+/MlwMXu 8F2l0wObfSk2UsB5Dk9tPoBRFXwVKzqv8ZWdz8aH6tf7AsfQAloacKm3lmKE+Xj2uWJv Govc/74/GHTR45rriTat2bDrmCYoFbabV+xQ/5N+eZDgjJPHDFFE+TLtd0w9u57QaQJX anMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685485481; x=1688077481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G/1SowEewql6UJanqoqPfCeIbhtfTWUbi0a35Y9vIrs=; b=CTSRwGZwGhuGJafL/mDYTaTHqh9j4iubWQ961PZeCu/DaYOBgoG0TQkY9hDcodf+uL CnJCwuNSXIMN4v8vurdhuVae2MrdFOl02O1PpjUOcVL83WI2xIAPL2v0VYNHj5egoUih Rl/CL9S56kVb9TMktXr5kuOKJClVDl9/g99jtSiRkhh2vt0KDYqAC6lo9rv61r+J4lfR ZBZieHjarx3PxURz+BFK2fx4os/ZJVhRWA6aCjIixH5VhUBaPUCOZ5x6CK/u5PMiyXIK R11uWLjgLyiREUSjRXlXywojB8P5cUU1oglr+Yapux3+8vSltwe/dfAKDGqPJGXsO38r /Qzg== X-Gm-Message-State: AC+VfDwTeDdoSBfINap1BtZIOOm2FJioM1acIW+wr/2hjubdbzkd1x2k Z1WWLxt2zISscn3ryuDExJg= X-Google-Smtp-Source: ACHHUZ7o0vAxUBMoiek8AqoGTNtUZ009NsT2LcERUfQxIOYsAOkRZBMLNu4fP80xpI5LAqDbmuIFpQ== X-Received: by 2002:a17:902:e74f:b0:1b0:2658:db00 with SMTP id p15-20020a170902e74f00b001b02658db00mr4629006plf.31.1685485481413; Tue, 30 May 2023 15:24:41 -0700 (PDT) Received: from localhost (fwdproxy-prn-005.fbsv.net. [2a03:2880:ff:5::face:b00c]) by smtp.gmail.com with ESMTPSA id t5-20020a170902e84500b001a212a93295sm1719203plg.189.2023.05.30.15.24.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 15:24:41 -0700 (PDT) From: Nhat Pham To: akpm@linux-foundation.org Cc: hannes@cmpxchg.org, cerasuolodomenico@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, yosryahmed@google.com, kernel-team@meta.com Subject: [PATCH] zswap: do not shrink if cgroup may not zswap Date: Tue, 30 May 2023 15:24:40 -0700 Message-Id: <20230530222440.2777700-1-nphamcs@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: AF9F420008 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: jnsbqngjideniumcshcupfzbnpr7ace6 X-HE-Tag: 1685485482-22920 X-HE-Meta: U2FsdGVkX1+99bKMLpjqV5ugX7ygRB1GoWG4m6ksqLkfKRNVrVhuvQXF7iu4smV/FxxGPjWYpKDMG/gBHB2B+iSO6GtDyklh1MbY2+ZLaZETZiOSY2jMQdm5sZ1pbcDqpPWP9SItBno3w0DwMSjR2sLOZudjjezk8TAa10gGRTViBW5KnVGO9uz3sece1RT/EfwwU86qkHjCZzMJ3XRX6/9fNY2N7LUVRAYhskjlSg+tlaPTUjrmOLYrKiJuTdQ51jveAvSSwbpQh0xin4FuwEzqWG3RhYlrxkAb8kAtwv9QyAF4NIBQxrVe/kEc7Rd2Kyb6yHjn8CBvGrnAIWy7co0/iE4e9dWDCbKzH8D2VzsSTx4F6gW9/OziiuxJzZxrGWU7Wd2h2GJGZK+sJyYpac7MgkM8wCYjTmOCYq1TGxwNx60arloavoh4/rCHcfQJVTuBiZCkP1GpsAtM9FyZuB2zZDGyBV+JDKnX1D95SCUj6OJN4LcNgOvmkTTi+bhzmi0HQqtYk3Beqr3tXLIc+3iTcdMVzo1g57vZtIm/5wuMwwRWsrpTSsSaDkIa/NFToKOSTVfIbG73SgMBulNhDSkOVvMSVLQtEYaoDwX9RcqQqKOLPQzUNA98qShmXOHn/uu+pedusmYz46X7YYnmSb38x0QOVoE96I/pNkFuguDJIEM/wN0WfezIpzsmZFpIMnvgvJOuNu+IYiOd4usx8olPe0iDs3/zVzm4ZfrXoGJXuY4/s7UsYuhfs+JEt3Ljcy9KLPSLFm+B/owtXou8VgFOBZ/LSQ1e/Kc8amqraki02Kn8caw4bax1u/hFqgZiziW6VezH+3JG0W0Qcn8hVdw6HlO/zu7fpJ07Y2o2pOxR8ZBaUtQppHjpq5dv6aRy9VX/vDMCs7aa8A+sN9aiQSn5ShhDZmPdcaRfllblYgjXFbCLs/Cg062wcfz0S9ia1Io/mA3gy1h7NCaThNI D914WRrv SxlEeeOZpze5yBe7nP47PALvH51pJKLNHU4KuMKBRCwLbDcYAi85W2ML2LaMphCP+E8v7dsLVUgvAaFM5aHIWYMaFKXqgClnZavdoYfFwiGm2O+bhhgOl6O4Yvzo19Xls9n7IsBi/DCPdoeKw2ethYJYEhzlYoPEpLD9bPfUALdWHVDtCOanjBmsifVXbHsMpXITEurId3zcrRJCFpMKrKahrRnuc4Cnjxps6H5a4DbDvl3MTJE4P8Jp2KXos0IWMLKuw6z+gnDVW0t2WmJjYPH3uaapk5KphVhmMuA6ZEQIZJaO2qHZPfTklhE8oMJNtBa9TOErQ3es0lWp3I05QCEokuj3v6wMBQ4JROM8gnwrsam6OXEHhuMwfrJCmwUGrIvipbFB/OJGRSB41xM8ViG5FuzE+P2/jBxX0lkktcY/Yt0A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000063, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Before storing a page, zswap first checks if the number of stored pages exceeds the limit specified by memory.zswap.max, for each cgroup in the hierarchy. If this limit is reached or exceeded, then zswap shrinking is triggered and short-circuits the store attempt. However, since the zswap's LRU is not memcg-aware, this can create the following pathological behavior: the cgroup whose zswap limit is reached will evict pages from other cgroups continually, without lowering its own zswap usage. This means the shrinking will continue until the need for swap ceases or the pool becomes empty. As a result of this, we observe a disproportionate amount of zswap writeback and a perpetually small zswap pool in our experiments, even though the pool limit is never hit. This patch fixes the issue by rejecting zswap store attempt without shrinking the pool when obj_cgroup_may_zswap() returns false. Fixes: f4840ccfca25 ("zswap: memcg accounting") Signed-off-by: Nhat Pham Reviewed-by: Yosry Ahmed --- mm/zswap.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/mm/zswap.c b/mm/zswap.c index 59da2a415fbb..cff93643a6ab 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -1174,9 +1174,14 @@ static int zswap_frontswap_store(unsigned type, pgoff_t offset, goto reject; } + /* + * XXX: zswap reclaim does not work with cgroups yet. Without a + * cgroup-aware entry LRU, we will push out entries system-wide based on + * local cgroup limits. + */ objcg = get_obj_cgroup_from_page(page); if (objcg && !obj_cgroup_may_zswap(objcg)) - goto shrink; + goto reject; /* reclaim space if needed */ if (zswap_is_full()) {