From patchwork Wed Jun 21 09:20:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: liuq X-Patchwork-Id: 13286936 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 569E5EB64DC for ; Wed, 21 Jun 2023 09:21:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDD558D0002; Wed, 21 Jun 2023 05:21:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C8E878D0001; Wed, 21 Jun 2023 05:21:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B54FC8D0002; Wed, 21 Jun 2023 05:21:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A2A038D0001 for ; Wed, 21 Jun 2023 05:21:17 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6FE8E1208B1 for ; Wed, 21 Jun 2023 09:21:17 +0000 (UTC) X-FDA: 80926211394.21.7CDAE7B Received: from chinatelecom.cn (prt-mail.chinatelecom.cn [42.123.76.223]) by imf19.hostedemail.com (Postfix) with ESMTP id 527371A000A for ; Wed, 21 Jun 2023 09:21:10 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of liuq131@chinatelecom.cn designates 42.123.76.223 as permitted sender) smtp.mailfrom=liuq131@chinatelecom.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687339275; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=tsZ59JOEqwXlTliHk3l8bSgiy/CyzMbvttX+LQwXlj4=; b=SM8mBeB5T9J5vsHc2DtDV4Lf6x82boeCx08MvGty3tuuznV400Q5bY7AMq4GLDSq/5rOd9 fFIFKVnFHfsWPnhh+ksHG474J6IiMUAfg7o/+wHgACaC25OCcbDu0lEezvVnrLmt49S0iC L9VEIpkrhMtd87zIsTLQlwvSwp6AFxA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of liuq131@chinatelecom.cn designates 42.123.76.223 as permitted sender) smtp.mailfrom=liuq131@chinatelecom.cn ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687339275; a=rsa-sha256; cv=none; b=tUa8+3q2R0gxoCQwZQSKWfCiyNuPdZvi7Dv/YYa2w9A6aN1isqqa+spaFayIhCSyJ5aOUv LzXutN5OE6fG7rQUuwHUZHYwweJ4lxvZgHAooW9QH+kIqwQB5vbzqP/PNEJAr7/nnZngSa Av94mJqwuc2gEK0PG4rK4omvgz36V7M= HMM_SOURCE_IP: 172.18.0.48:41464.1037017731 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP Received: from clientip-36.111.64.85 (unknown [172.18.0.48]) by chinatelecom.cn (HERMES) with SMTP id A0D352800BB; Wed, 21 Jun 2023 17:21:01 +0800 (CST) X-189-SAVE-TO-SEND: +liuq131@chinatelecom.cn Received: from ([36.111.64.85]) by app0024 with ESMTP id fa69a156f7714ae4ae7368d0327bf29c for akpm@linux-foundation.org; Wed, 21 Jun 2023 17:21:07 CST X-Transaction-ID: fa69a156f7714ae4ae7368d0327bf29c X-Real-From: liuq131@chinatelecom.cn X-Receive-IP: 36.111.64.85 X-MEDUSA-Status: 0 From: liuq To: akpm@linux-foundation.org Cc: ying.huang@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, liuq Subject: [PATCH v3] mm/min_free_kbytes: modify min_free_kbytes calculation rules Date: Wed, 21 Jun 2023 17:20:48 +0800 Message-Id: <20230621092048.5242-1-liuq131@chinatelecom.cn> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 527371A000A X-Stat-Signature: pdj54ynstygar1rr4g3h3t5cif68gwr7 X-HE-Tag: 1687339270-962652 X-HE-Meta: U2FsdGVkX18XfyybNi+gByPbbzGdS5cNPb01Uij5tPH7XzcLcYjn46aWzrLvczn/Vqpx2Al5hLGP+v7PlxveuqvkaMVC5/DufimocV1mAWoDbOPOE5Z46uryfkagio6MMDlM4+kuWgragbe+2keFbPQdh6bC04UeM1YXN8Q0QwCxRwgw5rqFRLb7OpXRQrRbgsHhZcNNDxPJFXlCm0JoZtRjYCAk7Ix7XGihj4zDkrsIxXU9Q0pgn/j8V71SQdRVO8LfamKBXzrelAzltGy3bFgsacO1lD3Qa5b8Jq6t2D1m0y0RwKZENZ0Et9W38573DE1SOQ7kRBPZUpgtadfBummIdMz5pU76pjSlBs9MlxJgf2ZmnRoRg6POvPVvgGOvjBPwrmnv+vemmOfdy6zLhPubPv1f7gjqrbcx2kT3aCLwI1U4UABVSLHI3pNHgvpWSmEkjjRNxZFZu/KBygcglI10lkLS9PI+LtJLW/MYqRMg4euAAgTVirnPNfESYvF3+YL1GnTX+sgP1LgGeXg8MYe9fcX9eXP0PEZfoRrxinD4hnJCcOasoanW3DL3i+Qp2fTAlE1kThWMHyOiLmf7F+cvsCj6GmXMzuCaHRsjrNAXdPV1AsWL0lbPzG2kymtbNwxUHkQCzYIfYDFYN5q6uQE03rz6oNZWeC7dVbYK4cpGhfLhJLwoem6Fw+xvL6t6XcYU4cgX0dPtZ4Xwxoauy2He16PvM+3XplYnpFRJuB2JzU8oKhLDquUL2tJcHkG0QnzQJNGHv+NRr5OB+ndqPchiXtLDnWHpMbGVAMVrKURH620XSxiDWK1HzN8vSyKOlRQ+pEK1gxv3nGNzB7/fvo6TLoCfsllRAnky+Nwoaw1BZkZF2j4zptSIew1CqXZoTxoGPCr5eaX155job0voHY7Sh9jsIOFSxjrGypAarqrXMJUqmgg767xMxox60pIaKVqqTZW7DaY0aU1BlKO AoAC3HOL BIY1DMxs5TTlodCgRToTolLNeT2C6flSzsXlcrf/oMKkLXFHmMTvUdVgoPltM+3f2SwsKvL6hQUs40u4J3GipjfXp66lU29p3Iir+5xpUm+KgwTxwOjCa/fZrwI0AmkiDvV9CfXuDP3Jn2mmjgATseFXpng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.096636, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The current calculation of min_free_kbytes only uses ZONE_DMA and ZONE_NORMAL pages,but the ZONE_MOVABLE zone->_watermark[WMARK_MIN] will also divide part of min_free_kbytes.This will cause the min watermark of ZONE_NORMAL to be too small in the presence of ZONE_MOVEABLE. __GFP_HIGH and PF_MEMALLOC allocations usually don't need movable zone pages, so just like ZONE_HIGHMEM, cap pages_min to a small value in __setup_per_zone_wmarks. On my testing machine with 16GB of memory (transparent hugepage is turned off by default, and movablecore=12G is configured) The following is a comparative test data of watermark_min no patch add patch ZONE_DMA 1 8 ZONE_DMA32 151 709 ZONE_NORMAL 233 1113 ZONE_MOVABLE 1434 128 min_free_kbytes 7288 7326 Signed-off-by: liuq --- mm/page_alloc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 47421bedc12b..590ed8725e09 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6362,9 +6362,9 @@ static void __setup_per_zone_wmarks(void) struct zone *zone; unsigned long flags; - /* Calculate total number of !ZONE_HIGHMEM pages */ + /* Calculate total number of !ZONE_HIGHMEM and !ZONE_MOVABLE pages */ for_each_zone(zone) { - if (!is_highmem(zone)) + if (!is_highmem(zone) && zone_idx(zone) != ZONE_MOVABLE) lowmem_pages += zone_managed_pages(zone); } @@ -6374,15 +6374,15 @@ static void __setup_per_zone_wmarks(void) spin_lock_irqsave(&zone->lock, flags); tmp = (u64)pages_min * zone_managed_pages(zone); do_div(tmp, lowmem_pages); - if (is_highmem(zone)) { + if (is_highmem(zone) || zone_idx(zone) == ZONE_MOVABLE) { /* * __GFP_HIGH and PF_MEMALLOC allocations usually don't - * need highmem pages, so cap pages_min to a small - * value here. + * need highmem and movable zones pages, so cap pages_min + * to a small value here. * * The WMARK_HIGH-WMARK_LOW and (WMARK_LOW-WMARK_MIN) * deltas control async page reclaim, and so should - * not be capped for highmem. + * not be capped for highmem and movable zones. */ unsigned long min_pages;