From patchwork Thu Jun 22 07:27:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivek Kasireddy X-Patchwork-Id: 13288349 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93528EB64DA for ; Thu, 22 Jun 2023 07:53:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 213B38D0003; Thu, 22 Jun 2023 03:53:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F65A8D0001; Thu, 22 Jun 2023 03:53:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED9FC8D0002; Thu, 22 Jun 2023 03:53:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DE7AE8D0001 for ; Thu, 22 Jun 2023 03:53:07 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B75EBC0A9C for ; Thu, 22 Jun 2023 07:53:07 +0000 (UTC) X-FDA: 80929618014.27.893668E Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf21.hostedemail.com (Postfix) with ESMTP id B6C061C0011 for ; Thu, 22 Jun 2023 07:53:05 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=WAufhhGu; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of vivek.kasireddy@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687420386; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bChjejs42JDqaly1ZOsJqv5Dr6zV2fCgdPJr+PE/O0E=; b=jUU+uF52znV9rXf0igaTWyA3aj5rREB/JBg3qDJQ3qqXDOZlk7G1nqcKtRoxCIdl3ZdwnN 0WBPoaaTO7k/1o41IZ1PSrhEkbfkOrH/cXpF+I5xmLI0haasPTOd6McT8YXBofn7A3AVoP 1JT6vCNbR5Lw/Ti/u95ElMTWvabB8BM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=WAufhhGu; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of vivek.kasireddy@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687420386; a=rsa-sha256; cv=none; b=X9VixXDvKZbv0XOS72fy5QRkvF1LxreAwziJutKT6pUQ8XRGgG+KqOOhY7BZUcXJ+QmwFf mwrozz/Sbr2qqGQ7Skizl6RJbA4/uMMAXtJfSqogGmCCXBfb7oSKnHDZoD7tcRE3s96E27 KHO4oMCVSll0dIuIsUBZMSnG5fjZD9g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687420385; x=1718956385; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uDBd4/YsqUQQDyHVrKGd5PdP5Z3CATu2lZahmmVGji8=; b=WAufhhGu3CfgDrQYaAdO8z7eE9EPZgahsCbZHjIg1S3qKX7bliPtikun mnMOwbrjfcNfMIby/4OYXe84aLJjqGFT42xLLr5Q5yvL3qbEhvbLwhGSU l0R0X3LN1eSUiMzCo1OKxcIS0icdlTLFZkttssbiN3KrJxDZP9L9YSF71 h9AYqeURMwCGZF0BkaFJT4Eh5kOd8G8c+T0FheyyPitdHG53kexy1CpPv EEx60wTlr2Fon//3KVbazSqCH3MhHk6CQE2xz40TG1fQJQ0NlqVeE8Bum jBpNGCyFMX3ygHYrdce2CB6I//zbouwzdPNRGmqTRKmnEq1YSh2JrVYgW A==; X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="357910355" X-IronPort-AV: E=Sophos;i="6.00,263,1681196400"; d="scan'208";a="357910355" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2023 00:52:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="784801072" X-IronPort-AV: E=Sophos;i="6.00,263,1681196400"; d="scan'208";a="784801072" Received: from vkasired-desk2.fm.intel.com ([10.105.128.127]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2023 00:52:24 -0700 From: Vivek Kasireddy To: dri-devel@lists.freedesktop.org, linux-mm@kvack.org Cc: Vivek Kasireddy , Mike Kravetz , David Hildenbrand , Gerd Hoffmann , Dongwon Kim , Andrew Morton , James Houghton , Jerome Marchand , Junxiao Chang , "Kirill A . Shutemov" , Michal Hocko , Muchun Song Subject: [PATCH v1 1/2] udmabuf: Use vmf_insert_pfn and VM_PFNMAP for handling mmap Date: Thu, 22 Jun 2023 00:27:09 -0700 Message-Id: <20230622072710.3707315-2-vivek.kasireddy@intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230622072710.3707315-1-vivek.kasireddy@intel.com> References: <20230622072710.3707315-1-vivek.kasireddy@intel.com> MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: 8xyupda714qfat8psxa9p4opib7ckfnq X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B6C061C0011 X-HE-Tag: 1687420385-992615 X-HE-Meta: U2FsdGVkX1/6BcgVFKl0/5CSO9TQkOg5VAoAC6S+NmG6Kncu3K6nLRqhJDJHukojMrItik1VSvlOF+hKjgP9yF1rrAWjom2vS2Gy7Lwt7gICoKYdYrjr2N1uq38frGL4wo9wA/iuu3DIlqVNQUVkpRr1opquSCFi2iUxWounK1z/f4gpwws6PYugmBVECsLTROd4qXzYvXyRvvtbdj7wMWzVA0WCZ0nevdGSb+HIIboAcXRj+E03CajZitzJo0Jzi+wV2VQyJLWn9mDaPvfQ2QfyNyj8+Qijw60C9XGVOELAx8bvc1nI28Tp6YghFEusRyq01wMAKc1vxvuwgUKD2Rm+17W9gkVowWSXy5lkh6dFAkL7zn+QvRFc2FTee3mqWNVgxbA7MJCyowa+ctAKt+httMXFF/6J9bozYLDv0OsG3rCMW3WIIn0LOEEx2O5aWVCPOJbIPltcDers0Iaruh+equCWERk8wrAl74agO4Yr/CQvMH9PBHqHIchjKrPoSv4jBTWx3OLZiC31KWTMGRC+LH9Hz0B6AS0j0eNHMHrC2hfUJmyMpF7x26WavQ+0e5KBBsqCgR2C6J2KrIOYUfEzidxjZanWKeYGmD1V0SzKDJdBNhT3R/y5RqQqWnhE63XlrSN2eoY+fmAa8nGfHRkqo4J1H3FGkoUXh9Rh3LiRKOwpCf7LLUmyhVQ3ZaITRuPw8cgC6WNn2oxKzQ6sNSWGsdUNHTdTJVxEy7FB4QeuLDwFgpHeibwsarNpb5x6OrKBrlIFzgJh2m0VNiI3fLWyaJe+WNglsJLOvAvc230HzYpW2dEongb6AyIY9iSnj7uZ+R86DwY9xMJgmzUiIpFjVm/m20TkHtt5z1RPoZzbjoUVXkTby6rGI7zhIttj46s5gXcQkuLmg8YT67YvMqxlDHjmfBSTKKOrinwoLt+Gtz/TfXg+LhwP7X5n+yZdupxpyZ+RrdGaeveogX6 YVKnEGUh 9m7fcjOiWjpSffp0chFSrisKM/KOfyggEiFMUs802skVlNt5lFlXsymzJWDxhQLdaWkAxrfoDm6ndQD4xjMFG3wz5lNqaIw6QlZFDutMWEUexz99IzZJjmS6V1ZB3BQAlrjwPzF1yCzdVrH/s8AWYMu/s1gkpnIqA3eDx/1mK1QOqC1Rvx7cq/vgOW51aIbGvqmgC8IO6orzn76KcTiFgMmYl5Q/kqNEVZbJh456K8bwyMbBz6FcT63DLitJLQNjz1IA+oobiOzxhN7xFQAxYctcirRJ+RKjyTp+LvGgIDdFuotTH597wIT5oue4hhfnEyAnbVRtccdVPDMsqKlkZM8aEY4VBR8AvQ3khDbj5KKlhhM4zgtCXZfl8mNVA4PlhsQrJsc8ZbfG6Q+4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add VM_PFNMAP to vm_flags in the mmap handler to ensure that the mappings would be managed without using struct page. And, in the vm_fault handler, use vmf_insert_pfn to share the page's pfn to userspace instead of directly sharing the page (via struct page *). Cc: Mike Kravetz Cc: David Hildenbrand Cc: Gerd Hoffmann Cc: Dongwon Kim Cc: Andrew Morton Cc: James Houghton Cc: Jerome Marchand Cc: Junxiao Chang Cc: Kirill A. Shutemov Cc: Michal Hocko Cc: Muchun Song Suggested-by: David Hildenbrand Signed-off-by: Vivek Kasireddy --- drivers/dma-buf/udmabuf.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index 12cf6bb2e3ce..6de40c51d895 100644 --- a/drivers/dma-buf/udmabuf.c +++ b/drivers/dma-buf/udmabuf.c @@ -35,12 +35,13 @@ static vm_fault_t udmabuf_vm_fault(struct vm_fault *vmf) struct vm_area_struct *vma = vmf->vma; struct udmabuf *ubuf = vma->vm_private_data; pgoff_t pgoff = vmf->pgoff; + unsigned long pfn; if (pgoff >= ubuf->pagecount) return VM_FAULT_SIGBUS; - vmf->page = ubuf->pages[pgoff]; - get_page(vmf->page); - return 0; + + pfn = page_to_pfn(ubuf->pages[pgoff]); + return vmf_insert_pfn(vma, vmf->address, pfn); } static const struct vm_operations_struct udmabuf_vm_ops = { @@ -58,6 +59,7 @@ static int mmap_udmabuf(struct dma_buf *buf, struct vm_area_struct *vma) vma->vm_ops = &udmabuf_vm_ops; vma->vm_private_data = ubuf; + vm_flags_set(vma, VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP); return 0; }