From patchwork Thu Jun 22 08:24:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zheng X-Patchwork-Id: 13288415 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5DA0EB64DB for ; Thu, 22 Jun 2023 08:26:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7798C8D0005; Thu, 22 Jun 2023 04:26:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74F6D8D0001; Thu, 22 Jun 2023 04:26:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63F4C8D0005; Thu, 22 Jun 2023 04:26:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 53EB68D0001 for ; Thu, 22 Jun 2023 04:26:32 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 258EC140149 for ; Thu, 22 Jun 2023 08:26:32 +0000 (UTC) X-FDA: 80929702224.19.5A28EC4 Received: from out-48.mta0.migadu.com (out-48.mta0.migadu.com [91.218.175.48]) by imf06.hostedemail.com (Postfix) with ESMTP id 54DD518000E for ; Thu, 22 Jun 2023 08:26:30 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Vou+QBcB; spf=pass (imf06.hostedemail.com: domain of qi.zheng@linux.dev designates 91.218.175.48 as permitted sender) smtp.mailfrom=qi.zheng@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687422390; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oQpOCkSVz0jjdFm4oEP2NJJ+zKFOVCxqbVN/b6qKeiM=; b=HQ5XIvP5mUUhq7snu0XhEp+U8SWGamfID1czk0n6EeWeHs0DyfWtaTjkQXB6+66u5x37LZ Wp3V6+CslowA18ixp1QuDQ9HBytFN9d90Wcs5P1n5Nv/Mxd5XBSP1XoJpfKwuAbGvZoRWI k0i0YWCTUjVyPEM1gaPSbZtVKUfX4UA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687422390; a=rsa-sha256; cv=none; b=kkzsbqCmucY0UhkxBySxObGVhURoBR/exOmBhFNwyUaEH7orwtScXYq4SwmR0GQ1jwnLAz wNe9Ixp57jIwxc9rX8gXCMKtsaakhm4MZM/uIZV/Q09zgUk2SRTZrq6v1e3GtwHCRlSZzU 8kDHI8mT8DdrvHHtvCSfJfincffW9l8= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Vou+QBcB; spf=pass (imf06.hostedemail.com: domain of qi.zheng@linux.dev designates 91.218.175.48 as permitted sender) smtp.mailfrom=qi.zheng@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1687422388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oQpOCkSVz0jjdFm4oEP2NJJ+zKFOVCxqbVN/b6qKeiM=; b=Vou+QBcBsFfrycM2PkKySs/6vc7t4z2y+ESRPtdGGBu1nh2ELX2n3XwLyStu2J7FwIsey0 GRSdEt3Uk6O3X+qjfRuw6k2zIEyamPbwTm+TOHkS5CEaR6KvBgQJdhpJF9uZHGex1bKqla yWmLNi3h067slmAnbRZ3GfDMps2hTHE= From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu Cc: airlied@gmail.com, daniel@ffwll.ch, robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, sean@poorly.run, marijn.suijten@somainline.org, robh@kernel.org, tomeu.vizoso@collabora.com, steven.price@arm.com, alyssa.rosenzweig@collabora.com, agk@redhat.com, snitzer@kernel.org, song@kernel.org, colyli@suse.de, kent.overstreet@gmail.com, namit@vmware.com, gregkh@linuxfoundation.org, mst@redhat.com, david@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, viro@zeniv.linux.org.uk, adilger.kernel@dilger.ca, jack@suse.com, chuck.lever@oracle.com, neilb@suse.de, kolga@netapp.com, minchan@kernel.org, senozhatsky@chromium.org, clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, christian.koenig@amd.com, ray.huang@amd.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH 02/29] mm: vmscan: introduce some helpers for dynamically allocating shrinker Date: Thu, 22 Jun 2023 08:24:27 +0000 Message-Id: <20230622082454.4090236-3-qi.zheng@linux.dev> In-Reply-To: <20230622082454.4090236-1-qi.zheng@linux.dev> References: <20230622082454.4090236-1-qi.zheng@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 54DD518000E X-Rspam-User: X-Stat-Signature: hbc38hi7ox5txhe987h6pc9nbznekmtc X-Rspamd-Server: rspam03 X-HE-Tag: 1687422390-714468 X-HE-Meta: U2FsdGVkX1/o+S1CfBKAxSouiAWP8E1kxXySxsps2/DOFeFJeg4XLoh6ZO5lmjQzWxLp9WoGta8U+MF4hxmY91GV7Nl4h8tr4eeREY9IH0G2NASlxw16PeAbvArTyaPWrS0eF5LYljapMTR0c8YwE2t9hCVUsGmw6/umZFBATcZAodL+Vb1k2nomYoDmG4u8HTdx1O/Oa2C7Es5VlV1n/7fTi5VrgZ3usUVdxOgP33tNC4Z/HxeKCdWKJ3xA7OU/TcJaAUJ7o3IAgJr6Qj0dMyWrLCXjz54MgKRCnC5Z7k4HEuCWgf3/hAkoEqAG9MRTOTBjjBW1jGerB0ZIwXT6UDod9QKSe1hBMcHQvVBJvORZoFkAtksacM6G1Bkej1ZMscumH081qZpYT0/jcKc4kj6VZBVSbCrUkRkNCMf1tfGEs/GyQbAiHTBTfVGCON/+2enaEfUQ37gFHUJk2HVh7Tevq0u80IefyKo9VcL0im3zpBhDGdIGAO68kY9Z0J6zaohE+o2ZaFlPeescB9Sa87T5RHUxXRL2vPknUEUNb+JEPTBK5Wr17bF3+1koyx3CsCR/bKSNCGKpFYJNgdqv5x1jFSsaneGjOwW1YmnGHfa3Qo12p0z5LEARW0KlR4iyxx0hFOzj9xl9c5yPZInQgCklVHoTB47UwEh//qI/f4Q1QLXGzjdacVnz9NrEVW2Riiwp/QIKQ4MIhio1GUJ81N0Ajz1cDEVt9evshHFv+r5DAgNbLZgQNNjjktKxreCr1heHr31oH5FSksrzSLmoGyvBtmOcCp7OfexHwxTwZvMAoOgpstrXgwBpnNeAdhRy3vAUpL8oGM7EHBrOX3yZd36JDQh1iI+kV1c9J6+wsrMVJ1/GEsy5xPE6okDn0Qu32/E/646VK2h+otnpz7YV1x/qF8vHirjeHHyIoGlaJEaNyMBSAMV9c2lnAG7BR+NcIBrEjZQY2JBcGnxmSMs WZuu1hUQ 7GIpBQ6M67Tw4JrnTPLvjLzea2X3zWJr/GvPEurWtJJvz0yRd9x3nPcakEajq7AL/57CE/dvz4cnbmfHYBaOPiZSicZiW4hHzYKq7dsp76N9sMhKEaAX+rHRgvo7jeui91cf6BN5EBCF2XAFNYiAOLQRlVHxw+uhdhlZYlRJJH6JXlnUbY7LvACZu5NXhrrEudC1AGUvvqMrnvAU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Qi Zheng Introduce some helpers for dynamically allocating shrinker instance, and their uses are as follows: 1. shrinker_alloc_and_init() Used to allocate and initialize a shrinker instance, the priv_data parameter is used to pass the pointer of the previously embedded structure of the shrinker instance. 2. shrinker_free() Used to free the shrinker instance when the registration of shrinker fails. 3. unregister_and_free_shrinker() Used to unregister and free the shrinker instance, and the kfree() will be changed to kfree_rcu() later. Signed-off-by: Qi Zheng --- include/linux/shrinker.h | 12 ++++++++++++ mm/vmscan.c | 35 +++++++++++++++++++++++++++++++++++ 2 files changed, 47 insertions(+) diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h index 43e6fcabbf51..8e9ba6fa3fcc 100644 --- a/include/linux/shrinker.h +++ b/include/linux/shrinker.h @@ -107,6 +107,18 @@ extern void unregister_shrinker(struct shrinker *shrinker); extern void free_prealloced_shrinker(struct shrinker *shrinker); extern void synchronize_shrinkers(void); +typedef unsigned long (*count_objects_cb)(struct shrinker *s, + struct shrink_control *sc); +typedef unsigned long (*scan_objects_cb)(struct shrinker *s, + struct shrink_control *sc); + +struct shrinker *shrinker_alloc_and_init(count_objects_cb count, + scan_objects_cb scan, long batch, + int seeks, unsigned flags, + void *priv_data); +void shrinker_free(struct shrinker *shrinker); +void unregister_and_free_shrinker(struct shrinker *shrinker); + #ifdef CONFIG_SHRINKER_DEBUG extern int shrinker_debugfs_add(struct shrinker *shrinker); extern struct dentry *shrinker_debugfs_detach(struct shrinker *shrinker, diff --git a/mm/vmscan.c b/mm/vmscan.c index 45d17c7cc555..64ff598fbad9 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -809,6 +809,41 @@ void unregister_shrinker(struct shrinker *shrinker) } EXPORT_SYMBOL(unregister_shrinker); +struct shrinker *shrinker_alloc_and_init(count_objects_cb count, + scan_objects_cb scan, long batch, + int seeks, unsigned flags, + void *priv_data) +{ + struct shrinker *shrinker; + + shrinker = kzalloc(sizeof(struct shrinker), GFP_KERNEL); + if (!shrinker) + return NULL; + + shrinker->count_objects = count; + shrinker->scan_objects = scan; + shrinker->batch = batch; + shrinker->seeks = seeks; + shrinker->flags = flags; + shrinker->private_data = priv_data; + + return shrinker; +} +EXPORT_SYMBOL(shrinker_alloc_and_init); + +void shrinker_free(struct shrinker *shrinker) +{ + kfree(shrinker); +} +EXPORT_SYMBOL(shrinker_free); + +void unregister_and_free_shrinker(struct shrinker *shrinker) +{ + unregister_shrinker(shrinker); + kfree(shrinker); +} +EXPORT_SYMBOL(unregister_and_free_shrinker); + /** * synchronize_shrinkers - Wait for all running shrinkers to complete. *