From patchwork Thu Jun 22 08:39:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zheng X-Patchwork-Id: 13288501 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3120EB64DB for ; Thu, 22 Jun 2023 08:41:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32D9A8D0006; Thu, 22 Jun 2023 04:41:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B6C28D0001; Thu, 22 Jun 2023 04:41:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17EFB8D0006; Thu, 22 Jun 2023 04:41:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0576E8D0001 for ; Thu, 22 Jun 2023 04:41:14 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D649C40B15 for ; Thu, 22 Jun 2023 08:41:13 +0000 (UTC) X-FDA: 80929739226.06.E82A14E Received: from out-63.mta1.migadu.com (out-63.mta1.migadu.com [95.215.58.63]) by imf21.hostedemail.com (Postfix) with ESMTP id 157461C000E for ; Thu, 22 Jun 2023 08:41:11 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Rt6sUHgD; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf21.hostedemail.com: domain of qi.zheng@linux.dev designates 95.215.58.63 as permitted sender) smtp.mailfrom=qi.zheng@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687423272; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d+AM9AbU04XIkkoYvbopAzRmafCipQHXZK8a6yWOVaI=; b=hTdQf3uG8Qyzuw5O9/8Gg82OGs2AB8S7fl1gtVvKlhMFzm0psBs6cv65ynxVfd/lrWdG6t gA1mkj6kWKNZbj0tRJ4rg7hLnqVUX+pADwutmqdykO77d1HUKydu8pQfLLRjmbl4JXv+Je 88ZecEphn4NctnWFaraSmUkNwg5YCWw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Rt6sUHgD; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf21.hostedemail.com: domain of qi.zheng@linux.dev designates 95.215.58.63 as permitted sender) smtp.mailfrom=qi.zheng@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687423272; a=rsa-sha256; cv=none; b=CzIq8vfvhQveDfkRwJCWFX320+gf027lj4Ihm+LQu6KndKIccPVB7auZj3BOgKJhJQly/+ fxB9Fk+Gsgk7l7zBwFx4vxR8cRM0GrHNOKWP8J9QUZatBBPxPmvLeb+EhfUTJpktsxts11 RXCdUi+fkZUyL0AHz+QPgEtIFmryWd0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1687423270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d+AM9AbU04XIkkoYvbopAzRmafCipQHXZK8a6yWOVaI=; b=Rt6sUHgDiz0buDFWoRsy0JmrKjzmMej9/+xDlubVaxRuAM1omPxRfGEiGbO/u++P6qT8OT vFU86inmnxKhzxlFlP/jNKu4tSE/qwVDpnPDU6KzPqJgVzjXg8XwfcJz0tLWWkfVol8igm J9AOSXjRae20nP2HluZSJpqMGnfJGyM= From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH 10/29] vmw_balloon: dynamically allocate the vmw-balloon shrinker Date: Thu, 22 Jun 2023 08:39:13 +0000 Message-Id: <20230622083932.4090339-11-qi.zheng@linux.dev> In-Reply-To: <20230622083932.4090339-1-qi.zheng@linux.dev> References: <20230622083932.4090339-1-qi.zheng@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 157461C000E X-Stat-Signature: 7c19fbcmeeu4u8afjhf8m8zjofis878t X-HE-Tag: 1687423271-999960 X-HE-Meta: U2FsdGVkX19lAwJMJnu3PbqFyynhPcHcyJOoazIy8cy3KZQBl2VC1n4ikUeOUyMfpeLvXePLeAekOd/OzuycL9DKxnX4JLIQL6nnTVawE1ms1NWupF1qE73e/lW+Tqf7a8KRtgg2Oisy824CKGjYKU00gotAXm+jEy3Ju8Omw+CYX0xF9/h2SBBb+HhkEeUG2j4LivxjvBqjAKae867SeGc9j4GkYb9eykJ41PDV6li7sWrGAFpexuj9kmHqkgK4ugsSxjtrwLI3VQZ6xlSv/auHCLD5ldzLt33jBUU7pz4HAl9Ca5VOM3ruunHNHGcBpbyZ7rn3ilJxPSxu4ASlhoXaHfiLjKhJzaUSunniX5CuN5VDAk6sXeTu145tFIg+KJCwfiWFXDpavesqTI/gjqo5OCOkt3j8eattCEw8jsc05y8mmFwJpyQtAhixwH9+j887alKZZMRur172G/WTd48nCMrzXYpAdAzAJOiefU5zQeFk6Kgv10m0h78x2/BMHt0tpW4T2iOH3QuTREhWmi7k3hADkgRb5iylMT7e1HX8qMTxQYD+eIJIB/nxvJ+7ArznIT88/A92gArjSumHBDHsnusF5/7RjbejdEdR9pUezVTOA3VhOWHuRLexAIJgcDuCSoS4LFnaPQJG1jDLkjllTNBR8EcjPg2FXDBUFE8hquCdN5xBHsfSvTBi0rOnkQKT0RjFd7QonyZIczi7ACtL7rKlNzOy4c10D3886+S76pbCHkWjrQvOwk2JaEHw6XEUcwjIJIgXiv9bkaXYvzScJFHOG1wylwKMAbN3g/WtkQptcFYmJD9DBqRE6zYTaZv6KgGMIh1zcs3swZlKQ7xo/PNMr7NUd+1BpNvwhg6Eebg3GD3g+BvJq9TFUBzQbZnmHAN+1WnbYqJ+2SxagItPY/XujzBi22XJrL+aNNbo0g/vJuPwWjF1aRdzLj5DMgJdFLwlthDxHWzIuGd HgPaEokm dJsvDYcWHLuAzfnavbw2mzfm9wOTUIqzzEY7+baiqmGUouiPwwVp9LGOVUreX/9A8tiY/X++wzmsYjieoTgVBNI3LFWrYQk0Z4Ww/ZiQSTofJlA60waR2rKlLz4Wa6MaxLQYENRopbSo2KUZB862HPbBy9/z8qndDJih9QzazY1fHM0O7z07yhVIJ3A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Qi Zheng In preparation for implementing lockless slab shrink, we need to dynamically allocate the vmw-balloon shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct vmballoon. Signed-off-by: Qi Zheng --- drivers/misc/vmw_balloon.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c index 9ce9b9e0e9b6..2f86f666b476 100644 --- a/drivers/misc/vmw_balloon.c +++ b/drivers/misc/vmw_balloon.c @@ -380,7 +380,7 @@ struct vmballoon { /** * @shrinker: shrinker interface that is used to avoid over-inflation. */ - struct shrinker shrinker; + struct shrinker *shrinker; /** * @shrinker_registered: whether the shrinker was registered. @@ -1569,7 +1569,7 @@ static unsigned long vmballoon_shrinker_count(struct shrinker *shrinker, static void vmballoon_unregister_shrinker(struct vmballoon *b) { if (b->shrinker_registered) - unregister_shrinker(&b->shrinker); + unregister_and_free_shrinker(b->shrinker); b->shrinker_registered = false; } @@ -1581,14 +1581,18 @@ static int vmballoon_register_shrinker(struct vmballoon *b) if (!vmwballoon_shrinker_enable) return 0; - b->shrinker.scan_objects = vmballoon_shrinker_scan; - b->shrinker.count_objects = vmballoon_shrinker_count; - b->shrinker.seeks = DEFAULT_SEEKS; + b->shrinker = shrinker_alloc_and_init(vmballoon_shrinker_count, + vmballoon_shrinker_scan, + 0, DEFAULT_SEEKS, 0, b); + if (!b->shrinker) + return -ENOMEM; - r = register_shrinker(&b->shrinker, "vmw-balloon"); + r = register_shrinker(b->shrinker, "vmw-balloon"); if (r == 0) b->shrinker_registered = true; + else + shrinker_free(b->shrinker); return r; }