From patchwork Fri Jun 23 17:07:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Wilcox X-Patchwork-Id: 13290834 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FB86EB64D7 for ; Fri, 23 Jun 2023 17:07:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7566F8D0002; Fri, 23 Jun 2023 13:07:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 706D18D0001; Fri, 23 Jun 2023 13:07:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F5638D0002; Fri, 23 Jun 2023 13:07:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 50B308D0001 for ; Fri, 23 Jun 2023 13:07:47 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1113580CBD for ; Fri, 23 Jun 2023 17:07:47 +0000 (UTC) X-FDA: 80934644574.13.A1D0D84 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id D05572000C for ; Fri, 23 Jun 2023 17:07:43 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=e5lTG91l; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687540065; a=rsa-sha256; cv=none; b=ZioY9SnWc+GWOQREhVsp+pkNloi5jhkoIcoyVg7jSRPRZoUhms8i1mv5RVYQb6LY1GwydZ xL8nqEZcCYm/ZEauSKkX/F9Zt1X9SRztoBvIyuUFG5LV0+Zq7yhz5CpxYZv6gnO8kXvmEB xw7cdByNdsHH+WrHNbgJVboQ072hijU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=e5lTG91l; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687540065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=02timQVtu6aTaDZlo3R3D4w+fsAbkYRbfC53CEOsKBw=; b=MmBIZRmaQEpaTrkY3nbvMelyd1dtGD7JYUJmxTf6nvcZlZ8Ie9hum46dKUBAqlCiyl0XOB v2XtR+4lhivuyqgZLKN4B3Ba6P9BYUD9sfCnq8Sz1dNNFr6GEXja8iSfAe9Ct3Cb87AIvb gIShtEw4RLfSpf4el1DxJn8Zc8sxf14= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=02timQVtu6aTaDZlo3R3D4w+fsAbkYRbfC53CEOsKBw=; b=e5lTG91llhH4wWPjAixCgHASoQ gEle+9UxZ6FBfNOKYQG5tbXufVqeX2JO/BNMifZCSCFBf+Eu+u6KxoYOmP7zTnftJyD/f7PuJAfO+ GhBUJKrVqcLzsJzVrH2HyzuFShUiMSqkikpXxPKcT0/0caDupaOYyKzNzwb6w6jCU7dOb1+brYkY2 WgmpzocQzziisZKh986bzrE0Vz6Cn7SfuzwKH0EFww5gkSfJGjAPX7lddtAAIOiWrC4NxRFfVr8/r XNf1aSU/OI5IhQuHwb2yQL9iaD+fQ8BY8EYj4gBjtT1CVumUxqG7z9c0fWEkomcqJIrJSgJGZ7Pcd xd38NNSw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qCkG4-00GdfI-Oa; Fri, 23 Jun 2023 17:07:40 +0000 From: "Matthew Wilcox (Oracle)" To: Andrew Morton Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: Fix sparse warnings in backing-dev.h Date: Fri, 23 Jun 2023 18:07:37 +0100 Message-Id: <20230623170737.3965705-1-willy@infradead.org> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D05572000C X-Stat-Signature: aue9dbybhncdqrbu5dxqdcq7caws7q1h X-Rspam-User: X-HE-Tag: 1687540063-328475 X-HE-Meta: U2FsdGVkX1/872cHEtalJe98VjlVfrBnUwfRJ6BnDAdFrW6ZhIJfzMGjNf1M4MCYKA8d6HOI3d4WRgRHqfWJ9YqPZw581vUAtGHSKjaR7AmH0vlC2ze2FaGGcl21ldDvV8SSJJ2p8sbGMRKfeeaqlrVJantVNRf5uhUAhBBcri6DXvjYV1fqtPumamz/KVroupfn4DUWcNF8ddO8jNhq8frDWwTdroT2RXRs8nhD4Az6QM0PaJvRhgsq0VuFOMsBf1lTkcuokB7emWxwdaxWo9zDAYHe2FR022y53RykGjufIHJWixrKvi+kJjAZEP8ro/iPJYoz6cvEE/Urh4568aYJy2oMmYqseLDjiuO/0nP2NWyp1imhMo0wdAFHdJEVGHuYjSfrjiPZV88TfAr6/qLJEDyqFpwk+tRlnAANiu89GMiOp2aKDbqP1w6W6SXQLShriyHe5JoGjlY6BhzZn6jpIvpZduA4J4NHN4ax+VhoRKVYcXlo5n2X5D+V/JnPVvJWkKym40CH7eODIknpidETaRyPuLxds3IOB280//KSfsnmoJdfBxukrjoWCaSDWY+Dxm8YIabDgn+PNjJHAIRlwEA7mmqtT4bMRLua/ReB5UuLlPJtxnQRRUJkKlTXO8sExdLgCYoDvfs/LPtLy9uD7KURdNBIXKdZ9aDGGDhSaXTHGASBAQVJT2OvsepMwm5CCZSJqw5qmxOMbiNMDps6R/pfUvvsP9C85TWKj2GfUuM0Lj38UXlus5fkKSrAUB91Kf/AYSiy+iYoQ1aB3jze/NDWePx2Hj1FVHizZ1NrMB2PCFEF7NAKGhFYTQ1dhQ/LuVdFg4mD2wgNASvaARm6PiuVkHvjIFWGfxG5XVUHSChoVGfC/O/+uF6th2dNvlqcOBtegUzjGYbiqR/gW079MaZfi2STUX87Ugwzj+HWC9aKCYp5M7sfOQ8sYTngrWexsFaxiHLgHdigg8G SsCUDnge o/qc9mBK8DWqB4ZXt1q3ht0MohSSxWNd/HBrdIPPBepeYafE8AehwkBkJCFhgh08RLg2Fxvt9X/MGdLsDzVrKPuHY2cwe0/tY95y04Gor4HjQl4vdVoiBUdWQXD7zOK2ASFiz1Fo4mppWYitGn5WdmkTbN/jIBEPGwN68ZDeKrk1O9uOVecL+ROKt6g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sparse reports a context imbalance, and indeed _begin() returns with the RCU lock held and _end() releases it. Reassure sparse that this is fine by adding appropriate annotations. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/backing-dev.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h index fbad4fcd408e..69bb13412a3e 100644 --- a/include/linux/backing-dev.h +++ b/include/linux/backing-dev.h @@ -284,8 +284,9 @@ static inline struct bdi_writeback *inode_to_wb_wbc( * can't sleep during the transaction. IRQs may or may not be disabled on * return. */ -static inline struct bdi_writeback * -unlocked_inode_to_wb_begin(struct inode *inode, struct wb_lock_cookie *cookie) +static inline +struct bdi_writeback *unlocked_inode_to_wb_begin(struct inode *inode, + struct wb_lock_cookie *cookie) __acquires(RCU) { rcu_read_lock(); @@ -311,7 +312,7 @@ unlocked_inode_to_wb_begin(struct inode *inode, struct wb_lock_cookie *cookie) * @cookie: @cookie from unlocked_inode_to_wb_begin() */ static inline void unlocked_inode_to_wb_end(struct inode *inode, - struct wb_lock_cookie *cookie) + struct wb_lock_cookie *cookie) __releases(RCU) { if (unlikely(cookie->locked)) xa_unlock_irqrestore(&inode->i_mapping->i_pages, cookie->flags);