From patchwork Wed Jul 5 18:12:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Valentin Schneider X-Patchwork-Id: 13302576 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B482C0015E for ; Wed, 5 Jul 2023 18:17:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE82D8E0003; Wed, 5 Jul 2023 14:17:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C73DB8E0002; Wed, 5 Jul 2023 14:17:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC4E48E0003; Wed, 5 Jul 2023 14:17:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 95D5A8E0002 for ; Wed, 5 Jul 2023 14:17:04 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1F07DB054C for ; Wed, 5 Jul 2023 18:17:04 +0000 (UTC) X-FDA: 80978364768.05.F365F19 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 225DB20018 for ; Wed, 5 Jul 2023 18:17:01 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aiPqgkKg; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of vschneid@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688581022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QCdKg/xbfvFvfuEOm23BNeuog3oDcFdsQXIARij7I9Y=; b=5+CavtQLZT+uxWyWvlhQ9M8Wi2wNHe4sCg022BxBIpiBBh9dCnSGZPqeZpKZZ78/fztBL/ OBv68Y9lQwCt6gLfyr0k6FlfYr63NPL5+0VdvUvQxYcVh5Att0TlC9OEMlvSJOIA1PgODO OKP4ky/0tgnTbN90YG5hEBsmoMUJd2I= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aiPqgkKg; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of vschneid@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688581022; a=rsa-sha256; cv=none; b=rfPcTnkUquLZQ/S2ygbUBnBOePm2dKGIPQUHeWxDvR3YKMPeQrdHq/GAYt0SvAE0gIrioa 0wLK92qiNnJVElOROVokMvy9n2C5N4UD9e0GAbvUULSxbL15Y9ZWnSJ9kUmC+nwKRWyL/X 1qh0rOdE4UuHO0c/2RFqmB7wUOq7aEI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688581021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QCdKg/xbfvFvfuEOm23BNeuog3oDcFdsQXIARij7I9Y=; b=aiPqgkKgRy9eHlAaYPclG316HcHz+0EnFImAgF6cGLmoUaISTQ6zbeIoDyLKeYmtprrmdu Ltmd5XtDXmVNHYRMD7dU4oka+P1nAyMhJrE5k9ZjHYlzJKklTx0uVji1yFt7L7J77oixP1 bDZqAziN/qkqoKAvxExA9evljKAcNxk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-108-UhoNqooBN1GAazRibK82Gg-1; Wed, 05 Jul 2023 14:16:59 -0400 X-MC-Unique: UhoNqooBN1GAazRibK82Gg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E89FD3C108C9; Wed, 5 Jul 2023 18:16:57 +0000 (UTC) Received: from vschneid.remote.csb (unknown [10.42.28.164]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E7BEE18EB4; Wed, 5 Jul 2023 18:16:52 +0000 (UTC) From: Valentin Schneider To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org Cc: Steven Rostedt , Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Josh Poimboeuf , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: [RFC PATCH 10/14] x86/sev-es: Make sev_es_enable_key __ro_after_init Date: Wed, 5 Jul 2023 19:12:52 +0100 Message-Id: <20230705181256.3539027-11-vschneid@redhat.com> In-Reply-To: <20230705181256.3539027-1-vschneid@redhat.com> References: <20230705181256.3539027-1-vschneid@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Rspamd-Queue-Id: 225DB20018 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: k97u55q664s6gr91jjtweb3ibd85pg9o X-HE-Tag: 1688581021-192362 X-HE-Meta: U2FsdGVkX19VRph8lD0w61QqkEjgrag2tWJnJ0BfOA50X5B51vZkWkiOEM+ZCM/k8juUIt/UuoERPIG3Dkl16BfwNIZ61kJ5fa09DdhIaJ6/6NxGn5wYgFC1K1/UvOKi7THL+d/hKNqZpUjUh61iRe+ddq2t/Ga+oPsdjP0DXQRlb197ELlu3e5SE3GklA15X+1pGoQ1R8qrZR52GvdsrR0KdeOR7CZcOSpgQhDq883uMep6KU8UM3IrcX4Y/UJXF56cRUZlDzL5BqKFyZWfsc5f//VPd8SVw13oBVAkK43KqTCQmxSn49X+9rYtVgYq8hpGIXfP1fI2vSTOWNEZX3WY+PFpSuYOXAuThUvwNdv34hUiChdlGhp5QoM6EIfiw+Ou/+DsZMfwg1EQJncXUvhFMveVFwCsc5YkteyXRiWTJDfBS2jWIgoHLk37qgdoEuNui8owAyWOqbJ5SrFzxpazXLSPxEpwZUBbYVmAppIprmxkMsyofkJOuta4kLWqAlAXoDXp1TqEm4X+eWsUPrPuRZX5I2Dae2uwU09/WrzYvVeeCV+2teSkZluFebZmt3W6sM0+CwiVGOKRcGcDfzdt9ACfskVGcGnb3jyuMJXQkUVAf4NIXSo8XQS3VAriDGyx32ahE4llrH1eBWGgLy6NfUt8GEIMKm9UEhk0XHsQGvJvvBXfjeZbgvj9lXo843hbKKXEVJWo7F1bzOTnsQDaTajExYB1aEP/OBfGabV7gDKITPI5BuykWzp/6NmsHrNhNB8mXQYf0e4NzxDuOBK39hqW00NO9plYmlDhEsmKZSEFuVDCPD8j7efIPx3IPVoi2XfSo4K7Z2ZvQqzxfEEKHpPidBviL0aMCVo8hSnnHtleOujlzA0gdVgQSwDEgapDe7wVN6Jrx6aSEavPRBXYo+RYOOZfyHrZqAiOb3zQC6wQ+/glaYk2wqeu2zKKmYt7jiXDUYVb4jny53d jqHsyvU9 Da+os2Qf5EQTx0qVJhpGFzyi4oOESrTBNvkf8s1gMPD34sS3VhIBh8UFkCGAl3uH8203S5+F0kDpRiT63btah9XEqvlAjihiyMUAkmQN1l/FB89KLu49qLzWBWXullDEGtD4NK0q8Tjws/DipGIvT+XRzjqV7IMF8+oLAlufJQsnDi5bdE4FJNYhqg+Jctdm0Vt6qFw3lmcBdcTytXU0pO2krf8nLwl3S/rDl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: objtool now warns about it: vmlinux.o: warning: objtool: exc_nmi+0xbf: Non __ro_after_init static key "sev_es_enable_key" in .noinstr section vmlinux.o: warning: objtool: exc_nmi+0x4d: Non __ro_after_init static key "sev_es_enable_key" in .noinstr section vmlinux.o: warning: objtool: exc_nmi+0xc: Non __ro_after_init static key "sev_es_enable_key" in .noinstr section The key can only be enabled (and not disabled) in the __init function sev_es_init_vc_handling(), so mark it as __ro_after_init. Signed-off-by: Valentin Schneider --- arch/x86/kernel/sev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c index b031244d6d2df..4178e18383232 100644 --- a/arch/x86/kernel/sev.c +++ b/arch/x86/kernel/sev.c @@ -113,7 +113,7 @@ struct ghcb_state { }; static DEFINE_PER_CPU(struct sev_es_runtime_data*, runtime_data); -DEFINE_STATIC_KEY_FALSE(sev_es_enable_key); +DEFINE_STATIC_KEY_FALSE_RO(sev_es_enable_key); static DEFINE_PER_CPU(struct sev_es_save_area *, sev_vmsa);