From patchwork Thu Jul 6 17:58:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Azeem Shaikh X-Patchwork-Id: 13304037 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2782EEB64DD for ; Thu, 6 Jul 2023 17:58:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F4646B0072; Thu, 6 Jul 2023 13:58:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A4BC6B0074; Thu, 6 Jul 2023 13:58:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46C4F8D0001; Thu, 6 Jul 2023 13:58:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 341916B0072 for ; Thu, 6 Jul 2023 13:58:19 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7CB311A0C8A for ; Thu, 6 Jul 2023 17:58:18 +0000 (UTC) X-FDA: 80981946276.23.DB21AB3 Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by imf11.hostedemail.com (Postfix) with ESMTP id 8A40940004 for ; Thu, 6 Jul 2023 17:58:16 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=OWnTn31n; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of azeemshaikh38@gmail.com designates 209.85.166.50 as permitted sender) smtp.mailfrom=azeemshaikh38@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688666296; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=JxZ6vfHvXf39QbafRxcNDYjeiJshVCIJaiyxL7XtpQA=; b=kpHZPezASrubjYoWx8e3Bd/dVTT2cKSYbW9C6Q2YgUrZ+P4HXfYIdl4puHGqo6USSMHO04 YhG5qBpkTK21yym5B3kBXv9G3lRGU7XBaMIY7p+vFqGOkOvKteHprpft+M46P0Z419KtBp y8c8aw4MMlldLu493feAzh7hUQPlSN0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=OWnTn31n; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of azeemshaikh38@gmail.com designates 209.85.166.50 as permitted sender) smtp.mailfrom=azeemshaikh38@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688666296; a=rsa-sha256; cv=none; b=KQViz0JtIiUetBX/VOilD5dcFZRuTRduoOG5GbEbV58lCULN4EfQ0v0IykJDGxb7OZ9Hmy TS6rylJ2hA2y4Xl5pgjshbrZSTTYSauxZ7lanmg3ugVujuP4FOUPEnl2jio17MzqXtuxtx PPsJROxnOXloEQHtNkjXGsRrp2X1QyM= Received: by mail-io1-f50.google.com with SMTP id ca18e2360f4ac-78362f574c9so35943339f.3 for ; Thu, 06 Jul 2023 10:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688666295; x=1691258295; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=JxZ6vfHvXf39QbafRxcNDYjeiJshVCIJaiyxL7XtpQA=; b=OWnTn31nuWCSI4rU2SYwsjX+Om77s/G6+5jLKR2h/bHP1HEeXMy0wlsg/GMmh3ZtJU rnuuz6LKJnu3BErQc6QkZUnPbi2G5p2EaXFVRa2XUoq8oRN3BWsbyhM8c/wUxM4KK/N9 65DQLGILGfvKFi6Z1/+V7LYc/9bgwXS4W+rnXc7pQLdPduqKQFsEU+YlZNeFXp5Rb/dA sQ/iNsuYlgrldPQe0tWe31Bjl6pP/ulALdEqK/71IFGEm8HXiCsks4XR/05WTZc9Ftz+ sVyiQxhhx67Fruy6ppOeUIXcsrnTrK+nlLxJaHXIs53Fi3s3u8CkNPwiRaMl/qBqihQ6 9NbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688666295; x=1691258295; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JxZ6vfHvXf39QbafRxcNDYjeiJshVCIJaiyxL7XtpQA=; b=BZ9A2Y+BM1A+JZtlbct6YbiqJPQBLRDkASEBqtLkDGCgx1RI2PxfGW6vap9ba0g8td wuDJPVrzONf6nHT1yfIIsSyc8rz7IroMdapjiUzQIGY+EZxumbFpaY3pXxIbBj8izuCA 4jlI+q344j3hawLWYIL+KAAlTQXjDwc7QbFd3OlloR+LehHMlO+zAb4UJr5NSiQL9DrI NEkydKgq2vpyhnE8YUTfCVUfdFafxKnrdK8y/2Cugu5kmuGxSHqkgFCmE/s1DvkbSknr T4Pr6ti4DMef8tn2/IBmS2F1EVIg9IrIuiTD4QCPjW3feR5yvBO0Q7V3idVv4BbFWa59 IzHQ== X-Gm-Message-State: ABy/qLZRp7y5lMwYV+Sfshn/ycdG/819rBl/HXXUy2d4EV4iz2RDiueT 5I2c/9aa0ZsUh63DghC0PWg= X-Google-Smtp-Source: APBJJlHg8HsoyIl8oK8bHyAx8asRYDBps+i8gOope6rvLtEddzu1qCT9IPPHraJFmnKu0jHfpwl6/A== X-Received: by 2002:a5d:9bd0:0:b0:786:cd9b:1ccd with SMTP id d16-20020a5d9bd0000000b00786cd9b1ccdmr3168930ion.0.1688666295453; Thu, 06 Jul 2023 10:58:15 -0700 (PDT) Received: from azeems-kspp.c.googlers.com.com (54.70.188.35.bc.googleusercontent.com. [35.188.70.54]) by smtp.gmail.com with ESMTPSA id s24-20020a02ad18000000b004249d9e81besm633683jan.131.2023.07.06.10.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 10:58:14 -0700 (PDT) From: Azeem Shaikh To: Andrew Morton Cc: linux-hardening@vger.kernel.org, Azeem Shaikh , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Kees Cook Subject: [PATCH] EISA: Replace all non-returning strlcpy with strscpy Date: Thu, 6 Jul 2023 17:58:04 +0000 Message-ID: <20230706175804.2249018-1-azeemshaikh38@gmail.com> X-Mailer: git-send-email 2.41.0.255.g8b1d071c50-goog MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8A40940004 X-Stat-Signature: cuez8bc1bxch3jqpy8fp5aqcsunncri1 X-HE-Tag: 1688666296-401902 X-HE-Meta: U2FsdGVkX1/vM9lzDapOtmFa2JjeIelGqbfjWVjfyZSRz+wfPzl1Wq9LY+TBbstyHj8x308Ra5TwnJkRIt4tmOp+gLs4tdDah5Gz3yiq3BGZIbvTDuoOyZGWhw5OBGnrZil4V62nrhmHgvKPOYlr0p1LJiFsvxcKcilb2Il0+6wqKD/xEG3pi+uVZ4yRVIlt/AG2xqV2A5X7PAuwoSOwHQuDMGMG0UnPt9rOb1Ydoova4jhMxSCKraZ05JYBHktkN5U5zcUunjRKvjQs0Q99ZvI73uOC48HbpEQ70kSty2KT03US/L7USoIr19duBC20yHKBEbFYCZt1+7PyOR3p2SLeMFwtXXAfc56kFMqQXmld4HsBjzreM0b11/TMKD3jrk2k39/v/eu+etUowQDJBDK4n15Xc2Cf29dR1yOkpwgvLGlJvC9x8Q61ykXKuQjsLKfaB1bHeM4tNQJ6w8Jvd0L2WIzoKw7hXW1T9OWEAEXqyJh+7LtWu1AXnO8yjHjIyStpCMg8aRHY/629ytfV5TFPJnKYmb4FixOgUfSVN/bGBuDGMSQbWquVdJlfpC8Olyws2G3SQxIUemA6Ou6eIrUE8M9AJqOZLWUxziP8PlEQuFYNnInX2FFOTIQKWpsKcO8zbal5ngbQdI7WClIw4WiR6DjTdJ2AM4u/88STJw1NNukL0J+klHhlSwyVvFDsnpqvUEaMznrQ42Y79O2Z0Mu2oodxcEkQpXJpisa6Imod4n+qUPExd61LH46mmmH7ifM5J2R8t1UtS9xvyOlXdMXfl5LXskPyuerQVGupsgjfypSA1XorVit5kDBZ0TtEywdcRAuL0tJww9vRxyggkkDxF4OZl3hZ0/2rCA5H25GZhwKktSN+AUAr9DTaTS22dZwS1axkppAS1LeJmJwYwBvpTw/riUeIiOYuKooYS/AV1ltkLE7h8SY5hxzb6VLLz3Au6ebA4gkxJ7qB27e q+GbfC9G aXyR/e1mgCN9ENen3rVMtmz9wvsEM721hwsG+Pfxpj7u3tBiiWBQeGlmc1/mHGbdq3UhsmC+74QNoou4iMm9CxHgEG0iQF2RIxQJZ9tJ5sTiGycGFCuBpAUqk+vLAhXSnn/dUdsfgo9Nk5uvFGtw866Yef8XT1+OBPGTl5YLuByvlkPNUCYNwEcNjGVM26dvpF5LZ7CD4BV7rHR8tzI6lUaV1qvfkUDdmlBleG3AGIS03xjjOuNCFBTnZZX/Ae3AEt6v2xu0v5/qT/KnL2YPkqbyeRpK1GasaWFwIxlecZOj0uvrqS5L8mFeiFqYxP8lgu5lBM2Bg0vixcoGW+SrPqmwwvteBRHXb6Z/2ksyvofmg21TMOCZ5qZmEbNNFcpMFXOlThVvuaHnqwA24TxKeUQ67iGwMHyiVyeDyuFSlkCPB0yhUVomL8WsQfK6OuK6TKK85V/+bzpxfTFWk66IsXeGjznSlY9JY0d/XyVCAWe1tSQoHhTaR0adpQGy91MA1n66P+LD5yBVB+UQrPgCEvGPYdU7S7EkvmTpE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000146, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] https://github.com/KSPP/linux/issues/89 Signed-off-by: Azeem Shaikh Reviewed-by: Kees Cook --- drivers/eisa/eisa-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/eisa/eisa-bus.c b/drivers/eisa/eisa-bus.c index 713582cc27d1..33f0ba11c6ad 100644 --- a/drivers/eisa/eisa-bus.c +++ b/drivers/eisa/eisa-bus.c @@ -60,7 +60,7 @@ static void __init eisa_name_device(struct eisa_device *edev) int i; for (i = 0; i < EISA_INFOS; i++) { if (!strcmp(edev->id.sig, eisa_table[i].id.sig)) { - strlcpy(edev->pretty_name, + strscpy(edev->pretty_name, eisa_table[i].name, sizeof(edev->pretty_name)); return;