From patchwork Sat Jul 8 08:57:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaohe Lin X-Patchwork-Id: 13305636 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E24FEB64DA for ; Sat, 8 Jul 2023 08:57:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 048B18D0006; Sat, 8 Jul 2023 04:57:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE0CE8E0003; Sat, 8 Jul 2023 04:57:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABD7B8E0001; Sat, 8 Jul 2023 04:57:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 886678D0009 for ; Sat, 8 Jul 2023 04:57:39 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5D9C6120141 for ; Sat, 8 Jul 2023 08:57:39 +0000 (UTC) X-FDA: 80987841438.18.377C193 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf12.hostedemail.com (Postfix) with ESMTP id 2AB4B40009 for ; Sat, 8 Jul 2023 08:57:36 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf12.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688806657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4zvreph+WtV4FNPz7Sph1CKBbIMj5dh6CNbYbbIKYXM=; b=mOSKJxQjMiFmo0xepBU3lNhIEVqDh/tNDfWPXOcCwUko7ZQfUQ/0yGR8gB/0MGgrbdWp8e T40K8JdoHMKoCn8Vdfp36Zkjqfx0UuKS0+IJhMlAF2gIzJfYhLFRyE1oJ5VYvxebNiCzrO RIMgZJRet/8T8CI94OG0/fG12l5uVz4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf12.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688806657; a=rsa-sha256; cv=none; b=Iv+XuU6XYqsXIJZMo8edgxIG7Pu2VsD1K2u1X9LE7p2VebaANk2ry1XCH7RT1KyIx0uJtC HbF/rG/692YayqMn4dpmASteCG65BYSy5T7oPmFulJfloiEgnJBKpLfOVk17Em0mWNcPIm 4hC89ZKIKsowSfkOeoxERLDjWgzamzY= Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Qykbc53xHztQnv; Sat, 8 Jul 2023 16:54:36 +0800 (CST) Received: from huawei.com (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sat, 8 Jul 2023 16:57:31 +0800 From: Miaohe Lin To: , CC: , , Subject: [PATCH 7/8] mm: memory-failure: fetch compound head after extra page refcnt is held Date: Sat, 8 Jul 2023 16:57:43 +0800 Message-ID: <20230708085744.3599311-8-linmiaohe@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20230708085744.3599311-1-linmiaohe@huawei.com> References: <20230708085744.3599311-1-linmiaohe@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2AB4B40009 X-Stat-Signature: etey6dagg7x943ymijkrdwh96haqjofi X-HE-Tag: 1688806656-29082 X-HE-Meta: U2FsdGVkX1/zAp3mRB1IS2RQveL0eZ367RLK4dilwpuswuEwdl9ok2Zv4gVc+Ixwb46G1m/bi0cRkKegx5ZIAXuKkZmpPSw00wTzZwxIeRPWjKWOlfVSqeiX3zgDTTOqKxjIiDgXRyPOV6ziHyCbax1PGHO8adT5vMat/cyJALQDMnLBI7xbVbAEaJGwCte86YICayzKzfvt4GwMicCqZBBd9rXv1BsuF997ZVzdy1dfeikr7u5DrKe4fJ6PnALC+ve7O0vpCka9lZWrUzUCOJben+bsDgL+N811aEGMlePRCb5ohUHfiX5xxmJJatM7fSMLDLs45kkBvlSrLJnxpmBqdDkPCOAbdgKle6hyZ23jOq1hFA++uPex3T+gJEifw4kgwDrH81FpoB9PEycmj5inzV2z7Nyx3w7hpU81+B6a4RqE6Wv2KuD5SqdVhCrY1Ibuc2iMKvMpRDqj4uo2pU27/lKwEXExxI0R/QDIPP7e7XSpmfsr/vOjCTPkPiNhreKuGRxzQTVMC+IPggfdHyEGPuyYT7lp34n9zzhezJLZPWL4/EyXMgwK2iQYL4ie9kMSak6GSdQ4lZS7wBAal3IEzTmk93u7xmQOWuLsCzdjFLCO/ntZYq/bmuyi1g/ozXjZfBgoYTkjg0ZfQNceFMR46oE7b1eLAZBXhZjpVUNpKwXgTbJf5zALbNKMjrcDBdGDiMWZU9/7KdBccMcsXZHaEWsCwbgyo107dyaaXB/lWDrnKDzeqaPnnzhtzkgrmoyq18+rrLSG98yqMiHlL1M0onOGjk/O3tNmjfGO6vrUsqicMDHcNLXQyp6QT9WBpfpzxqn2tUdecXtMWuwnTybEwNtoeSsw/DKs2H8/gmqBSuKvZfZMUw9pvayXlMUNK9KfGa5BEesH1meMvn9g2+LnKMu09HLaNC/iFVEtKwXkU9b0jCb090cnuwZyzGgP3E1nUCLN1khZzCO4VyH 5i+61kiF HNTu5qUPWH4/mgX2WDIjijtcrmJh0fYT5wTIBE8aTjFSX7SAx2Y4vW4rCnTD9Kt4Vfwju5d7HR7NY9sK/dE8fh6wLXqBpZTXlzBJU2maSrJBu5XRHy5ccd5mDwKg+jEuIbKRevvv4/dWxr6U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Page might become thp, huge page or being splited after compound head is fetched but before page refcnt is bumped. So hpage might be a tail page leading to VM_BUG_ON_PAGE(PageTail(page)) in PageTransHuge(). Fixes: 415c64c1453a ("mm/memory-failure: split thp earlier in memory error handling") Signed-off-by: Miaohe Lin Acked-by: Naoya Horiguchi --- mm/memory-failure.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 0f93175ed862..76d88d27cdbe 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -2179,8 +2179,6 @@ int memory_failure(unsigned long pfn, int flags) goto unlock_mutex; } - hpage = compound_head(p); - /* * We need/can do nothing about count=0 pages. * 1) it's a free page, and therefore in safe hand: @@ -2219,6 +2217,7 @@ int memory_failure(unsigned long pfn, int flags) } } + hpage = compound_head(p); if (PageTransHuge(hpage)) { /* * The flag must be set after the refcount is bumped