diff mbox series

acct: Replace all non-returning strlcpy with strscpy

Message ID 20230710011748.3538624-1-azeemshaikh38@gmail.com (mailing list archive)
State New
Headers show
Series acct: Replace all non-returning strlcpy with strscpy | expand

Commit Message

Azeem Shaikh July 10, 2023, 1:17 a.m. UTC 
strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
---
 kernel/acct.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.41.0.255.g8b1d071c50-goog
diff mbox series

Patch

diff --git a/kernel/acct.c b/kernel/acct.c
index 010667ce6080..10f769e13f72 100644
--- a/kernel/acct.c
+++ b/kernel/acct.c
@@ -445,7 +445,7 @@  static void fill_ac(acct_t *ac)
 	memset(ac, 0, sizeof(acct_t));

 	ac->ac_version = ACCT_VERSION | ACCT_BYTEORDER;
-	strlcpy(ac->ac_comm, current->comm, sizeof(ac->ac_comm));
+	strscpy(ac->ac_comm, current->comm, sizeof(ac->ac_comm));

 	/* calculate run_time in nsec*/
 	run_time = ktime_get_ns();