diff mbox series

mm/mm_init.c: mark check_for_memory() as __init

Message ID 20230710093750.1294-1-haifeng.xu@shopee.com (mailing list archive)
State New
Headers show
Series mm/mm_init.c: mark check_for_memory() as __init | expand

Commit Message

Haifeng Xu July 10, 2023, 9:37 a.m. UTC
The only caller of check_for_memory() is free_area_init(), which
is annotated with __init, so it should be safe to also mark the
former as __init.

Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
---
 mm/mm_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mike Rapoport July 11, 2023, 6:19 p.m. UTC | #1
On Mon, Jul 10, 2023 at 09:37:50AM +0000, Haifeng Xu wrote:
> The only caller of check_for_memory() is free_area_init(), which
> is annotated with __init, so it should be safe to also mark the
> former as __init.
> 
> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>

Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org>

> ---
>  mm/mm_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index a1963c3322af..a313d1828a6c 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -1737,7 +1737,7 @@ static void __init free_area_init_node(int nid)
>  }
>  
>  /* Any regular or high memory on that node ? */
> -static void check_for_memory(pg_data_t *pgdat)
> +static void __init check_for_memory(pg_data_t *pgdat)
>  {
>  	enum zone_type zone_type;
>  
> -- 
> 2.25.1
>
Anshuman Khandual July 13, 2023, 11:21 a.m. UTC | #2
On 7/10/23 15:07, Haifeng Xu wrote:
> The only caller of check_for_memory() is free_area_init(), which
> is annotated with __init, so it should be safe to also mark the
> former as __init.
> 
> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>

> ---
>  mm/mm_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index a1963c3322af..a313d1828a6c 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -1737,7 +1737,7 @@ static void __init free_area_init_node(int nid)
>  }
>  
>  /* Any regular or high memory on that node ? */
> -static void check_for_memory(pg_data_t *pgdat)
> +static void __init check_for_memory(pg_data_t *pgdat)
>  {
>  	enum zone_type zone_type;
>
diff mbox series

Patch

diff --git a/mm/mm_init.c b/mm/mm_init.c
index a1963c3322af..a313d1828a6c 100644
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -1737,7 +1737,7 @@  static void __init free_area_init_node(int nid)
 }
 
 /* Any regular or high memory on that node ? */
-static void check_for_memory(pg_data_t *pgdat)
+static void __init check_for_memory(pg_data_t *pgdat)
 {
 	enum zone_type zone_type;