From patchwork Tue Jul 11 07:54:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Ghiti X-Patchwork-Id: 13308222 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30276EB64DD for ; Tue, 11 Jul 2023 07:57:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B62638E0001; Tue, 11 Jul 2023 03:57:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B12518D0001; Tue, 11 Jul 2023 03:57:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DBD98E0001; Tue, 11 Jul 2023 03:57:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8EDC08D0001 for ; Tue, 11 Jul 2023 03:57:43 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 60C8480148 for ; Tue, 11 Jul 2023 07:57:43 +0000 (UTC) X-FDA: 80998576806.11.FDBDF8A Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf01.hostedemail.com (Postfix) with ESMTP id 823B840010 for ; Tue, 11 Jul 2023 07:57:41 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b=jpjsGIvH; dmarc=none; spf=pass (imf01.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689062261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+GXjLhe5TXUta+EXxk7AgfyYmiNiXB9g5OSSIlBPGEA=; b=32NuS16B+E6pVE+tdkbex7PIcWMas5rpmKx8A8AHqO9uvD5Ya70gN4wLiupuf8wPds2RB/ NFNHMZO5YhpTSdQEM9sxOLMPEWZ+neHGzdGmR00lfZXDQWmamsl/MxSocsQBZzKVluqpgV bn4slVLKn2LL8BfvwQDYszph1AA6cj0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b=jpjsGIvH; dmarc=none; spf=pass (imf01.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689062261; a=rsa-sha256; cv=none; b=0iGZjVu3na/DbJhCaJmv/NMu8DGtLf9xFcQiAo49asX3lJrgD4rls7mr6CIL7GXeScNtyb 0mCHPcK3Lb/0uDkR7S/WHZK6NzPI6vEXxbse+KWz7m4MFmkFUXFJEe29x4HZDF2ufIxzPS 2SWA4fhQmlXds0moX4qzzJRI3NUofXk= Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-3fbc656873eso67201535e9.1 for ; Tue, 11 Jul 2023 00:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1689062260; x=1691654260; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+GXjLhe5TXUta+EXxk7AgfyYmiNiXB9g5OSSIlBPGEA=; b=jpjsGIvHWDXwtmenwjPw+yleh84wYF4Gde1Y36TPhdybnF0jpwSLd/aOo7CFMtSuDK ScyvlYS80l2vcQ9apidNHokPdNcKdGvUFOz16EWh6HyNXWzuR/QaMrKyDRVuWrs51yKx skZgZTUZjD6cFKSOYgb53UN64gLFvysjjqU8dLz9nE2+HJHAHGf48tinF7oqdJtBI4pc Et4wuuECz5m6cPYyXZRudVvVIj9AKfqmjpYZWVzHlfwOhzfYW2aebgP/Fu+HS+8C0bcV XDhilVqCMXb407/A4iXWplI1yIn5lQwUah0v2s5df1KU/cDtaR7kCadJjP9Y4QwOQKtB s4Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689062260; x=1691654260; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+GXjLhe5TXUta+EXxk7AgfyYmiNiXB9g5OSSIlBPGEA=; b=HlX5uP8CKOPUEj25Wi7LbtO76eQ9edD6Ok8MurlQCuuypgrHgsB3se1y/9aFVQbng0 6BUIMR5Aa+YUA39uJjYn5QBD44Nyvjrh5cnAKHDEC12oHPWEIIiid2vJiUksBYILyhjX DNIrc/KIwz1i8I8VifiPnGFN/DniIfoMXJ2bVXRPAkX5LfnbTa269Il0PpNh7oBe0BIr b9v6hm9TX5MnyrFPluLU6oodnjAxWF6cymbomKMZW2TjjucnTsDEf16gxTfhILMNZ/2x tV1OGIL7NSNIWaPJYCrStf+ENDKT4DqSLIEbIIE045Whfyh9fTs5pmV0BNDqndVosNLa J6Jg== X-Gm-Message-State: ABy/qLb0voSAYd401sux2XBLp6sg1tZ7BDJQ69npjSUs/bNXGrI9XfOp dQlp/+pu9cU1+XTyOv6s5aw3vw== X-Google-Smtp-Source: APBJJlFF+JXKqksjRHwPA1L44xQAHuT0wraSNDH0ZMzzf07N8OaPZzuThlMge3mXhbU6gGV1bjdvMg== X-Received: by 2002:a5d:4404:0:b0:314:46cb:880a with SMTP id z4-20020a5d4404000000b0031446cb880amr18276011wrq.28.1689062260118; Tue, 11 Jul 2023 00:57:40 -0700 (PDT) Received: from alex-rivos.ba.rivosinc.com (amontpellier-656-1-456-62.w92-145.abo.wanadoo.fr. [92.145.124.62]) by smtp.gmail.com with ESMTPSA id t16-20020a5d49d0000000b003143bb5ecd5sm1499978wrs.69.2023.07.11.00.57.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 00:57:39 -0700 (PDT) From: Alexandre Ghiti To: Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Mayuresh Chitale , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Alexandre Ghiti Subject: [PATCH 3/4] riscv: Make __flush_tlb_range() loop over pte instead of flushing the whole tlb Date: Tue, 11 Jul 2023 09:54:33 +0200 Message-Id: <20230711075434.10936-4-alexghiti@rivosinc.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230711075434.10936-1-alexghiti@rivosinc.com> References: <20230711075434.10936-1-alexghiti@rivosinc.com> MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 823B840010 X-Stat-Signature: a63izr1xwzxdipay8hesntpaau8p6kym X-Rspam-User: X-HE-Tag: 1689062261-870140 X-HE-Meta: U2FsdGVkX1+84SqmAThKD8DCJXVKRIRDnKhdpNbRWOVsYnveg3WXmh+TNBwx0tSNOpNJMZqlkRaMAA5vAjMFkiNms/ohiPBt/zKr93cSYP8E8UC8bcUO0qGmhxBiouvZTAaEC4YmFvYFJ2UloYX9++QS7cn73OyGabnh8fu3TaTBbmX5R6QVkahwK9WuYvsFhf3k68sQ4haNgHnOS+SPgwZN1OO56O1fJFM4iMFuEI4JCJ5+hSDE39aRMf19uDtzVoRwmSGvLJFKl1a/Y0POFDlTPUgoQCARpKqQiH3BS7z/cEpEMOWCxGT36sqkoyng1I7L1oPkBdSodPQlSJ/42wgp4NQVlh8eo8w59/ZK8NPpSHXOYZa4/dfzsZoPAuc84AicpNTKfEha5Xd42PyeU0hGP5plSj21uCsWcH4Dh2Bvo23lh4MhxhQWsNFFcLptCNpOTQ29+ZtYqXE1e0mA6W/SOkFzWr0qbk75yARIXQe0VZEG8rfzyGJyXiON3E0QqQA+B90FPXLLXAKT8UJzzaDD6a/9x5HHTLfgMQersHkQNtdTV5DMjLjrHRpnh9ciQ6gPIBEXopsDfpMYbWQU5Mga35ENvRgNAD0LX9K8K6RLmPE3zROxJAXt88iSj3z6bDGJMW5RfyGcdwfZBEqWYAz3SCqs0mtz2RBGFj0ktBpwxG5FH6xXCunqKgMjRlismAO3/eKIEVXaK+0FCq0GMs+MTcSl7oV1xgtF0fAhQBPNZ+lfnojtz5bIEARsld8UmAZHTYJhjMDQXpJXf1PvEDZ8azpZa037pEDZjKRJJnDjXCe49AIe3kv4Asjy1WMdgA+gVRRyRMALR3LfTl7FwAIPiIPTQPScgMLfiwRrdKRiBN4NGUSSrVL+1ftR63XZP/z+OLx7gV2NzwGoz00hImgahPzObWcECKpAgUL00oQKwKYtt4J4rNVo9HF/Muxexr0NFwlS7uAzUeO6WcF Oc3MpUAI ug1NPTCpyFfynpA5O6RbdeocFvPhiKvDk+Fe9aCmUxHbp8kwChmvsWlQUdCEfYuJi9o+WT/PvRbsMFcTPZaFigkx8RCrLxDA85Yg3Yf3pUt0BO9p3THvkRjFoWPk9atJEapzd9487oDt30pR8+b0HdaILKHrOzemXL8hy9RxIKuz4iR9uQRm/zzPfq7b5FGQkgGtDTXAlkMQsj8oSV7xzUj9M9f6uMUh/tppKI09wcEDpzEiP40lmb6DXmZ3XgpqtdlF+qtcFLJgx/TAhQJj2RqgRQaC89MEfy2JGlW8uBxqoX8xyOhyDj/B8Sv+bzBpP8ThOcKPvZfWcjDBFgVt2P93/rXFjPTm8iEuqIP0TbNysf0Yvz+e9q9M7Y/L8q3BiGq24+BcCiC2bEHrZUQ07fw3koeRZzYK++Prhsf2sKQtgjMJB8nx+TPN8W0oPNQQ/igkJgpPncGnZwLgTDUnewPNdpmNvQl9ISFX/jP2yx9bDs6HzdYzZiMWJdfH8cHioXjBCtLiBA29CgLXe92jlkfwyy7kgaNN4LYvPbg9hXbyUMoc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Currently, when the range to flush covers more than one page (a 4K page or a hugepage), __flush_tlb_range() flushes the whole tlb. Flushing the whole tlb comes with a greater cost than flushing a single entry so we should flush single entries up to a certain threshold so that: threshold * cost of flushing a single entry < cost of flushing the whole tlb. This threshold is microarchitecture dependent and can/should be overwritten by vendors. Co-developed-by: Mayuresh Chitale Signed-off-by: Mayuresh Chitale Signed-off-by: Alexandre Ghiti --- arch/riscv/mm/tlbflush.c | 41 ++++++++++++++++++++++++++++++++++++++-- 1 file changed, 39 insertions(+), 2 deletions(-) diff --git a/arch/riscv/mm/tlbflush.c b/arch/riscv/mm/tlbflush.c index 3e4acef1f6bc..de61ecaa218a 100644 --- a/arch/riscv/mm/tlbflush.c +++ b/arch/riscv/mm/tlbflush.c @@ -24,13 +24,48 @@ static inline void local_flush_tlb_page_asid(unsigned long addr, : "memory"); } +/* + * Flush entire TLB if number of entries to be flushed is greater + * than the threshold below. Platforms may override the threshold + * value based on marchid, mvendorid, and mimpid. + */ +unsigned long tlb_flush_all_threshold __read_mostly = 64; + +static void local_flush_tlb_range_threshold_asid(unsigned long start, + unsigned long size, + unsigned long stride, + unsigned long asid) +{ + u16 nr_ptes_in_range = DIV_ROUND_UP(size, stride); + int i; + + if (nr_ptes_in_range > tlb_flush_all_threshold) { + if (asid != -1) + local_flush_tlb_all_asid(asid); + else + local_flush_tlb_all(); + return; + } + + for (i = 0; i < nr_ptes_in_range; ++i) { + if (asid != -1) + local_flush_tlb_page_asid(start, asid); + else + local_flush_tlb_page(start); + start += stride; + } +} + static inline void local_flush_tlb_range(unsigned long start, unsigned long size, unsigned long stride) { if (size <= stride) local_flush_tlb_page(start); - else + else if (size == (unsigned long)-1) local_flush_tlb_all(); + else + local_flush_tlb_range_threshold_asid(start, size, stride, -1); + } static inline void local_flush_tlb_range_asid(unsigned long start, @@ -38,8 +73,10 @@ static inline void local_flush_tlb_range_asid(unsigned long start, { if (size <= stride) local_flush_tlb_page_asid(start, asid); - else + else if (size == (unsigned long)-1) local_flush_tlb_all_asid(asid); + else + local_flush_tlb_range_threshold_asid(start, size, stride, asid); } static void __ipi_flush_tlb_all(void *info)