From patchwork Thu Jul 13 23:00:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 13312720 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FCFBC001DE for ; Thu, 13 Jul 2023 23:01:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B2786B0081; Thu, 13 Jul 2023 19:01:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 362BC6B0082; Thu, 13 Jul 2023 19:01:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B5408D0002; Thu, 13 Jul 2023 19:01:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0AC156B0081 for ; Thu, 13 Jul 2023 19:01:44 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D66C0803AC for ; Thu, 13 Jul 2023 23:01:43 +0000 (UTC) X-FDA: 81008112486.12.AA8CA5F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id ECF2440037 for ; Thu, 13 Jul 2023 23:01:41 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BikyFRuC; spf=pass (imf17.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689289302; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xvtDyXZiv47HaH52LmRi9yHPxJlG9e6XVtw2iD8b/FA=; b=7ZmvN15O2SBfucFhpQlq1+79R5XNAfBST2rjVS3DJ4QbWUO5rEIQ4eEjk0E+QS9lrsr8p9 eyv94DSxqKzb7Ld+fSL7wZHjEuryAsuwMOjyw4YcAihB8nySB5BgzeiDeJm5cMWTt2kbwT akgkodbePJoB1WY5s/EkaiDuew8Y5m4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689289302; a=rsa-sha256; cv=none; b=EkXP4/9ZKNL6oFqv8G+w1tiDyPKgYxh8J4e8uc7dtOpts0gQrQns7GiyK50EP6hVjX65zD JwFU3XIBpNmMKEnQm+1dnkqDYOw7wsv/F5H11iaO2EuIl3nqPOrhcCMaT7YUGQ7rw7yLOJ 2PIw+UlkEtE1J9a7tZbLEhUCwdfDBy0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BikyFRuC; spf=pass (imf17.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1F3BF61BA6; Thu, 13 Jul 2023 23:01:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D1B3C611A0; Thu, 13 Jul 2023 23:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689289300; bh=aa5qbguHFcu6OOlBUAepw2+xHt44QiNWyfL22OUBSqs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=BikyFRuCdOODbIqFMPk9kNKNlEo0dYJ6zt4FyqFTbTjpdmiUktdW71dJkcCNhfnr6 IH8wNPwLcwjFwqbPM9ABFfIZZoaAAjZWuXcaDgVP/9O9ow8exs0ur2EO1mxw06CUVs OIVi6P2uBcHxFX31zL/bkUGRt7Vk6GxZq50OE6iR5Xkgc+XbbqUbUANDiMMWaLTCgU 9YSpAieiO+VbSduJMVGrLCDzqj6M76cg/ERleiQQWLvjl1lRNaDYvlOMtASHc3hRxY 3zxwROtQCWYj4ZhKhLitrJ1WKe8G5IuDdn4pkmXKWnP8iuqxCuy46i0Jj0SbW9jVX2 AHP5DZp2LCIgA== From: Jeff Layton Date: Thu, 13 Jul 2023 19:00:54 -0400 Subject: [PATCH v5 5/8] xfs: XFS_ICHGTIME_CREATE is unused MIME-Version: 1.0 Message-Id: <20230713-mgctime-v5-5-9eb795d2ae37@kernel.org> References: <20230713-mgctime-v5-0-9eb795d2ae37@kernel.org> In-Reply-To: <20230713-mgctime-v5-0-9eb795d2ae37@kernel.org> To: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Alexander Viro , Christian Brauner , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , "Darrick J. Wong" Cc: Dave Chinner , v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, Jeff Layton X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1284; i=jlayton@kernel.org; h=from:subject:message-id; bh=aa5qbguHFcu6OOlBUAepw2+xHt44QiNWyfL22OUBSqs=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBksIIuYLDaeyv+0bFKxMDi4TCGl7qNqh97QkbqR 7MnTf0XpqqJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCZLCCLgAKCRAADmhBGVaC FdKeD/90gpS8fulOOgQezr1N2uNArvD5brmGxA6b7tTzZSvcpOejwinrQKvQhs+PxBZDriYQCQh OwxNuTnA93R76ZkHT+sLOHGoGBQ6UBAtkzGtxH9v1fgcuhwappw6969ZTeRpLIIWBZ0MFdVDXTe YFcM04RAjErJxaPi7Kt5ULpq1V7YIjHa0dovLbQ7frkm24o+WlVOqKpXRct7ZQqa2k6bkGFkhed NZPwy8zsD4D/ZthBftUASAETJsO1x4cs1v02gmv4U6YR4J39mE20H8TT+918pwwZU/VSIOj1M8H Oirc7oG/xtEnVFeE6nGc9DoXtvpO3IUf1FdW5mKKcKqLzZoKXfj3gk1gLXOX0mdQ2JHPZcGc49+ LHI8cuBfrkN/yVk5aVMC/t0fyaM1xcR+wuz2sQL3b3ax5gG8hx3oSg5INanDl7BDUq7lbtQYpHC 44+w5XUDYxIFpjAozvDGpAzbAsZNp/fmKeaNAFZ0DPSY2csmopw1l3HzeL2s29LE29J+DbWrN4Q dQtkbmyLS83Mo3Rus7OEOTowcfLEdmVZ4nlYwkUBpsAbUeo3Gpzvy+DYU8t8ma/Kb96NS7sEx81 5WULDzoq4LwO4MreHRa/DvZr0oyyhT5qcmZWNWLeSdaA0x6eEh2hzaWN9VBX+UNVXANgJRn57fJ LrcnCGwsCj+PM0g== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 X-Stat-Signature: h3o8usksigb8yf5rmwrjskm9o35g8ixx X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: ECF2440037 X-Rspam-User: X-HE-Tag: 1689289301-954258 X-HE-Meta: U2FsdGVkX1+bASsC/Hn+Oo+Yw/z2ssf4MbmFZe5VInbmBXqc3whtTL/IC0XwYD5sQazBP5riT4FkY0BmLP4IsLTkhFRr6E4N8Y3WmRcEKWpHETtkV3OxlQewUl95bXfxoKG9MrlpJm0VOiUGqBueCOK0fnjjySPKqZxL6XPEG/IrSAfPeaEmCdhwdBWsrWjPn8VKlR92wVmshdeGz9ReFUF8zjNmz5b+4AyUGP174HVt6RPVAiZqt7RD6viFUwkKGad34Ht8UJorBRXtzwWHpU6KLmiwZQvkczIsttcw5TewBKU9SGD8HwhXj3jMGHfrXUaSAuYj/0La3otzhuy9hLI3FzGSdk23aTasrJO1AZurVggQWfSn8M2g75EN9BTJrPXgsXI+72z57TG8JOVOyieLrZgL/1jZbkUMnRm1TmDDc8iwOJ24PprYYhsu2roFyGy5ZQgdk48ndrz08xIXRwefZdI/vKBdgTrmdRpVmop4hCQNARh4wL02TZoa4VdeyCIdzUFUaDMB/lQp+9OXSXENoBwFNfVDfdCeYw66vEp0XefQ4VZycsaVg0vdOy+IAfyFTcFWzUtsKE/KQO0RbliFrDFZvF6eKAtXetLhQqb7fbyDIfYp8P0xpI0KcIYuGXVswpY+uoEMY8F1W2puKYc7vImYOmBONF1/M0Z9fNKOOVViQNIMWDWeeR8PbWflGnqOywhc0bWhooQ5r+h5Z/EXWm++X4hWVE97beIffOPYe8nuiXrrAwKgN+NNGAfTU7CUNxYNOIXNPbD5SuT7b8EMFAqdwbEJrX84KlMsiSaNZEuirAtjxPpwcpEU8UR5RT34pK3JPm6euHEtowo14j+RqX7PNZ/PgBFA0/X5KgfEWArHOZqMMzsmRlJe+sZVf0v5D8uXDT0AGI5aJ2C2DYgTQVni6Ep7OhgY/UjoQzyAsybwCX8Kh2LGkHFu0CDvuenxhhWh5uyPfHa2ldU xv13TiyU y5pQ/T7Ds44BKH+SDXLNN0k8RT2hVh6g6++W2Ype9JsHxSomz3oo7rn4Jsz5mjZN/Nsydlx4s+Wsj0DAlCc2Y4iJv0h41Lj2bNL0qzZtjfphFPnh1Du9Wt0m7sHPWs1TI9+c+iN2DfreCH4G5yws1bzb5UdjqupKUwA0aaaj0xH1nmxKdaeDaHj08l9fVSIVThDExakgfs2H6zgdoJ3AeNCLPFhkvhTQ96c88RQliRYpInxkFtNbZQVZ7RVSHfNsyPNP9zJ6NOggQ8TFRQmaZkXT2SQztY8nEE5e+6629V1pBvIuTsRn6P2ZjDg7g6fBynh9LW276bLbnz7dvLZf+UMSLRNvcikdVFDfELV5UeCDMYuR4kifjAQBgRfoRfoskXBrN3v9oNuo98WY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Nothing ever sets this flag, which makes sense since the create time is set at inode instantiation and is never changed. Remove it and the handling of it in xfs_trans_ichgtime. Signed-off-by: Jeff Layton --- fs/xfs/libxfs/xfs_shared.h | 2 -- fs/xfs/libxfs/xfs_trans_inode.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/fs/xfs/libxfs/xfs_shared.h b/fs/xfs/libxfs/xfs_shared.h index c4381388c0c1..8989fff21723 100644 --- a/fs/xfs/libxfs/xfs_shared.h +++ b/fs/xfs/libxfs/xfs_shared.h @@ -126,8 +126,6 @@ void xfs_log_get_max_trans_res(struct xfs_mount *mp, */ #define XFS_ICHGTIME_MOD 0x1 /* data fork modification timestamp */ #define XFS_ICHGTIME_CHG 0x2 /* inode field change timestamp */ -#define XFS_ICHGTIME_CREATE 0x4 /* inode create timestamp */ - /* * Symlink decoding/encoding functions diff --git a/fs/xfs/libxfs/xfs_trans_inode.c b/fs/xfs/libxfs/xfs_trans_inode.c index 6b2296ff248a..0c9df8df6d4a 100644 --- a/fs/xfs/libxfs/xfs_trans_inode.c +++ b/fs/xfs/libxfs/xfs_trans_inode.c @@ -68,8 +68,6 @@ xfs_trans_ichgtime( inode->i_mtime = tv; if (flags & XFS_ICHGTIME_CHG) inode_set_ctime_to_ts(inode, tv); - if (flags & XFS_ICHGTIME_CREATE) - ip->i_crtime = tv; } /*