From patchwork Thu Jul 13 17:26:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 13311643 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB3DFEB64DD for ; Thu, 13 Jul 2023 09:26:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A9458D0002; Thu, 13 Jul 2023 05:26:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 52ED88D0003; Thu, 13 Jul 2023 05:26:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3815A8D0002; Thu, 13 Jul 2023 05:26:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 23BCE8D0001 for ; Thu, 13 Jul 2023 05:26:04 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DD19F1A01AF for ; Thu, 13 Jul 2023 09:26:03 +0000 (UTC) X-FDA: 81006057006.26.2A48FB9 Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by imf21.hostedemail.com (Postfix) with ESMTP id D0C761C001E for ; Thu, 13 Jul 2023 09:26:00 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=none; spf=none (imf21.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689240361; a=rsa-sha256; cv=none; b=y5dcvi1RQ7DOnd0AvVbqreNMBM1OpezsQCN/gdmP1zYqa84LR2YS0rIjG5hSJb447/o/cV x8HDZ55sL/V9/Tg68XH1Iydm8TN30gl55vtXyUJq8uDp9MtJufZvhDt28T4uKGxv4j8S5F wNVEuCH5DyxhdsjKqWvsPBymbqYXtEk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=none; spf=none (imf21.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689240361; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uHro5qAkw16w8PdVbxq61FlHyptvTuIuK0OOCzrLKHw=; b=QSFv/YqkY8Jeo7AUemLnctJlAL4aSzRkU/iII6jJX0yGrloCt48yBlZkghbRoBH5wj8BnW KlaFlcTNqtwLnBq2fOd/DV9fZF5Z5GPIqpNDDGLXDFkxyHbqafcOM5fkm9x5kzgRHKH+vB tOx5S42gKPbrL+jI4V+JavO7ZF1/EBo= Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4R1q3P3Hszz4f3khH for ; Thu, 13 Jul 2023 17:25:53 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP2 (Coremail) with SMTP id Syh0CgDHu+khw69kr7cmNw--.13397S5; Thu, 13 Jul 2023 17:25:55 +0800 (CST) From: Kemeng Shi To: pasha.tatashin@soleen.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: shikemeng@huaweicloud.com Subject: [PATCH 3/8] mm/page_table_check: remove unused parameter in [__]page_table_check_pte_clear Date: Fri, 14 Jul 2023 01:26:31 +0800 Message-Id: <20230713172636.1705415-4-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230713172636.1705415-1-shikemeng@huaweicloud.com> References: <20230713172636.1705415-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: Syh0CgDHu+khw69kr7cmNw--.13397S5 X-Coremail-Antispam: 1UD129KBjvJXoWxKF18uF4xXrW8GF4fZr1DKFg_yoW7ZF1kpa s8W3s2qrW5W34rWry7uFs0yry8trsxW3yfJry8GF4Yvw13KrWIqF98Gr9xAas5Ga4kX34f GFWFgrsrGF4Igr7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUPSb4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M2 8IrcIa0xkI8VA2jI8067AKxVWUWwA2048vs2IY020Ec7CjxVAFwI0_Gr0_Xr1l8cAvFVAK 0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4 x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l 84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I 8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AK xVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zV CS5cI20VAGYxC7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E 5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAV WUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY 1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI 0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7s RNBT5UUUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D0C761C001E X-Stat-Signature: nmdqtfgqmhtj95ked3jffzq73immits3 X-Rspam-User: X-HE-Tag: 1689240360-642869 X-HE-Meta: U2FsdGVkX18v4EK+d8aV75w7wybZU1Nnakd2k2jMroo32dA8h9rXhWJTgTB6m9v7WeQ1NOZrpiiAyVWPB9D+OCisWj7J+Nx3tdNChxB/1uH5MbwaaeHRhZs4oG/dUz0yzPtkwDLn49gtzZHvofYZ3cE93WgvCZ0MTjb6dcS9bMOArlvkXYe/z1EllYOuDmIwFKKcbtTvihS0JfnENkz1qOoVjLNXhZrR99d0iLPVzWLkrYKqF157FJgh0SN+raYd80HYIdxAY1GvilUcWEr8Ctjpiv4toyfgV9o95/YiQV8RmAY+y1BzQtahlAUwc10XhCxtqCZ0jmykAi9IDtRlpwulxlkttfVuJXO1G25p0uZhZFRFP/DJUA5bs6MBaIHtrkssCDPTmvv6p6Btxr/mwu2HRx3Mjy7oiwl1ePGxjyhmOZZD+tBpc9sLlrReCbWhq5qr/ULgEO/J+8U90yJFlKyWWcLs6R8BdV7FlOpKdnMbo5lcKU2TDKtREcln+GcI5JKbHbVtgHwVWbPGxz8crign5PmMdzlb/j4WomrGSfktsCqKRGcr7Zxu5L5boiQ4aSik8QD/GCB1heED9+FlbxlcFzbjHArbUMT6uQZYaKXGbFPU0kChqmVylUwLX9LMzDhWG0WN1kksOT7qqJRFsdSy/ZysqJlv7BpjGAOl6hkxa0vM+hgesBtcm9hn3epO6JB69ewM+vqzBkF7xhZgBPV+FDgvm2qLdBHA/oUVLabvRAMJ23aA5eCMP7iztHS+yNvwQG/dyd0QzG5NZ+Cyp/BwsIc1FGy2SinVnsP0F4KPxqPIkhsTBpyXItABxXCDnQHT7Ti+U2NdeA97rv67GOVnn3LVo1WJnMUXLtD2Dxc1L2fjJA4WYT8RU1jGo0qOvLU9o6+UjYwIVmmD/zXqgKdH8IbmZu9V+DofJvUjtNr0mk3AE5exa0ZrSzXMDyRnAj6pONGWd3I/a549CBw /o2OwdDJ bfeJdAQKa+Vl0zWcD0z6pZIkIvLR+ZU8bp577VyIcajgwZl79k5IsVZhddxqCNOIlLN+e7h16MtfiAvWbl+MxNO/VqHi0ARIbkWLoD0InorAyzJnS6nLxzt6xDhLFI7xNwMtWAS56CgZoZT56L01cYxlQHJxfOCSrn372yyIhedW/Pke+AHMJk9WoWdZhwPifQm9EyC79GyRzWDwJAuxzlRCeBUMp1FijHi4q4HRlncETwkX45M93IAGAz/rPySr6ybSYBBMURKuSm2eVD1fMSIQbPKtIVqxAEefNAs7WaTDg9dF/P0qzXh6AwmH1UvOies3Z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Remove unused addr in page_table_check_pte_clear and __page_table_check_pte_clear. Signed-off-by: Kemeng Shi --- arch/arm64/include/asm/pgtable.h | 2 +- arch/riscv/include/asm/pgtable.h | 2 +- arch/x86/include/asm/pgtable.h | 4 ++-- include/linux/page_table_check.h | 11 ++++------- include/linux/pgtable.h | 2 +- mm/page_table_check.c | 7 +++---- 6 files changed, 12 insertions(+), 16 deletions(-) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index e8a252e62b12..f7ea51f9c1c1 100644 --- a/arch/arm64/include/asm/pgtable.h +++ b/arch/arm64/include/asm/pgtable.h @@ -928,7 +928,7 @@ static inline pte_t ptep_get_and_clear(struct mm_struct *mm, { pte_t pte = __pte(xchg_relaxed(&pte_val(*ptep), 0)); - page_table_check_pte_clear(mm, address, pte); + page_table_check_pte_clear(mm, pte); return pte; } diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h index 75970ee2bda2..5e07312cd3e1 100644 --- a/arch/riscv/include/asm/pgtable.h +++ b/arch/riscv/include/asm/pgtable.h @@ -529,7 +529,7 @@ static inline pte_t ptep_get_and_clear(struct mm_struct *mm, { pte_t pte = __pte(atomic_long_xchg((atomic_long_t *)ptep, 0)); - page_table_check_pte_clear(mm, address, pte); + page_table_check_pte_clear(mm, pte); return pte; } diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h index 5700bb337987..5085e838b860 100644 --- a/arch/x86/include/asm/pgtable.h +++ b/arch/x86/include/asm/pgtable.h @@ -1068,7 +1068,7 @@ static inline pte_t ptep_get_and_clear(struct mm_struct *mm, unsigned long addr, pte_t *ptep) { pte_t pte = native_ptep_get_and_clear(ptep); - page_table_check_pte_clear(mm, addr, pte); + page_table_check_pte_clear(mm, pte); return pte; } @@ -1084,7 +1084,7 @@ static inline pte_t ptep_get_and_clear_full(struct mm_struct *mm, * care about updates and native needs no locking */ pte = native_local_ptep_get_and_clear(ptep); - page_table_check_pte_clear(mm, addr, pte); + page_table_check_pte_clear(mm, pte); } else { pte = ptep_get_and_clear(mm, addr, ptep); } diff --git a/include/linux/page_table_check.h b/include/linux/page_table_check.h index 01e16c7696ec..35c53c4b94d3 100644 --- a/include/linux/page_table_check.h +++ b/include/linux/page_table_check.h @@ -14,8 +14,7 @@ extern struct static_key_true page_table_check_disabled; extern struct page_ext_operations page_table_check_ops; void __page_table_check_zero(struct page *page, unsigned int order); -void __page_table_check_pte_clear(struct mm_struct *mm, unsigned long addr, - pte_t pte); +void __page_table_check_pte_clear(struct mm_struct *mm, pte_t pte); void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr, pmd_t pmd); void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr, @@ -46,13 +45,12 @@ static inline void page_table_check_free(struct page *page, unsigned int order) __page_table_check_zero(page, order); } -static inline void page_table_check_pte_clear(struct mm_struct *mm, - unsigned long addr, pte_t pte) +static inline void page_table_check_pte_clear(struct mm_struct *mm, pte_t pte) { if (static_branch_likely(&page_table_check_disabled)) return; - __page_table_check_pte_clear(mm, addr, pte); + __page_table_check_pte_clear(mm, pte); } static inline void page_table_check_pmd_clear(struct mm_struct *mm, @@ -123,8 +121,7 @@ static inline void page_table_check_free(struct page *page, unsigned int order) { } -static inline void page_table_check_pte_clear(struct mm_struct *mm, - unsigned long addr, pte_t pte) +static inline void page_table_check_pte_clear(struct mm_struct *mm, pte_t pte) { } diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h index 9fa34be65159..a1ccb13c4853 100644 --- a/include/linux/pgtable.h +++ b/include/linux/pgtable.h @@ -322,7 +322,7 @@ static inline pte_t ptep_get_and_clear(struct mm_struct *mm, { pte_t pte = ptep_get(ptep); pte_clear(mm, address, ptep); - page_table_check_pte_clear(mm, address, pte); + page_table_check_pte_clear(mm, pte); return pte; } #endif diff --git a/mm/page_table_check.c b/mm/page_table_check.c index 53a9a1e4f342..a1015fc4d045 100644 --- a/mm/page_table_check.c +++ b/mm/page_table_check.c @@ -149,8 +149,7 @@ void __page_table_check_zero(struct page *page, unsigned int order) page_ext_put(page_ext); } -void __page_table_check_pte_clear(struct mm_struct *mm, unsigned long addr, - pte_t pte) +void __page_table_check_pte_clear(struct mm_struct *mm, pte_t pte) { if (&init_mm == mm) return; @@ -191,7 +190,7 @@ void __page_table_check_pte_set(struct mm_struct *mm, unsigned long addr, if (&init_mm == mm) return; - __page_table_check_pte_clear(mm, addr, ptep_get(ptep)); + __page_table_check_pte_clear(mm, ptep_get(ptep)); if (pte_user_accessible_page(pte)) { page_table_check_set(pte_pfn(pte), PAGE_SIZE >> PAGE_SHIFT, pte_write(pte)); @@ -241,7 +240,7 @@ void __page_table_check_pte_clear_range(struct mm_struct *mm, if (WARN_ON(!ptep)) return; for (i = 0; i < PTRS_PER_PTE; i++) { - __page_table_check_pte_clear(mm, addr, ptep_get(ptep)); + __page_table_check_pte_clear(mm, ptep_get(ptep)); addr += PAGE_SIZE; ptep++; }