| Message ID | 20230714215113.3919026-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | shmem: set variable shmem_mark_dquot_dirty and shmem_dquot_write_info storage-class-specifier to static | expand |
On Fri, Jul 14, 2023 at 05:51:13PM -0400, Tom Rix wrote: > smatch reports > mm/shmem_quota.c:318:5: warning: symbol 'shmem_mark_dquot_dirty' > was not declared. Should it be static? > mm/shmem_quota.c:323:5: warning: symbol 'shmem_dquot_write_info' > was not declared. Should it be static? > > These variables are only used in their defining file, so it should be static. These are functions, not variables, and you're the third person to send this patch today.
diff --git a/mm/shmem_quota.c b/mm/shmem_quota.c index e349c0901bce..062d1c1097ae 100644 --- a/mm/shmem_quota.c +++ b/mm/shmem_quota.c @@ -315,12 +315,12 @@ static int shmem_release_dquot(struct dquot *dquot) return 0; } -int shmem_mark_dquot_dirty(struct dquot *dquot) +static int shmem_mark_dquot_dirty(struct dquot *dquot) { return 0; } -int shmem_dquot_write_info(struct super_block *sb, int type) +static int shmem_dquot_write_info(struct super_block *sb, int type) { return 0; }
smatch reports mm/shmem_quota.c:318:5: warning: symbol 'shmem_mark_dquot_dirty' was not declared. Should it be static? mm/shmem_quota.c:323:5: warning: symbol 'shmem_dquot_write_info' was not declared. Should it be static? These variables are only used in their defining file, so it should be static. Signed-off-by: Tom Rix <trix@redhat.com> --- mm/shmem_quota.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)