From patchwork Thu Jul 20 16:30:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Valentin Schneider X-Patchwork-Id: 13320795 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B8BAEB64DA for ; Thu, 20 Jul 2023 16:33:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A65B8280139; Thu, 20 Jul 2023 12:33:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EF5B28004C; Thu, 20 Jul 2023 12:33:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86931280139; Thu, 20 Jul 2023 12:33:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 763F528004C for ; Thu, 20 Jul 2023 12:33:41 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4D466B0AA5 for ; Thu, 20 Jul 2023 16:33:41 +0000 (UTC) X-FDA: 81032536242.14.8298541 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 718E540024 for ; Thu, 20 Jul 2023 16:33:39 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UdUytoeq; spf=pass (imf04.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689870819; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gxt5b+dw2J3MlRZgV6DoONRBYEDjEJLqkxMRP/UHfXc=; b=wmWgkzNJeteDjFxDiW4HUh33scLNuTtSFz/Kcg4O55yCmP6odQASD+KPdFC7g8A57zdMnA ap70VvDsnyd8HqCO/mlbpTUARItho3gBFI5M8ow5rL/Mjnq1yQC67AavD+t9kQ8iRyWMit jzh9mxWP3bRj9+vjba3Yft/JTg35xWk= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UdUytoeq; spf=pass (imf04.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689870819; a=rsa-sha256; cv=none; b=2vOTdk5X46kWFLjqfKn8+q404rHVDOeAbvTN8u8Rf+88wiF0MfmIJGYshEa3KFcWa90UlA 6TiVTtU6bbm8ZOWwNBjb7I//+z8RKQgSSU54bdI++6Hj54Flkkappn6IkIxDv1MFqfn1k9 w9EfeY4aL0Fq4QH71vd7zvqRJH/JY9E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689870818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gxt5b+dw2J3MlRZgV6DoONRBYEDjEJLqkxMRP/UHfXc=; b=UdUytoeqCFg/Fw9s0WqWqSojhl3ADm0COqr37rDs+fLsToB14zv4y4EOdshlY2KDYI75CE ZRTw0mcJ9kZ19D8BPP1OHIE3IV//bQPQs7ozyyTE8T/krXFhyEa+q2CKFTYcUoomIC/3WJ Dv+MhkYMYVUYIOqyu41Tf776FCmS2/M= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-637-bk8eKh1PMsKjdr3SYosUIQ-1; Thu, 20 Jul 2023 12:33:32 -0400 X-MC-Unique: bk8eKh1PMsKjdr3SYosUIQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 902321C05EAA; Thu, 20 Jul 2023 16:33:25 +0000 (UTC) Received: from vschneid.remote.csb (unknown [10.42.28.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C6B9240C2070; Thu, 20 Jul 2023 16:33:18 +0000 (UTC) From: Valentin Schneider To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Steven Rostedt , Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Josh Poimboeuf , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: [RFC PATCH v2 11/20] objtool: Flesh out warning related to pv_ops[] calls Date: Thu, 20 Jul 2023 17:30:47 +0100 Message-Id: <20230720163056.2564824-12-vschneid@redhat.com> In-Reply-To: <20230720163056.2564824-1-vschneid@redhat.com> References: <20230720163056.2564824-1-vschneid@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Rspamd-Queue-Id: 718E540024 X-Rspam-User: X-Stat-Signature: quwrt8sxurqdmhgn9qsixs4fmfoa1iy5 X-Rspamd-Server: rspam01 X-HE-Tag: 1689870819-730657 X-HE-Meta: U2FsdGVkX1+f8aoQxEzoAkS9sTrUWBnN9tHKy5AyWRI26LERpLYnI8hJb4zPEVQQQjFV5OwnEqtbIttu7lwf43j3fBwUpyq2eeLBTu10K/TpNG07Zh5s+LGXBPUko8W28WSnCzRy2aIXuCiaA5SeX8f/aoxSeu6CRhZ/miFGckX2jirEWNQZVByJHpkAnnE6OmHfFPeyuUwEVhs5+nJaXlNJcxLQEa8dmF50QDETzWhUQ0SlnLETpywrhhZ9Xrd0pFvSdsEDINOUwf6pETUPHMDis5MlK4Am0RfNNhgWvgzp6v7FLqFDwJK+L5MsX/QqcG+ezuEjjZ+QuBX9z+/e/eneCTDD6pDlaRTdZT9QEzCbl/dgml9nBWQLHjL69MFalRLTKoMqbMNXY7jZ+NWA6YEfQEiAbngb5+gJ4YLzUq4XphOKMOWoOk3Iljk47EE7Iddmb6K+M83eG6e053FTl8kDVDOZxMPs51Qie/+xYhsM1hESSIYGodl/JLwTPUsh41ilO4beq0XZgp2qxy0rr50/K4TiN8kVesMBNUTRKvXUR9ORPufTr6Z1z1Vr9ovjMJMwfwvYkpumqbiUwZGGW6w+f+VWnFx4AF/Bahykzurn5BZ2SQPcalEL9n1MRjIThyjOmFG1C0JDsA+BLqckmMhemmM/6ssWEqv1JogXsBgTMWXtIdWlKeQ4K9fiKSoMWYB/RPaPJUqe6wuFToXkrdMwxx3sj+1BGmtaqWtIskzHyiVI55yiIz+FkQr5VqaXr+XlWBup1M0dKh1cCmfC0Y4sJ8JuBqjZtTM9uC8OfvlgtbMyx9FXp8FoR9mxjcsSs/btlG7CAMuBtYOqsw4W9J7N9oULZiJIAAPuzkEFiJX7CTr+TSqBrVMNsXmX267xEl24cu0Dlf7G9aemv5WdfU2OAjRilOKi3FsagcnqXso87+/mcYHBPaAfe4UXibxLo8sebUFuXS+H/YaoaH0 2Xfu9kW8 tW7kdw+QI3WGYX1ohwnwAVZgZEP9kKMlMNJ2MZC0osrg2klzNZbJSSyQTbIQLPcmAEJ3/TKnd64w9/T2xTM7FmmFjml/Rfp50knSRSHPLl75+2FUuVjGkX5wJS6HimMnxeqpeKpOqVavsV/hDCVDA3dVKe/Pw9onGVdc35F150FIpvqP9rc7ebLcOmP+1kKMW8gUdjLaoyWg0SECnSyMLdNCapn224ilQjw4aNeZFnb0NVSSSs1iOwcxyI9iMlrKKOHCRDgdkGligB2d2nRyIlS3zDiQWjoGnQwHN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I had to look into objtool itself to understand what this warning was about; make it more explicit. Signed-off-by: Valentin Schneider --- tools/objtool/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 8936a05f0e5ac..d308330f2910e 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -3360,7 +3360,7 @@ static bool pv_call_dest(struct objtool_file *file, struct instruction *insn) list_for_each_entry(target, &file->pv_ops[idx].targets, pv_target) { if (!target->sec->noinstr) { - WARN("pv_ops[%d]: %s", idx, target->name); + WARN("pv_ops[%d]: indirect call to %s() leaves .noinstr.text section", idx, target->name); file->pv_ops[idx].clean = false; } }