From patchwork Fri Jul 21 13:17:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 13321975 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 074BFC001DC for ; Fri, 21 Jul 2023 13:18:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4038C6B0071; Fri, 21 Jul 2023 09:18:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38CC88D0002; Fri, 21 Jul 2023 09:18:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 191CD6B0074; Fri, 21 Jul 2023 09:18:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F3EC46B0071 for ; Fri, 21 Jul 2023 09:18:17 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C073C402CA for ; Fri, 21 Jul 2023 13:18:17 +0000 (UTC) X-FDA: 81035672634.11.E0E9574 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id A49FC12000E for ; Fri, 21 Jul 2023 13:18:15 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K2S4aYKl; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689945495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+qYMYKznWRCQRLs4itQFPGrBm6WN+EZaQC54fSpIxmA=; b=iGg2lzn9RSid36CWyMvviJhb1bJ8utZtrB7uDuMhFbPPYAP9Aj7ag8zB7q9YKQrSmqGsnB s6w1zp7ix0EItaFZs4t4KLTKfX8KrVxoeKbgoZmcdr01IrqEI7mxnp1Hx9jdB7aaMo6vgC xSU4E5PMixaVm7zjiArEPVUKNEKy4cw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K2S4aYKl; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689945495; a=rsa-sha256; cv=none; b=I3qcfGlid5IQegBE+WKrjbZGI7CJ7bM9qcKoLndaQDUBx3xiN2V0dghKijN+9fH0BUZyfr RF5gxEXQhq2wAAC17DC9PC8On6Uyoz3XY0zlQmQQTCxmuSRtoQJSgt1iGb6eaHTcYv9tBv Ga0g1fjkxpry6ntMtdNjIjrlt0J4wro= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689945494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+qYMYKznWRCQRLs4itQFPGrBm6WN+EZaQC54fSpIxmA=; b=K2S4aYKlhqsF1Acjyf54Fh1L6IYNb1O36PNNx9syS2aur3J8iyDv98e/JFejU97vN7ienO 447W/9fo5zaIDCxAFhpojFyTzVdde8Cb9SjitaWJXKLe54Ir1QtJ1DHOMflmHq/e1sLjqt WxfBVv48vUrTqqkagAH3/NIWeXTabRU= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-617-zn0bPHkSOBi7QroqT667-g-1; Fri, 21 Jul 2023 09:18:13 -0400 X-MC-Unique: zn0bPHkSOBi7QroqT667-g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C24F71C05154; Fri, 21 Jul 2023 13:18:12 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-18.pek2.redhat.com [10.72.12.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id F0A2C40C2071; Fri, 21 Jul 2023 13:18:08 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, akpm@linux-foundation.org, dennis@kernel.org, tj@kernel.org, cl@linux.com, mawupeng1@huawei.com, Baoquan He Subject: [PATCH 1/3] mm/percpu.c: remove redundant check Date: Fri, 21 Jul 2023 21:17:58 +0800 Message-Id: <20230721131800.20003-2-bhe@redhat.com> In-Reply-To: <20230721131800.20003-1-bhe@redhat.com> References: <20230721131800.20003-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A49FC12000E X-Stat-Signature: y354hqsf1wfgfb9krjump9hpyxwz9ha4 X-HE-Tag: 1689945495-253542 X-HE-Meta: U2FsdGVkX19uZrdEWqZ4fAPxRUKVeTUQ3DJAjnE1Mel1z60wGlMAymtNU7EdqT2gyzEfxqKBsScMxXHjxDZU5956i4pAiuvgIsDqHKe7bm4zrAtp560AMc8iamHU5NUarDhWoYjh5gX3sAf1PavRJKI/3XLEZmIlEpvTSEzctcKNfmX7HFditFORiTbh3z2Kcd+n7CATUVEvdSE5v9Xi7CxUygPFz8BVK58LAKNj9/tTZ0TUEf43SKjS6rSv5IPMc3VdV0rDx54+FT95yTSLsHgkbJ6hyn4Z0HDLDzwZXRxNJSotPfDskaLwoPYSii66+2Fs5EGI/gUoHWacGKQrDAHxkz/tFHlpvDTZcTVcrQ44HRZr9QsZiyMDVQRZUozq1kxt1qrneh93TTwiXEyIU/N3YkWzikzXEjG0WiwC2PtCdQM+jJG/wrC5BoJ1HyDRVnvC8KhA4Xld4+0vr0XR6S4rAtHYk1NrP4C02shKyqGn/ZtPXFD+M550gPOUv3Ekv1PhQr/VBOKERWsAkkrVC5MQjwDhrS1FgWagaW/PgShUkMyO6vHm9opJnSIcJhJCMYtC81ZaW5rKbvn1iX+hpDRl5pOqy3ukmyD6TnX7jBlB5uiXLp9Ahzzvvngw1HlXipxlsi5tlDOaYK+dzjfW+kuMoQEdJML10uzPFZ2pzm4Go7iQwvFJWkLBUtcB4ZthflCWglbEyE/qjCh/QbxfYvz2Tc0LG3O5Dg+tv6uKonZTV1DnGZtb07dQ7xnDGWWWtMV+z18OBhrnDf3keApVBbSi8ZigftWUnglDICUlHtTEEPNvFj5ARKhx6/BOq8CUZWc30D6uIU/ovtvXsW3bVrZ4BIo77916COt/FOJr8QfCizJZfADGAXSsAIH14ApXXRRnJ8QSIxEll8zagGXXSRWBwf8eZm58i8couU6gYfbuDaB4IeiV6hPrBlby8j+pQ6actByfWgOA8Xitjgx 9faWujZI 09ys7/6exqGDi4QyrYflW2ppAPj3tai4RjMnkImvCI/iSYsVZGDfYQyRoAaoS6sW8WY5lEFnmBgvuiN1pznrr09lKbt0TFGyNUnQ58ae7HYVkF0U04+fZhuHXxSYTIT0v7LQHFWqShAW5vE9TD9CgFDu8p2hha2WBLPe3vy7ES3VJXYY+q/AHqofOkdQfxbEfSaNQZuTtJIX6rsE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The conditional check "(ai->dyn_size < PERCPU_DYNAMIC_EARLY_SIZE) has covered the check '(!ai->dyn_size)'. Signed-off-by: Baoquan He Acked-by: Dennis Zhou --- mm/percpu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/percpu.c b/mm/percpu.c index 28e07ede46f6..1480bf283d11 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -2615,7 +2615,6 @@ void __init pcpu_setup_first_chunk(const struct pcpu_alloc_info *ai, PCPU_SETUP_BUG_ON(ai->unit_size < PCPU_MIN_UNIT_SIZE); PCPU_SETUP_BUG_ON(!IS_ALIGNED(ai->unit_size, PCPU_BITMAP_BLOCK_SIZE)); PCPU_SETUP_BUG_ON(ai->dyn_size < PERCPU_DYNAMIC_EARLY_SIZE); - PCPU_SETUP_BUG_ON(!ai->dyn_size); PCPU_SETUP_BUG_ON(!IS_ALIGNED(ai->reserved_size, PCPU_MIN_ALLOC_SIZE)); PCPU_SETUP_BUG_ON(!(IS_ALIGNED(PCPU_BITMAP_BLOCK_SIZE, PAGE_SIZE) || IS_ALIGNED(PAGE_SIZE, PCPU_BITMAP_BLOCK_SIZE)));