From patchwork Fri Jul 21 13:18:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 13321977 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26883EB64DD for ; Fri, 21 Jul 2023 13:18:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2F6D8D0005; Fri, 21 Jul 2023 09:18:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB9618D0002; Fri, 21 Jul 2023 09:18:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 931958D0005; Fri, 21 Jul 2023 09:18:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 83B3E8D0002 for ; Fri, 21 Jul 2023 09:18:29 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DE074801DA for ; Fri, 21 Jul 2023 13:18:28 +0000 (UTC) X-FDA: 81035673096.02.7F268E7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 16B0B40019 for ; Fri, 21 Jul 2023 13:18:26 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dkeZj72q; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689945507; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3RZSzIkl7Lg2t6SJUFm5Lmk6ZzRLZxYILlnvYuCsuFM=; b=eptGJzJVKivYX6dqCJjN0KXF8reSxCQw4NcYtbjp4e4YghYCiZcod6h0O2sTBZk05rKzjO Hb4HSPFg2Yu0COXXd21IkI4BVlrRHGg1q+Ncg8Tay6FLT+bglnNszjEW5a+fNTAywu3Cov vvqqANVGdvr/za8H+Klb6c5NFc5z2Bw= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dkeZj72q; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689945507; a=rsa-sha256; cv=none; b=LEkM7S9dVoiMyNLxdSXe0qx0XEGOmPukWVI4NEVgV5UVPUB8GnwNBhM0ezVCmrcNw2Rau6 Ef85mpJNc4r+wog5jHGmI6b+b4keak2Hv/6vSfqcOVrx6EjoTAScVwitXOHUuiGGen8Wjs 48vgq9cufHtxGoK+Em5E0RE+OUAS3B0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689945506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3RZSzIkl7Lg2t6SJUFm5Lmk6ZzRLZxYILlnvYuCsuFM=; b=dkeZj72q3cQp7e0bsLoOt4ZI6izKF4CO5A1oeB7ncnYhD/U7zrqj6UP6RPN5CNWd90RWrk nMZcxfiwFtBDZ97P82oaBRAZytZ3QYoQPJlJl9KbYvtO4REQI7GYNnRUHo90SEx9+eeIG7 ddEyeoQWz1g7XD3RMsmGPGK0zkTd4o4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-372-A6k7ExN7MsehoQtAg3USbQ-1; Fri, 21 Jul 2023 09:18:22 -0400 X-MC-Unique: A6k7ExN7MsehoQtAg3USbQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6879A8F184A; Fri, 21 Jul 2023 13:18:22 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-18.pek2.redhat.com [10.72.12.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4DF6540C2073; Fri, 21 Jul 2023 13:18:17 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, akpm@linux-foundation.org, dennis@kernel.org, tj@kernel.org, cl@linux.com, mawupeng1@huawei.com, Baoquan He Subject: [PATCH 3/3] mm/percpu.c: print error message too if atomic alloc failed Date: Fri, 21 Jul 2023 21:18:00 +0800 Message-Id: <20230721131800.20003-4-bhe@redhat.com> In-Reply-To: <20230721131800.20003-1-bhe@redhat.com> References: <20230721131800.20003-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Rspam-User: X-Stat-Signature: pgczwg6z7gnwnxgzmh8q6wtpou8o41if X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 16B0B40019 X-HE-Tag: 1689945506-962713 X-HE-Meta: U2FsdGVkX1+MAPd61mPLBGJZUXinZPM0U8hLgHeetTFilhdRDY0dxurxB5We4/Nmk84YMxcZdOGLTplZ6pFL0bZHhPW6HD0C5nQZifGUD927Xrck0Nf8eYxJqVXz3m6+6Cw40ticJlV7BCMovkXXk8yWTQBz4AdHwevCTTd0/CaY9+CVtUI8mGwOF1KT8KnhEzr1X6pee/syezh4ngrrnZ9Wma89fmGKqqRY3nEYCADKr44MGbsH3WYaz93l4FPF3l2uHDwz9BqyvRuW7R7xEfbv+B75l9ga1LYQDAre/QNPMlgczHXEBQdj4DOy9l3SpB4/2YLA2m+5wucoT1C75F0aBwZ0Jg7IKDQKAbdP2EbiLowMzanVCYc7tUhX/PUI46mDh+Z78KmDZSmKLeeAhkxMTl0e6uEelZLin8xK7MON8RZsCq/Wz9ka8+FcjX3/eZ0ArBM2mys4iNBQ2jBrvFBKggZND9e77Y4qmwjimsA6Tk1TR5pSg8ISzC7WfOOCKNI/xWK/JJqL7IzBZ0876d1vvHYvsk0gbKp0u2DTdxCrjnh5+GmipWPyfvIl+EvhnPAhvj9OYlEQksri22ngNBK949osJJ3rAUBs1GDpAdHaXmxHPocdXcL8/95TsRDuIjA3ej9S6BO0mtQ0OdVfuOGijgUwOKG5SNlRQmMyuxIdQaWCdWzZSeQjWMoaRi2otBtSMf0JYHAb9FWKUb03SKrNXwbidV4ubAndNl6yKW40xT1Z2THOlsLxteWwMJjP9VGne4ItEpbj76wGa7wZv4IJG0+TNasZaw5yU6tVjrWmGbbWP+m1DBl0kM0WU1kRye6eqRgTSmAJaeGw0Uj1VytyEnf/K/b0a1xPU9303PR+deuwWOBbn1EJ+1PzMcR9mZcrofwylJpYaaOxPEnxc6IirlrndKGGEUM7dhKLQhOoh+IGk2MawSHmaJfBbF7GEFe90qOS1Nz0e80o6hX M0ccsqgE qFOxbS5nCDexQFOp0USBq3pKwGnxJCALCcqF/xPIMCoUSetNDmiPIHsfuR1mkPm+JhyjdRxKg/0nCm9GnQJ8IkOFB0z58aZMYgsYRKdcxs/DQTgLtbvs1u3hfRgx3iQ+r25UbKqYJuj7G6i68s9Q37iFcRjlwLnrooAAi45lyZad1KAU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The variable 'err' is assgigned to an error message if atomic alloc failed, while it has no chance to be printed if is_atomic is true. Here change to print error message too if atomic alloc failed, while avoid to call dump_stack() if that case. Signed-off-by: Baoquan He --- mm/percpu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mm/percpu.c b/mm/percpu.c index c25b058a46ad..74f75ef0ad58 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -1890,13 +1890,15 @@ static void __percpu *pcpu_alloc(size_t size, size_t align, bool reserved, fail: trace_percpu_alloc_percpu_fail(reserved, is_atomic, size, align); - if (!is_atomic && do_warn && warn_limit) { + if (do_warn && warn_limit) { pr_warn("allocation failed, size=%zu align=%zu atomic=%d, %s\n", size, align, is_atomic, err); - dump_stack(); + if (is_atomic) + dump_stack(); if (!--warn_limit) pr_info("limit reached, disable warning\n"); } + if (is_atomic) { /* see the flag handling in pcpu_balance_workfn() */ pcpu_atomic_alloc_failed = true;