diff mbox series

mm/mprotect: fix obsolete function name in change_pte_range()

Message ID 20230723033114.3224409-1-linmiaohe@huawei.com (mailing list archive)
State New
Headers show
Series mm/mprotect: fix obsolete function name in change_pte_range() | expand

Commit Message

Miaohe Lin July 23, 2023, 3:31 a.m. UTC
Since commit 79a1971c5f14 ("mm: move the copy_one_pte() pte_present check
into the caller"), the explanation of preserving soft-dirtiness is moved
into copy_nonpresent_pte(). Update corresponding comment.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 mm/mprotect.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Hildenbrand July 25, 2023, 3:54 p.m. UTC | #1
On 23.07.23 05:31, Miaohe Lin wrote:
> Since commit 79a1971c5f14 ("mm: move the copy_one_pte() pte_present check
> into the caller"), the explanation of preserving soft-dirtiness is moved
> into copy_nonpresent_pte(). Update corresponding comment.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>   mm/mprotect.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/mprotect.c b/mm/mprotect.c
> index 5c3112d92466..3f36c88a238e 100644
> --- a/mm/mprotect.c
> +++ b/mm/mprotect.c
> @@ -213,7 +213,7 @@ static long change_pte_range(struct mmu_gather *tlb,
>   			} else if (is_writable_device_private_entry(entry)) {
>   				/*
>   				 * We do not preserve soft-dirtiness. See
> -				 * copy_one_pte() for explanation.
> +				 * copy_nonpresent_pte() for explanation.
>   				 */
>   				entry = make_readable_device_private_entry(
>   							swp_offset(entry));

Reviewed-by: David Hildenbrand <david@redhat.com>
diff mbox series

Patch

diff --git a/mm/mprotect.c b/mm/mprotect.c
index 5c3112d92466..3f36c88a238e 100644
--- a/mm/mprotect.c
+++ b/mm/mprotect.c
@@ -213,7 +213,7 @@  static long change_pte_range(struct mmu_gather *tlb,
 			} else if (is_writable_device_private_entry(entry)) {
 				/*
 				 * We do not preserve soft-dirtiness. See
-				 * copy_one_pte() for explanation.
+				 * copy_nonpresent_pte() for explanation.
 				 */
 				entry = make_readable_device_private_entry(
 							swp_offset(entry));