From patchwork Mon Jul 24 13:46:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Usama Arif X-Patchwork-Id: 13324804 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D67EC001DF for ; Mon, 24 Jul 2023 13:46:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BCB1900004; Mon, 24 Jul 2023 09:46:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96B90900002; Mon, 24 Jul 2023 09:46:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80B7A900004; Mon, 24 Jul 2023 09:46:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6C672900002 for ; Mon, 24 Jul 2023 09:46:54 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2A59340B43 for ; Mon, 24 Jul 2023 13:46:54 +0000 (UTC) X-FDA: 81046631148.13.82D538F Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf30.hostedemail.com (Postfix) with ESMTP id 28BDB80010 for ; Mon, 24 Jul 2023 13:46:51 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=MgcuJRY5; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf30.hostedemail.com: domain of usama.arif@bytedance.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=usama.arif@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690206412; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VUFHsk/m/GY1eTNfZx8Py//rj4lEwu1OMjpML8i4XiA=; b=gKqdeZQEfMGPFgS/mH5DSHT6HOKKBpjLeysU9NI8qIv1q1k6JXgkntLj02KB+6euyadcsL /wKMNlIGj69Va2vxNW3uowP43gI3Gyxn3Bq3F+Wm2woWcsSvpRVVIqpFD3iYZig5aMKF/X h3L79p+KtxPsJJYG0WVZzQF3qGDj4gY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=MgcuJRY5; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf30.hostedemail.com: domain of usama.arif@bytedance.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=usama.arif@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690206412; a=rsa-sha256; cv=none; b=Vh0P7sVNnMlB38LtAxJC1b3Ni8oq7XH+kqAjKkVQdA8tkALk8NtRMhKEm06i8Ro/iZF4gI eshGBvOZkA6RocrnSbi9s4o6SOu3TqKAMr5ZsnNxtgCsbL8NR/bvtQNCtOinpe+D0b0F14 V7kPbdO9V5kKYWZU+cye6DzXwVJOUyo= Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-3fbc1218262so41886375e9.3 for ; Mon, 24 Jul 2023 06:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690206410; x=1690811210; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VUFHsk/m/GY1eTNfZx8Py//rj4lEwu1OMjpML8i4XiA=; b=MgcuJRY5CZqiaM6oN+2ZgOrZfx75ny19uB226sSasic7Mnx54MWMiPH2vVvPOLfApJ prGjNWXiRaSzV4+PdVcYOKWYfpjwq8s/M8+afykb+Nc06bZYe/+gbxa1+Be4Rm3jeWI0 8cCsZq8cfyydU59ItSQYEJs5yxH0yKdyeTfFZmwx6fK1dDSSKyPHBvlQzTgukYT3kPUX EQcr7s+o30vHTb1ipJOy2fJMjidD+R8BdV4yReZet1FTj9rlNgXk8HK6ZpTxwwfR3+Y5 MrrxBs3KhFwb0TnnMWnCPZSjTb//F/UJ43wX8Vj0/TqJXnIo2EGyycAVn4dvvn7wm2nd L09Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690206410; x=1690811210; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VUFHsk/m/GY1eTNfZx8Py//rj4lEwu1OMjpML8i4XiA=; b=Qzu2+/G2UstzHrMbRNlGWnJMo8N6bT77T9ppAG5mrKqv1PKkHvtC3YQ/Jd9vy8FNH0 ZnvJNiGAB8iavUVKnD94P8CBGjGFblBGzXCnkJw5dwD8JqqcNgjGupgPlF2pxTzn7jYT CYlTKiorYVNMN1Vbf44E7TSjyKQeXmRksLB8fWIfbjxzSNPOub6adVPUW57/YEVvkGDb CFwBKT9GKHEKbV6mFpoi/I4uX7C4YImhh83jl9TapS965M3AT78cJVCXwDKlIauk/jmu K1uX47gqX2mL9pZHlchxTy5zhRgTptN6+l7fjFPSRaPhfRCrfPh2mlp/m86t7e2hAKgB qY/w== X-Gm-Message-State: ABy/qLaK3ZvQBqLjE5As8fHNunSZNdJOZTxd01uo6EUrbqtS7RGJwILN qe5HYWQJYa+5wU3YTyGWAbu2DofB6otV5KYb/4M= X-Google-Smtp-Source: APBJJlGKyOnJzA0snmPQ5aknmyxWInB37EjZPNgnEdY747vTPxkIvkOio6Xp4jLPbIkb3rasSdJxGQ== X-Received: by 2002:a7b:c349:0:b0:3fc:5bcc:a909 with SMTP id l9-20020a7bc349000000b003fc5bcca909mr7478357wmj.2.1690206410523; Mon, 24 Jul 2023 06:46:50 -0700 (PDT) Received: from localhost.localdomain ([2a02:6b6a:b465:0:d7c4:7f46:8fed:f874]) by smtp.gmail.com with ESMTPSA id e19-20020a05600c219300b003fbe791a0e8sm10209354wme.0.2023.07.24.06.46.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jul 2023 06:46:49 -0700 (PDT) From: Usama Arif To: linux-mm@kvack.org, muchun.song@linux.dev, mike.kravetz@oracle.com, rppt@kernel.org Cc: linux-kernel@vger.kernel.org, fam.zheng@bytedance.com, liangma@liangbit.com, simon.evans@bytedance.com, punit.agrawal@bytedance.com, Usama Arif Subject: [RFC 3/4] mm/hugetlb_vmemmap: Use nid of the head page to reallocate it Date: Mon, 24 Jul 2023 14:46:43 +0100 Message-Id: <20230724134644.1299963-4-usama.arif@bytedance.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230724134644.1299963-1-usama.arif@bytedance.com> References: <20230724134644.1299963-1-usama.arif@bytedance.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 28BDB80010 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ped8r9kxfuefauf1scgksg5c9ozu71bd X-HE-Tag: 1690206411-896135 X-HE-Meta: U2FsdGVkX18A4tLTEebjIObexQ4nc7K5p1C809UOApf2hCr7Ta60DOi0Zx7fucUeJ+3Yd4XGbJpmzbshlhZv4jvughmKB2us5I1ZB+EHMo9UicanwUhIXDbbZwUE2QMaQg+y1i91L5yk24qynBOLWap7ZmQ1J0jEY9JstWgJv0bk/Y019ccxYH93WZnZ/fM3NwbdrJyH8LB8fbvwHoR4knejOa9PYIP6dQsyN7GboDsmmRyPBRrkfvz7ygpJ+/4r1Y4xauIxnrM1CF9nUUORNxEXjEIv7tPE+Gm21znC5pwPkXgg5W130mX4nQwIOYPyp2Vsv3OBqPToKOTeQER5uIv8KfD77jEFZGzdY/0P+HGdUWIzzxY88y63wPdl4us6av1ycFDSVpEOZzKI5im3svdDFBoJIhWb7MqZCm7DyrsZLb/9uq60e1386KgSZgtsMGdGoi1rR7mUkXrP9UKYvQwVraS4gNMk1x2wG1zdOzm0RFWKNHi4GD5wMy1fRCn4uB+o9/dGRpDaLfFP4QBMzy1MbrVhzr8nnpkgiqvCg5cYR44Jspti8Lty6m57XoLCfjfKlTGVZcgbrG6zpr4hAjZjjwPfnq0TP7/Nw3qy+1BIcKlN6QclKZ5wOBtTKtLfd1mfCE7d8yweq8ECUsXxdWpO1fq/UMN1q0AZpVUvlh58WZB8u9DadjMrdOB/Yb/fbeSYHrFlv//Lc0Pa1uhNSytCQsuvGlHc+UDATdJgLPFsXukpro41Y148ljBN37zB2jQkxDtzcS1AUi22traKQs/fMuqGnl5Iyt1RH7XRvmbX82pvD+mwWmtLZ5Zev02LqXd893HDSqljKb3bCqd56AnJOG/8SkOMO8TEbkVuSEnz/ZbRHljubQsfxYRNk9BPNVBB1QegD0ZqyH68W7PFqynRb8QTrgbnQPMl0Z//7DM0YKmRxb8mgYA7RVmL+NF7BoC1iMvy5a4bnEzfUlG LZtCFmGX Nx0zw4WC372EY7izuvkKisSamL3oFtZyeX/TFyQbfYCN3QCHc4lME4BL9Rj2ZxOa75S8DKvuIP3I6iE17pmqMysatT5vuP9/d8Z09nI5ucvli3dDO7yql82h+R2MMRH00LLn5cGSVPe329Nb3Fmw39q7SwNuvFG61/4YYyK2cIwSy/Qjl++Daq5+Lj3DrrMqJGuV9yAZLikLTu5sOLZEubO/tdqNLDyubHrfEf2QeQe1f+PUvfaoVxtUVHq7ZyCIZQX/z7UcwuVnyWXa1u+QCudNVC1v95SrCfk7RY1pDFSUNsSE+MxnlmmtKfKClPQbLXcQCSiZW552hWnsFXkwOz42u3RJxZus7y7S3O9SRzXedfi9KXYIqDNP+xnKuDGw3Dv7xqFChVTJLp6aQ6+yoJDj5QRTS4Jukxs4dSPOlBmKoKiiwpEIx4zg39DCy6OPXIgbFQ7b39UMkF40G0N+y3U5XoQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000095, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If tail page prep and initialization is skipped, then the "start" page will not contain the correct nid. Use the nid from first vmemap page. Signed-off-by: Usama Arif --- mm/hugetlb_vmemmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c index b721e87de2b3..bdf750a4786b 100644 --- a/mm/hugetlb_vmemmap.c +++ b/mm/hugetlb_vmemmap.c @@ -324,7 +324,7 @@ static int vmemmap_remap_free(unsigned long start, unsigned long end, .reuse_addr = reuse, .vmemmap_pages = &vmemmap_pages, }; - int nid = page_to_nid((struct page *)start); + int nid = page_to_nid((struct page *)reuse); gfp_t gfp_mask = GFP_KERNEL | __GFP_THISNODE | __GFP_NORETRY | __GFP_NOWARN;